![“Code review is systematic examination […] of
computer source code. It is intended to find mistakes
overlooked in software development, improving the
overall quality of software. Reviews are done in various
forms such as pair programming, informal
walkthroughs, and formal inspections.
Wikipedia](https://image.slidesharecdn.com/developers-and-designers-180424170254/85/Let-s-review-it-What-designers-can-learn-from-code-review-11-320.jpg)
Let's review it: What designers can learn from (code) review
- 1. Let’s review it. Ida Aalen Chief Product Officer, Confrere [email protected] / @idaaa Yggdrasil 2018
- 2. Links & resources for testing: bit.ly/tools-for-testing To check out the service: confrere.com
- 8. There’s also an API.
- 10. Code review.
- 11. “Code review is systematic examination […] of computer source code. It is intended to find mistakes overlooked in software development, improving the overall quality of software. Reviews are done in various forms such as pair programming, informal walkthroughs, and formal inspections. Wikipedia
- 12. Dag-Inge, CTO Ingvild, Senior Engineer
- 13. Pull request submitted by ingvilin #423 Add onboarding status To keep track of the onoardingProgress a default onboarding progress object is added to the users metadata on completing the sign up process. ingvilin requested a review from daginge
- 16. Weeds out errors and heightens quality.
- 19. Curtails “my” code and “your” code. It’s our code.
- 20. Are reviews just for code?
- 22. “Code reviews set the tone for the entire company that everything we do should be open to scrutiny from others, and that such scrutiny should be a welcome part of your workflow rather than viewed as threatening. Bruce Johnson, co-founder of Full Story
- 23. “Code reviews set the tone for the entire company that everything we do should be open to scrutiny from others, and that such scrutiny should be a welcome part of your workflow rather than viewed as threatening. Me
- 26. How can we generalise this advice beyond code?
- 27. Principle #1 Think like an adversary, but be nice about it. Critique the work, not the author.
- 28. Principle #2 Differentiate between a) suggestions, b) requirements, and c) points that need discussion or clarification.
- 29. Principle #3 Don’t forget to praise the good parts.
- 30. An example.
- 33. Suggestion
- 34. Suggestion
- 37. Don’t forget to praise all the good work!
- 42. 1 of 3 problems found in expert review are false alarm 1 of 2 problems found in user testing were overlooked in expert review
- 43. 5
- 44. N (1-(1-L)n)
- 45. 0% 25% 50% 75% 100% Number of test subjects 0 3 6 9 12 15 Observedproblems Small & frequent tests are more efficient
- 48. Testing that’s affordable enough to be regular.
- 53. Add screenshots to InvisionApp before you begin Add your observations between each test
- 54. By connecting it to Slack your team- mates can follow the test
- 57. «Hugging»
- 59. If you need observers: Test machine Observation + Screen sharing+
- 60. 30 min pause between each test
- 62. Summarizing and prioritising in Google Sheets or AirTable
- 64. Review walkthroughs • Walkthrough is done together • One person in charge of reviewing and documenting • Choose a format that gives as much context as possible • The idea is to identify issues, not necessarily solve them
- 65. User testing
- 66. Usability review
- 67. Usability review
- 68. Usability review
- 69. Usability review
- 73. Feature review
- 74. Feature review
- 75. Feature review
- 76. Feature review
- 77. Design review
- 79. A good idea will survive review.
- 80. We’re not artists. We’re artisans.
- 82. Thank you! Ida Aalen Chief Product Officer, Confrere [email protected] / @idaaa PS. Send en mail til [email protected] for to måneder gratis trial <3