SlideShare a Scribd company logo
Let’s review it.
Ida Aalen
Chief Product Officer, Confrere
ida@confrere.com / @idaaa
Yggdrasil 2018
Links & resources for testing:
bit.ly/tools-for-testing
To check out the service:
confrere.com
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
There’s also an API.
Design and
development.
Code review.
“Code review is systematic examination […] of
computer source code. It is intended to find mistakes
overlooked in software development, improving the
overall quality of software. Reviews are done in various
forms such as pair programming, informal
walkthroughs, and formal inspections.

Wikipedia
Dag-Inge, CTO Ingvild, Senior Engineer
Pull request submitted by ingvilin

#423 Add onboarding status
To keep track of the
onoardingProgress a default
onboarding progress object is
added to the users metadata on
completing the sign up process.
ingvilin requested a review from
daginge
👍
Main Repository
AuthorReviewer
Why do code
review?
Weeds out

errors and

heightens quality.
Ensures

consistency.
Promotes learning
and openness.
Curtails “my” code

and “your” code.

It’s our code.
Are reviews

just for code?
Time to review
ourselves.
“Code reviews set the tone for the entire company that
everything we do should be open to scrutiny from
others, and that such scrutiny should be a welcome
part of your workflow rather than viewed as
threatening.
Bruce Johnson, co-founder of Full Story
“Code reviews set the tone for the entire company that
everything we do should be open to scrutiny from
others, and that such scrutiny should be a welcome
part of your workflow rather than viewed as
threatening.
Me
Review ≠
Design by
Committee
One author
+
Reviewer(s)
How can we
generalise this
advice beyond
code?
Principle #1
Think like an adversary, but
be nice about it.

Critique the work, not the
author.
Principle #2
Differentiate between

a) suggestions, 

b) requirements, and

c) points that need
discussion or clarification.
Principle #3
Don’t forget to praise the
good parts.
An example.
Let's review it: What designers can learn from (code) review
Nominate reviewers
Suggestion
Suggestion
Requirement
Nominating a reviewer
Let's review it: What designers can learn from (code) review
Don’t forget to
praise all the
good work!
User testing as
review.
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
1 of 3

problems found in
expert review are

false alarm
1 of 2

problems found in

user testing were
overlooked in

expert review
5
N (1-(1-L)n)
0%
25%
50%
75%
100%
Number of test subjects
0 3 6 9 12 15
Observedproblems
Small & frequent
tests are more
efficient
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Testing that’s
affordable enough to
be regular.
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
Add
screenshots to
InvisionApp
before you
begin
Add your
observations
between each
test
By
connecting it to
Slack your team-
mates can follow
the test
Let's review it: What designers can learn from (code) review
Let's review it: What designers can learn from (code) review
«Hugging»
Let's review it: What designers can learn from (code) review
If you need observers:
Test machine Observation
+ Screen

sharing+
30 min pause
between each test
Informed
consent!
Summarizing
and prioritising
in Google Sheets
or AirTable
Regular review
walkthroughs.
Review walkthroughs
• Walkthrough is done together
• One person in charge of reviewing and documenting
• Choose a format that gives as much context as possible
• The idea is to identify issues, not necessarily solve them
User testing
Usability
review
Usability
review
Usability
review
Usability
review
Accessibility
review
Accessibility
review
Accessibility
review
Feature
review
Feature
review
Feature
review
Feature
review
Design
review
Review:

Death to creativity?
A good idea will
survive review.
We’re not artists.
We’re artisans.
Let’s make
something together.
Thank you!
Ida Aalen
Chief Product Officer, Confrere
ida@confrere.com / @idaaa
PS. Send

en mail til
ida@confrere.com
for to måneder
gratis trial <3

More Related Content

What's hot (20)

PPTX
Automation testing & Unit testing
Kapil Rajpurohit
 
PDF
Improving the Quality of Incoming Code
Naresh Jain
 
PPTX
Bro, manage test data like a pro!
Mikalai Alimenkou
 
PDF
TDD for Testers Workshop
Sarah Usher
 
PDF
A Concise QA Process
Arslan Ali
 
PPTX
Pertanyaan dan jawaban (graham et.al 2011) part 3
ikhwana luthfi
 
PDF
What is Software Testing | Edureka
Edureka!
 
PPTX
Why Automated Testing Matters To DevOps
dpaulmerrill
 
PPTX
5 top pain points of test automation
Mikalai Alimenkou
 
PPTX
What is the difference between manual testing and automation testing
Er Mahednra Chauhan
 
PPTX
Coding and testing in Software Engineering
Abhay Vijay
 
PDF
Code audition
Maciej Dziergwa
 
PPTX
Abc of testing
Nimble Esolutions
 
DOCX
General technical interview questions
Kevalkumar Shah
 
KEY
Testing and DevOps Culture: Lessons Learned
LB Denker
 
PDF
The Essentials Of Test Driven Development
Rock Interview
 
PDF
Cloud for Agile Testing - Burak Koyuncu
Keytorc Software Testing Services
 
PDF
Software Testing Tutorial For Beginners | Manual & Automation Testing | Selen...
Edureka!
 
PPT
Agile Testing Process
Intetics
 
DOCX
Selenium Testing Project report
Kapil Rajpurohit
 
Automation testing & Unit testing
Kapil Rajpurohit
 
Improving the Quality of Incoming Code
Naresh Jain
 
Bro, manage test data like a pro!
Mikalai Alimenkou
 
TDD for Testers Workshop
Sarah Usher
 
A Concise QA Process
Arslan Ali
 
Pertanyaan dan jawaban (graham et.al 2011) part 3
ikhwana luthfi
 
What is Software Testing | Edureka
Edureka!
 
Why Automated Testing Matters To DevOps
dpaulmerrill
 
5 top pain points of test automation
Mikalai Alimenkou
 
What is the difference between manual testing and automation testing
Er Mahednra Chauhan
 
Coding and testing in Software Engineering
Abhay Vijay
 
Code audition
Maciej Dziergwa
 
Abc of testing
Nimble Esolutions
 
General technical interview questions
Kevalkumar Shah
 
Testing and DevOps Culture: Lessons Learned
LB Denker
 
The Essentials Of Test Driven Development
Rock Interview
 
Cloud for Agile Testing - Burak Koyuncu
Keytorc Software Testing Services
 
Software Testing Tutorial For Beginners | Manual & Automation Testing | Selen...
Edureka!
 
Agile Testing Process
Intetics
 
Selenium Testing Project report
Kapil Rajpurohit
 

Similar to Let's review it: What designers can learn from (code) review (20)

PDF
What designers can learn from (code) review
Ida Aalen
 
PPT
Introduction to Software Review
Philip Johnson
 
PPT
Tester developer interaction
gaoliang641
 
PPT
Code Review
Ravi Raj
 
PDF
code_review_checklist_6_actions_to_improve_the_quality_of_your_reviews.pdf
sarah david
 
PPTX
code_review_checklist_6_actions_to_improve_the_quality_of_your_reviews.pptx
sarah david
 
PPTX
Ben Walters - Creating Customer Value With Agile Testing - EuroSTAR 2011
TEST Huddle
 
PPT
Peer Code Review An Agile Process
gsporar
 
PPTX
Mastering Agile Practices to Build High Performing Teams
AgileThought
 
PDF
Software Defect Prevention via Continuous Inspection
Josh Gough
 
PDF
Agile Testing 20021015
Raghu Karnati
 
PPTX
Test Policy and Practices
Talentica Software
 
PPTX
Lecture 2 - software testing SE 412.pptx
TaghreedAltamimi
 
PDF
Code-Review-Principles-Process-and-Tools (1)
Aditya Bhuyan
 
PPTX
Topic production code
Kavi Kumar
 
PPTX
Types of testing
Sonam Agarwal
 
PPTX
An introduction to Software Testing and Test Management
Anuraj S.L
 
PDF
Software Testing Basic Concepts
wesovi
 
PDF
Behavior Driven Development—A Guide to Agile Practices by Josh Eastman
QA or the Highway
 
PDF
CHAPTER 1 BASIC CONCEPTS AND PRELIMINARIES
Samruddhi Sheth
 
What designers can learn from (code) review
Ida Aalen
 
Introduction to Software Review
Philip Johnson
 
Tester developer interaction
gaoliang641
 
Code Review
Ravi Raj
 
code_review_checklist_6_actions_to_improve_the_quality_of_your_reviews.pdf
sarah david
 
code_review_checklist_6_actions_to_improve_the_quality_of_your_reviews.pptx
sarah david
 
Ben Walters - Creating Customer Value With Agile Testing - EuroSTAR 2011
TEST Huddle
 
Peer Code Review An Agile Process
gsporar
 
Mastering Agile Practices to Build High Performing Teams
AgileThought
 
Software Defect Prevention via Continuous Inspection
Josh Gough
 
Agile Testing 20021015
Raghu Karnati
 
Test Policy and Practices
Talentica Software
 
Lecture 2 - software testing SE 412.pptx
TaghreedAltamimi
 
Code-Review-Principles-Process-and-Tools (1)
Aditya Bhuyan
 
Topic production code
Kavi Kumar
 
Types of testing
Sonam Agarwal
 
An introduction to Software Testing and Test Management
Anuraj S.L
 
Software Testing Basic Concepts
wesovi
 
Behavior Driven Development—A Guide to Agile Practices by Josh Eastman
QA or the Highway
 
CHAPTER 1 BASIC CONCEPTS AND PRELIMINARIES
Samruddhi Sheth
 
Ad

More from Ida Aalen (7)

PDF
How Content Helped Us Scale
Ida Aalen
 
PDF
Can you hear me now?
Ida Aalen
 
PDF
Easy and affordable user testing at Confab Central 2018
Ida Aalen
 
PDF
Enkel og effektiv brukertesting (andvändartesting)
Ida Aalen
 
PDF
Easy and affordable user testing - Front Trends 2017
Ida Aalen
 
PDF
Falske nyheter, sa du? En presisering.
Ida Aalen
 
PDF
Never show a design you haven't tested
Ida Aalen
 
How Content Helped Us Scale
Ida Aalen
 
Can you hear me now?
Ida Aalen
 
Easy and affordable user testing at Confab Central 2018
Ida Aalen
 
Enkel og effektiv brukertesting (andvändartesting)
Ida Aalen
 
Easy and affordable user testing - Front Trends 2017
Ida Aalen
 
Falske nyheter, sa du? En presisering.
Ida Aalen
 
Never show a design you haven't tested
Ida Aalen
 
Ad

Recently uploaded (20)

DOCX
Amplopxxxxxxxxxvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
Lm Hardin 'Idin'
 
PDF
Zidane ben hmida _ Portfolio
Zidane Ben Hmida
 
PPTX
Artificial Intelligence presentation.pptx
snehajana651
 
PDF
Kitchen_Aluminium_Doors_Prices_Presentation.pdf
Royal Matrixs
 
PDF
Home_Decor_Presentation and idiea with decor
sp1357556
 
PPTX
Residential_Interior_Design_No_Images.pptx
hasansarkeraidt
 
PPTX
Mini-Project description of design of expert project
peter349484
 
PDF
PowerPoint Presentation -- Jennifer Kyte -- 9786400311489 -- ade9381d14f65b06...
Adeel452922
 
PPTX
VERTICAL TRANSPORTATION SYSTEMS.pptxhvcvcvvdh
jp0718076
 
PPTX
DISS-Group-5_110345.pptx Basic Concepts of the major social science
mattygido
 
PPT
UNIT- 2 CARBON FOOT PRINT.ppt yvvuvvvvvvyvy
sriram270905
 
PPT
Strengthening of an existing reinforced concrete structure.ppt
erdarshanpshah
 
PPTX
lesson 02- Mang- Ruklani Wickramasinghe (2).pptx
dinalisanjala002
 
PPTX
Modern_Dhaka_Apartment_Interior_Design.pptx
hasansarkeraidt
 
PPTX
Time_Management_Presenuuuuuuutation.pptx
Rajni Goyal
 
PDF
Ggggggggggggggggggggroup singing.pdf.pdf
nadifalrazi3
 
PDF
Shayna Andrieze Yjasmin Goles - Your VA!
shaynagoles31
 
PDF
ornament making and its material used for.pdf
departmentofcdft
 
PPTX
CHANDIGARH Architecture Design and Planning
FaizSaifi3
 
PDF
mlbrolllist2024-25 (1)ygrude4ferfssrddde
rishabh1chaurasia4
 
Amplopxxxxxxxxxvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
Lm Hardin 'Idin'
 
Zidane ben hmida _ Portfolio
Zidane Ben Hmida
 
Artificial Intelligence presentation.pptx
snehajana651
 
Kitchen_Aluminium_Doors_Prices_Presentation.pdf
Royal Matrixs
 
Home_Decor_Presentation and idiea with decor
sp1357556
 
Residential_Interior_Design_No_Images.pptx
hasansarkeraidt
 
Mini-Project description of design of expert project
peter349484
 
PowerPoint Presentation -- Jennifer Kyte -- 9786400311489 -- ade9381d14f65b06...
Adeel452922
 
VERTICAL TRANSPORTATION SYSTEMS.pptxhvcvcvvdh
jp0718076
 
DISS-Group-5_110345.pptx Basic Concepts of the major social science
mattygido
 
UNIT- 2 CARBON FOOT PRINT.ppt yvvuvvvvvvyvy
sriram270905
 
Strengthening of an existing reinforced concrete structure.ppt
erdarshanpshah
 
lesson 02- Mang- Ruklani Wickramasinghe (2).pptx
dinalisanjala002
 
Modern_Dhaka_Apartment_Interior_Design.pptx
hasansarkeraidt
 
Time_Management_Presenuuuuuuutation.pptx
Rajni Goyal
 
Ggggggggggggggggggggroup singing.pdf.pdf
nadifalrazi3
 
Shayna Andrieze Yjasmin Goles - Your VA!
shaynagoles31
 
ornament making and its material used for.pdf
departmentofcdft
 
CHANDIGARH Architecture Design and Planning
FaizSaifi3
 
mlbrolllist2024-25 (1)ygrude4ferfssrddde
rishabh1chaurasia4
 

Let's review it: What designers can learn from (code) review