Martin Fowler's Refactoring Techniques Quick Reference

Refactoring Techniques Quick Reference https://technical-leader.tistory.com
1 | 11
Composing
Methods
Extract Method
- Code that can be grouped
- Meaningful name for method
void printOwing(double amount){
//print details
System.out.println(“name:” +name);
System.out.println(“amount: “ + amount);
}
void printOwing(double mount){
printDetails(name, amount);
}
void printDetails(String name, double amount){
System.out.println(“name:”+name);
System.out.println(“amount: “ + amount);
}
Inline Method
- inverse of “Extract Method”
- Method body is more obvious
int getRating() {
return (morethanFiveLateDeliveries()?2:1;
}
Boolean moreThanFiveLateDeliveries() {
return numberOfLateDeliveries > 5;
}
int getRating() {
return (numberOfLateDeliveries >5)?2:1;
}
Extract Variable
- Expression: hard to understand
- Separate self-explanatory var
if((platform.toUpperCase().indexOf(“MAC”) > -1) &&
(browser.toUpperCase().indexOf(“IE”) > -1) &&
wasInitialized() && resize > 0) {
//do something
}
final boolean isMacOs = platform.toUpperCase().indexOf(“MAC”) > -1;
final boolean isIEBrowser = browser.toUpperCase().indexOf(“IE”) > -1;
final Boolean wasResized = resize > 0;
if (isMacOs && isIEBrowser && wasInitialized() && wasResized) {
//do something
}
Inline Temp double basePrice = anOrder.basePrice();
return (basePrice > 1000);
return (anOrder.BasePrice() > 1000);
Replace Temp with Query
- Temp var holding expression
- Extract Expression into method
double basePrice = quantity * itemPrice;
if (basePrice > 1000)
return basePrice * 0.95;
else
return basePrice;
if (basePrice() > 1000)
return basePrice() * 0.95;
else
return basePrice() * 0.98;
double basePrice() {
return quantity * itemPrice;
}
Split Temporary Variable
- different var for different value
double temp = 2 * (height + width);
System.out.println(temp);
temp = height * width;
System.out.println(temp);

2 | 11
Composing
Methods
final double perimeter = 2 * (height + width);
System.out.println(perimeter);
final double area = height * width;
System.out.println(area);
Remove Assignments to Param
- use temp var instead
int discount(int inputVal, int Quantity, int yearToDate){
if (intputVal>50)
inputVal -=2;
}
int discount(int inputVal, int Quantity, int yearToDate) {
int result = inputVal;
if (inputVal > 50)
result - = 2;
}
Replace Method with Method Obj
- Extract Method cannot be applied
- Separate class
class Order {
…
double price() {
double primaryBasePrice;
double secondaryBasePrice;
double TeriaryBasePrice;
//long computation
…
}
}
class Order {
…
public double price() {
return new PriceCalculator(this).compute();
}
}
class PriceCalculator {
private double primaryBasePrice;
private double seconadaryBasePrice;
private double tertiaryBasePrice;
PriceCalculator(Order order) {
//copy relevant info
}
public double compute() {
//…
}
}
Substitute Algorithm
- Replace existing algorithm
- Replace body of the method
String foundPerson(String[] people) {
for(int I = 0;i<people.length;i++) {
if(people[i].equals(“Don”))
return “Don”;
if((people[i].equals(“John”))
return “John”;
if(people[i].equals(“Kent”))
return “Kent”;
}
return “”;
}

3 | 11
Composing
Methods
String foundPerson(String[] people) {
ListCandidates = Arrays.asList(new String[] {“Don”, “John”, “Kent”});
for(int i = 0;i<people.length;;i++) {
if (candidates.contains(people[i])) {
return people[i];
}
}
return “”;
}
Moving
Feature btwn
Obj
Move Method
- Use more features in another class
Move Field
- Field used by another class more
Extract Class
- One class does the work of two
Inline Class
- Class does almost nothing
Hide Delegate
- use A for getting B info
- new method of A delegating B
Remove Middle Man
- too many methods that simply
delegate
- force the client to call the end methods
directly
Introduce Foreign method
- server class cannot contain the needed
class
- add a method in the client
Date newStart = new Date(previousEnd.getYear(), previousEnd.getMonth(),
previousEnd.getDate() + 1);
Date newStart = nextDay(previousEnd);
private static Date nextDay(Date arg) {
return new Date(arg.getYear(), arg.getMonth(), arg.getDate() + 1);
}

4 | 11
Moving
Feature btwn
Obj
Introduce Local Extension
- server class cannot contain some
methods that you need
Organizing
Data
Self Encapsulate Field
- Create a getter and setter
private int low, high
Boolean includes(int arg) {
return arg >= low && arg <= high;
}
private int low, high
Boolean includes(int arg) {
return arg >= getLow() && arg <= getHigh();
}
int getLow() {
return low;
}
int getHigh() {
rturn high;
}
Replace Data Value with Object
- Contain a data field with its own
behavior and associated data
- Change the data item into an object
Change Value to Reference
- Many identical instances of a single
class
- Converted to a single reference object
Change Reference to Value
- Reference object is too small
- Converted it into a value object
Replace Array with Object
- Arrays containing various types of data
- Replace array with an object
String[] row = new String[];
row[0] = “Liverpool”;
row[1] = “15”;
Performance row = new Performance();
row.setName(“Liverpool”);
row.setWins(“15”);
Duplicate Observed Data
- Domain data in GUI control
- Copy data to model and set up
observer
Change Unidirectional Association to
Bidirectional
- Add missing association
Change Bidirectional Association to
Unidirectional
- Remove unused association

5 | 11
Organizing
Data
Replace Magic Number with Symbolic
Constant
- number having a certain meaning
- Replace with constant
double potentialEnergy(double mass, double height) {
return mass * 9.81 * height;
}
double potentialEnergy(double mass, double height) {
return mass * GRAVITATION_CONSTANT * height;
}
static final double GRAVITATION_ONSTANT = 9.81;
Encapsulate Field
- make public field as private
- provide accessors
public String name;
private String name;
public String getName() {
return name;
}
public String setName(String arg) {
name = arg;
}
Encapsulate Collection
- Collection Field with a simple
getter/setter
- Getter returns read-only, Setter
replaced with adding/removing elements
Replace Type Code with Class
- fields containing type code
- Create a new class and use its objects
instead
(Obsolete: Java enumeration is another
option)
Replace Type Code with Subclasses
- immutable type code affecting the
behavior
- Create subclasses for each value
(OCP)
Replace Type Code with State/Strategy
- Type code affects behavior, but cannot
use subclassing
- Replace Type code with State/Strategy
Replace Subclass with Fields
- Subclass differs in constant-returning
methods
- Remove subclass

6 | 11
Simplifying
Conditional
Expression
Decompose conditional
- Complex conditional
- Decompose to separate methods
if(data.before(SUMMER_START)||date.after(SUMMER_END))
charge = quantity * winterRate + winterServiceCharge;
else
charge = quantity * summerRate;
if(notSummer(date))
charge = winterCharge(quantity);
else
charge = summerCharge(quantity);
Consolidate Conditional Expression double disabilityAmount() P
if (seniority < 2)
return 0;
if(mounthsDisabled > 12)
return 0;
if (isPatTime)
return 0;
…
}
double disabilityAmount() {
if(isNortEligableForDisability())
return 0;
…
}
Consolidate Duplicate Conditional
Fragments
if (isSpecialDeal()) {
total = price* 0.95;
send();
} else {
total = price * 0.98;
send();
}
if (isSpecialDeal()) {
total = price* 0.95;
} else {
total = price * 0.98;
}
send();
Remove Control Flag void checkSecurity(String[] people) {
boolean found = false;
for (int i = 0; i < people.length; i++) {
if (! found) {
if (people[i].equals ("Don")){
sendAlert();
found = true;
}
if (people[i].equals ("John")){
sendAlert();
found = true;
}
}
}
}

7 | 11
Simplifying
Conditional
Expression
Remove Control Flag void checkSecurity(String[] people) {
boolean found = false;
for (int i = 0; i < people.length; i++) {
if (people[i].equals ("Don")){
sendAlert();
found = true;
break;
}
if (people[i].equals ("John")){
sendAlert();
found = true;
break;
}
}
}
Replace Nested Conditional with Guard
Clauses
double getPayAmount() {
double result;
if (_isDead) result = deadAmount();
else {
if (_isSeparated) result = separatedAmount();
else {
if (_isRetired) result = retiredAmount();
else result = normalPayAmount();
};
}
return result;
};
double getPayAmount() {
if (_isDead) return deadAmount();
if (_isSeparated) return separatedAmount();
if (_isRetired) return retiredAmount();
return normalPayAmount();
};
Replace Conditional with Polymorphism
Introduce Null Object
Introduce Assertion double getExpenseLimi() {
//should have either expense limit or a primary project
return (expenseLimit != NULL_EXPSENSE)? expenseLimit
;:primaryProject.getMemberExpenseLimit()
}

8 | 11
Simplifying
Conditional
Expression
double getExpenseLimi() {
Assert.isTrue(expenseLimit !=NULL_EXPENSE || primaryProject != null);
return (expenseLimit != NULL_EXPSENSE)? expenseLimit
;:primaryProject.getMemberExpenseLimit()
}
Simplifying
Method Calls
Rename Method
Add Parameter
Remove Parameter
Separate Query from Modifier
Parameterize Method
Replace Param with Explicit Method void setValue (String name, int value) {
if (name.equals("height"))
_height = value;
if (name.equals("width"))
_width = value;
Assert.shouldNeverReachHere();
}
void setHeight(int arg) {
_height = arg;
}
void setWidth (int arg) {
_width = arg;
}
Preserve Whole Object int low = daysTempRange().getLow();
int high = daysTempRange().getHigh();
withinPlan = plan.withinRange(low, high);
withinPlan = plan.withinRange(daysTempRange());
Replace Parameter with Method Call int basePrice = _quantity * _itemPrice;
discountLevel = getDiscountLevel();
double finalPrice = discountedPrice (basePrice, discountLevel);
int basePrice = _quantity * _itemPrice;
double finalPrice = discountedPrice (basePrice);
Introduce Parameter Object

9 | 11
Simplifying
Method Calls
Remove Setting Method
Hide Method
Replace Constructor With Factory
Method
Employee (int type) {
_type = type;
}
static Employee create(int type) {
return new Employee(type);
}
Encapsulate Downcast
(Needed?)
Object lastReading() {
return readings.lastElement();
}
Reading lastReading() {
return (Reading) readings.lastElement();
}
Replace Error Code With Exception int withdraw(int amount) {
if (amount > _balance)
return -1;
else {
_balance -= amount;
return 0;
}
}
void withdraw(int amount) throws BalanceException {
if (amount > _balance) throw new BalanceException();
_balance -= amount;
}
Replace Exception With Test double getValueForPeriod (int periodNumber) {
try {
return _values[periodNumber];
} catch (ArrayIndexOutOfBoundsException e) {
return 0;
}
}
double getValueForPeriod (int periodNumber) {
if (periodNumber >= _values.length) return 0;
return _values[periodNumber];
}
Dealing with
Generalizatio
n
Pull Up Field

10 | 11
Dealing with
Generalizatio
n
Pull Up Method
Pull Up Constructor Body class Manager extends Employee...
public Manager (String name, String id, int grade) {
_name = name;
_id = id;
_grade = grade;
}
public Manager (String name, String id, int grade) {
super (name, id);
_grade = grade;
}
Push Down Method
Push Down Field
Extract Subclass
Extract Superclass
Extract Interface
Collapse Hierarchy

11 | 11
Dealing with
Generalizatio
n
From Template Method
Replace Inheritance with Delegation
Replace Delegation with Inheritance
Big
Refractorings
Tease Apart Inheritance
Convert Procedural Design to Objects
Separate Domain from Presentation
Extract Hierarchy

Martin Fowler's Refactoring Techniques Quick Reference

More Related Content

What's hot (20)

Similar to Martin Fowler's Refactoring Techniques Quick Reference (20)

More from Seung-Bum Lee (6)

Recently uploaded (20)

Martin Fowler's Refactoring Techniques Quick Reference