SlideShare a Scribd company logo

Points.com fisheye crucible code reviews 2011

Download as PPT, PDF
P
pointstechgeeks

This document discusses code reviews and how Fisheye and Crucible can be used to facilitate the code review process. It provides an overview of the key features of Fisheye for viewing and searching code and Crucible for conducting code reviews and collaborating on review comments. Examples are given of how to use Fisheye to view changes, commits, and reviews and how to navigate and manage reviews within Crucible.

Technology
1 of 32
Downloaded 137 times
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
Private and Confidential Private and Confidential July 28, 2011 Private and Confidential Fisheye, Crucible and the wonders of  Code Reviews Thank you Atlassian! Created by Michael Lossos Points.com July 2011 Private & Confidential
Private and Confidential Private and Confidential Agenda Why code reviews? Code review tips What's Fisheye for? What's Crucible for? Fisheye answers Crucible workflows
Why code reviews? Catch bugs and design flaws early. Help teammates learn. Enforce coding standards, consistency. Ensure architecture alignment.  Review tests. 
When do code reviews? Early and Often. Daily. Theme: small commits, incremental changes, frequent small reviews. This is less work... Than fixing buggy bug bugs. Than fatty reviews. Than big bang commits.
Code reviews: what to look for Design or logic errors. Missing parameter / pre-condition checks. Bad/missing exception handling. Incorrect log levels (error -> info). Useless log messages (not enough context). Long methods (> 20 - 50 lines of code). Potential side effects. Missing comments/docs on interfaces. More at:  https://mwiki.points.com/wiki/Code_Reviews
What's Fisheye for? Fisheye aka FE ViewVC replacement. Source code: Browsing / viewing Comparison Search Monitoring (activity stream)
What's Crucible for? Crucible aka CRU* Code reviews. Pre and post commit. Collaboration. Comments in reviews. Notifications. Release branch code checks.     *FishEye + Crucible = FECRU   ;)
Fisheye answers (1) What changes are in this release?  commit graph, hover on dots to ctrl+c changeset# Were these commits merged between branches?
Fisheye commit graph (1)
Fisheye commit graph (2) Copy changeset numbers.
Fisheye answers (2) What commits associated with a JIRA issue? What code reviews are there for this code?
Fisheye commit graph (3): reviews
Fisheye answers (3) Who made that change?  line by line blame When was that change introduced?  start date for bugs
Fisheye/Crucible file diff: blame by line
Fisheye answers (4) Where's that code?  Search, browse, by filename
Fisheye answers (5) Where's that code?  QuickNav bar CamelCase filename wildcard matching  e.g. BI => BuyImpl => BuyServiceImpl
Fisheye answers (5) How can I share a link to this file in FE? How can I filter changesets in a diff?
Crucible: creating reviews (1) Anyone creates a review * Committer usually creates review Add reviewers Notifications Link to JIRA Finding changes:  Browse Search: author/branch *Anyone  with a login + license
Crucible: creating reviews (2)
Crucible: creating reviews (3)
Crucible: creating reviews (4) By author, date, etc.
Crucible: creating reviews (5)
Crucible: navigating reviews (0)
Crucible: navigating reviews (1) Comments, creating defects.
Crucible: navigating reviews (2) Flipping through comments, filters. 
Crucible: navigating reviews (3) Side by side diffs, unified diffs, context.
Crucible: navigating reviews (4) Files marked as reviewed. Progress meter => done.  Mark complete, summary.
Happy Linking:  Fisheye <=> Crucible <=> JIRA
Happy Linking:  Fisheye <=> Crucible <=> JIRA (2)
Getting Started Who to contact Licenses  Unified usernames Our Crucible/Fisheye
Slightly More Advanced Stuff Pre-commit CRs: Snippets Pre-commit CRs: Eclipse IDE connector. EyeQL
Links to more info Better code and what to look for in code reviews: Effective Java by Josh Bloch http://my.safaribooksonline.com/book/programming/java/9780137150021?bookview=overview Code Complete by Steve McConnell http://my.safaribooksonline.com/book/software-engineering-and-development/0735619670?bookview=overview Fisheye & Crucible links: http://summit.atlassian.com/archives/code-and-build/developer-tools-state-of-union http://www.atlassian.com/software/fisheye/tour/ http://confluence.atlassian.com/display/FISHEYE/FishEye+User%27s+Guide http://blogs.atlassian.com/devtools/2011/07/developer-tools-state-union--summit-2011.html http://www.atlassian.com/software/crucible/tour/ http://confluence.atlassian.com/display/CRUCIBLE/Crucible+User%27s+Guide 

More Related Content

What's hot (20)

PPTX
BDD for APIs
Jason Harmon
 
PDF
Automated testing in javascript
Michael Yagudaev
 
PPTX
'IS THERE JAVASCRIPT ON SWAGGER PLUGINS?' by Dmytro Gusev
OdessaJS Conf
 
PPTX
How does Java 8 exert hidden power on Test Automation?
Sergey Korol
 
PPTX
Test Driven Development on Android (Kotlin Kenya)
Danny Preussler
 
PDF
End-to-end performance testing, profiling, and analysis at Redis
Filipe Oliveira
 
PDF
Test Essentials @mdevcon 2012
Maxim Zaks
 
PPTX
Three Developer Behaviors to Eliminate 85 Percent of Accessibility Defects
Sean Kelly
 
PDF
Continuous Integration 101
John Ferguson Smart Limited
 
PDF
Barcamp Bangkhen :: Robot Framework
Somkiat Puisungnoen
 
DOC
Mca 02 year_exp_unit_automation_testing_ldra_rtrt_c -
sandeep kumar gupta
 
PDF
Effective code reviews
Sebastian Marek
 
PPTX
Cypress test techniques cucumber bdd framework,tdd,api tests course
Narayanan Palani
 
PPTX
Trunk Based Development in the Enterprise - Its Relevance and Economics
Perforce
 
PDF
Continuous Integration (CI) - An effective development practice
Dao Ngoc Kien
 
PPTX
How do you tame a big ball of mud? One test at a time.
Matt Eland
 
PDF
DevOpsDaysRiga 2018: Neil Crawford - Trunk based development, continuous depl...
DevOpsDays Riga
 
PPTX
Accessibility Testing Tools for Developers - Seattle Code Camp
gerardkcohen
 
PDF
TLC2018 Tanya Kravtsov: 10 Steps to CI, Testing and Delivery
Anna Royzman
 
PDF
[Webinar] Continuous Testing Done Right: Test Automation at the World's Leadi...
Applitools
 
BDD for APIs
Jason Harmon
 
Automated testing in javascript
Michael Yagudaev
 
'IS THERE JAVASCRIPT ON SWAGGER PLUGINS?' by Dmytro Gusev
OdessaJS Conf
 
How does Java 8 exert hidden power on Test Automation?
Sergey Korol
 
Test Driven Development on Android (Kotlin Kenya)
Danny Preussler
 
End-to-end performance testing, profiling, and analysis at Redis
Filipe Oliveira
 
Test Essentials @mdevcon 2012
Maxim Zaks
 
Three Developer Behaviors to Eliminate 85 Percent of Accessibility Defects
Sean Kelly
 
Continuous Integration 101
John Ferguson Smart Limited
 
Barcamp Bangkhen :: Robot Framework
Somkiat Puisungnoen
 
Mca 02 year_exp_unit_automation_testing_ldra_rtrt_c -
sandeep kumar gupta
 
Effective code reviews
Sebastian Marek
 
Cypress test techniques cucumber bdd framework,tdd,api tests course
Narayanan Palani
 
Trunk Based Development in the Enterprise - Its Relevance and Economics
Perforce
 
Continuous Integration (CI) - An effective development practice
Dao Ngoc Kien
 
How do you tame a big ball of mud? One test at a time.
Matt Eland
 
DevOpsDaysRiga 2018: Neil Crawford - Trunk based development, continuous depl...
DevOpsDays Riga
 
Accessibility Testing Tools for Developers - Seattle Code Camp
gerardkcohen
 
TLC2018 Tanya Kravtsov: 10 Steps to CI, Testing and Delivery
Anna Royzman
 
[Webinar] Continuous Testing Done Right: Test Automation at the World's Leadi...
Applitools
 

Viewers also liked (20)

PDF
FishEye and Crucible Presentation
Ellen Feaheny
 
PPTX
Using Git and BitBucket
Medhat Dawoud
 
PDF
How Atlassian Scales Bitbucket Data Center on AWS
Atlassian
 
PPTX
Bitbucket
Okba Mahdjoub
 
PPTX
BitBucket presentation
Jonathan Lawerh
 
PPTX
Git from SVN
Justin Yoo
 
KEY
Git with bitbucket
Sumin Byeon
 
PPTX
git-and-bitbucket
azwildcat
 
PPTX
Crucibles slide show final rev.1
Calvin Hill
 
PDF
Pull Requests = Code Review
Atlassian
 
PDF
AtlasCamp 2015: Bitbucket: Building kick-ass tools for 2.5M developers
Atlassian
 
PDF
AtlasCamp 2015: Builders advancing humanity: Past to future
Atlassian
 
PDF
Making the Switch: One Team's Story of Adopting JIRA, FishEye, Eclipse & Myly...
Atlassian
 
KEY
Code Review: An apple a day
Kathryn Rotondo
 
PPTX
The Fisheye Analytics media lens training deck
Fisheye Analytics
 
PPTX
Intro to Git, GitHub, and BitBucket
Legal Services National Technology Assistance Project (LSNTAP)
 
PDF
Best of tata crucible handa
jain_rohit
 
PDF
Code Review: How and When
Paul Gower
 
PPTX
Improving Code Quality Through Effective Review Process
Dr. Syed Hassan Amin
 
PDF
The Best Booking Channels for Tours & Activities
Rezdy
 
FishEye and Crucible Presentation
Ellen Feaheny
 
Using Git and BitBucket
Medhat Dawoud
 
How Atlassian Scales Bitbucket Data Center on AWS
Atlassian
 
Bitbucket
Okba Mahdjoub
 
BitBucket presentation
Jonathan Lawerh
 
Git from SVN
Justin Yoo
 
Git with bitbucket
Sumin Byeon
 
git-and-bitbucket
azwildcat
 
Crucibles slide show final rev.1
Calvin Hill
 
Pull Requests = Code Review
Atlassian
 
AtlasCamp 2015: Bitbucket: Building kick-ass tools for 2.5M developers
Atlassian
 
AtlasCamp 2015: Builders advancing humanity: Past to future
Atlassian
 
Making the Switch: One Team's Story of Adopting JIRA, FishEye, Eclipse & Myly...
Atlassian
 
Code Review: An apple a day
Kathryn Rotondo
 
The Fisheye Analytics media lens training deck
Fisheye Analytics
 
Intro to Git, GitHub, and BitBucket
Legal Services National Technology Assistance Project (LSNTAP)
 
Best of tata crucible handa
jain_rohit
 
Code Review: How and When
Paul Gower
 
Improving Code Quality Through Effective Review Process
Dr. Syed Hassan Amin
 
The Best Booking Channels for Tours & Activities
Rezdy
 
Ad

Similar to Points.com fisheye crucible code reviews 2011 (20)

PDF
FUG Agile software engineering practices
Serena Software
 
PDF
Code Review Tool Evaluation
Kate Semizhon
 
PDF
Code Review
Lukas Rypl
 
PPTX
Unit3 software review control software
Reetesh Gupta
 
PPTX
AnyMP4 DVD Ripper 8.1.12 + Crack Free Download [Latest 2025]
salma
 
PPTX
Undelete Plus 4.0.23.823 Crack With License Key [Latest 2025]
salma
 
PDF
FishEye - Source Code Explore and more - Brief
Ellen Feaheny
 
PPTX
Serial Port Monitor 8.0.388 Crack With Activation Code [2025]
salma
 
PPTX
AlterCam 6.2 Full Crack With License Key Free Download [2025]
salma
 
PPTX
BitTorrent Pro 7.11.0.47063 Crack Full Free Download [2025]
salma
 
PPTX
Secret Disk Professional 2024.24 Crack With License Key [Latest]
salma
 
PPT
Adopting code reviews for agile software development
mariobernhart
 
PDF
Software Engineering Culture - Improve Code Quality
Dmytro Patserkovskyi
 
PPT
Introduction to Software Review
Philip Johnson
 
PDF
Code Review for Teams Too Busy to Review Code - Atlassian Summit 2010
Atlassian
 
PPTX
Agile Code Reviews: Supporting collaboration and improving production uptime ...
Atlassian
 
PPTX
Code Reviews
phildenoncourt
 
PPTX
Marrying Jenkins and Gerrit-Berlin Expert Days 2013
Dharmesh Sheta
 
PPTX
Peering into the white box: A testers approach to Code Reviews
Alan Page
 
PPTX
Code reviews
Robert Lee
 
FUG Agile software engineering practices
Serena Software
 
Code Review Tool Evaluation
Kate Semizhon
 
Code Review
Lukas Rypl
 
Unit3 software review control software
Reetesh Gupta
 
AnyMP4 DVD Ripper 8.1.12 + Crack Free Download [Latest 2025]
salma
 
Undelete Plus 4.0.23.823 Crack With License Key [Latest 2025]
salma
 
FishEye - Source Code Explore and more - Brief
Ellen Feaheny
 
Serial Port Monitor 8.0.388 Crack With Activation Code [2025]
salma
 
AlterCam 6.2 Full Crack With License Key Free Download [2025]
salma
 
BitTorrent Pro 7.11.0.47063 Crack Full Free Download [2025]
salma
 
Secret Disk Professional 2024.24 Crack With License Key [Latest]
salma
 
Adopting code reviews for agile software development
mariobernhart
 
Software Engineering Culture - Improve Code Quality
Dmytro Patserkovskyi
 
Introduction to Software Review
Philip Johnson
 
Code Review for Teams Too Busy to Review Code - Atlassian Summit 2010
Atlassian
 
Agile Code Reviews: Supporting collaboration and improving production uptime ...
Atlassian
 
Code Reviews
phildenoncourt
 
Marrying Jenkins and Gerrit-Berlin Expert Days 2013
Dharmesh Sheta
 
Peering into the white box: A testers approach to Code Reviews
Alan Page
 
Code reviews
Robert Lee
 
Ad

Recently uploaded (20)

PDF
Agentic AI lifecycle for Enterprise Hyper-Automation
Debmalya Biswas
 
PPTX
Webinar: Introduction to LF Energy EVerest
DanBrown980551
 
PDF
Achieving Consistent and Reliable AI Code Generation - Medusa AI
medusaaico
 
PDF
From Code to Challenge: Crafting Skill-Based Games That Engage and Reward
aiyshauae
 
PDF
Biography of Daniel Podor.pdf
Daniel Podor
 
PDF
POV_ Why Enterprises Need to Find Value in ZERO.pdf
darshakparmar
 
PDF
IoT-Powered Industrial Transformation – Smart Manufacturing to Connected Heal...
Rejig Digital
 
PDF
What Makes Contify’s News API Stand Out: Key Features at a Glance
Contify
 
PDF
DevBcn - Building 10x Organizations Using Modern Productivity Metrics
Justin Reock
 
PDF
Newgen 2022-Forrester Newgen TEI_13 05 2022-The-Total-Economic-Impact-Newgen-...
darshakparmar
 
PDF
The Rise of AI and IoT in Mobile App Tech.pdf
IMG Global Infotech
 
PDF
Empower Inclusion Through Accessible Java Applications
Ana-Maria Mihalceanu
 
PDF
"AI Transformation: Directions and Challenges", Pavlo Shaternik
Fwdays
 
PDF
HubSpot Main Hub: A Unified Growth Platform
Jaswinder Singh
 
PPTX
AUTOMATION AND ROBOTICS IN PHARMA INDUSTRY.pptx
sameeraaabegumm
 
PPTX
COMPARISON OF RASTER ANALYSIS TOOLS OF QGIS AND ARCGIS
Sharanya Sarkar
 
PDF
LLMs.txt: Easily Control How AI Crawls Your Site
Keploy
 
PDF
[Newgen] NewgenONE Marvin Brochure 1.pdf
darshakparmar
 
PPTX
WooCommerce Workshop: Bring Your Laptop
Laura Hartwig
 
PDF
CIFDAQ Weekly Market Wrap for 11th July 2025
CIFDAQ
 
Agentic AI lifecycle for Enterprise Hyper-Automation
Debmalya Biswas
 
Webinar: Introduction to LF Energy EVerest
DanBrown980551
 
Achieving Consistent and Reliable AI Code Generation - Medusa AI
medusaaico
 
From Code to Challenge: Crafting Skill-Based Games That Engage and Reward
aiyshauae
 
Biography of Daniel Podor.pdf
Daniel Podor
 
POV_ Why Enterprises Need to Find Value in ZERO.pdf
darshakparmar
 
IoT-Powered Industrial Transformation – Smart Manufacturing to Connected Heal...
Rejig Digital
 
What Makes Contify’s News API Stand Out: Key Features at a Glance
Contify
 
DevBcn - Building 10x Organizations Using Modern Productivity Metrics
Justin Reock
 
Newgen 2022-Forrester Newgen TEI_13 05 2022-The-Total-Economic-Impact-Newgen-...
darshakparmar
 
The Rise of AI and IoT in Mobile App Tech.pdf
IMG Global Infotech
 
Empower Inclusion Through Accessible Java Applications
Ana-Maria Mihalceanu
 
"AI Transformation: Directions and Challenges", Pavlo Shaternik
Fwdays
 
HubSpot Main Hub: A Unified Growth Platform
Jaswinder Singh
 
AUTOMATION AND ROBOTICS IN PHARMA INDUSTRY.pptx
sameeraaabegumm
 
COMPARISON OF RASTER ANALYSIS TOOLS OF QGIS AND ARCGIS
Sharanya Sarkar
 
LLMs.txt: Easily Control How AI Crawls Your Site
Keploy
 
[Newgen] NewgenONE Marvin Brochure 1.pdf
darshakparmar
 
WooCommerce Workshop: Bring Your Laptop
Laura Hartwig
 
CIFDAQ Weekly Market Wrap for 11th July 2025
CIFDAQ
 

Points.com fisheye crucible code reviews 2011

  • 1. Private and Confidential Private and Confidential July 28, 2011 Private and Confidential Fisheye, Crucible and the wonders of  Code Reviews Thank you Atlassian! Created by Michael Lossos Points.com July 2011 Private & Confidential
  • 2. Private and Confidential Private and Confidential Agenda Why code reviews? Code review tips What's Fisheye for? What's Crucible for? Fisheye answers Crucible workflows
  • 3. Why code reviews? Catch bugs and design flaws early. Help teammates learn. Enforce coding standards, consistency. Ensure architecture alignment.  Review tests. 
  • 4. When do code reviews? Early and Often. Daily. Theme: small commits, incremental changes, frequent small reviews. This is less work... Than fixing buggy bug bugs. Than fatty reviews. Than big bang commits.
  • 5. Code reviews: what to look for Design or logic errors. Missing parameter / pre-condition checks. Bad/missing exception handling. Incorrect log levels (error -> info). Useless log messages (not enough context). Long methods (> 20 - 50 lines of code). Potential side effects. Missing comments/docs on interfaces. More at:  https://mwiki.points.com/wiki/Code_Reviews
  • 6. What's Fisheye for? Fisheye aka FE ViewVC replacement. Source code: Browsing / viewing Comparison Search Monitoring (activity stream)
  • 7. What's Crucible for? Crucible aka CRU* Code reviews. Pre and post commit. Collaboration. Comments in reviews. Notifications. Release branch code checks.     *FishEye + Crucible = FECRU   ;)
  • 8. Fisheye answers (1) What changes are in this release?  commit graph, hover on dots to ctrl+c changeset# Were these commits merged between branches?
  • 10. Fisheye commit graph (2) Copy changeset numbers.
  • 11. Fisheye answers (2) What commits associated with a JIRA issue? What code reviews are there for this code?
  • 12. Fisheye commit graph (3): reviews
  • 13. Fisheye answers (3) Who made that change?  line by line blame When was that change introduced?  start date for bugs
  • 15. Fisheye answers (4) Where's that code?  Search, browse, by filename
  • 16. Fisheye answers (5) Where's that code?  QuickNav bar CamelCase filename wildcard matching  e.g. BI => BuyImpl => BuyServiceImpl
  • 17. Fisheye answers (5) How can I share a link to this file in FE? How can I filter changesets in a diff?
  • 18. Crucible: creating reviews (1) Anyone creates a review * Committer usually creates review Add reviewers Notifications Link to JIRA Finding changes:  Browse Search: author/branch *Anyone  with a login + license
  • 21. Crucible: creating reviews (4) By author, date, etc.
  • 24. Crucible: navigating reviews (1) Comments, creating defects.
  • 25. Crucible: navigating reviews (2) Flipping through comments, filters. 
  • 26. Crucible: navigating reviews (3) Side by side diffs, unified diffs, context.
  • 27. Crucible: navigating reviews (4) Files marked as reviewed. Progress meter => done.  Mark complete, summary.
  • 28. Happy Linking:  Fisheye <=> Crucible <=> JIRA
  • 29. Happy Linking:  Fisheye <=> Crucible <=> JIRA (2)
  • 30. Getting Started Who to contact Licenses  Unified usernames Our Crucible/Fisheye
  • 31. Slightly More Advanced Stuff Pre-commit CRs: Snippets Pre-commit CRs: Eclipse IDE connector. EyeQL
  • 32. Links to more info Better code and what to look for in code reviews: Effective Java by Josh Bloch http://my.safaribooksonline.com/book/programming/java/9780137150021?bookview=overview Code Complete by Steve McConnell http://my.safaribooksonline.com/book/software-engineering-and-development/0735619670?bookview=overview Fisheye & Crucible links: http://summit.atlassian.com/archives/code-and-build/developer-tools-state-of-union http://www.atlassian.com/software/fisheye/tour/ http://confluence.atlassian.com/display/FISHEYE/FishEye+User%27s+Guide http://blogs.atlassian.com/devtools/2011/07/developer-tools-state-union--summit-2011.html http://www.atlassian.com/software/crucible/tour/ http://confluence.atlassian.com/display/CRUCIBLE/Crucible+User%27s+Guide