Static Analysis in IDEA

IntelliJ IDEA
Static Code Analysis

Hamlet D'Arcy
Canoo Engineering AG
@HamletDRC
http://hamletdarcy.blogspot.com

Code Inspections
JSR 305 and 308 Annotations
Duplicate Detection
Stack Trace Analysis
Dataflow Analysis
Dependency Analysis

www.jetbrains.com/idea 2

About Me


Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


class _01Example {

private static long count = 0L;

public synchronized void increment() {
count++;
}
}


class _02Example {

private boolean active = false;

public boolean isActive() {
return active;
}

public synchronized void activate() {
active = true;
}
}

class _03Example {
private final ReentrantLock lock = new ReentrantLock();
private boolean active = false;

public boolean isActive() throws Exception {
lock.lock();
boolean result = active;
lock.unlock();
return result;
}

public void activate() {
lock.lock();
active = true;
lock.unlock();
}
}


class _04Example {
private static final boolean DEFAULT = true;

void myMethod(Boolean value) {
if (value == null)
System.out.println("value: null");
value = DEFAULT;

System.out.println("received: " + value);
}
}


class _05Example {

Frame makeFrame(int height, int width) {
Frame frame = new Frame();
frame.setSize(height, width);
return frame;
}

Rectangle makeRectangle() {
int x = 0;
int y = 0;
return new Rectangle(y, x, 20, 20);
}
}

class _06Example {
{
try {
doSomething();
} catch (UnsupportedOperationException e) {
handleError(e);
} catch (IllegalStateException e) {
handleError(e);
} catch (IllegalArgumentException e) {
handleError(e);
}
}
...
}

class _07Example {
private def Object lock = new Object()

def method() {
synchronized(lock) {
// do something
}
}
}


class _08Example {
var property: String = null

def getProperty() {
println(property)
}
}


Correctness
Multi-threaded correctness
Malicious code vulnerability
Bad practice
Internationalization
Performance
Code style violations
Dodgy
* Bill Pugh, FindBugs

… and more
Suppress False Positives
Define profiles and scopes
Run on demand
Run from command line
Team City integration
FindBugs, PMD & CheckStyle plugins
Language and framework support...


Supported Frameworks
Android JSF
Ant JSP
Application Server Junit
Inspections LESS
CDI(Contexts and Maven
Dependency OSGi
Injection)
RELAX NG
CSS
SCSS
Faces Model
Spring Model
FreeMarker

Write Your Own

IntelliJ IDEA Static Analysis:
Custom Rules with Structural Search & Replace

On http://JetBrains.tv


10 Best Unknown Inspections
Illegal package dependencies return of collection or array
'this' reference escapes field
constructor call to 'Thread.run()'
Field accessed in both expression.equals("literal")
synched & unsynched rather than
contexts "literal".equals(expression)
non private field accessed in equals method does not check
synched context class of parameter
Synchronization on 'this' and method may be static
'synchronized' method

http://hamletdarcy.blogspot.com/2008/04/10-best-idea-inspections-youre-not.html


How it Works
Searches AST for Bug Patterns


How it Works
@Override
public void visitMethod(@NotNull final PsiMethod method) {
super.visitMethod(method);
if (method.hasModifierProperty(PsiModifier.ABSTRACT)) {
return;
}
if (!RecursionUtils.methodMayRecurse(method)) {
return;
}
if (!RecursionUtils.methodDefinitelyRecurses(method)) {
return;
}
super.registerMethodError(method);
}

Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


@Immutable and @GuardedBy
@Immutable
public class GuardedByExample {

private final Object lock = new Object();

@GuardedBy("lock")
private final List<Object> myList = new ArrayList<Object>();

public Object getElement(int index) {
synchronized (lock) {
return myList.get(index);
}
}

public void addElement(Object e) {
synchronized (lock) {
myList.add(e);
}
}
}

@Nullable and @NotNull
public class NullableExample {
@Nullable Integer getId() {
return 1;
}

@NotNull String getName() {
return "name";
}

@Override public String toString() {
if (getName() == null) {
return getId().toString() + "<unknown>";
} else {
return getId().toString() + getName();
}
}
}

@Pattern

class PatternExample {

@Pattern("[a-zA-Z]+")
String getName() {
return "my name";
}
}


@Language

public class LanguageExample {

@Language("Groovy")
String getScript() {
return "5.times { i -> println "Hello $i" } ";
}

String getMarkup() {
@Language("XML")
String markup = "<root><body>Some Text</body></root>";
return markup;
}
}


@Nls, @NonNls, @PropertyKey
Resource bundle & i18n integration

Extracting hard-coded String literals:
http://goo.gl/VZDln

Documentation: http://goo.gl/NWzsv


Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


Duplicate Detection
Anonymizes Local Variables, Fields,
Methods, Types, and Literals
Provides weighted/scored analysis
Supports several languages

More info: http://goo.gl/qmhhd


Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


Analyze Stacktrace
Copy and paste log files into IDEA
ZKM Unscramble support (& others)

More Info: http://goo.gl/A8i87


Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


Dataflow Analysis
Code archeology

to here – how a reference gets set
from here – where a reference goes to

More info: http://goo.gl/Cp92Q


Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


UML Generation
Dynamically generates diagram
Standard Show/Hide options
Integrated with Refactorings

Dependency Analysis
Shows all classes your code depends on
Shows specific usages in your classes
Allows jump to source

Dependency Structure Matrix
Analyzes structure of complex projects
Shows module, package, class
dependencies
Shows cyclic & backwards dependencies
Helps eliminate illegal dependencies


Classes on top depend-on classes below


* le click *

CalculatorFacade uses:
– Conversions, OperationsFactory & BinaryOperation


CalculatorFacade is used by
– CalculatorServlet & FPCalculatorServlet


* le click *
BinaryOperation is used 4 times by Facade
– Darker color == more dependencies
Green shows who BinaryOperation is “used by”
Yellow shows who BinaryOperation “uses”

Cyclic Dependencies can be highlighted
Modules can be collapsed/expanded


Dependency Structure Matrix
Demos on JetBrains site & booth

Feature Overview: http://goo.gl/0bcz3
JetBrains Blog Post: http://goo.gl/fdj26
Canoo Blog Post: http://goo.gl/M1hTY


Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


Software Lifecycle
Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis


Software Lifecycle
Code Inspections every second
JSR 305 and 308 Annotations every second

Duplicate Detection
Dataflow Analysis
Dependency Analysis


Software Lifecycle
Code Inspections every debug
JSR 305 and 308 Annotations every debug

Duplicate Detection
Dataflow Analysis every debug
Dependency Analysis


Software Lifecycle
Code Inspections every build
Duplicate Detection
Dataflow Analysis
Dependency Analysis


Software Lifecycle
Code Inspections
Duplicate Detection every day
Dataflow Analysis
Dependency Analysis


Software Lifecycle
Code Inspections
Duplicate Detection
Dataflow Analysis
Dependency Analysis every release


Learn More – Q & A
My JetBrains.tv Screencasts: http://tv.jetbrains.net/tags/hamlet
My IDEA blog: http://hamletdarcy.blogspot.com/search/label/IDEA
Work's IDEA blog: http://www.canoo.com/blog/tag/idea/
Main blog: http://hamletdarcy.blogspot.com
YouTube channel: http://www.youtube.com/user/HamletDRC
Twitter: http://twitter.com/hamletdrc
IDEA RefCard from DZone: http://goo.gl/Fg4Af
IDEA Keyboard Stickers: JetBrains Booth

Share-a-Canooie – http://people.canoo.com/share/
Hackergarten – http://www.hackergarten.net/

Static Analysis in IDEA

More Related Content

What's hot (20)

Similar to Static Analysis in IDEA (20)

More from HamletDRC (8)

Recently uploaded (20)

Static Analysis in IDEA

Editor's Notes