Skip to content

fix: add redirect_uri_trailing slash param to run_local_server #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

arithmetic1728
Copy link
Contributor

Fixes #110

Add a new redirect_uri_trailing_slash keyword argument to run_local_server. If the user's redirect_uri doesn't have trailing slash (http://localhost:{port}), then the user can pass redirect_uri_trailing_slash=True when calling run_local_server.

@arithmetic1728 arithmetic1728 requested a review from a team as a code owner March 29, 2021 19:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2021
@arithmetic1728 arithmetic1728 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2021
@arithmetic1728 arithmetic1728 merged commit 666863a into master Mar 29, 2021
@arithmetic1728 arithmetic1728 deleted the slash branch March 29, 2021 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InstalledAppFlow.run_local_server() asserts self.redirect_uri ends with '/'
3 participants