Skip to content

fix(deps): add lower bounds to all dependencies #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 6, 2021

Conversation

busunkim96
Copy link
Contributor

Add constraints file to test lower bounds

@busunkim96 busunkim96 requested a review from a team as a code owner December 4, 2020 00:50
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2020
@busunkim96 busunkim96 changed the title chore: add constraints file fix(deps): add lower bounds to all dependencies Feb 6, 2021
@@ -18,9 +18,9 @@
from setuptools import setup


TOOL_DEPENDENCIES = "click"
TOOL_DEPENDENCIES = "click>=6.0.0"
Copy link
Contributor Author

@busunkim96 busunkim96 Feb 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the right version, but it can be tweaked when the noxfile is updated to use these constraints files: googleapis/synthtool#869

Copy link
Contributor

@arithmetic1728 arithmetic1728 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants