Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add error when value is misconfigured
  • Loading branch information
dargudear-google committed Dec 3, 2024
commit 0bfd387972a20b0347a5bb06343e67c49c0cc8b2
6 changes: 1 addition & 5 deletions vars/vars.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,7 @@ func (ev EnvVar) GetBooleanValue() (bool, error) {
if isPresent {
boolValue, err := strconv.ParseBool(oEnvValue)
if err != nil {
defaultBoolValue, err := strconv.ParseBool(ev.defaultValue)
if err != nil {
return false, fmt.Errorf("error parsing default value: %v", err)
}
return defaultBoolValue, nil
return false, fmt.Errorf("error parsing the boolean value: %v", err)
}
return boolValue, nil
}
Expand Down
8 changes: 1 addition & 7 deletions vars/vars_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func TestGetBooleanValue(t *testing.T) {
name: "default value when env value is misconigured",
in: EnvVar{envVarName: "TEST_ENV_VAR", defaultValue: "false", isRequired: false},
want: false,
wantErr: nil,
wantErr: fmt.Errorf("error parsing the boolean value: strconv.ParseBool: parsing \"not_a_bool\": invalid syntax"),
envVars: map[string]string{"TEST_ENV_VAR": "not_a_bool"},
},
{
Expand All @@ -112,12 +112,6 @@ func TestGetBooleanValue(t *testing.T) {
wantErr: fmt.Errorf("error parsing default value: strconv.ParseBool: parsing \"not_a_bool\": invalid syntax"),
envVars: map[string]string{},
},
{
name: "default value is misconfigured and env var is present",
in: EnvVar{envVarName: "TEST_ENV_VAR", defaultValue: "not_a_bool", isRequired: false},
wantErr: fmt.Errorf("error parsing default value: strconv.ParseBool: parsing \"not_a_bool\": invalid syntax"),
envVars: map[string]string{"TEST_ENV_VAR": "again_not_a_bool"},
},
}
for _, tc := range tests {
t.Run(tc.name, func(t *testing.T) {
Expand Down
Loading