blob: c9195fc67fd8fc41dbe5614b04e3cd9a5f0e42dd [file] [log] [blame]
Thomas Gleixner2874c5f2019-05-27 08:55:01 +02001// SPDX-License-Identifier: GPL-2.0-or-later
David Howells31143d52007-05-09 02:33:46 -07002/* handling of writes to regular files and writing back to the server
3 *
4 * Copyright (C) 2007 Red Hat, Inc. All Rights Reserved.
5 * Written by David Howells ([email protected])
David Howells31143d52007-05-09 02:33:46 -07006 */
David Howells4343d002017-11-02 15:27:52 +00007
Alexey Dobriyan4af3c9c2007-10-16 23:29:23 -07008#include <linux/backing-dev.h>
David Howells31143d52007-05-09 02:33:46 -07009#include <linux/slab.h>
10#include <linux/fs.h>
11#include <linux/pagemap.h>
12#include <linux/writeback.h>
13#include <linux/pagevec.h>
14#include "internal.h"
15
David Howells31143d52007-05-09 02:33:46 -070016/*
17 * mark a page as having been made dirty and thus needing writeback
18 */
19int afs_set_page_dirty(struct page *page)
20{
21 _enter("");
22 return __set_page_dirty_nobuffers(page);
23}
24
25/*
David Howells31143d52007-05-09 02:33:46 -070026 * partly or wholly fill a page that's under preparation for writing
27 */
28static int afs_fill_page(struct afs_vnode *vnode, struct key *key,
David Howellse8e581a2017-03-16 16:27:44 +000029 loff_t pos, unsigned int len, struct page *page)
David Howells31143d52007-05-09 02:33:46 -070030{
David Howells196ee9c2017-01-05 10:38:34 +000031 struct afs_read *req;
David Howells2a0b4f62018-10-20 00:57:57 +010032 size_t p;
33 void *data;
David Howells31143d52007-05-09 02:33:46 -070034 int ret;
35
Anton Blanchard5e7f2332011-06-13 22:31:12 +010036 _enter(",,%llu", (unsigned long long)pos);
David Howells31143d52007-05-09 02:33:46 -070037
David Howells2a0b4f62018-10-20 00:57:57 +010038 if (pos >= vnode->vfs_inode.i_size) {
39 p = pos & ~PAGE_MASK;
40 ASSERTCMP(p + len, <=, PAGE_SIZE);
41 data = kmap(page);
42 memset(data + p, 0, len);
43 kunmap(page);
44 return 0;
45 }
46
Zhengyuan Liuee102582019-06-20 18:12:17 +010047 req = kzalloc(struct_size(req, array, 1), GFP_KERNEL);
David Howells196ee9c2017-01-05 10:38:34 +000048 if (!req)
49 return -ENOMEM;
50
David Howellsf3ddee82018-04-06 14:17:25 +010051 refcount_set(&req->usage, 1);
David Howells196ee9c2017-01-05 10:38:34 +000052 req->pos = pos;
David Howellse8e581a2017-03-16 16:27:44 +000053 req->len = len;
David Howells196ee9c2017-01-05 10:38:34 +000054 req->nr_pages = 1;
David Howellsf3ddee82018-04-06 14:17:25 +010055 req->pages = req->array;
David Howells196ee9c2017-01-05 10:38:34 +000056 req->pages[0] = page;
David Howells5611ef22017-03-16 16:27:43 +000057 get_page(page);
David Howells196ee9c2017-01-05 10:38:34 +000058
David Howellsd2ddc772017-11-02 15:27:50 +000059 ret = afs_fetch_data(vnode, key, req);
David Howells196ee9c2017-01-05 10:38:34 +000060 afs_put_read(req);
David Howells31143d52007-05-09 02:33:46 -070061 if (ret < 0) {
62 if (ret == -ENOENT) {
63 _debug("got NOENT from server"
64 " - marking file deleted and stale");
65 set_bit(AFS_VNODE_DELETED, &vnode->flags);
66 ret = -ESTALE;
67 }
68 }
69
70 _leave(" = %d", ret);
71 return ret;
72}
73
74/*
David Howells31143d52007-05-09 02:33:46 -070075 * prepare to perform part of a write to a page
David Howells31143d52007-05-09 02:33:46 -070076 */
Nick Piggin15b46502008-10-15 22:04:32 -070077int afs_write_begin(struct file *file, struct address_space *mapping,
78 loff_t pos, unsigned len, unsigned flags,
David Howells21db2cd2020-10-22 14:03:03 +010079 struct page **_page, void **fsdata)
David Howells31143d52007-05-09 02:33:46 -070080{
Al Viro496ad9a2013-01-23 17:07:38 -050081 struct afs_vnode *vnode = AFS_FS_I(file_inode(file));
Nick Piggin15b46502008-10-15 22:04:32 -070082 struct page *page;
David Howells215804a2017-11-02 15:27:52 +000083 struct key *key = afs_file_key(file);
David Howells4343d002017-11-02 15:27:52 +000084 unsigned long priv;
85 unsigned f, from = pos & (PAGE_SIZE - 1);
86 unsigned t, to = from + len;
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +030087 pgoff_t index = pos >> PAGE_SHIFT;
David Howells31143d52007-05-09 02:33:46 -070088 int ret;
89
David Howells3b6492d2018-10-20 00:57:57 +010090 _enter("{%llx:%llu},{%lx},%u,%u",
Nick Piggin15b46502008-10-15 22:04:32 -070091 vnode->fid.vid, vnode->fid.vnode, index, from, to);
David Howells31143d52007-05-09 02:33:46 -070092
Nick Piggin54566b22009-01-04 12:00:53 -080093 page = grab_cache_page_write_begin(mapping, index, flags);
David Howells4343d002017-11-02 15:27:52 +000094 if (!page)
Nick Piggin15b46502008-10-15 22:04:32 -070095 return -ENOMEM;
Nick Piggin15b46502008-10-15 22:04:32 -070096
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +030097 if (!PageUptodate(page) && len != PAGE_SIZE) {
David Howellse8e581a2017-03-16 16:27:44 +000098 ret = afs_fill_page(vnode, key, pos & PAGE_MASK, PAGE_SIZE, page);
David Howells31143d52007-05-09 02:33:46 -070099 if (ret < 0) {
David Howells6d06b0d2017-03-16 16:27:48 +0000100 unlock_page(page);
101 put_page(page);
David Howells31143d52007-05-09 02:33:46 -0700102 _leave(" = %d [prep]", ret);
103 return ret;
104 }
Nick Piggin15b46502008-10-15 22:04:32 -0700105 SetPageUptodate(page);
David Howells31143d52007-05-09 02:33:46 -0700106 }
107
David Howells31143d52007-05-09 02:33:46 -0700108try_again:
David Howells4343d002017-11-02 15:27:52 +0000109 /* See if this page is already partially written in a way that we can
110 * merge the new write with.
111 */
112 t = f = 0;
113 if (PagePrivate(page)) {
114 priv = page_private(page);
David Howells185f0c72020-10-26 13:22:47 +0000115 f = afs_page_dirty_from(priv);
116 t = afs_page_dirty_to(priv);
David Howells4343d002017-11-02 15:27:52 +0000117 ASSERTCMP(f, <=, t);
David Howells31143d52007-05-09 02:33:46 -0700118 }
119
David Howells4343d002017-11-02 15:27:52 +0000120 if (f != t) {
David Howells5a039c32017-11-18 00:13:30 +0000121 if (PageWriteback(page)) {
122 trace_afs_page_dirty(vnode, tracepoint_string("alrdy"),
123 page->index, priv);
124 goto flush_conflicting_write;
125 }
David Howells5a813272018-04-06 14:17:26 +0100126 /* If the file is being filled locally, allow inter-write
127 * spaces to be merged into writes. If it's not, only write
128 * back what the user gives us.
129 */
130 if (!test_bit(AFS_VNODE_NEW_CONTENT, &vnode->flags) &&
131 (to < f || from > t))
David Howells4343d002017-11-02 15:27:52 +0000132 goto flush_conflicting_write;
David Howells31143d52007-05-09 02:33:46 -0700133 }
134
David Howells21db2cd2020-10-22 14:03:03 +0100135 *_page = page;
David Howells4343d002017-11-02 15:27:52 +0000136 _leave(" = 0");
David Howells31143d52007-05-09 02:33:46 -0700137 return 0;
138
David Howells4343d002017-11-02 15:27:52 +0000139 /* The previous write and this write aren't adjacent or overlapping, so
140 * flush the page out.
141 */
142flush_conflicting_write:
David Howells31143d52007-05-09 02:33:46 -0700143 _debug("flush conflict");
David Howells4343d002017-11-02 15:27:52 +0000144 ret = write_one_page(page);
David Howells21db2cd2020-10-22 14:03:03 +0100145 if (ret < 0)
146 goto error;
David Howells31143d52007-05-09 02:33:46 -0700147
David Howells4343d002017-11-02 15:27:52 +0000148 ret = lock_page_killable(page);
David Howells21db2cd2020-10-22 14:03:03 +0100149 if (ret < 0)
150 goto error;
David Howells31143d52007-05-09 02:33:46 -0700151 goto try_again;
David Howells21db2cd2020-10-22 14:03:03 +0100152
153error:
154 put_page(page);
155 _leave(" = %d", ret);
156 return ret;
David Howells31143d52007-05-09 02:33:46 -0700157}
158
159/*
160 * finalise part of a write to a page
161 */
Nick Piggin15b46502008-10-15 22:04:32 -0700162int afs_write_end(struct file *file, struct address_space *mapping,
163 loff_t pos, unsigned len, unsigned copied,
164 struct page *page, void *fsdata)
David Howells31143d52007-05-09 02:33:46 -0700165{
Al Viro496ad9a2013-01-23 17:07:38 -0500166 struct afs_vnode *vnode = AFS_FS_I(file_inode(file));
David Howells215804a2017-11-02 15:27:52 +0000167 struct key *key = afs_file_key(file);
David Howellsf792e3a2020-10-26 14:05:33 +0000168 unsigned long priv;
169 unsigned int f, from = pos & (PAGE_SIZE - 1);
170 unsigned int t, to = from + copied;
David Howells31143d52007-05-09 02:33:46 -0700171 loff_t i_size, maybe_i_size;
David Howells3ad216e2020-11-14 17:27:57 +0000172 int ret = 0;
David Howells31143d52007-05-09 02:33:46 -0700173
David Howells3b6492d2018-10-20 00:57:57 +0100174 _enter("{%llx:%llu},{%lx}",
Nick Piggin15b46502008-10-15 22:04:32 -0700175 vnode->fid.vid, vnode->fid.vnode, page->index);
David Howells31143d52007-05-09 02:33:46 -0700176
David Howells3ad216e2020-11-14 17:27:57 +0000177 if (copied == 0)
178 goto out;
179
Nick Piggin15b46502008-10-15 22:04:32 -0700180 maybe_i_size = pos + copied;
David Howells31143d52007-05-09 02:33:46 -0700181
182 i_size = i_size_read(&vnode->vfs_inode);
183 if (maybe_i_size > i_size) {
David Howells1f32ef72020-06-12 23:58:51 +0100184 write_seqlock(&vnode->cb_lock);
David Howells31143d52007-05-09 02:33:46 -0700185 i_size = i_size_read(&vnode->vfs_inode);
186 if (maybe_i_size > i_size)
187 i_size_write(&vnode->vfs_inode, maybe_i_size);
David Howells1f32ef72020-06-12 23:58:51 +0100188 write_sequnlock(&vnode->cb_lock);
David Howells31143d52007-05-09 02:33:46 -0700189 }
190
David Howellse8e581a2017-03-16 16:27:44 +0000191 if (!PageUptodate(page)) {
192 if (copied < len) {
193 /* Try and load any missing data from the server. The
194 * unmarshalling routine will take care of clearing any
195 * bits that are beyond the EOF.
196 */
197 ret = afs_fill_page(vnode, key, pos + copied,
198 len - copied, page);
199 if (ret < 0)
David Howellsafae4572018-01-02 10:02:19 +0000200 goto out;
David Howellse8e581a2017-03-16 16:27:44 +0000201 }
202 SetPageUptodate(page);
203 }
204
David Howellsf792e3a2020-10-26 14:05:33 +0000205 if (PagePrivate(page)) {
206 priv = page_private(page);
David Howells185f0c72020-10-26 13:22:47 +0000207 f = afs_page_dirty_from(priv);
208 t = afs_page_dirty_to(priv);
David Howellsf792e3a2020-10-26 14:05:33 +0000209 if (from < f)
210 f = from;
211 if (to > t)
212 t = to;
David Howells185f0c72020-10-26 13:22:47 +0000213 priv = afs_page_dirty(f, t);
David Howellsf792e3a2020-10-26 14:05:33 +0000214 set_page_private(page, priv);
215 trace_afs_page_dirty(vnode, tracepoint_string("dirty+"),
216 page->index, priv);
217 } else {
David Howells185f0c72020-10-26 13:22:47 +0000218 priv = afs_page_dirty(from, to);
David Howellsf792e3a2020-10-26 14:05:33 +0000219 attach_page_private(page, (void *)priv);
220 trace_afs_page_dirty(vnode, tracepoint_string("dirty"),
221 page->index, priv);
222 }
223
David Howells31143d52007-05-09 02:33:46 -0700224 set_page_dirty(page);
David Howells31143d52007-05-09 02:33:46 -0700225 if (PageDirty(page))
226 _debug("dirtied");
David Howellsafae4572018-01-02 10:02:19 +0000227 ret = copied;
228
229out:
Nick Piggin15b46502008-10-15 22:04:32 -0700230 unlock_page(page);
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300231 put_page(page);
David Howellsafae4572018-01-02 10:02:19 +0000232 return ret;
David Howells31143d52007-05-09 02:33:46 -0700233}
234
235/*
236 * kill all the pages in the given range
237 */
David Howells4343d002017-11-02 15:27:52 +0000238static void afs_kill_pages(struct address_space *mapping,
David Howells31143d52007-05-09 02:33:46 -0700239 pgoff_t first, pgoff_t last)
240{
David Howells4343d002017-11-02 15:27:52 +0000241 struct afs_vnode *vnode = AFS_FS_I(mapping->host);
David Howells31143d52007-05-09 02:33:46 -0700242 struct pagevec pv;
243 unsigned count, loop;
244
David Howells3b6492d2018-10-20 00:57:57 +0100245 _enter("{%llx:%llu},%lx-%lx",
David Howells31143d52007-05-09 02:33:46 -0700246 vnode->fid.vid, vnode->fid.vnode, first, last);
247
Mel Gorman86679822017-11-15 17:37:52 -0800248 pagevec_init(&pv);
David Howells31143d52007-05-09 02:33:46 -0700249
250 do {
251 _debug("kill %lx-%lx", first, last);
252
253 count = last - first + 1;
254 if (count > PAGEVEC_SIZE)
255 count = PAGEVEC_SIZE;
David Howells4343d002017-11-02 15:27:52 +0000256 pv.nr = find_get_pages_contig(mapping, first, count, pv.pages);
David Howells31143d52007-05-09 02:33:46 -0700257 ASSERTCMP(pv.nr, ==, count);
258
259 for (loop = 0; loop < count; loop++) {
David Howells7286a352017-03-16 16:27:48 +0000260 struct page *page = pv.pages[loop];
261 ClearPageUptodate(page);
David Howells4343d002017-11-02 15:27:52 +0000262 SetPageError(page);
263 end_page_writeback(page);
David Howells7286a352017-03-16 16:27:48 +0000264 if (page->index >= first)
265 first = page->index + 1;
David Howells4343d002017-11-02 15:27:52 +0000266 lock_page(page);
267 generic_error_remove_page(mapping, page);
Marc Dionne21bd68f2019-04-13 08:37:37 +0100268 unlock_page(page);
David Howells31143d52007-05-09 02:33:46 -0700269 }
270
271 __pagevec_release(&pv);
David Howells4343d002017-11-02 15:27:52 +0000272 } while (first <= last);
David Howells31143d52007-05-09 02:33:46 -0700273
274 _leave("");
275}
276
277/*
David Howells4343d002017-11-02 15:27:52 +0000278 * Redirty all the pages in a given range.
David Howells31143d52007-05-09 02:33:46 -0700279 */
David Howells4343d002017-11-02 15:27:52 +0000280static void afs_redirty_pages(struct writeback_control *wbc,
281 struct address_space *mapping,
282 pgoff_t first, pgoff_t last)
David Howells31143d52007-05-09 02:33:46 -0700283{
David Howells4343d002017-11-02 15:27:52 +0000284 struct afs_vnode *vnode = AFS_FS_I(mapping->host);
285 struct pagevec pv;
286 unsigned count, loop;
287
David Howells3b6492d2018-10-20 00:57:57 +0100288 _enter("{%llx:%llu},%lx-%lx",
David Howells4343d002017-11-02 15:27:52 +0000289 vnode->fid.vid, vnode->fid.vnode, first, last);
290
Linus Torvalds487e2c92017-11-16 11:41:22 -0800291 pagevec_init(&pv);
David Howells4343d002017-11-02 15:27:52 +0000292
293 do {
294 _debug("redirty %lx-%lx", first, last);
295
296 count = last - first + 1;
297 if (count > PAGEVEC_SIZE)
298 count = PAGEVEC_SIZE;
299 pv.nr = find_get_pages_contig(mapping, first, count, pv.pages);
300 ASSERTCMP(pv.nr, ==, count);
301
302 for (loop = 0; loop < count; loop++) {
303 struct page *page = pv.pages[loop];
304
305 redirty_page_for_writepage(wbc, page);
306 end_page_writeback(page);
David Howells31143d52007-05-09 02:33:46 -0700307 if (page->index >= first)
308 first = page->index + 1;
309 }
310
311 __pagevec_release(&pv);
David Howells4343d002017-11-02 15:27:52 +0000312 } while (first <= last);
David Howells31143d52007-05-09 02:33:46 -0700313
314 _leave("");
315}
316
317/*
David Howellsa58823a2019-05-09 15:16:10 +0100318 * completion of write to server
319 */
320static void afs_pages_written_back(struct afs_vnode *vnode,
321 pgoff_t first, pgoff_t last)
322{
323 struct pagevec pv;
324 unsigned long priv;
325 unsigned count, loop;
326
327 _enter("{%llx:%llu},{%lx-%lx}",
328 vnode->fid.vid, vnode->fid.vnode, first, last);
329
330 pagevec_init(&pv);
331
332 do {
333 _debug("done %lx-%lx", first, last);
334
335 count = last - first + 1;
336 if (count > PAGEVEC_SIZE)
337 count = PAGEVEC_SIZE;
338 pv.nr = find_get_pages_contig(vnode->vfs_inode.i_mapping,
339 first, count, pv.pages);
340 ASSERTCMP(pv.nr, ==, count);
341
342 for (loop = 0; loop < count; loop++) {
David Howellsfa04a402020-10-21 13:22:19 +0100343 priv = (unsigned long)detach_page_private(pv.pages[loop]);
David Howellsa58823a2019-05-09 15:16:10 +0100344 trace_afs_page_dirty(vnode, tracepoint_string("clear"),
345 pv.pages[loop]->index, priv);
David Howellsa58823a2019-05-09 15:16:10 +0100346 end_page_writeback(pv.pages[loop]);
347 }
348 first += count;
349 __pagevec_release(&pv);
350 } while (first <= last);
351
352 afs_prune_wb_keys(vnode);
353 _leave("");
354}
355
356/*
David Howellse49c7b22020-04-10 20:51:51 +0100357 * Find a key to use for the writeback. We cached the keys used to author the
358 * writes on the vnode. *_wbk will contain the last writeback key used or NULL
359 * and we need to start from there if it's set.
360 */
361static int afs_get_writeback_key(struct afs_vnode *vnode,
362 struct afs_wb_key **_wbk)
363{
364 struct afs_wb_key *wbk = NULL;
365 struct list_head *p;
366 int ret = -ENOKEY, ret2;
367
368 spin_lock(&vnode->wb_lock);
369 if (*_wbk)
370 p = (*_wbk)->vnode_link.next;
371 else
372 p = vnode->wb_keys.next;
373
374 while (p != &vnode->wb_keys) {
375 wbk = list_entry(p, struct afs_wb_key, vnode_link);
376 _debug("wbk %u", key_serial(wbk->key));
377 ret2 = key_validate(wbk->key);
378 if (ret2 == 0) {
379 refcount_inc(&wbk->usage);
380 _debug("USE WB KEY %u", key_serial(wbk->key));
381 break;
382 }
383
384 wbk = NULL;
385 if (ret == -ENOKEY)
386 ret = ret2;
387 p = p->next;
388 }
389
390 spin_unlock(&vnode->wb_lock);
391 if (*_wbk)
392 afs_put_wb_key(*_wbk);
393 *_wbk = wbk;
394 return 0;
395}
396
397static void afs_store_data_success(struct afs_operation *op)
398{
399 struct afs_vnode *vnode = op->file[0].vnode;
400
David Howellsda8d0752020-06-13 19:34:59 +0100401 op->ctime = op->file[0].scb.status.mtime_client;
David Howellse49c7b22020-04-10 20:51:51 +0100402 afs_vnode_commit_status(op, &op->file[0]);
403 if (op->error == 0) {
David Howellsd383e342020-10-22 14:40:31 +0100404 if (!op->store.laundering)
405 afs_pages_written_back(vnode, op->store.first, op->store.last);
David Howellse49c7b22020-04-10 20:51:51 +0100406 afs_stat_v(vnode, n_stores);
407 atomic_long_add((op->store.last * PAGE_SIZE + op->store.last_to) -
408 (op->store.first * PAGE_SIZE + op->store.first_offset),
409 &afs_v2net(vnode)->n_store_bytes);
410 }
411}
412
413static const struct afs_operation_ops afs_store_data_operation = {
414 .issue_afs_rpc = afs_fs_store_data,
415 .issue_yfs_rpc = yfs_fs_store_data,
416 .success = afs_store_data_success,
417};
418
419/*
David Howellsd2ddc772017-11-02 15:27:50 +0000420 * write to a file
421 */
David Howells4343d002017-11-02 15:27:52 +0000422static int afs_store_data(struct address_space *mapping,
423 pgoff_t first, pgoff_t last,
David Howellsd383e342020-10-22 14:40:31 +0100424 unsigned offset, unsigned to, bool laundering)
David Howellsd2ddc772017-11-02 15:27:50 +0000425{
David Howells4343d002017-11-02 15:27:52 +0000426 struct afs_vnode *vnode = AFS_FS_I(mapping->host);
David Howellse49c7b22020-04-10 20:51:51 +0100427 struct afs_operation *op;
David Howells4343d002017-11-02 15:27:52 +0000428 struct afs_wb_key *wbk = NULL;
David Howellse49c7b22020-04-10 20:51:51 +0100429 int ret;
David Howellsd2ddc772017-11-02 15:27:50 +0000430
David Howells3b6492d2018-10-20 00:57:57 +0100431 _enter("%s{%llx:%llu.%u},%lx,%lx,%x,%x",
David Howellsd2ddc772017-11-02 15:27:50 +0000432 vnode->volume->name,
433 vnode->fid.vid,
434 vnode->fid.vnode,
435 vnode->fid.unique,
David Howellsd2ddc772017-11-02 15:27:50 +0000436 first, last, offset, to);
437
David Howellse49c7b22020-04-10 20:51:51 +0100438 ret = afs_get_writeback_key(vnode, &wbk);
439 if (ret) {
440 _leave(" = %d [no keys]", ret);
441 return ret;
442 }
443
444 op = afs_alloc_operation(wbk->key, vnode->volume);
445 if (IS_ERR(op)) {
446 afs_put_wb_key(wbk);
David Howellsa58823a2019-05-09 15:16:10 +0100447 return -ENOMEM;
David Howellse49c7b22020-04-10 20:51:51 +0100448 }
David Howellsa58823a2019-05-09 15:16:10 +0100449
David Howellse49c7b22020-04-10 20:51:51 +0100450 afs_op_set_vnode(op, 0, vnode);
451 op->file[0].dv_delta = 1;
452 op->store.mapping = mapping;
453 op->store.first = first;
454 op->store.last = last;
455 op->store.first_offset = offset;
456 op->store.last_to = to;
David Howellsd383e342020-10-22 14:40:31 +0100457 op->store.laundering = laundering;
David Howellsb3597942020-06-11 21:50:24 +0100458 op->mtime = vnode->vfs_inode.i_mtime;
David Howells811f04b2020-07-08 09:27:07 +0100459 op->flags |= AFS_OPERATION_UNINTR;
David Howellse49c7b22020-04-10 20:51:51 +0100460 op->ops = &afs_store_data_operation;
David Howells4343d002017-11-02 15:27:52 +0000461
David Howells4343d002017-11-02 15:27:52 +0000462try_next_key:
David Howellse49c7b22020-04-10 20:51:51 +0100463 afs_begin_vnode_operation(op);
464 afs_wait_for_operation(op);
David Howells4343d002017-11-02 15:27:52 +0000465
David Howellse49c7b22020-04-10 20:51:51 +0100466 switch (op->error) {
David Howells4343d002017-11-02 15:27:52 +0000467 case -EACCES:
468 case -EPERM:
469 case -ENOKEY:
470 case -EKEYEXPIRED:
471 case -EKEYREJECTED:
472 case -EKEYREVOKED:
473 _debug("next");
David Howellse49c7b22020-04-10 20:51:51 +0100474
475 ret = afs_get_writeback_key(vnode, &wbk);
476 if (ret == 0) {
477 key_put(op->key);
478 op->key = key_get(wbk->key);
479 goto try_next_key;
480 }
481 break;
David Howells4343d002017-11-02 15:27:52 +0000482 }
483
484 afs_put_wb_key(wbk);
David Howellse49c7b22020-04-10 20:51:51 +0100485 _leave(" = %d", op->error);
486 return afs_put_operation(op);
David Howellsd2ddc772017-11-02 15:27:50 +0000487}
488
489/*
David Howells4343d002017-11-02 15:27:52 +0000490 * Synchronously write back the locked page and any subsequent non-locked dirty
491 * pages.
David Howells31143d52007-05-09 02:33:46 -0700492 */
David Howells4343d002017-11-02 15:27:52 +0000493static int afs_write_back_from_locked_page(struct address_space *mapping,
494 struct writeback_control *wbc,
495 struct page *primary_page,
496 pgoff_t final_page)
David Howells31143d52007-05-09 02:33:46 -0700497{
David Howells13524ab2017-11-02 15:27:53 +0000498 struct afs_vnode *vnode = AFS_FS_I(mapping->host);
David Howells31143d52007-05-09 02:33:46 -0700499 struct page *pages[8], *page;
David Howells4343d002017-11-02 15:27:52 +0000500 unsigned long count, priv;
501 unsigned n, offset, to, f, t;
David Howells31143d52007-05-09 02:33:46 -0700502 pgoff_t start, first, last;
David Howells793fe822020-06-12 16:13:52 +0100503 loff_t i_size, end;
David Howells31143d52007-05-09 02:33:46 -0700504 int loop, ret;
505
506 _enter(",%lx", primary_page->index);
507
508 count = 1;
David Howells31143d52007-05-09 02:33:46 -0700509 if (test_set_page_writeback(primary_page))
510 BUG();
511
David Howells4343d002017-11-02 15:27:52 +0000512 /* Find all consecutive lockable dirty pages that have contiguous
513 * written regions, stopping when we find a page that is not
514 * immediately lockable, is not dirty or is missing, or we reach the
515 * end of the range.
516 */
David Howells31143d52007-05-09 02:33:46 -0700517 start = primary_page->index;
David Howells4343d002017-11-02 15:27:52 +0000518 priv = page_private(primary_page);
David Howells185f0c72020-10-26 13:22:47 +0000519 offset = afs_page_dirty_from(priv);
520 to = afs_page_dirty_to(priv);
David Howells13524ab2017-11-02 15:27:53 +0000521 trace_afs_page_dirty(vnode, tracepoint_string("store"),
522 primary_page->index, priv);
David Howells4343d002017-11-02 15:27:52 +0000523
524 WARN_ON(offset == to);
David Howells13524ab2017-11-02 15:27:53 +0000525 if (offset == to)
526 trace_afs_page_dirty(vnode, tracepoint_string("WARN"),
527 primary_page->index, priv);
David Howells4343d002017-11-02 15:27:52 +0000528
David Howells5a813272018-04-06 14:17:26 +0100529 if (start >= final_page ||
530 (to < PAGE_SIZE && !test_bit(AFS_VNODE_NEW_CONTENT, &vnode->flags)))
David Howells31143d52007-05-09 02:33:46 -0700531 goto no_more;
David Howells4343d002017-11-02 15:27:52 +0000532
David Howells31143d52007-05-09 02:33:46 -0700533 start++;
534 do {
535 _debug("more %lx [%lx]", start, count);
David Howells4343d002017-11-02 15:27:52 +0000536 n = final_page - start + 1;
David Howells31143d52007-05-09 02:33:46 -0700537 if (n > ARRAY_SIZE(pages))
538 n = ARRAY_SIZE(pages);
David Howells4343d002017-11-02 15:27:52 +0000539 n = find_get_pages_contig(mapping, start, ARRAY_SIZE(pages), pages);
David Howells31143d52007-05-09 02:33:46 -0700540 _debug("fgpc %u", n);
541 if (n == 0)
542 goto no_more;
543 if (pages[0]->index != start) {
David Howells9d577b62007-05-10 22:22:19 -0700544 do {
545 put_page(pages[--n]);
546 } while (n > 0);
David Howells31143d52007-05-09 02:33:46 -0700547 goto no_more;
548 }
549
550 for (loop = 0; loop < n; loop++) {
551 page = pages[loop];
David Howells5a813272018-04-06 14:17:26 +0100552 if (to != PAGE_SIZE &&
553 !test_bit(AFS_VNODE_NEW_CONTENT, &vnode->flags))
554 break;
David Howells4343d002017-11-02 15:27:52 +0000555 if (page->index > final_page)
David Howells31143d52007-05-09 02:33:46 -0700556 break;
Nick Piggin529ae9a2008-08-02 12:01:03 +0200557 if (!trylock_page(page))
David Howells31143d52007-05-09 02:33:46 -0700558 break;
David Howells4343d002017-11-02 15:27:52 +0000559 if (!PageDirty(page) || PageWriteback(page)) {
David Howells31143d52007-05-09 02:33:46 -0700560 unlock_page(page);
561 break;
562 }
David Howells4343d002017-11-02 15:27:52 +0000563
564 priv = page_private(page);
David Howells185f0c72020-10-26 13:22:47 +0000565 f = afs_page_dirty_from(priv);
566 t = afs_page_dirty_to(priv);
David Howells5a813272018-04-06 14:17:26 +0100567 if (f != 0 &&
568 !test_bit(AFS_VNODE_NEW_CONTENT, &vnode->flags)) {
David Howells4343d002017-11-02 15:27:52 +0000569 unlock_page(page);
570 break;
571 }
572 to = t;
573
David Howells13524ab2017-11-02 15:27:53 +0000574 trace_afs_page_dirty(vnode, tracepoint_string("store+"),
575 page->index, priv);
576
David Howells31143d52007-05-09 02:33:46 -0700577 if (!clear_page_dirty_for_io(page))
578 BUG();
579 if (test_set_page_writeback(page))
580 BUG();
581 unlock_page(page);
582 put_page(page);
583 }
584 count += loop;
585 if (loop < n) {
586 for (; loop < n; loop++)
587 put_page(pages[loop]);
588 goto no_more;
589 }
590
591 start += loop;
David Howells4343d002017-11-02 15:27:52 +0000592 } while (start <= final_page && count < 65536);
David Howells31143d52007-05-09 02:33:46 -0700593
594no_more:
David Howells4343d002017-11-02 15:27:52 +0000595 /* We now have a contiguous set of dirty pages, each with writeback
596 * set; the first page is still locked at this point, but all the rest
597 * have been unlocked.
598 */
599 unlock_page(primary_page);
600
David Howells31143d52007-05-09 02:33:46 -0700601 first = primary_page->index;
602 last = first + count - 1;
603
David Howells793fe822020-06-12 16:13:52 +0100604 end = (loff_t)last * PAGE_SIZE + to;
605 i_size = i_size_read(&vnode->vfs_inode);
606
David Howells31143d52007-05-09 02:33:46 -0700607 _debug("write back %lx[%u..] to %lx[..%u]", first, offset, last, to);
David Howells793fe822020-06-12 16:13:52 +0100608 if (end > i_size)
609 to = i_size & ~PAGE_MASK;
David Howells31143d52007-05-09 02:33:46 -0700610
David Howellsd383e342020-10-22 14:40:31 +0100611 ret = afs_store_data(mapping, first, last, offset, to, false);
David Howells4343d002017-11-02 15:27:52 +0000612 switch (ret) {
613 case 0:
David Howells31143d52007-05-09 02:33:46 -0700614 ret = count;
David Howells4343d002017-11-02 15:27:52 +0000615 break;
616
617 default:
618 pr_notice("kAFS: Unexpected error from FS.StoreData %d\n", ret);
Gustavo A. R. Silvadf561f662020-08-23 17:36:59 -0500619 fallthrough;
David Howells4343d002017-11-02 15:27:52 +0000620 case -EACCES:
621 case -EPERM:
622 case -ENOKEY:
623 case -EKEYEXPIRED:
624 case -EKEYREJECTED:
625 case -EKEYREVOKED:
626 afs_redirty_pages(wbc, mapping, first, last);
627 mapping_set_error(mapping, ret);
628 break;
629
630 case -EDQUOT:
631 case -ENOSPC:
632 afs_redirty_pages(wbc, mapping, first, last);
633 mapping_set_error(mapping, -ENOSPC);
634 break;
635
636 case -EROFS:
637 case -EIO:
638 case -EREMOTEIO:
639 case -EFBIG:
640 case -ENOENT:
641 case -ENOMEDIUM:
642 case -ENXIO:
David Howellsf51375c2018-10-20 00:57:57 +0100643 trace_afs_file_error(vnode, ret, afs_file_error_writeback_fail);
David Howells4343d002017-11-02 15:27:52 +0000644 afs_kill_pages(mapping, first, last);
645 mapping_set_error(mapping, ret);
646 break;
David Howells31143d52007-05-09 02:33:46 -0700647 }
648
649 _leave(" = %d", ret);
650 return ret;
651}
652
653/*
654 * write a page back to the server
655 * - the caller locked the page for us
656 */
657int afs_writepage(struct page *page, struct writeback_control *wbc)
658{
David Howells31143d52007-05-09 02:33:46 -0700659 int ret;
660
661 _enter("{%lx},", page->index);
662
David Howells4343d002017-11-02 15:27:52 +0000663 ret = afs_write_back_from_locked_page(page->mapping, wbc, page,
664 wbc->range_end >> PAGE_SHIFT);
David Howells31143d52007-05-09 02:33:46 -0700665 if (ret < 0) {
666 _leave(" = %d", ret);
667 return 0;
668 }
669
670 wbc->nr_to_write -= ret;
David Howells31143d52007-05-09 02:33:46 -0700671
672 _leave(" = 0");
673 return 0;
674}
675
676/*
677 * write a region of pages back to the server
678 */
Adrian Bunkc1206a22007-10-16 23:26:41 -0700679static int afs_writepages_region(struct address_space *mapping,
680 struct writeback_control *wbc,
681 pgoff_t index, pgoff_t end, pgoff_t *_next)
David Howells31143d52007-05-09 02:33:46 -0700682{
David Howells31143d52007-05-09 02:33:46 -0700683 struct page *page;
684 int ret, n;
685
686 _enter(",,%lx,%lx,", index, end);
687
688 do {
Jan Karaaef6e412017-11-15 17:35:23 -0800689 n = find_get_pages_range_tag(mapping, &index, end,
690 PAGECACHE_TAG_DIRTY, 1, &page);
David Howells31143d52007-05-09 02:33:46 -0700691 if (!n)
692 break;
693
694 _debug("wback %lx", page->index);
695
Matthew Wilcoxb93b0162018-04-10 16:36:56 -0700696 /*
697 * at this point we hold neither the i_pages lock nor the
698 * page lock: the page may be truncated or invalidated
699 * (changing page->mapping to NULL), or even swizzled
700 * back from swapper_space to tmpfs file mapping
David Howells31143d52007-05-09 02:33:46 -0700701 */
David Howells4343d002017-11-02 15:27:52 +0000702 ret = lock_page_killable(page);
703 if (ret < 0) {
704 put_page(page);
705 _leave(" = %d", ret);
706 return ret;
707 }
David Howells31143d52007-05-09 02:33:46 -0700708
David Howellsc5051c72017-03-16 16:27:49 +0000709 if (page->mapping != mapping || !PageDirty(page)) {
David Howells31143d52007-05-09 02:33:46 -0700710 unlock_page(page);
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300711 put_page(page);
David Howells31143d52007-05-09 02:33:46 -0700712 continue;
713 }
714
David Howellsc5051c72017-03-16 16:27:49 +0000715 if (PageWriteback(page)) {
David Howells31143d52007-05-09 02:33:46 -0700716 unlock_page(page);
David Howellsc5051c72017-03-16 16:27:49 +0000717 if (wbc->sync_mode != WB_SYNC_NONE)
718 wait_on_page_writeback(page);
David Howells29c8bbb2017-03-16 16:27:43 +0000719 put_page(page);
David Howells31143d52007-05-09 02:33:46 -0700720 continue;
721 }
722
David Howells65a15102017-03-16 16:27:49 +0000723 if (!clear_page_dirty_for_io(page))
724 BUG();
David Howells4343d002017-11-02 15:27:52 +0000725 ret = afs_write_back_from_locked_page(mapping, wbc, page, end);
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300726 put_page(page);
David Howells31143d52007-05-09 02:33:46 -0700727 if (ret < 0) {
728 _leave(" = %d", ret);
729 return ret;
730 }
731
732 wbc->nr_to_write -= ret;
733
David Howells31143d52007-05-09 02:33:46 -0700734 cond_resched();
735 } while (index < end && wbc->nr_to_write > 0);
736
737 *_next = index;
738 _leave(" = 0 [%lx]", *_next);
739 return 0;
740}
741
742/*
743 * write some of the pending data back to the server
744 */
745int afs_writepages(struct address_space *mapping,
746 struct writeback_control *wbc)
747{
David Howellsec0fa0b2020-10-07 14:22:12 +0100748 struct afs_vnode *vnode = AFS_FS_I(mapping->host);
David Howells31143d52007-05-09 02:33:46 -0700749 pgoff_t start, end, next;
750 int ret;
751
752 _enter("");
753
David Howellsec0fa0b2020-10-07 14:22:12 +0100754 /* We have to be careful as we can end up racing with setattr()
755 * truncating the pagecache since the caller doesn't take a lock here
756 * to prevent it.
757 */
758 if (wbc->sync_mode == WB_SYNC_ALL)
759 down_read(&vnode->validate_lock);
760 else if (!down_read_trylock(&vnode->validate_lock))
761 return 0;
762
David Howells31143d52007-05-09 02:33:46 -0700763 if (wbc->range_cyclic) {
764 start = mapping->writeback_index;
765 end = -1;
766 ret = afs_writepages_region(mapping, wbc, start, end, &next);
Wu Fengguang1b430be2010-10-26 14:21:26 -0700767 if (start > 0 && wbc->nr_to_write > 0 && ret == 0)
David Howells31143d52007-05-09 02:33:46 -0700768 ret = afs_writepages_region(mapping, wbc, 0, start,
769 &next);
770 mapping->writeback_index = next;
771 } else if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX) {
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300772 end = (pgoff_t)(LLONG_MAX >> PAGE_SHIFT);
David Howells31143d52007-05-09 02:33:46 -0700773 ret = afs_writepages_region(mapping, wbc, 0, end, &next);
774 if (wbc->nr_to_write > 0)
775 mapping->writeback_index = next;
776 } else {
Kirill A. Shutemov09cbfea2016-04-01 15:29:47 +0300777 start = wbc->range_start >> PAGE_SHIFT;
778 end = wbc->range_end >> PAGE_SHIFT;
David Howells31143d52007-05-09 02:33:46 -0700779 ret = afs_writepages_region(mapping, wbc, start, end, &next);
780 }
781
David Howellsec0fa0b2020-10-07 14:22:12 +0100782 up_read(&vnode->validate_lock);
David Howells31143d52007-05-09 02:33:46 -0700783 _leave(" = %d", ret);
784 return ret;
785}
786
787/*
David Howells31143d52007-05-09 02:33:46 -0700788 * write to an AFS file
789 */
Al Viro50b55512014-04-03 14:13:46 -0400790ssize_t afs_file_write(struct kiocb *iocb, struct iov_iter *from)
David Howells31143d52007-05-09 02:33:46 -0700791{
Al Viro496ad9a2013-01-23 17:07:38 -0500792 struct afs_vnode *vnode = AFS_FS_I(file_inode(iocb->ki_filp));
David Howells31143d52007-05-09 02:33:46 -0700793 ssize_t result;
Al Viro50b55512014-04-03 14:13:46 -0400794 size_t count = iov_iter_count(from);
David Howells31143d52007-05-09 02:33:46 -0700795
David Howells3b6492d2018-10-20 00:57:57 +0100796 _enter("{%llx:%llu},{%zu},",
Al Viro50b55512014-04-03 14:13:46 -0400797 vnode->fid.vid, vnode->fid.vnode, count);
David Howells31143d52007-05-09 02:33:46 -0700798
799 if (IS_SWAPFILE(&vnode->vfs_inode)) {
800 printk(KERN_INFO
801 "AFS: Attempt to write to active swap file!\n");
802 return -EBUSY;
803 }
804
805 if (!count)
806 return 0;
807
Al Viro50b55512014-04-03 14:13:46 -0400808 result = generic_file_write_iter(iocb, from);
David Howells31143d52007-05-09 02:33:46 -0700809
David Howells31143d52007-05-09 02:33:46 -0700810 _leave(" = %zd", result);
811 return result;
812}
813
814/*
David Howells31143d52007-05-09 02:33:46 -0700815 * flush any dirty pages for this process, and check for write errors.
816 * - the return status from this call provides a reliable indication of
817 * whether any write errors occurred for this process.
818 */
Josef Bacik02c24a82011-07-16 20:44:56 -0400819int afs_fsync(struct file *file, loff_t start, loff_t end, int datasync)
David Howells31143d52007-05-09 02:33:46 -0700820{
Al Viro3c981bf2013-09-03 13:37:45 -0400821 struct inode *inode = file_inode(file);
Al Viro3c981bf2013-09-03 13:37:45 -0400822 struct afs_vnode *vnode = AFS_FS_I(inode);
David Howells31143d52007-05-09 02:33:46 -0700823
David Howells3b6492d2018-10-20 00:57:57 +0100824 _enter("{%llx:%llu},{n=%pD},%d",
Al Viro3c981bf2013-09-03 13:37:45 -0400825 vnode->fid.vid, vnode->fid.vnode, file,
David Howells31143d52007-05-09 02:33:46 -0700826 datasync);
827
David Howells4343d002017-11-02 15:27:52 +0000828 return file_write_and_wait_range(file, start, end);
David Howells31143d52007-05-09 02:33:46 -0700829}
David Howells9b3f26c2009-04-03 16:42:41 +0100830
831/*
832 * notification that a previously read-only page is about to become writable
833 * - if it returns an error, the caller will deliver a bus error signal
834 */
Souptick Joarder0722f182018-08-23 17:00:48 -0700835vm_fault_t afs_page_mkwrite(struct vm_fault *vmf)
David Howells9b3f26c2009-04-03 16:42:41 +0100836{
David Howells1cf7a152017-11-02 15:27:52 +0000837 struct file *file = vmf->vma->vm_file;
838 struct inode *inode = file_inode(file);
839 struct afs_vnode *vnode = AFS_FS_I(inode);
840 unsigned long priv;
David Howells9b3f26c2009-04-03 16:42:41 +0100841
David Howells3b6492d2018-10-20 00:57:57 +0100842 _enter("{{%llx:%llu}},{%lx}",
David Howells1cf7a152017-11-02 15:27:52 +0000843 vnode->fid.vid, vnode->fid.vnode, vmf->page->index);
David Howells9b3f26c2009-04-03 16:42:41 +0100844
David Howells1cf7a152017-11-02 15:27:52 +0000845 sb_start_pagefault(inode->i_sb);
846
847 /* Wait for the page to be written to the cache before we allow it to
848 * be modified. We then assume the entire page will need writing back.
849 */
David Howells9b3f26c2009-04-03 16:42:41 +0100850#ifdef CONFIG_AFS_FSCACHE
David Howells1cf7a152017-11-02 15:27:52 +0000851 fscache_wait_on_page_write(vnode->cache, vmf->page);
David Howells9b3f26c2009-04-03 16:42:41 +0100852#endif
853
David Howells1cf7a152017-11-02 15:27:52 +0000854 if (PageWriteback(vmf->page) &&
855 wait_on_page_bit_killable(vmf->page, PG_writeback) < 0)
856 return VM_FAULT_RETRY;
857
858 if (lock_page_killable(vmf->page) < 0)
859 return VM_FAULT_RETRY;
860
861 /* We mustn't change page->private until writeback is complete as that
862 * details the portion of the page we need to write back and we might
863 * need to redirty the page if there's a problem.
864 */
865 wait_on_page_writeback(vmf->page);
866
David Howells185f0c72020-10-26 13:22:47 +0000867 priv = afs_page_dirty(0, PAGE_SIZE);
David Howellsf86726a2020-10-22 14:08:23 +0100868 priv = afs_page_dirty_mmapped(priv);
David Howells13524ab2017-11-02 15:27:53 +0000869 trace_afs_page_dirty(vnode, tracepoint_string("mkwrite"),
870 vmf->page->index, priv);
David Howellsfa04a402020-10-21 13:22:19 +0100871 if (PagePrivate(vmf->page))
872 set_page_private(vmf->page, priv);
873 else
874 attach_page_private(vmf->page, (void *)priv);
David Howellsbb413482020-06-12 00:15:13 +0100875 file_update_time(file);
David Howells1cf7a152017-11-02 15:27:52 +0000876
877 sb_end_pagefault(inode->i_sb);
878 return VM_FAULT_LOCKED;
David Howells9b3f26c2009-04-03 16:42:41 +0100879}
David Howells4343d002017-11-02 15:27:52 +0000880
881/*
882 * Prune the keys cached for writeback. The caller must hold vnode->wb_lock.
883 */
884void afs_prune_wb_keys(struct afs_vnode *vnode)
885{
886 LIST_HEAD(graveyard);
887 struct afs_wb_key *wbk, *tmp;
888
889 /* Discard unused keys */
890 spin_lock(&vnode->wb_lock);
891
892 if (!mapping_tagged(&vnode->vfs_inode.i_data, PAGECACHE_TAG_WRITEBACK) &&
893 !mapping_tagged(&vnode->vfs_inode.i_data, PAGECACHE_TAG_DIRTY)) {
894 list_for_each_entry_safe(wbk, tmp, &vnode->wb_keys, vnode_link) {
895 if (refcount_read(&wbk->usage) == 1)
896 list_move(&wbk->vnode_link, &graveyard);
897 }
898 }
899
900 spin_unlock(&vnode->wb_lock);
901
902 while (!list_empty(&graveyard)) {
903 wbk = list_entry(graveyard.next, struct afs_wb_key, vnode_link);
904 list_del(&wbk->vnode_link);
905 afs_put_wb_key(wbk);
906 }
907}
908
909/*
910 * Clean up a page during invalidation.
911 */
912int afs_launder_page(struct page *page)
913{
914 struct address_space *mapping = page->mapping;
915 struct afs_vnode *vnode = AFS_FS_I(mapping->host);
916 unsigned long priv;
917 unsigned int f, t;
918 int ret = 0;
919
920 _enter("{%lx}", page->index);
921
922 priv = page_private(page);
923 if (clear_page_dirty_for_io(page)) {
924 f = 0;
925 t = PAGE_SIZE;
926 if (PagePrivate(page)) {
David Howells185f0c72020-10-26 13:22:47 +0000927 f = afs_page_dirty_from(priv);
928 t = afs_page_dirty_to(priv);
David Howells4343d002017-11-02 15:27:52 +0000929 }
930
David Howells13524ab2017-11-02 15:27:53 +0000931 trace_afs_page_dirty(vnode, tracepoint_string("launder"),
932 page->index, priv);
David Howellsd383e342020-10-22 14:40:31 +0100933 ret = afs_store_data(mapping, page->index, page->index, t, f, true);
David Howells4343d002017-11-02 15:27:52 +0000934 }
935
David Howellsfa04a402020-10-21 13:22:19 +0100936 priv = (unsigned long)detach_page_private(page);
David Howells13524ab2017-11-02 15:27:53 +0000937 trace_afs_page_dirty(vnode, tracepoint_string("laundered"),
938 page->index, priv);
David Howells4343d002017-11-02 15:27:52 +0000939
940#ifdef CONFIG_AFS_FSCACHE
941 if (PageFsCache(page)) {
942 fscache_wait_on_page_write(vnode->cache, page);
943 fscache_uncache_page(vnode->cache, page);
944 }
945#endif
946 return ret;
David Howells31143d52007-05-09 02:33:46 -0700947}