Project

General

Profile

Activity

From 07/26/2018 to 08/01/2018

08/01/2018

11:41 PM Feature #14473: Add Range#subrange?
I agree that the max performance issue is likely to be a rare case; I am happy to leave it as-is.
Apologies on the...
owst (Owen Stephens)
10:54 PM Bug #14716: SecureRandom throwing an error in Ruby 2.5.1
We also got this error after upgrading to 2.5.1 (we had been on 2.4.2). We're also on a v3.13 kernel (3.13.0-24-gener... patbl (Patrick Brinich-Langlois)
08:55 PM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
normalperson (Eric Wong) wrote:
> We will probably match arenas to Guild count dynamically;
> depending on whethe...
Eregon (Benoit Daloze)
07:22 PM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
[email protected] wrote:
> The question then becomes: What happens when Guilds land?

We will probably match are...
normalperson (Eric Wong)
01:04 PM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
The question then becomes: What happens when Guilds land?
It will be a hard choice to have slow allocations when t...
Eregon (Benoit Daloze)
10:04 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
> https://bugs.ruby-lang.org/issues/14759#change-73263

Btw, has anybody tested this patch with various allocators...
normalperson (Eric Wong)
09:42 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
> https://bugs.ruby-lang.org/issues/14759#change-73263

Another followup on this, current glibc 2.28 still creates...
normalperson (Eric Wong)
12:20 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
Koichi / Nobu

Is there any chance we can merge this in and even backport to 2.4/2.5.
It is a very safe change...
sam.saffron (Sam Saffron)
03:21 PM Bug #14958 (Closed): rand(endless_range) raises TypeError (no implicit conversion of Range into Integer)
I think TypeError message is a bit strange.
```console
$ ruby -v
ruby 2.6.0dev (2018-08-01 trunk 64154) [x86_64-...
znz (Kazuhiro NISHIYAMA)
02:46 PM Bug #14957 (Closed): MinGW, gcc 8.2.0, bootstraptest test_thread.rb - failure ?
Very recently MSYS/MinGW updated gcc from 7.3.0 to 8.2.0. For the most part, every test suite runs fine except the b... MSP-Greg (Greg L)
10:04 AM Feature #14718: Use jemalloc by default?
[email protected] wrote:
> As much as we like to think of jemalloc as a silver bullet of
> sorts... there are ...
normalperson (Eric Wong)
03:41 AM Feature #14718: Use jemalloc by default?
sam.saffron (Sam Saffron) wrote:
> After spending a bit too much time thinking about this, I would like to recommend...
bluz71 (Dennis B)
02:12 AM Feature #14718: Use jemalloc by default?
> Are you using LD_PRELOAD instead?
Yes that is how we deploy PRD we compile without jemalloc and then just ld pre...
sam.saffron (Sam Saffron)
01:04 AM Feature #14718: Use jemalloc by default?
> Testing the following patch with
> "MALLOC_ARENA_MAX=1 MALLOC_ARENA_TEST=1 make gcbench-rdoc"
> seems show a sma...
normalperson (Eric Wong)
12:55 AM Feature #14718: Use jemalloc by default?
Sam, I'm ok with your suggestion, any progress here is welcome. The main issue with tcmalloc is that Ruby doesn't su... mperham (Mike Perham)
12:14 AM Feature #14718: Use jemalloc by default?
After spending a bit too much time thinking about this, I would like to recommend **against** any jemalloc related ch... sam.saffron (Sam Saffron)
09:58 AM Bug #7750 (Rejected): GC中にオブジェクトが割り当てられる
1.9.3 はすでにサポートを終了しているバージョン、かつ現在の安定バージョンの Ruby では GC の仕組みを大きく変わっているのでクローズします。 hsbt (Hiroshi SHIBATA)
09:56 AM Bug #7781 (Rejected): Ruby fails make test on Cygwin for test_io.rb.
1.9.3 is already EOL status. If you have the same issue with the latest stable version of Ruby, Please report again.
...
hsbt (Hiroshi SHIBATA)
07:42 AM Feature #14955: [PATCH] gc.c: use MADV_FREE to release most of the heap page body
[email protected] wrote:
> It causes system call and extra overhead so that I'm not sure
> it is acceptable.
> On pre...
normalperson (Eric Wong)
06:53 AM Feature #14955: [PATCH] gc.c: use MADV_FREE to release most of the heap page body
It causes system call and extra overhead so that I'm not sure it is acceptable.
On previous proposal I could measu...
ko1 (Koichi Sasada)
12:44 AM Feature #14955 (Open): [PATCH] gc.c: use MADV_FREE to release most of the heap page body
gc.c: use MADV_FREE to release most the heap page body
On x86 and x86-64 Linux and FreeBSD (at least), we can rele...
normalperson (Eric Wong)
06:20 AM Misc #14921: DevelopersMeeting20180809Japan
sam.saffron (Sam Saffron) wrote:
> really hoping we can make a call on:
> https://bugs.ruby-lang.org/issues/14759
...
duerst (Martin Dürst)
02:22 AM Misc #14921: DevelopersMeeting20180809Japan
really hoping we can make a call on:
https://bugs.ruby-lang.org/issues/14759
I would also very much like to se...
sam.saffron (Sam Saffron)
12:27 AM Misc #14921: DevelopersMeeting20180809Japan
* [Feature #14869] Proposal to add Hash#=== (nobu)
* [Feature #14916] Proposal to add Array#=== (aycabta)
* [Featur...
baweaver (Brandon Weaver)
03:54 AM Misc #14956: Remove staled branches in svn repository
v1_* branches are just like ruby_2_* branches.
Please keep them.
usa (Usaku NAKAMURA)
03:48 AM Misc #14956 (Closed): Remove staled branches in svn repository
the ruby svn repository has a lot of staled branches.
I will remove the following branches for migrating git.
`...
hsbt (Hiroshi SHIBATA)
03:41 AM Bug #14948 (Assigned): MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
hsbt (Hiroshi SHIBATA)
03:40 AM Revision e62214be (git): move atomic logic from mjit.c from ruby_atomic.h
This macro shall be shared among other files, not just for mjit.c.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trun...
shyouhei (Shyouhei Urabe)
02:55 AM Revision 740a1706 (git): (cosmetic) add blank lines for better readability
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64155 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
12:18 AM Feature #14912: Introduce pattern matching syntax
There was a previous discussion on this which had many good details and discussion:
https://bugs.ruby-lang.org/iss...
baweaver (Brandon Weaver)

07/31/2018

10:53 PM Bug #14949: test_jit.rb test_unload_units fails on 32-bit
Eric, thanks to the header information, I could fix at least the RubyCI's Debian 7.11 i686. k0kubun (Takashi Kokubun)
11:19 AM Bug #14949 (Closed): test_jit.rb test_unload_units fails on 32-bit
Applied in changeset trunk|r64138.
----------
transform_mjit_header.rb: accept having attribute
between a type of r...
k0kubun (Takashi Kokubun)
06:58 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
jeremyevans0 (Jeremy Evans) wrote:
> sawa (Tsuyoshi Sawada) wrote:
> > I propose to extend the exclusive or operato...
danga (Dan Garubba)
05:10 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
danga (Dan Garubba) wrote:
> Sure. In my day job, I write testing code. So I've written an expression like:
>
> ~...
nobu (Nobuyoshi Nakada)
02:45 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
sawa (Tsuyoshi Sawada) wrote:
> I propose to extend the exclusive or operator `^` to be defined on `Object`. For `In...
jeremyevans0 (Jeremy Evans)
07:28 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
I propose to extend the exclusive or operator `^` to be defined on `Object`. For `Integer`, the method would be overw... sawa (Tsuyoshi Sawada)
02:34 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
Thanks. Essentially, this helper is a form of the boolean singleton normalization I apply at the application level.
...
danga (Dan Garubba)
01:26 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
How about defining a helper function for your assertions?
```
def assert_same_as_boolean(x, y)
raise MyError u...
mame (Yusuke Endoh)
05:23 PM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
@k0kubun
I just built ruby 2.6.0dev (2018-08-01 trunk 64153) [x64-mingw32], and every JIT test is showing stderr a...
MSP-Greg (Greg L)
05:11 PM Revision fa98c129 (git): [DOC] Added CI build status for Japanese docs
[Fix GH-1923]
From: Andrea Gómez <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64...
nobu (Nobuyoshi Nakada)
03:20 PM Revision b95fff7f (git): Add same comment to thwait.gemspec like other gemspec at r64145
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64153 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
03:20 PM Revision ae83c35b (git): Add PRINTF_ARGS to kprintf
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64152 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
03:02 PM Revision e4aca224 (git): * 2018-08-01
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64151 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:02 PM Revision d99fb784 (git): Makefile.in: remove GNU-make dependency
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64150 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
02:46 PM Feature #14944: Support optional inherit argument for Module#method_defined?
If you want to suppress warnings, you can use `undef_method` instead of `remove_method` for the time being.
```rub...
znz (Kazuhiro NISHIYAMA)
02:21 PM Revision 8b310ae7 (git): merge revision(s) 60011:
test_gc.rb: relax criterion
* test/ruby/test_gc.rb (TestGc#test_expand_heap): relax the
criterion ...
U.Nakamura
02:12 PM Bug #14790: DateTime.iso8601 parses incorrect ISO8601
ruby_2_4 r64148 merged revision(s) 63512,63514. usa (Usaku NAKAMURA)
02:12 PM Revision 9f86a436 (git): merge revision(s) 63512,63514: [Backport #14790]
time.rb: fix parsing time zone in iso8601
* lib/time.rb (Time.xmlschema): a colon in time zone designator
...
U.Nakamura
02:01 PM Bug #14756: `Exception` may cause SEGV when `#backtrace` returns a string
ruby_2_4 r64147 merged revision(s) 63417. usa (Usaku NAKAMURA)
02:01 PM Revision 607d93b9 (git): merge revision(s) 63417: [Backport #14756]
error.c: check redefined backtrace result
* error.c (rb_get_backtrace): check the result of `backtrace` even...
U.Nakamura
01:54 PM Revision 312de7a9 (git): backport openssl v2.0.8 [Backport #14754]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_4@64146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e U.Nakamura
12:56 PM Revision ca32fe16 (git): Try to load version file of github repository at first.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:55 PM Revision cf855124 (git): transform_mjit_header.rb: more strict FUNC_HEADER_REGEXP
to reduce "SKIPPED" logs on MJIT header build.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64144 b2dd03c8-39d4...
k0kubun (Takashi Kokubun)
12:43 PM Revision 11974fc0 (git): mjit.c: allow using MJIT header in build directory
when $MJIT_SEARCH_BUILD_DIR is set.
If prefix path is owned by root, `make install` needs to be run by root.
But in ...
k0kubun (Takashi Kokubun)
12:25 PM Revision c4734308 (git): Follow up r64141 with sync tool.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64142 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:12 PM Revision b7d3d771 (git): Fixed inconsistency gemspec location.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64141 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:05 PM Revision 7c980498 (git): Fixed unexpected direction deletion with irb sync.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64140 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
11:48 AM Revision cfd512df (git): Support Sync module same as other default gems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64139 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
11:18 AM Revision d3f57771 (git): transform_mjit_header.rb: accept having attribute
between a type of return value and function identifier. Like:
```
rb_control_frame_t *
__attribute__ ((__fastcall__)...
k0kubun (Takashi Kokubun)
10:19 AM Misc #14921: DevelopersMeeting20180809Japan
* [Feature #14954] Add :wait option to RubyVM::MJIT.pause
* Since it's not released even in preview2 yet, is it ok...
k0kubun (Takashi Kokubun)
10:10 AM Feature #14954 (Closed): Add :wait option to RubyVM::MJIT.pause
## Problem
To measure an MJIT-generated code's performance, currently we need to do `sleep ...; RubyVM::MJIT.pause` ...
k0kubun (Takashi Kokubun)
10:09 AM Feature #14953 (Closed): Add :wait option to RubyVM::MJIT.pause
Wrongly created in ruby-dev... I'll re-create this on ruby-core. k0kubun (Takashi Kokubun)
10:05 AM Feature #14953 (Closed): Add :wait option to RubyVM::MJIT.pause
## Problem
To measure an MJIT-generated code's performance, currently we need to do `sleep ...; RubyVM::MJIT.pause` ...
k0kubun (Takashi Kokubun)
03:49 AM Revision 8bcf2752 (git): Move obsoleted test/thread/test_*.rb with the current implementation.
* test/ruby/test_thread_{cv,queue}.rb: Move under the test/ruby directory.
and rename TestThread* from Test*.
*...
hsbt (Hiroshi SHIBATA)
01:52 AM Feature #14473: Add Range#subrange?
Thank you for the new patch.

At the first issue, I understood max method has performance issue at that case.
But...
Anonymous
12:29 AM Feature #14473: Add Range#subrange?
Hi tarui, thank you for reviewing and your suggestion/question.
In fact, with my v4 patch in the case you describ...
owst (Owen Stephens)
01:35 AM Revision e52a9b59 (git): Fixed inconsistency file structure for gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64136 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
01:33 AM Revision 931cda4d (git): test/ruby/test_io.rb (test_race_gets_and_close): use SIGABRT on timeout
I can't reproduce the test failure and I'm still not sure what's
wrong, but maybe we can get a core dump from P895:
h...
Eric Wong
12:31 AM Feature #14718: Use jemalloc by default?
davidtgoldblatt (David Goldblatt) wrote:
> I don't think this benchmark is a useful way to compare performance betwe...
bluz71 (Dennis B)

07/30/2018

10:59 PM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
I'm investigating this. It looks like a symbol (of rb_mRubyVMFrozenCore) referred from /tmp/_ruby_mjit_pXXXuYYY.so is... k0kubun (Takashi Kokubun)
10:52 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
> yet, sky3 had a failure at
> http://ci.rvm.jp/results/trunk-test@ruby-sky3/1173398 and it
> might be related. I...
normalperson (Eric Wong)
06:22 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
[email protected] wrote:
> Congrats to achieve this. I think this should be a notable
> change written in NEWS...
normalperson (Eric Wong)
01:34 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
Congrats to achieve this. I think this should be a notable change written in NEWS :) k0kubun (Takashi Kokubun)
10:46 PM Feature #14718: Use jemalloc by default?
davidtgoldblatt (David Goldblatt) wrote:
> I don't think this benchmark is a useful way to compare performance betwe...
andresakata (André Guimarães Sakata)
08:27 PM Feature #14718: Use jemalloc by default?
I don't think this benchmark is a useful way to compare performance between versions 3 and 5 of jemalloc. In between ... davidtgoldblatt (David Goldblatt)
04:16 PM Feature #14718: Use jemalloc by default?
Got it, thanks @fweimer.
I did run a test with **jemalloc 5.1** and I've got the same results as you did.
```
...
andresakata (André Guimarães Sakata)
01:20 PM Feature #14718: Use jemalloc by default?
andresakata (André Guimarães Sakata) wrote:
> Hello @fewimer, very interesting.
>
> Just to understand one thing,...
fweimer (Florian Weimer)
01:16 PM Feature #14718: Use jemalloc by default?
Hello @fewimer, very interesting.
Just to understand one thing, were you using MALLOC_ARENA_MAX=2 in your first test?
andresakata (André Guimarães Sakata)
12:16 PM Feature #14718: Use jemalloc by default?
I can reproduce your MALLOC_ARENA_MAX=2 number.
But my untuned glibc 2.26 numbers are slightly worse (presumably d...
fweimer (Florian Weimer)
10:22 AM Feature #14718: Use jemalloc by default?
[email protected] wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=14581

> The Ruby allocator calls pos...
normalperson (Eric Wong)
09:48 PM Revision 86d35a6b (git): thread_pthread.c (unregister_ubf_list): assert unblock.func is unset
We must not allow reentry into ubf_list_head once we delete
ourselves, otherwise we could hang in there forever.
[ru...
Eric Wong
09:42 PM Bug #14945: [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
> https://bugs.ruby-lang.org/issues/14945

Actually, r64083 may not be completely safe, either, as
the list_empty...
normalperson (Eric Wong)
09:16 PM Bug #14952 (Closed): [Docs] Backport r64057 to ruby 2.5
Please backport r64057 (https://github.com/ruby/ruby/commit/ac1193d38f12e6ce5106f5413bcc57b6f585a2a1) since the bug a... nomadium (Miguel Landaeta)
08:20 PM Bug #14949: test_jit.rb test_unload_units fails on 32-bit
I'm also seeing a lot of error text, 395 items in the errs array. Asserts pass up to the assert_equal at line 562. ... MSP-Greg (Greg L)
06:02 PM Bug #14949: test_jit.rb test_unload_units fails on 32-bit
Header from native 32-bit machine (can't attach multiple files
w/o JS, it seems)
normalperson (Eric Wong)
06:00 PM Bug #14949: test_jit.rb test_unload_units fails on 32-bit
Attached is rb_mjit_header.h from a 32-bit userspace on 64-bit kernel/HW
and mjit_header_i686_native.h from a 32-bit...
normalperson (Eric Wong)
01:28 PM Bug #14949: test_jit.rb test_unload_units fails on 32-bit
Eric, thanks to notify this. To fix it, I want to know the content of MJIT header files. I could see debian i686-linu... k0kubun (Takashi Kokubun)
07:57 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
Sure. In my day job, I write testing code. So I've written an expression like:
~~~ ruby
raise MyError unless in_s...
danga (Dan Garubba)
02:31 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
Can you show me examples of concrete usage of the proposed operator?
Your explanation is a bit vague.
Matz.
matz (Yukihiro Matsumoto)
02:16 PM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
I am not sure if the trade off of adding a new operator is worth it in
this case, even well aside from backwards co...
shevegen (Robert A. Heiler)
05:54 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
It conflicts with the existing syntax, `a=?b`. nobu (Nobuyoshi Nakada)
05:31 AM Feature #14951 (Open): New operator to evaluate truthy/falsy/logical equivalence
I propose adding a new operator for truthy/falsy equivalence, similar to what was proposed on https://bugs.ruby-lang.... danga (Dan Garubba)
06:53 PM Revision 508f0031 (git): thread_pthread.c (gvl_yield): do ubf wakeups when uncontended
Not having contention for GVL could mean everybody else is stuck
in blocking region without GVL, so we kick the ubf l...
Eric Wong
04:35 PM Bug #14009: macOS High Sierra and “fork” compatibility
nagachika (Tomoyuki Chikanaga) wrote:
> ruby_2_4 r61358 merged revision(s) 60182.
With 2.4.4 (ruby 2.4.4p296 (201...
quaeler (loki der quaeler)
04:21 PM Feature #13050: Readline: expose rl_completion_quote_character variable
It is now registered for the next upcoming developer meeting at:
https://bugs.ruby-lang.org/issues/14921
(I thi...
shevegen (Robert A. Heiler)
03:24 PM Bug #14950 (Closed): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
Sorry, it was my mistake. nobu (Nobuyoshi Nakada)
11:07 AM Bug #14950 (Assigned): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
It still happens at `TestOpen3#test_pipeline_start`.
And it seems less frequently with -O0 than with -O3.
nobu (Nobuyoshi Nakada)
10:33 AM Bug #14950 (Closed): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
normalperson (Eric Wong) wrote:
> I wrote:
> > I wonder if condvars on OSX has a "memory" of which mutexes
> > a...
nobu (Nobuyoshi Nakada)
10:03 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
I wrote:
> I wonder if condvars on OSX has a "memory" of which mutexes
> are associated with it. If so, that woul...
normalperson (Eric Wong)
09:42 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
[email protected] wrote:
> normalperson (Eric Wong) wrote:
> > [email protected] wrote:
> > > Since r64107, `m...
normalperson (Eric Wong)
09:10 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
normalperson (Eric Wong) wrote:
> [email protected] wrote:
> > Since r64107, `make test-all` crashes by EINVAL at...
nobu (Nobuyoshi Nakada)
06:42 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
[email protected] wrote:
> Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
> Attache...
normalperson (Eric Wong)
05:06 AM Bug #14950 (Assigned): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
nobu (Nobuyoshi Nakada)
05:06 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
Since r64107, `make test-all` crashes by EINVAL at `pthread_cond_timedwait`.
Attached logs at r64113.
nobu (Nobuyoshi Nakada)
03:40 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
@normalperson
Eric, r64111 passed Appveyor mswin & MingW (ruby-loco). Travis also.
Thanks, Greg
MSP-Greg (Greg L)
01:12 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
[email protected] wrote:
> 1) Failure:
> TestQueue#test_thr_kill [/home/travis/build/ruby/ruby/test/thread/tes...
normalperson (Eric Wong)
01:09 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
@normalperson Eric,
Thanks. mswin passed, I haven't checked MinGW yet. Bad news is the Travis build had the foll...
MSP-Greg (Greg L)
12:33 AM Bug #14950: r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
OK, r64110 should work. I mangled #ifdef nesting in r64109 :x normalperson (Eric Wong)
12:31 AM Bug #14950 (Closed): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
Applied in changeset trunk|r64110.
----------
thread.c: move ppoll wrapper into thread_pthread.c
thread_pthread.c r...
normalperson (Eric Wong)
12:14 AM Bug #14950 (Assigned): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
I got another error with macOS. hsbt (Hiroshi SHIBATA)
03:21 PM Revision 2a4e8c17 (git): * 2018-07-31
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64132 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:21 PM Revision 09df9972 (git): thread_pthread.c: revert r64123
* thread_pthread.c (USE_NATIVE_SLEEP_COND): revised wrongly removed
line with the ifndef guard.
git-svn-id: svn+ss...
nobu (Nobuyoshi Nakada)
02:15 PM Bug #14868: [PATCH] process.c (ruby_fork_ruby): fix race in signal handling
ruby_2_4 r64130 merged revision(s) 63741. usa (Usaku NAKAMURA)
02:15 PM Revision 8f2e9879 (git): merge revision(s) 63741: [Backport #14868]
process.c (ruby_fork_ruby): fix race in signal handling
We must block signals before stopping timer-thread, ...
U.Nakamura
02:11 PM Bug #14865: Raising exception in c_return event hook causes infinite loop
ruby_2_4 r64129 merged revision(s) 63727. usa (Usaku NAKAMURA)
02:11 PM Revision cd5c3d12 (git): merge revision(s) 63727: [Backport #14865]
vm.c: fix infinite loop
* vm.c: use EXEC_EVENT_HOOK_AND_POP_FRAME. While exception handling, if an exception...
U.Nakamura
02:06 PM Bug #14856: [PATCH] lib/drb/extservm.rb (service): do not return `false'
ruby_2_4 r64128 merged revision(s) 63698. usa (Usaku NAKAMURA)
02:06 PM Revision 5b5739df (git): merge revision(s) 63698: [Backport #14856]
lib/drb/extservm.rb (service): do not return `false'
invoke_service_command may set entries in @servers to `...
U.Nakamura
02:00 PM Bug #14818: [Docs] Backport r63112 to ruby 2.5
ruby_2_4 r64127 merged revision(s) 63112. usa (Usaku NAKAMURA)
02:00 PM Revision 08c74b75 (git): merge revision(s) 63112: [Backport #14818]
Remove outdated example from Numeric documentation
Since 2.5, Numeric instances can be cloned and duplicated...
U.Nakamura
01:57 PM Bug #14816: Extension build failure on a system with musl libc
ruby_2_4 r64126 merged revision(s) 63571,63572. usa (Usaku NAKAMURA)
01:57 PM Revision b6ab48d8 (git): merge revision(s) 63571,63572: [Backport #14816]
`int isnan(double)` is a POSIXism
- `isnan` is something relatively new. We need to provide one for
...
U.Nakamura
01:54 PM Bug #14805: Enumerator#count is silently limited to int32
ruby_2_4 r64125 merged revision(s) 63549,63551,63554. usa (Usaku NAKAMURA)
01:54 PM Revision 7367d5db (git): merge revision(s) 63549,63551,63554: [Backport #14805]
memo->u3.cnt is long not int [Bug #14805]
enum.c: mitigate overflows
* enum.c (enum_count): convert...
U.Nakamura
09:54 AM Revision a038bf23 (git): thread_pthread.h (native_thread_data): split condvars on some platforms
Maybe some platforms have strange condition variable implementations
which have a "memory" of which mutexes they're a...
Eric Wong
08:45 AM Revision c307ffe6 (git): thread_pthread.c: remove duplicate define
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64123 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
08:22 AM Revision 2dd0fb21 (git): fix typo(#2), sorry!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64122 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
08:21 AM Revision dc4e6a8a (git): fix typo; sorry!
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64121 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
08:13 AM Feature #6284: Add composition for procs
matz (Yukihiro Matsumoto) wrote:
> Considering the combination of OOP and FP, it seems a good idea to adding both fo...
printercu (Max Melentiev)
08:05 AM Revision ebfc4485 (git): bootstraptest/runner.rb: speed up assert_finish with IO.select (take #2)
Resurrect r63754 in a 1.8-compatible way. While we're at it,
add a note to maintain 1.8 compatibility (cf. r63757).
...
Eric Wong
07:53 AM Revision ab740cbb (git): move #pragma out of functions
gcc (GCC) 4.4.7 20120313 (Red Hat 4.4.7-18) reportedly fails to compile
cf: https://rubyci.org/logs/rubyci.s3.amazona...
shyouhei (Shyouhei Urabe)
07:31 AM Feature #14473: Add Range#subrange?

Thank you for your patch owst.
I reviewed it and feel the behavior below is strange.
~~~
$ ruby -e 'p (1..3.1...
tarui (Masaya Tarui)
07:07 AM Revision d83536c9 (git): reduce copy & paste
We see several occurrence of "diagnostic push/pop" so why not
make them macros. Tested on GCC8 / Clang 6.
Note that...
shyouhei (Shyouhei Urabe)
06:35 AM Revision 7018acc9 (git): process.c (waitpid_nogvl): prevent conflicting use of sleep_cond
We reuse sleep_cond for waitpid notifications as well as GVL
waiting. So we must take care to not hold onto sleep_co...
Eric Wong
06:02 AM Revision 56491afc (git): thread_pthread.c (rb_sigwait_sleep): th may be 0 from MJIT
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64116 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eric Wong
05:51 AM Revision ab47a57a (git): thread*.c: waiting on sigwait_fd performs periodic ubf wakeups
We need to be able to perform periodic ubf_list wakeups when a
thread is sleeping and waiting on signals.
[ruby-core...
Eric Wong
05:51 AM Revision 95cae748 (git): thread_pthread.c (gvl_destroy): make no-op on GVL bits
It's possible for another thread to take vm->gvl.lock
during gvl_release at the end of thread_start_func_2
during VM ...
Eric Wong
04:28 AM Revision 45143629 (git): thread_pthread.c (rb_sigwait_sleep): fix uninitialized poll set in UBF case
[ruby-core:88088] [Misc #14937] [Bug #5343]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64113 b2dd03c8-39d4-4d...
Eric Wong
03:23 AM Revision 18e22154 (git): non-constant aggregate initializer is a C99ism
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64112 b2dd03c8-39d4-4d8f-98ff-823fe69b080e shyouhei (Shyouhei Urabe)
02:28 AM Revision 26b8a70b (git): thread_pthread.c (rb_sigwait_sleep): re-fix [Bug #5343] harder
We can't always designate a timer thread, so any sleepers must
also perform ubf wakeups. Note: a similar change need...
Eric Wong
01:23 AM Feature #14938: Provide API to get same result as ruby -wc
mtsmfm (Fumiaki Matsushima) wrote:
> ~~~ruby
> #=> /tmp/20180729-457-smihk6:1: warning: ambiguous first argument; p...
nobu (Nobuyoshi Nakada)
12:31 AM Revision 3dc7727d (git): thread.c: move ppoll wrapper into thread_pthread.c
thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
[Bug...
Eric Wong

07/29/2018

11:48 PM Bug #14950 (Closed): r64109 thread.c: move ppoll wrapper before thread_pthread.c - Windows compile failure - thread.c
@normalperson
Eric,
Both windows builds (mswin & mingw) failed compiling thread.c.
Attached logs of both.
...
MSP-Greg (Greg L)
11:18 PM Bug #14949 (Closed): test_jit.rb test_unload_units fails on 32-bit
I get multiple definition warnings from this test. It only
happens on my 32-bit systems (both VM and real HW) on De...
normalperson (Eric Wong)
10:54 PM Revision 2fa1e2e3 (git): thread.c: move ppoll wrapper before thread_pthread.c
thread_pthread.c relies on ppoll for rb_sigwait_sleep, so ensure
the compatibility wrapper is available for it.
Repo...
Eric Wong
10:19 PM Revision 4c1ab82f (git): thread_pthread.c (ubf_select): refix [Bug #5343]
We still need to to designate a timer thread after registering target
thread for the ubf list.
Oops :x
Note: I was ...
Eric Wong
08:47 PM Revision 708bfd21 (git): thread_pthread: remove timer-thread by restructuring GVL
To reduce resource use and reduce CI failure; remove
timer-thread. Single-threaded Ruby processes (including forked
...
Eric Wong
08:28 PM Revision 822e54a5 (git): * 2018-07-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64106 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:28 PM Revision 5db03b7b (git): test/ruby/test_process.rb (test_wait_and_sigchld): improve reliability
This should fix CI failure under MJIT, 100ms wait may not be
enough for signal handler to fire:
http://ci.rvm.jp/resu...
Eric Wong
05:39 PM Feature #14718: Use jemalloc by default?
bluz71 (Dennis B) wrote:
> @andresakata,
>
> Which version of jemalloc?
>
> Ubuntu 16.04 provides jemalloc 3.6...
andresakata (André Guimarães Sakata)
04:34 PM Feature #14718: Use jemalloc by default?
I removed the NewRelic dependency and it's using the `get_process_mem` gem instead. It should work on different platf... andresakata (André Guimarães Sakata)
03:16 PM Feature #14718: Use jemalloc by default?
fweimer (Florian Weimer) wrote:
> Thanks. Would it be possible to eliminate the dependency on `newrelic_rpm`, and p...
andresakata (André Guimarães Sakata)
08:38 AM Feature #14718: Use jemalloc by default?
andresakata (André Guimarães Sakata) wrote:
> Hi!
>
> I'm another Ruby user that used to have memory bloat proble...
fweimer (Florian Weimer)
07:45 AM Feature #14718: Use jemalloc by default?
I believe this has been reported multiple times against glibc, without ever mentioning Ruby. The most relevant upstr... fweimer (Florian Weimer)
04:31 AM Feature #14718: Use jemalloc by default?
[email protected] (Carlos O'Donell) wrote:
> I will try to keep the ruby community updated with regard to our anal...
bluz71 (Dennis B)
04:27 AM Feature #14718: Use jemalloc by default?
@andresakata,
Which version of jemalloc?
Ubuntu 16.04 provides jemalloc 3.6.0 in the repos, is that the version...
bluz71 (Dennis B)
01:18 AM Feature #14718: Use jemalloc by default?
Hi!
I'm another Ruby user that used to have memory bloat problems and switched to `jemalloc` as well.
I just wr...
andresakata (André Guimarães Sakata)
04:37 PM Feature #14938: Provide API to get same result as ruby -wc
Hmm, I tried `warn` but it doesn't work in some case:
~~~ruby
#!/usr/bin/ruby
require 'ripper'
require 'tempfil...
mtsmfm (Fumiaki Matsushima)
11:00 AM Revision 93d74cff (git): common.mk: install for test-all iff load-relative is disabled
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64104 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:31 AM Revision b4705a52 (git): common.mk: test-all requires install for now
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64103 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
10:15 AM Revision c95467e5 (git): thread_pthread.c: clear altstacks in thread cache at GVL destruction
Otherwise, an altstack may live past ObjectSpace destruction
and xfree-ing the altstack will segfault.
[ruby-core:85...
Eric Wong
08:13 AM Revision 01d81d19 (git): reduce LibreSSL warnings
* ext/openssl/extconf.rb: LibreSSL headers emit "overriding WinCrypt
defines" warnings if wincrypt.h has been inclu...
nobu (Nobuyoshi Nakada)
08:04 AM Revision e3c1c406 (git): mjit.c: keep unit->o_file on --jit-save-temps
to use compaction with --jit-save-temps.
Prior to this commit, JIT compaction didn't work with --jit-save-temps
but ...
k0kubun (Takashi Kokubun)
04:03 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
Thanks again! I'll probably commit soon since this looks very
straightforward (it took a long time to get there, t...
normalperson (Eric Wong)
02:07 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
@normalperson
Eric,
Ran both patches on top of r64095, result was similar to above (passed as above).
Thanks...
MSP-Greg (Greg L)
12:33 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
> > https://bugs.ruby-lang.org/issues/14937
>
> https://80x24.org/spew/[email protected]/raw

...
normalperson (Eric Wong)
03:22 AM Revision c93c8e09 (git): test_jit.rb: skip known test failure on MinGW
for the ease of MSP-Greg's CI. I'll track this failure as Bug#14948 and
fix it later.
git-svn-id: svn+ssh://ci.ruby-...
k0kubun (Takashi Kokubun)
02:58 AM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
@k0kubun
I apologize, I should have been clearer. ruby-loco is built three times a day. The list of builds is sh...
MSP-Greg (Greg L)
02:28 AM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
> Starting with r64076, every subsequent build has failed
Does this mean, r64075 passes and r64076 fails? r64076 c...
k0kubun (Takashi Kokubun)
02:36 AM Revision 4d7114c9 (git): test_jit.rb: use the appropiate name
for better C-level backtrace
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64098 b2dd03c8-39d4-4d8f-98ff-823fe69...
k0kubun (Takashi Kokubun)
02:05 AM Revision 82bd2a9c (git): mjit.c: disable compaction on empty queue w/ --jit-wait
When --jit-wait is specified, `unit_queue.length` is always 0 and it's
not a good metric.
git-svn-id: svn+ssh://ci.r...
k0kubun (Takashi Kokubun)
01:32 AM Revision c5a5563d (git): repack structs
Repack rb_thread_struct, rb_execution_context_struct, args_info and
iseq_compile_data to save 1 word per struct.
re_...
nobu (Nobuyoshi Nakada)
12:09 AM Bug #14946 (Closed): ./win32/mkexports.rb:112: warning: flip-flop is deprecated
Applied in changeset trunk|r64095.
----------
mkexports.rb: flip-flop
* win32/mkexports.rb (Exports::Mswin#each_exp...
nobu (Nobuyoshi Nakada)
12:09 AM Revision 63ae1e3c (git): mkexports.rb: flip-flop
* win32/mkexports.rb (Exports::Mswin#each_export): get rid of
flip-flop warning. [ruby-core:88147] [Bug #14946]
g...
nobu (Nobuyoshi Nakada)

07/28/2018

11:43 PM Bug #14948 (Closed): MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
Starting with r64076, every subsequent build has failed, both in parallel & retry, on `TestJIT#test_unload_units`.
...
MSP-Greg (Greg L)
10:38 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
@normalperson
Eric,
Passed all tests using r64094. TestJIT#test_unload_units has been failing (both in paralle...
MSP-Greg (Greg L)
08:32 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
> https://bugs.ruby-lang.org/issues/14937

OK, new patch to eliminate timer-thread completely. It seems to pass
...
normalperson (Eric Wong)
06:35 PM Feature #14717: [PATCH] thread: allow disabling preempt
normalperson (Eric Wong) wrote:
> Giving control to other threads still happens with Thread.pass
> or anything wh...
Eregon (Benoit Daloze)
01:42 AM Feature #14717: [PATCH] thread: allow disabling preempt
[email protected] wrote:
> Is this the same as `Thread.new { Thread.handle_interrupt(Exception => :never) { ... } ...
normalperson (Eric Wong)
04:23 PM Bug #14634: Queue#push seems to crash after fork
Hi, we've also been running into this at work. Thanks for the fix and backport! We look forward to a 2.5.2 release. shan (Shannon Skipper)
04:15 PM Bug #14490 (Closed): MJIT slows down Rails applications
Applied in changeset trunk|r64094.
----------
mjit.c: introduce JIT compaction [experimental]
When all compilation ...
k0kubun (Takashi Kokubun)
04:14 PM Revision 443f4d58 (git): mjit.c: introduce JIT compaction [experimental]
When all compilation finishes or the number of JIT-ed code reaches
--jit-max-cache, this compacts all generated code ...
k0kubun (Takashi Kokubun)
03:29 PM Bug #14942 (Closed): Windows7でコンソールに長い文字列を出力できない
Applied in changeset trunk|r64092.
----------
win32.c: limit write size on console
* win32/win32.c (constat_parse):...
nobu (Nobuyoshi Nakada)
03:29 PM Revision 2a9cae33 (git): * 2018-07-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64093 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:29 PM Revision 73ae3e9b (git): win32.c: limit write size on console
* win32/win32.c (constat_parse): split long buffer and limit write
size on a console, as well as rb_w32_write.
[r...
nobu (Nobuyoshi Nakada)
01:06 PM Revision 440f4421 (git): test_function.rb: fix messages
* test/fiddle/test_function.rb (test_nogvl_poll): fix messages as
failed conditions, with errno description.
git-s...
nobu (Nobuyoshi Nakada)
12:47 PM Revision d383426a (git): make-snapshot: fetch from the official git site
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64090 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:00 AM Revision a832dc0f (git): Fix filename in comment [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64089 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
10:00 AM Revision 14892a26 (git): use https:// instead of http://
[ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64088 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
znz (Kazuhiro NISHIYAMA)
09:58 AM Bug #14946 (Closed): ./win32/mkexports.rb:112: warning: flip-flop is deprecated
I get the warning in the subject. I think it's better to get rid of this
in our own build code.
duerst (Martin Dürst)
09:56 AM Bug #14934 (Closed): Unicode: Hangul normalize bug
Closed. Because there is no actual bug, there is no need to backport this. duerst (Martin Dürst)
09:54 AM Bug #14934: Unicode: Hangul normalize bug
I committed the tests adapted from Python and the fix of the comparison operator, because it's technically correct an... duerst (Martin Dürst)
03:16 AM Bug #14934: Unicode: Hangul normalize bug
Get it. :) MaLin (Lin Ma)
09:44 AM Revision a7acec67 (git): fix range check for Hangul jamo trailers in Unicode normalization
* lib/unicode_normalize/normalize.rb: Fix the range check for trailing
Hangul jamo characters in Unicode normalizat...
duerst (Martin Dürst)
09:11 AM Revision 9eb6304a (git): always run unicode normalization that do not depend on data file
* test/test_unicode_normalize.rb: extract tests that do not depend
on NormalizationTest.txt data file from conditio...
duerst (Martin Dürst)
08:56 AM Revision fb105931 (git): update unicode data files directory for normalization tests
* test/test_unicode_normalize.rb: search ucd directory
first if it exists. This change follows r61415.
git-svn-id:...
duerst (Martin Dürst)
03:34 AM Revision 3943dcd1 (git): use https:// instead of git:// when possible
Avoid MitM when downloading from insecure networks.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64084 b2dd03c8...
Eric Wong
03:10 AM Bug #14945 (Closed): [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
Applied in changeset trunk|r64083.
----------
thread.c (blocking_region_end): clear ubf before unregister_ubf_list
...
normalperson (Eric Wong)
12:45 AM Bug #14945 (Closed): [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
thread.c (blocking_region_end): clear ubf before unregister_ubf_list
If we keep ubf set after unregistering, there...
normalperson (Eric Wong)
03:10 AM Revision 856bd77a (git): thread.c (blocking_region_end): clear ubf before unregister_ubf_list
If we keep ubf set after unregistering, there is a window for
other threads (including timer thread) to put this thre...
Eric Wong
01:14 AM Feature #14912: Introduce pattern matching syntax
shyouhei-san:
I changed my mind. We should be able to avoid such "fragile" case.
Though duck typing is important, i...
ktsj (Kazuki Tsujimoto)

07/27/2018

10:27 PM Revision 297ae343 (git): mjit.c: clean up unit link from iseq
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64082 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
05:28 PM Revision efee3033 (git): Include Hash#size in the examples
Both methods Hash#length and Hash#size share the same source code in
Ruby, but they also share the same documentation...
tenderlovemaking (Aaron Patterson)
05:19 PM Revision ecf4641b (git): * 2018-07-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64080 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
05:19 PM Revision 684cdb4f (git): Escape debug output in InvalidURIError exceptions.
Co-authored-by: Brad Landers <[email protected]>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64079 b2dd03c8...
tenderlovemaking (Aaron Patterson)
04:59 PM Feature #14944 (Closed): Support optional inherit argument for Module#method_defined?
Module has many introspection methods for methods and constants that
either return an array or return true or false ...
jeremyevans0 (Jeremy Evans)
04:15 PM Bug #13218 (Rejected): testing
nobu (Nobuyoshi Nakada)
01:57 PM Revision ffb09d8e (git): eval.c: rename "rb_frozen_class_p" to "rb_class_modify_check"
Just refactoring. Despite its name, the function does NOT return a
boolean but raises an exception when the class gi...
mame (Yusuke Endoh)
10:22 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
Btw, I can probably improve on this by making GVL waiter perform
timeslice; so it would eliminate timer-thread comp...
normalperson (Eric Wong)
10:22 AM Bug #14943: ruby 2.4 doesn't work with jemalloc 5.1.0 properly.
[email protected] wrote:
> With jemalloc 5.1.0, ruby 2.4.4 failed to initalize timer thread and it causes broken...
normalperson (Eric Wong)
10:00 AM Bug #14943 (Closed): ruby 2.4 doesn't work with jemalloc 5.1.0 properly.
With jemalloc 5.1.0, ruby 2.4.4 failed to initalize timer thread and it causes broken runtime, e.g. signals are ignor... repeatedly (Masahiro Nakagawa)
10:14 AM Feature #14717: [PATCH] thread: allow disabling preempt
Is this the same as `Thread.new { Thread.handle_interrupt(Exception => :never) { ... } }`?
What's the difference?
...
Eregon (Benoit Daloze)
08:12 AM Feature #14717: [PATCH] thread: allow disabling preempt
[email protected] wrote:
> `Thread.exclusive` ?

No, this is different from that old method because thread
swit...
normalperson (Eric Wong)
04:29 AM Feature #14717: [PATCH] thread: allow disabling preempt
`Thread.exclusive` ? nobu (Nobuyoshi Nakada)
09:27 AM Revision ceab460f (git): mjit.c: keep all .o files
and lazily delete them on termination.
This will be needed to create a large so file later.
The large number of .o f...
k0kubun (Takashi Kokubun)
08:51 AM Revision e09bf11f (git): mjit.c: use NOT_COMPILED_JIT_ISEQ_FUNC for unloaded
units, renaming it from NOT_COMPILABLE_JIT_ISEQ_FUNC.
NOT_READY_JIT_ISEQ_FUNC is for ones being compiled, so
mjit_ge...
k0kubun (Takashi Kokubun)
08:26 AM Bug #14942 (Closed): Windows7でコンソールに長い文字列を出力できない
WindowsのRubyは、WriteConsoleWでコンソールに文字を出力していますが、
Windows7では、WriteConsoleで書き出せるバッファのサイズは61KB程度が限界のようです。
(WriteConsoleW...
yagisu (Sumi Yagi)
08:24 AM Revision 0d753d4f (git): mjit.c: release memory for unloaded unit
`xfree(unit)` was missing.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64075 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
k0kubun (Takashi Kokubun)
06:28 AM Revision ca494df3 (git): insns.def: remove old wrong explanation for get/setconstant
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64074 b2dd03c8-39d4-4d8f-98ff-823fe69b080e mame (Yusuke Endoh)
06:01 AM Revision 4aa952f6 (git): mjit.c: clarify the intention of setting 0
which was originally NULL before r62221
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64073 b2dd03c8-39d4-4d8f-9...
k0kubun (Takashi Kokubun)
05:52 AM Revision 51f94872 (git): test_jit.rb: test unload_units
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64072 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
05:43 AM Bug #14941 (Closed): WindowsでARGVの文字列に汚染マークが付いてない
Applied in changeset trunk|r64071.
----------
ruby.c: taint ARGV on Windows
* ruby.c (external_str_new_cstr): strin...
nobu (Nobuyoshi Nakada)
03:57 AM Bug #14941 (Closed): WindowsでARGVの文字列に汚染マークが付いてない
WindowsのRuby2.2以降で、コマンドライン引数の文字列に汚染マークを付け忘れてます。
~~~
$ ruby -e "p ARGV[0].tainted?" arg
false
~~~
yagisu (Sumi Yagi)
05:42 AM Revision 9fbb6661 (git): ruby.c: taint ARGV on Windows
* ruby.c (external_str_new_cstr): strings come from the external
should be tainted. [ruby-dev:50596] [Bug #14941]
...
nobu (Nobuyoshi Nakada)
05:10 AM Bug #14934: Unicode: Hangul normalize bug
I think I have figured things out:
The patch is technically correct. While LBASE and VBASE are the values of the f...
duerst (Martin Dürst)
04:24 AM Misc #14921: DevelopersMeeting20180809Japan
[Feature #11076] Enumerable method count_by
As mentioned in the discussion, Nobu was kind enough to update this to...
baweaver (Brandon Weaver)
03:04 AM Feature #14938: Provide API to get same result as ruby -wc
Why don't you use ripper?
```ruby
#!/usr/bin/ruby
require 'ripper'
class Lint < Ripper
def warn(*s)
@re...
nobu (Nobuyoshi Nakada)

07/26/2018

08:40 PM Feature #13683: Add strict Enumerable#single
nobu (Nobuyoshi Nakada) wrote:
> How about `Enumerable#just(num=1)` or `Enumerable#only(num=1)`?
Or maybe a sligh...
shan (Shannon Skipper)
07:52 PM Feature #14915: Deprecate String#crypt
I've released a string-crypt gem based on the previous patch: https://github.com/jeremyevans/ruby-string-crypt
The...
jeremyevans0 (Jeremy Evans)
06:51 PM Feature #14718: Use jemalloc by default?
> vo.x (Vit Ondruch) wrote:
> > Thx :) I think that at least in Fedora/RHEL case, the decision will be based on this...
[email protected] (Carlos O'Donell)
06:46 PM Revision c0e478ed (git): * 2018-07-27
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64070 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:46 PM Revision 5219adf4 (git): lib/ostruct: Remove unnecessary `__send__`
Patch by yuuji.yaginuma [Fix GH-1890]
Since `remove_method` is public.
Ref: https://bugs.ruby-lang.org/issues/14133
...
Marc-Andre Lafortune
03:32 PM Feature #14183: "Real" keyword argument
@shevegen Of course, we will take plenty of time to migrate before making it a keyword.
If we made the decision, we ...
matz (Yukihiro Matsumoto)
10:38 AM Feature #14183: "Real" keyword argument
I don't want to write too much, so just one comment - I would also prefer foo(kw: 1)
to retain being a Hash rather t...
shevegen (Robert A. Heiler)
03:21 PM Feature #14938: Provide API to get same result as ruby -wc
I want to get 3 things.
1. Type (warning or error)
2. Message
3. Location
I think location interface should b...
mtsmfm (Fumiaki Matsushima)
06:25 AM Feature #14938: Provide API to get same result as ruby -wc
Good idea. Do you have an idea about API and implementation?
Maybe parse.y should be modified (== difficult).
ko1 (Koichi Sasada)
01:05 PM Revision 781c3ca5 (git): mjit.c: o -> so is not compilation
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64068 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
12:48 PM Revision 2bfc1334 (git): dir.c: fix glob with base when no DT_UNKNOWN
* dir.c (do_stat, do_lstat, do_opendir): need the length of the base
path for fstatat() when fd is valid.
* dir.c ...
nobu (Nobuyoshi Nakada)
12:47 PM Revision f6ae1ed6 (git): Add missing escape
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64066 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
12:04 PM Revision d6df54cc (git): process.c: conditionally used functions
* process.c (before_fork_ruby, after_fork_ruby): used only if fork()
or daemon() is available.
git-svn-id: svn+ssh...
nobu (Nobuyoshi Nakada)
11:07 AM Bug #14096 (Assigned): Psych allows invalid single quote escape character
hsbt (Hiroshi SHIBATA)
09:34 AM Revision dff596be (git): dladdr() is declared with non-const pointer on Solaris
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64064 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
09:32 AM Revision 05316c40 (git): fork() is deprecated on Solaris
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64063 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
08:42 AM Bug #14939: [PATCH] cont.c (ec_switch): prevent delayed/missed trap interrupt race
[email protected] wrote:
> Good point. Seems good. Thank you!

OK, commited as r64062

> BTW, I forget that why the...
normalperson (Eric Wong)
08:30 AM Bug #14939 (Closed): [PATCH] cont.c (ec_switch): prevent delayed/missed trap interrupt race
Applied in changeset trunk|r64062.
----------
cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-...
normalperson (Eric Wong)
06:40 AM Bug #14939: [PATCH] cont.c (ec_switch): prevent delayed/missed trap interrupt race
Oops, sorry forget about `sleep` lines.
ko1 (Koichi Sasada)
06:39 AM Bug #14939: [PATCH] cont.c (ec_switch): prevent delayed/missed trap interrupt race
Good point. Seems good. Thank you!
BTW, I forget that why the trap handler is limited to main thread.
```
tr...
ko1 (Koichi Sasada)
08:30 AM Misc #14937 (Closed): [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
Applied in changeset trunk|r64062.
----------
cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-...
normalperson (Eric Wong)
08:30 AM Revision 97538e81 (git): cont.c (ec_switch): prevent delayed/missed trap interrupt race
timer-thread may set trap interrupt with rb_threadptr_check_signal
at any time independent of GVL. This means timer-...
Eric Wong
07:23 AM Revision d3df0de6 (git): ignore built files
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64061 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
03:32 AM Feature #14940: Support bcrypt password hashing in webrick
Thanks, applied as r64060.

I needed to add RUBYLIB=/path/to/bcrypt/lib to my make command
line to test bcrypt; b...
normalperson (Eric Wong)
03:21 AM Feature #14940 (Closed): Support bcrypt password hashing in webrick
Applied in changeset trunk|r64060.
----------
webrick: Support bcrypt password hashing
This adds a password_hash ke...
normalperson (Eric Wong)
03:21 AM Revision 9749bfbf (git): webrick: Support bcrypt password hashing
This adds a password_hash keyword argument to
WEBrick::HTTPAuth::Htpasswd#initialize. If set to :bcrypt, it
will cre...
Eric Wong
02:16 AM Feature #13534 (Assigned): Checking installation results of default gems
hsbt (Hiroshi SHIBATA)
02:13 AM Bug #9366 (Assigned): "make -j32 check TESTS=-j32" occasionally fails on rubygems/specification
hsbt (Hiroshi SHIBATA)
02:12 AM Feature #12639 (Assigned): Speed up require in RubyGems by 5x
hsbt (Hiroshi SHIBATA)
02:12 AM Bug #12764 (Assigned): rubygems with multi default gem problem
hsbt (Hiroshi SHIBATA)
02:12 AM Bug #13834 (Assigned): RubyGems test suite occasionally changes working directory and breaks the rest of test suite
hsbt (Hiroshi SHIBATA)
 

Also available in: Atom