Project

General

Profile

Activity

From 08/02/2018 to 08/08/2018

08/08/2018

08:51 PM Feature #14869: Proposal to add Hash#===
I had mentioned this in the `Array#===` topic for consideration: https://bugs.ruby-lang.org/issues/14916#note-6
In...
baweaver (Brandon Weaver)
08:46 PM Feature #14916: Proposal to add Array#===
I've noticed that this will always return false if the other value is not an array:
(line 4011 of patch)
```ruby
...
baweaver (Brandon Weaver)
01:21 PM Feature #14916: Proposal to add Array#===
> I think there is a potential incompatibility here, due to changing the behavior of #===.
> The fact Module#=== doe...
osyo (manga osyo)
08:23 PM Feature #14975: String#append without changing receiver's encoding
I think this should be filed under Feature simply because it may change
existing functionality.
shevegen (Robert A. Heiler)
03:35 AM Feature #14975: String#append without changing receiver's encoding
One other option would be to add `String#append` which preserves encoding. ioquatix (Samuel Williams)
03:15 AM Feature #14975 (Rejected): String#append without changing receiver's encoding
I'm not sure where this fits in, but in order to avoid garbage and superfluous function calls, is it possible that `S... ioquatix (Samuel Williams)
06:37 PM Feature #6284: Add composition for procs
matz (Yukihiro Matsumoto) wrote:
> We need more discussion if we would add combination methods to the `Symbol` class...
shan (Shannon Skipper)
03:36 PM Revision 86f6fa45 (git): * 2018-08-09
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:36 PM Revision a6cb8552 (git): needs openssl/opensslv.h
* ext/openssl/extconf.rb: LIBRESSL_VERSION_NUMBER is defined in
openssl/opensslv.h. fix up r64101.
git-svn-id: sv...
nobu (Nobuyoshi Nakada)
02:34 PM Revision 8778e926 (git): fix mjit_min_header for universal binary
* common.mk: rules using MJIT_HEADER_SUFFIX, which to be overriden
in defs/universal.mk, must be in common.mk, not ...
nobu (Nobuyoshi Nakada)
02:28 PM Feature #14426 (Closed): [PATCH] openssl: reduce memory allocation in OpenSSL::Buffering#do_write
The patch is now in ruby/openssl (upstream)'s master branch and Ruby trunk.
For the record, the GitHub Pull Reques...
rhenium (Kazuki Yamaguchi)
02:13 PM Revision 1dfc377a (git): net/http, net/ftp: fix session resumption with TLS 1.3
When TLS 1.3 is in use, the session ticket may not have been sent yet
even though a handshake has finished. Also, the...
rhenium (Kazuki Yamaguchi)
02:13 PM Revision a0f292bb (git): openssl: sync with upstream repository
Sync with the current tip of master branch, 62436385306c of
ruby/openssl.git. Changes can be found at:
https...
rhenium (Kazuki Yamaguchi)
01:50 PM Revision 4b13656e (git): fix MSG_OOB spec
* OOBINLINE should be set for accepted socket
* When OOBINLINE is set, MSG_OOB shouldn't be passed to recv
Merge spe...
naruse (Yui NARUSE)
01:45 PM Misc #14921: DevelopersMeeting20180809Japan
- [Feature #14973] Proposal of percent literal to expand Hash
aycabta (aycabta .)
01:44 PM Revision e0cece9d (git): Add colon to avoid chkbuild's alert
https://github.com/ruby/chkbuild/blob/c0448670a9a5cb85f283bc639806ba09b294557f/chkbuild/ruby.rb#L847
Merge ruby/spec...
naruse (Yui NARUSE)
12:48 PM Revision 4078be54 (git): rename several internal macros in time.c
TIME_UTC_P -> TZMODE_UTC_P
TIME_SET_UTC -> TZMODE_SET_UTC
TIME_LOCALTIME_P -> TZMODE_LOCALTIME_P
TIME_SET_LOCALTIME -...
akr (Akira Tanaka)
11:50 AM Revision 0f904ff1 (git): Update comment of tzmode [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:22 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
[snipping some bits, because I can only speak to what I know]

On Wed, 8 Aug 2018 at 18:50, Eric Wong <normalperso...
phluid61 (Matthew Kerwin)
08:53 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
[email protected] wrote:
> I've been playing around with my gem async and I've come to
> the conclusion tha...
normalperson (Eric Wong)
01:21 AM Feature #13618: [PATCH] auto fiber schedule for rb_wait_for_single_fd and rb_waitpid
Eric that is a great update.
I've been playing around with my gem async and I've come to the conclusion that it is...
ioquatix (Samuel Williams)
10:39 AM Revision b81a3326 (git): Rename gmt field to tzmode in struct time_object.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e akr (Akira Tanaka)
10:00 AM Revision 277cedb8 (git): Store String as zone in struct vtm.
This removes zone_table and use fstring instead.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64227 b2dd03c8-3...
akr (Akira Tanaka)
09:33 AM Bug #14945: [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
[email protected] wrote:
> ko1 (Koichi Sasada) wrote:
> > One off topic question. `list_empty()` is thread-safe?
>
...
normalperson (Eric Wong)
05:53 AM Bug #14945: [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
ko1 (Koichi Sasada) wrote:
> One off topic question. `list_empty()` is thread-safe?
Sorry it should be safe (I mi...
ko1 (Koichi Sasada)
05:51 AM Bug #14945: [PATCH] thread.c (blocking_region_end): clear ubf before unregister_ubf_list
:+1:
One off topic question. `list_empty()` is thread-safe?
ko1 (Koichi Sasada)
08:37 AM Bug #14976 (Closed): /usr/local/lib/ruby/gems/2.6.0/gems/fluentd-1.2.4/lib/fluent/event.rb:193: [BUG] Segmentation fault at 0x0000000000000000 ruby 2.6.0preview1 (2018-02-24 trunk 62554) [x86_64-linux]
[root@sh_02 fluentd]# fluentd -c /alidata/install/fluentd/conf/datahub.conf
2018-08-08 16:31:29 +0800 [info]: parsin...
booboowei (booboo wei)
08:04 AM Feature #14717: [PATCH] thread: allow disabling preempt
[email protected] wrote:
> I don't think it is good idea to support
> `Thread#preemptible=false` because someone can m...
normalperson (Eric Wong)
05:39 AM Feature #14717: [PATCH] thread: allow disabling preempt
# The following is the fact I want to clear
(fix me if my understanding is wrong)
I believe this proposal is eq...
ko1 (Koichi Sasada)
08:00 AM Revision 60012d13 (git): Some environments do not have IPv6 address of localhost in /etc/hosts
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64226 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
07:52 AM Misc #14962: [PATCH] thread_pthread: stop trying to deal with cancellation
[email protected] wrote:
> I don't know about these deleted code. Who introduced?

Looks like akr did, but no reasoni...
normalperson (Eric Wong)
06:35 AM Misc #14962: [PATCH] thread_pthread: stop trying to deal with cancellation
I don't know about these deleted code. Who introduced?
ko1 (Koichi Sasada)
07:26 AM Revision 953b7a20 (git): mjit.c: remove old comment about WNOHANG and SIGCHLD [ci skip]
[Bug #14867] implemented exactly what was needed (for POSIX
platforms, at least).
git-svn-id: svn+ssh://ci.ruby-lang...
Eric Wong
06:31 AM Bug #14898: test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
> Oh, different test, that is test_timestampns getting stuck.
sorry.
> ko1: is frontier also on Docker?
No....
ko1 (Koichi Sasada)
06:27 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
> The question then becomes: What happens when Guilds land?
I have an optimistic opinion.
If transient heap succe...
ko1 (Koichi Sasada)
06:10 AM Feature #14759: [PATCH] set M_ARENA_MAX for glibc malloc
sam.saffron (Sam Saffron) wrote:
> Koichi / Nobu
>
> Is there any chance we can merge this in and even backport ...
ko1 (Koichi Sasada)
06:07 AM Feature #14955: [PATCH] gc.c: use MADV_FREE to release most of the heap page body
off-topic `:p`:
If we have a lightweight communication channel between user-process and OS, we can choose this tec...
ko1 (Koichi Sasada)
03:10 AM Bug #13407: We have recv_nonblock but not send_nonblock... can we add it?
We can close this issue, as there exists a satisfactory alternative. ioquatix (Samuel Williams)
03:08 AM Misc #10783: String#concat has an "appending" behavior
I also agree that this is confusing, and the only way to fix it would really be to rename `concat` to `append`. There... ioquatix (Samuel Williams)
03:01 AM Feature #14033: Add String#append
I would like to propose to extend this method to be binary safe.
If the destination string uses `Encoding::BINARY`...
ioquatix (Samuel Williams)
02:56 AM Revision ca5c3f1e (git): skip hanging-up tests on macOS
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
01:16 AM Revision 3b8b6688 (git): spec/ruby/library/socket/*: fix hanging on FreeBSD 11.1
There are still other test failures which need fixing on FreeBSD.
Keep an eye on:
http://rubyci.s3.amazonaws.com/f...
Eric Wong

08/07/2018

11:04 PM Bug #14974: "if" statement executes wrong branch
jeremyevans0 (Jeremy Evans) wrote:
> This appears to be a duplicate of #14897.
Yes, it is already fixed in trunk....
mame (Yusuke Endoh)
06:44 PM Bug #14974 (Closed): "if" statement executes wrong branch
This appears to be a duplicate of #14897. jeremyevans0 (Jeremy Evans)
06:32 PM Bug #14974 (Closed): "if" statement executes wrong branch
I've stumbled over a rather weird bug where Ruby 2.5+ executes an `else` branch of a condition when it should not. Th... kratob (Tobias Kraze)
07:22 PM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
> > or I will have to revert and reintroduce timer-thread :<
>
> reverted for now :< r64203

Btw, using POSIX t...
normalperson (Eric Wong)
05:08 PM Feature #14967: Any type
I do not have any particular opinion about "Any Type" as of yet,
neither pro or con, but just as to what Mr. Beaver ...
shevegen (Robert A. Heiler)
04:49 PM Revision 29ccaf6e (git): appveyor.yml: make sure MJIT is tested on AppVeyor
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
04:27 PM Revision 10bccf34 (git): mjit.c: initial support for mswin MJIT
By this commit's changes in other files, now MJIT started to work on VC++.
Unfortunately some features are still brok...
k0kubun (Takashi Kokubun)
04:07 PM Feature #14973: Proposal of percent literal to expand Hash
I can not read japanese but I believe I can understand part of this
proposal (the ruby code examples).
If I unde...
shevegen (Robert A. Heiler)
03:12 PM Feature #14973 (Closed): Proposal of percent literal to expand Hash
## 概要
変数名から `{ 変数名: 変数の値 }` という Hash を定義するための %記法の提案です。
以前からちょくちょく[提案されていた](https://bugs.ruby-lang.org/issues/145...
osyo (manga osyo)
03:14 PM Revision 7fef5883 (git): * 2018-08-08
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:14 PM Revision 8430d0d1 (git): win32/Makefile.sub: escape `=` in MJIT cflags
Since `=` is considered as delimiter in `()` of `for`, having
`-DRUBY_DEVEL=1` in CPPFLAGS had resulted in:
#define...
k0kubun (Takashi Kokubun)
01:08 PM Revision dfd6787f (git): Silence Net::HTTP warning in test.
https://github.com/ruby/webrick/pull/8
Co-authored-by: Espartaco Palma <>
git-svn-id: svn+ssh://ci.ruby-lang.org/...
hsbt (Hiroshi SHIBATA)
12:56 PM Bug #14866 (Closed): [PATCH] add missing test for WEBrick::HTTPAuth::Htgroup
Applied in changeset trunk|r64216.
----------
Add missing test for WEBrick::HTTPAuth::Htgroup.
[Bug #14866][ruby-...
hsbt (Hiroshi SHIBATA)
12:56 PM Revision 68fac148 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
12:56 PM Revision 5a99a740 (git): Add missing test for WEBrick::HTTPAuth::Htgroup.
[Bug #14866][ruby-core:87602]
https://github.com/ruby/webrick/pull/10
Co-authored-by: TSUYUSATO Kitsune <make.j...
hsbt (Hiroshi SHIBATA)
12:47 PM Revision 1380aa04 (git): Support old versions of Ruby with FrozenError.
They should work separatedly from Ruby core repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64215 b2dd...
hsbt (Hiroshi SHIBATA)
12:32 PM Revision d59fc41f (git): Fallback to load version constant for ruby core repository.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64214 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
12:30 PM Bug #14964: [MJIT] missing builtin methods
ok, I attached full build logs and my env vars.
output_witharch_81.txt - ```--with-arch-64='barcelona'``` or ```AR...
ahorek (Pavel Rosický)
12:02 PM Revision 7d9109f8 (git): Removed needless date attribute from gemspec of default gems.
They are assigned automatically when pushing gem file to rubygems.org.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
hsbt (Hiroshi SHIBATA)
12:00 PM Revision 2ce807e8 (git): Remove unnecessary assignment
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e znz (Kazuhiro NISHIYAMA)
11:36 AM Revision 325d378a (git): Removed needless file from gemspec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
11:18 AM Revision 9e5cd30b (git): Add support of Berkeley DB 6.x.
https://github.com/ruby/dbm/pull/3
Co-authored-by: Yasuhiro KIMURA <>
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby...
hsbt (Hiroshi SHIBATA)
09:52 AM Revision 83bdae19 (git): Add test for coverage.
https://github.com/ruby/cmath/pull/2
Co-authored-by: MATSUBARA Nobutada
git-svn-id: svn+ssh://ci.ruby-lang.org/ru...
hsbt (Hiroshi SHIBATA)
07:20 AM Bug #14972 (Closed): Net::HTTP inconsistently raises EOFError when peer closes the connection
If chunked transfer encoding is used, and the peer closes the connection while the caller is reading data, then the `... joshc (Josh C)
07:12 AM Bug #14971 (Closed): error: implicit declaration of function ‘rb_vm_call0
I get the errors below when making `make up install-nodoc`.
I'm not at v64208.
```
compiling vm.c
In file inclu...
duerst (Martin Dürst)
04:12 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
[email protected] wrote:
> All of the test-all failures show something similar to:
> ```
> [Errno::ENOENT] exce...
normalperson (Eric Wong)
02:44 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
@normalperson Eric,
The zip of all the logs is at
https://ci.appveyor.com/api/buildjobs/pwyhyvkao2nssxy1/artifa...
MSP-Greg (Greg L)
01:47 AM Bug #14969: Process.groups が返す GID が重複している場合がある
(シェルスクリプトの uniq と違って) ruby の uniq は sort 済みかどうかに依存していないので、 `.sort.uniq` よりも `.uniq.sort` の方が良いと思います。 znz (Kazuhiro NISHIYAMA)
01:17 AM Revision e9b63a84 (git): * 2018-08-07
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
01:17 AM Revision 20c1e4a7 (git): win32/Makefile.sub: remove RUBY_EXPORT macro
defined in XCFLAGS.
This change resolves following link errors in MJIT:
```
rb_mjit_header-2.6.0.obj : error LNK200...
k0kubun (Takashi Kokubun)

08/06/2018

11:54 PM Bug #14964: [MJIT] missing builtin methods
> ARCH_FLAG="-march=barcelona" works, but it isn't propagated to CFLAGS, so it doesn't have the desired effect. I thi... k0kubun (Takashi Kokubun)
11:00 PM Bug #14964: [MJIT] missing builtin methods
ARCH_FLAG="-march=barcelona" works, but it isn't propagated to CFLAGS, so it doesn't have the desired effect. I think... ahorek (Pavel Rosický)
11:42 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
[email protected] wrote:
> The build log is at
> https://ci.appveyor.com/api/buildjobs/d0s8pbatmb7ax667/log
>
...
normalperson (Eric Wong)
10:04 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
@normalperson
The patch was fine, but the Appveyor build stopped.
Earlier, r64206 built fine, and I added the p...
MSP-Greg (Greg L)
09:22 PM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
> > https://bugs.ruby-lang.org/issues/14968
>
> Updated patch on top of r64203 since I restored timer-thread :<
...
normalperson (Eric Wong)
05:42 AM Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
> Bug #14968: [PATCH] io.c: make all pipes nonblocking by default
> https://bugs.ruby-lang.org/issues/14968

Upda...
normalperson (Eric Wong)
04:46 AM Bug #14968 (Closed): [PATCH] io.c: make all pipes nonblocking by default
Crap, I always planned to have something like this for [Feature #13618]
(auto-Fiber); but introducing a race conditi...
normalperson (Eric Wong)
07:13 PM Misc #14907: [PATCH] io.c: do not close inherited FDs by default
Updated patch to default close_others to false
normalperson (Eric Wong)
06:27 PM Feature #14938: Provide API to get same result as ruby -wc
> This warning dispatches on_arg_ambiguous method.
> It dispatches on_parse_error method.
How can I find the li...
mtsmfm (Fumiaki Matsushima)
03:50 PM Bug #14966: 2.5 branch - Appveyor failures - backport missed line
My fork passed on Appveyor:
https://ci.appveyor.com/project/MSP-Greg/ruby/build/7#L4336
MSP-Greg (Greg L)
02:42 PM Misc #14921: DevelopersMeeting20180809Japan
* [Feature #14944] Support optional inherit argument for Module#method_defined? jeremyevans0 (Jeremy Evans)
05:03 AM Misc #14921: DevelopersMeeting20180809Japan
* [Bug #14968] io.c: make all pipes nonblocking by default

* [Misc #14937] timer-thread elimination depends on [B...
normalperson (Eric Wong)
03:11 AM Misc #14921: DevelopersMeeting20180809Japan
[Feature #14967] Any type - Adds a wildcard type, primarily for use in Pattern Matching type syntaxes
This would b...
baweaver (Brandon Weaver)
02:32 PM Feature #14916: Proposal to add Array#===
I think there is a potential incompatibility here, due to changing the behavior of #===.
The fact `Module#===` doesn...
Eregon (Benoit Daloze)
12:46 PM Bug #14970 (Closed): -i option doesn't work for multi-byte-char filenames on Windows Ruby2.5.1
Z:\>touch あ
Z:\>ruby -v
ruby 2.5.1p57 (2018-03-29 revision 63029) [i386-mingw32]
Z:\>ruby -i.bak -pe p あ
-e:1: wa...
tksotn (TAKASHI OOTANI)
09:08 AM Feature #13904 (Closed): getter for original information of Enumerator
Applied in changeset trunk|r64205.
----------
enumerator.c: Introduce Enumerator::ArithmeticSequence
This commit in...
mrkn (Kenta Murata)
09:08 AM Revision 24daf140 (git): * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64206 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
09:08 AM Revision f1506933 (git): enumerator.c: Introduce Enumerator::ArithmeticSequence
This commit introduces new core class Enumerator::ArithmeticSequence.
Enumerator::ArithmeticSequence is a subclass of...
Kenta Murata
08:42 AM Revision 1777e39c (git): test/ripper/test_parser_events.rb (test_block_variables): increase RLIMIT_AS
Unfortunately, MJIT goes over the 100M RLIMIT_AS for this test
on x86-64 (Debian 9)
git-svn-id: svn+ssh://ci.ruby-la...
Eric Wong
08:11 AM Bug #14969: Process.groups が返す GID が重複している場合がある
つまり、
・specを直すに賛成である
・ただ、API docで Process.groups.sort.uniq がふつうの使い方みたいに教えてあげるのが親切と思う
の2つが意見です
kosaki (Motohiro KOSAKI)
08:08 AM Bug #14969: Process.groups が返す GID が重複している場合がある
Process.groupsが
・結果が昇順にソートされている保証はない(OS依存)
・Effective gidが入っているかどうかはOS依存
・重複するIDはそのままarrayに入っていることもあれば、重複が取り除かれている...
kosaki (Motohiro KOSAKI)
08:03 AM Bug #14969: Process.groups が返す GID が重複している場合がある
Process.groupsはgetgroups(2)のラッパってことで、重複を省くなどの余計なことはしない、に一票です。
idコマンドの結果を期待値にしているspecの方にそもそも無理を感じます。なので、specの方をいじる、でよ...
mame (Yusuke Endoh)
07:53 AM Bug #14969 (Closed): Process.groups が返す GID が重複している場合がある
Ubuntu 16.04 から 18.04 にアップグレードした環境で以下の ruby spec が失敗することに気づきました。
```
1)
Process.groups gets an Array of the gids...
mrkn (Kenta Murata)
05:32 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
> > http://ci.rvm.jp/results/trunk@P895/1173951

> or I will have to revert and reintroduce timer-thread :<

r...
normalperson (Eric Wong)
04:52 AM Misc #14937: [PATCH] thread_pthread: lazy-spawn timer-thread only on contention
> http://ci.rvm.jp/results/trunk@P895/1173951

Damnit, this is because IO#gets on blocking pipes doesn't
hit rb...
normalperson (Eric Wong)
05:22 AM Revision 194a6a2c (git): thread_pthread.c: restore timer-thread for now :<
[ruby-core:88306]
Revert "process.c: ensure th->interrupt lock is held when migrating"
This reverts commit 5ca416bd...
Eric Wong
05:01 AM Revision 82815870 (git): Ignore native extension of Date library when syncing gemification files.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64202 b2dd03c8-39d4-4d8f-98ff-823fe69b080e hsbt (Hiroshi SHIBATA)
03:09 AM Feature #14967 (Open): Any type
In Scala, there's the concept of an Any type which can be used to match anything.
The implementation of which is q...
baweaver (Brandon Weaver)
01:06 AM Revision 5ca416bd (git): process.c: ensure th->interrupt lock is held when migrating
w->cond may be changed without our knowledge in waitpid_nogvl
without th->interrupt_lock
git-svn-id: svn+ssh://ci.ru...
Eric Wong

08/05/2018

11:37 PM Bug #14966 (Closed): 2.5 branch - Appveyor failures - backport missed line
A while ago, @hsbt committed r62990, and the following line was in `test\test_tmpdir.rb`:
```
TRAVERSAL_PATH.dele...
MSP-Greg (Greg L)
10:53 PM Feature #14869: Proposal to add Hash#===
I recently got permission to repurpose the `Any` gem, which gives us this:
```
require 'any'
case {id: 1, name...
baweaver (Brandon Weaver)
10:16 PM Bug #14964: [MJIT] missing builtin methods
Could you test configuring ARCH_FLAG instead of CFLAGS/CXXFLAGS? I'm not sure which variable should be used for -mtun... k0kubun (Takashi Kokubun)
03:57 PM Bug #14964: [MJIT] missing builtin methods
after some investigation, I found the problem is my build options
this builds successfully
```
rb_mjit_header_ok...
ahorek (Pavel Rosický)
02:00 PM Bug #14964: [MJIT] missing builtin methods
> Is it a known problem?
No, thanks to report.
> Maybe GCC isn't supported on Windows yet?
I intend to suppo...
k0kubun (Takashi Kokubun)
01:52 PM Bug #14964: [MJIT] missing builtin methods
I'm using MSYS1 that could be a problem, but I don't see any difference or a reason why it shouldn't work. You don't ... ahorek (Pavel Rosický)
01:13 PM Bug #14964: [MJIT] missing builtin methods
@ahorek
The most recent ruby-loco build (MinGW) passed all tests and had the following output when running test_ji...
MSP-Greg (Greg L)
12:32 PM Bug #14964: [MJIT] missing builtin methods
> [...] I can compile the lastest Ruby 2.5.1 with the same options.
> Maybe GCC isn't supported on Windows yet? [......
shevegen (Robert A. Heiler)
11:00 AM Bug #14964 (Closed): [MJIT] missing builtin methods
I'm having trouble building Ruby 2.6 on Windows.
this is the first error:
```
building rb_mjit_header.h
rb_mjit...
ahorek (Pavel Rosický)
09:27 PM Revision 217bdd77 (git): process.c (rb_waitpid): reduce sigwait_fd bouncing
Once a thread has acquired sigwait_fd, hold onto it until
waitpid is complete. This prevents unnecessary migration
a...
Eric Wong
08:06 PM Misc #14962 (Closed): [PATCH] thread_pthread: stop trying to deal with cancellation
Applied in changeset trunk|r64197.
----------
thread_pthread: stop trying to deal with cancellation
We don't use pt...
normalperson (Eric Wong)
08:06 PM Revision 9f395f11 (git): test/ruby/test_thread.rb (test_thread_timer_and_interrupt): add timeouts
Trying to diagnose CI failures from i686-linux on Debian 7.
This also fixes a potential GC problem with Thread.start...
Eric Wong
08:06 PM Revision d17c7ba3 (git): * 2018-08-06
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64198 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
08:06 PM Revision 2ba640f3 (git): thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painful to
use correctly. Any cancelled threads would break
vm...
Eric Wong
06:25 PM Bug #14965 (Third Party's Issue): Segmentation fault at 0x0000000000000000
I had installed rabbit (`$ gem install rabbit`) and created this file
```Markdown
# NES
```
I then run `$...
brunjact (Bruno Jacquet)
05:40 PM Bug #13167: Dir.glob is 25x slower since Ruby 2.2
@h.shirosaki, thanks for your work on this. I tested your patch 0001-dir.c-performance-fix-with-braces.patch (ruby he... ahorek (Pavel Rosický)
02:33 PM Revision e09c14a0 (git): mjit.c: use -Tc flag explicitly
This option makes sure that the argument is C source file.
Probably this is not needed, but since I'm debugging it, I...
k0kubun (Takashi Kokubun)
11:00 AM Bug #14350: Strange behavior for Array.min in ruby 2.5.0
ruby_2_5 r64195 merged revision(s) 61766. nagachika (Tomoyuki Chikanaga)
10:59 AM Revision 61cb2958 (git): merge revision(s) 61766: [Backport #14350]
vm_insnhelper.c: search in the indexing order
* vm_insnhelper.c (vm_opt_newarray_max, vm_opt_newarray_min):
...
nagachika (Tomoyuki Chikanaga)
08:56 AM Revision 14d13bc1 (git): test/ruby/test_process.rb (test_wait_and_sigchld): allow extra SIGCHLD
MJIT way generate an extra SIGCHLD, so we'll have to deal with it.
Any realistic Ruby program may hit unexpected SIG...
Eric Wong
08:56 AM Revision b3aa256c (git): thread_pthread.c (native_sleep): reduce ppoll sleeps
By holding into sigwait_fd until after we acquire GVL, we can
hit the faster native_cond_sleep path instead of ppoll ...
Eric Wong
06:30 AM Misc #14921: DevelopersMeeting20180809Japan
I am in Narita and I will try to come to the meeting. The only reason why I won't make it is because I get lost on th... ioquatix (Samuel Williams)
05:34 AM Revision 88975c82 (git): mjit.c: link precompiled object
This is needed to resolve:
"error LNK2011: precompiled object not linked in; image may not run"
win32/Makefile.sub: ...
k0kubun (Takashi Kokubun)
04:48 AM Revision d3e90363 (git): mjit.c: reorder functions to reduce #ifdef branches
Just moved make_pch into `#else` of `#ifdef _MSC_VER`.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64191 b2dd0...
k0kubun (Takashi Kokubun)
04:37 AM Revision d7786b1e (git): mjit.c: include prebuilt precompiled header
on mswin properly.
Deleted code to attempt make_pch for mswin, since it won't be needed.
git-svn-id: svn+ssh://ci.r...
k0kubun (Takashi Kokubun)
03:12 AM Revision 5f13fe31 (git): mjit.c: initialize prebuilt precompiled header
file name correctly. This allows to use the header installed by r64188.
win32/Makefile.sub: define prebuilt precompi...
k0kubun (Takashi Kokubun)

08/04/2018

11:53 PM Revision cdf72ddc (git): win32/Makefile.sub: build precompiled header
See the comment in win32/Makefile.sub.
Not only .pch, but also .obj needs to be installed and used on runtime.
.giti...
k0kubun (Takashi Kokubun)
11:33 PM Revision ff1e6657 (git): test/ruby/test_io.rb (test_select_leak): speedup and reduce memory use
We can reuse the sub-thread and exception with Thread#raise to
reproduce the old memory leak with less overhead. Thi...
Eric Wong
10:58 PM Revision 80e973f0 (git): test/ruby/test_thread.rb (test_thread_interrupt_for_killed_thread): conserve resources
Use Thread.pass to let the sub-thread finish. This should avoid
running out of memory on resource-constrained system...
Eric Wong
08:38 PM Revision 291a82f7 (git): thread.c (consume_communication_pipe): do not retry after short read
Saves a syscall and slightly improves vm_thread_condvar1
benchmark slightly (more improvements on the way):
...
Eric Wong
08:34 PM Revision 3dbd8d1f (git): test/ruby/test_io.rb (test_race_gets_and_close): timeout each thread
Still looking into CI failures on P895 (and seemingly no other boxes):
http://ci.rvm.jp/results/trunk@P895/119036...
Eric Wong
04:22 PM Feature #14916: Proposal to add Array#===
I recently got permission to repurpose the `Any` gem, which gives us this:
```
require 'any'
case ['Foo', 25]
...
baweaver (Brandon Weaver)
03:55 PM Feature #14869: Proposal to add Hash#===
I would agree with `===` being more useful than `<=`, as `case`, `all?`, `grep`, and other methods use it implicitly.... baweaver (Brandon Weaver)
03:12 PM Revision 32d6becb (git): * 2018-08-05
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64183 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:12 PM Revision be38f53b (git): common.mk: stop building MJIT min header for mswin
Since it's impossible to leave macro when preprocessing C source file
with cl.exe, I decided to create precompiled he...
k0kubun (Takashi Kokubun)

08/03/2018

09:53 PM Revision 81f1285b (git): spec/ruby/library/socket/socket/getaddrinfo_spec.rb: avoid nonsensical lookup
"http" is a TCP service, so /etc/services on typical GNU/Linux systems
only specify a TCP port for it. Use "discard"...
Eric Wong
04:19 PM Revision b53cf149 (git): Update to ruby/spec@9be7c7e
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64180 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
04:19 PM Revision aeeaadaa (git): Update to ruby/mspec@072849e
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64179 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
03:11 PM Revision a2c7d0ce (git): encoding.c (rb_enc_get_index): return -1 for non-encoding capable objects
* Clarify logic and add spec.
* Now passes test-all with the JSON fix.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/t...
Eregon (Benoit Daloze)
03:11 PM Revision e7da0fc3 (git): ext/json/parser/parser.c: do not call rb_str_resize() on Time object
* See https://github.com/flori/json/issues/342
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64177 b2dd03c8-39d4...
Eregon (Benoit Daloze)
03:11 PM Revision 27f34274 (git): * 2018-08-04
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64176 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:11 PM Revision bf226a9a (git): Fix missed update of parser source in r62429
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64175 b2dd03c8-39d4-4d8f-98ff-823fe69b080e Eregon (Benoit Daloze)
02:49 PM Bug #14963 (Closed): Since r64107, on Solaris, spec test of rb_io_wait_readable hangs up
Since r64107 (removal of timer thread), on Solaris (both on Solaris 10 and Solaris 11, both on x86 and sparc),
`make...
ngoto (Naohisa Goto)
02:31 PM Revision bd58361e (git): Revert "encoding.c (rb_enc_get_index): return -1 for non-encoding capable objects"
* This reverts commit fb253d2032e51f333e6577aa4fcf0c03f9c6fc02.
* The CI is failing, this seems a bug in the JSON C e...
Eregon (Benoit Daloze)
01:52 PM Revision fb253d20 (git): encoding.c (rb_enc_get_index): return -1 for non-encoding capable objects
* Clarify logic and add spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64173 b2dd03c8-39d4-4d8f-98ff-823fe6...
Eregon (Benoit Daloze)
01:52 PM Revision 080d700e (git): encoding.c (enc_set_index): raise instead of rb_bug() for non-encoding capable objects
* Add spec.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64172 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Eregon (Benoit Daloze)
11:13 AM Revision a3549926 (git): random.c: fix fallback value
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64171 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
10:52 AM Feature #14473: Add Range#subrange?
Great, thank you tarui owst (Owen Stephens)
03:04 AM Feature #14473: Add Range#subrange?
I am happy that match opinion with you.

I will commit based on your patch. It'll take a little while.
tarui (Masaya Tarui)
08:42 AM Bug #14961: Segfault when running RSpec / Capybara / Rails
[email protected] wrote:
> https://bugs.ruby-lang.org/issues/14961

queue_sleep. Is that combined with f...
normalperson (Eric Wong)
07:32 AM Bug #14961 (Feedback): Segfault when running RSpec / Capybara / Rails
No clue other than that it crashed in this thread.
```
Thread 5 Crashed:: server.rb:286
0 libsystem_kernel.dyl...
nobu (Nobuyoshi Nakada)
07:39 AM Bug #14959 (Closed): Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
nobu (Nobuyoshi Nakada)
07:38 AM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
Thank you, @rafaelfranca.
It a fixed bug in the trunk, but doesn't seem backported to 2.5 yet.
nobu (Nobuyoshi Nakada)
01:21 AM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
also see: https://bugs.ruby-lang.org/issues/14894 probably the same issue. sam.saffron (Sam Saffron)
07:25 AM Misc #14962 (Closed): [PATCH] thread_pthread: stop trying to deal with cancellation
thread_pthread: stop trying to deal with cancellation
We don't use pthreads cancellation ourselves and it's painfu...
normalperson (Eric Wong)
07:24 AM Revision 1f71ea2f (git): random.c: use rb_check_funcall
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64170 b2dd03c8-39d4-4d8f-98ff-823fe69b080e nobu (Nobuyoshi Nakada)
07:17 AM Revision 4b4d364e (git): random.c: moved domain error
* random.c (rand_range): moved call of domain_error(), not to
raise an exception in range_values().
git-svn-id: sv...
nobu (Nobuyoshi Nakada)
06:53 AM Revision 002f6ea8 (git): ast.c: allocator of Node
* ast.c (Init_ast): undefine allocator of Node, as a method call
on an uninitialized Node causes segfault.
git-svn...
nobu (Nobuyoshi Nakada)
06:32 AM Bug #14958 (Closed): rand(endless_range) raises TypeError (no implicit conversion of Range into Integer)
Applied in changeset trunk|r64167.
----------
random.c: endless range random
* random.c (range_values): cannot dete...
nobu (Nobuyoshi Nakada)
06:31 AM Revision 64712906 (git): random.c: endless range random
* random.c (range_values): cannot determine the domain of an endless
range. [ruby-core:88261] [Bug #14958]
git-sv...
nobu (Nobuyoshi Nakada)
05:11 AM Revision 4cef2c8d (git): thread_pthread.c: add a macro guard for PTHREAD_CANCEL_ENABLE
It seems to be unavailable on some platforms including my Android phone.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby...
mame (Yusuke Endoh)
12:25 AM Bug #14957: MinGW, gcc 8.2.0, bootstraptest test_thread.rb - failure ?
Done some more investigating. The following code I've run four ways.
Using two versions of ruby 2.6.0dev (2018-08...
MSP-Greg (Greg L)

08/02/2018

10:11 PM Bug #14961 (Closed): Segfault when running RSpec / Capybara / Rails
After upgrading to 2.5.1, we consistently see a segfault when running RSpec + Capybara against a Rails application. robear (Robert Wiegmann)
09:32 PM Bug #14898: test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
http://ci.rvm.jp/results/trunk_clang_38@silicon-docker/1185552
:<

> [email protected] wrote:
> > http://ci.rvm.jp/r...
normalperson (Eric Wong)
06:13 AM Bug #14898: test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
[email protected] wrote:
> http://ci.rvm.jp/results/trunk-test@frontier/1153126

Oh, different test, that is test_tim...
normalperson (Eric Wong)
06:10 AM Bug #14898 (Closed): test/lib/test/unit/parallel.rb: TestSocket#test_timestamp stuck sometimes
Applied in changeset trunk|r64157.
----------
test/socket/test_socket.rb (test_timestampns): retry send
It looks li...
normalperson (Eric Wong)
09:13 PM Revision 8c2ae6e3 (git): thread_pthread.c (gvl_acquire_common): persist timeout across calls
Reuse old expiration time if the previous native_cond_timedwait
did not return ETIMEDOUT. This should improve timesl...
Eric Wong
07:46 PM Bug #14959: Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
Minimal reproduction steps.
~~~ruby
code = <<~CODE
module ApplicationHelper
def broken_helper_in_application_...
rafaelfranca (Rafael França)
07:00 PM Bug #14959 (Closed): Writing a "link_to" method and a "url_helper" with a request parameter under certain "if else" statement in Rails helper crashes with KERN_INVALID_ADDRESS at 0x0000000000000000
# Disclaimer
Sorry about the problem being rails, and not ruby specific. I couldn't narrow down the problem and wor...
y4m4p (Masahiro Yamashita)
07:38 PM Bug #14960 (Closed): Segmentation fault
rbenv/versions/2.5.1/lib/ruby/gems/2.5.0/gems/bootsnap-1.3.0/lib/bootsnap/compile_cache/iseq.rb:12: [BUG] Segmentatio... damir (Damir Roso)
04:13 PM Bug #11370 (Closed): Use slightly less strict test for heap_eden_pages
Closing this as it doesn't seem to be an issue in recent Ruby/OpenBSD versions. jeremyevans0 (Jeremy Evans)
03:50 PM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
I changed the failing test from test_unload_units to test_compile_insn_putspecialobject_putiseq in r64163 because unl... k0kubun (Takashi Kokubun)
03:17 PM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
Yeah, the status is intentional. I checked many things for linking `rb_mRubyVMFrozenCore` properly but still no luck.... k0kubun (Takashi Kokubun)
02:57 PM Bug #14948: MinGW Failure - r64072 - test_jit.rb: test_compile_insn_putspecialobject_putiseq
@k0kubun
Re above message, after r64161, JIT tests are working again. I tried test_unload_units, and that is stil...
MSP-Greg (Greg L)
03:35 PM Revision 0a03394b (git): * 2018-08-03
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64164 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
03:35 PM Revision ef3abac0 (git): test_jit.rb: split the test concern
Actually unload_units is working on MinGW, but putiseq is behaving
badly.
git-svn-id: svn+ssh://ci.ruby-lang.org/rub...
k0kubun (Takashi Kokubun)
02:40 PM Revision d4381d2c (git): mjit.c: skip compaction on MinGW
because linking multiple .o files is problematic without having `static`
to the same function definitions.
git-svn-i...
k0kubun (Takashi Kokubun)
01:41 PM Revision 2aea3ded (git): mjit.c: don't apply workaround if --enable-load-relative
is specified.
This is needed for MinGW because MJIT_BUILD_DIR doesn't prefix path
like "C:\msys64", so it can't be r...
k0kubun (Takashi Kokubun)
01:03 PM Revision 57369c1c (git): mjit.c: suppress warnings by -Wunused-value
on MinGW with __atomic_exchange_n(). It returns the previous pointer value but
obviously it's not needed in MJIT's us...
k0kubun (Takashi Kokubun)
11:39 AM Revision 6a9b63e3 (git): thread_win32.c: suppress warnings by -Wsuggest-attribute
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64159 b2dd03c8-39d4-4d8f-98ff-823fe69b080e k0kubun (Takashi Kokubun)
07:16 AM Feature #14951: New operator to evaluate truthy/falsy/logical equivalence
After getting the feedback here, I no longer support my original proposal. But I would be happy if something like `Ob... danga (Dan Garubba)
06:09 AM Revision 6f7b3de1 (git): * 2018-08-02
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64158 b2dd03c8-39d4-4d8f-98ff-823fe69b080e svn[bot]
06:09 AM Revision 12f11714 (git): test/socket/test_socket.rb (test_timestampns): retry send
It looks like we need to retry test_timestampns in addition
to test_timestamp; so share some code while we're at it.
...
Eric Wong
12:04 AM Feature #14718: Use jemalloc by default?
Wow awesome news @normalperson this is going to make a massive difference with Ruby 2.6! sam.saffron (Sam Saffron)
 

Also available in: Atom