Google Git
Sign in
chromium / chromium / src / c70aec1f608aadaa811472adc93460316b60a81d
commitc70aec1f608aadaa811472adc93460316b60a81d[log] [tgz]
authordanakj <[email protected]>Thu Jul 07 15:48:19 2022
committerChromium LUCI CQ <[email protected]>Thu Jul 07 15:48:19 2022
tree3883d0d629f3ca77a8b31d361507636517698d21
parent7fc7b1beb91d1c5dbb6b017e02553d898d504e83 [diff]
Replace raw_ptr with raw_ref in DocumentService

This also changes the subclasses of DocumentService to work with
references to RenderFrameHost, since DocumentService no longer vends
a pointer.

While doing so, any public constructor or destructor in a
DocumentService subclass was made private. CreateForTesting() was
added where needed.

CHECK() is added if not present (or converted from DCHECK()) when
turning RenderFrameHost* into RenderFrameHost&.

There are, of course, more pointers that could become references, but
this CL has to stop somewhere.

[email protected]

Bug: 1339061, 1252046
Change-Id: I00033bcbabd9c4d268b0f5745b12031928dbf914
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3721411
Owners-Override: Alexander Timin <[email protected]>
Reviewed-by: Daniel Cheng <[email protected]>
Reviewed-by: Alexander Timin <[email protected]>
Commit-Queue: Alexander Timin <[email protected]>
Auto-Submit: danakj <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1021695}
115 files changed
tree: 3883d0d629f3ca77a8b31d361507636517698d21
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.