sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1 | // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 5 | #include <memory> |
dcheng | 51ace48a | 2015-12-26 22:45:17 | [diff] [blame] | 6 | #include <utility> |
| 7 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 8 | #include "base/bind.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 9 | #include "base/files/file_path.h" |
| 10 | #include "base/files/file_util.h" |
| 11 | #include "base/location.h" |
avi | 5dd91f8 | 2015-12-25 22:30:46 | [diff] [blame] | 12 | #include "base/macros.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 13 | #include "base/memory/ref_counted.h" |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 14 | #include "base/optional.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 15 | #include "base/path_service.h" |
| 16 | #include "base/run_loop.h" |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 17 | #include "base/stl_util.h" |
fdoray | 03349c1 | 2017-05-17 18:06:51 | [diff] [blame] | 18 | #include "base/task_scheduler/post_task.h" |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 19 | #include "base/task_scheduler/task_traits.h" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 20 | #include "base/test/scoped_path_override.h" |
fdoray | 03349c1 | 2017-05-17 18:06:51 | [diff] [blame] | 21 | #include "base/test/scoped_task_environment.h" |
gab | 7966d31 | 2016-05-11 20:35:01 | [diff] [blame] | 22 | #include "base/threading/thread_task_runner_handle.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 23 | #include "base/values.h" |
| 24 | #include "base/version.h" |
Sorin Jianu | 18890707 | 2018-01-22 18:42:22 | [diff] [blame] | 25 | #include "build/build_config.h" |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 26 | #include "components/prefs/testing_pref_service.h" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 27 | #include "components/update_client/component_unpacker.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 28 | #include "components/update_client/crx_update_item.h" |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 29 | #include "components/update_client/persisted_data.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 30 | #include "components/update_client/ping_manager.h" |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 31 | #include "components/update_client/protocol_parser.h" |
sorin | b120440b | 2015-04-27 16:34:15 | [diff] [blame] | 32 | #include "components/update_client/test_configurator.h" |
| 33 | #include "components/update_client/test_installer.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 34 | #include "components/update_client/update_checker.h" |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 35 | #include "components/update_client/update_client_errors.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 36 | #include "components/update_client/update_client_internal.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 37 | #include "testing/gmock/include/gmock/gmock.h" |
| 38 | #include "testing/gtest/include/gtest/gtest.h" |
| 39 | #include "url/gurl.h" |
| 40 | |
| 41 | namespace update_client { |
| 42 | |
| 43 | namespace { |
| 44 | |
| 45 | using base::FilePath; |
| 46 | |
| 47 | // Makes a copy of the file specified by |from_path| in a temporary directory |
| 48 | // and returns the path of the copy. Returns true if successful. Cleans up if |
| 49 | // there was an error creating the copy. |
| 50 | bool MakeTestFile(const FilePath& from_path, FilePath* to_path) { |
| 51 | FilePath temp_dir; |
| 52 | bool result = |
| 53 | CreateNewTempDirectory(FILE_PATH_LITERAL("update_client"), &temp_dir); |
| 54 | if (!result) |
| 55 | return false; |
| 56 | |
| 57 | FilePath temp_file; |
| 58 | result = CreateTemporaryFileInDir(temp_dir, &temp_file); |
| 59 | if (!result) |
| 60 | return false; |
| 61 | |
| 62 | result = CopyFile(from_path, temp_file); |
| 63 | if (!result) { |
| 64 | DeleteFile(temp_file, false); |
| 65 | return false; |
| 66 | } |
| 67 | |
| 68 | *to_path = temp_file; |
| 69 | return true; |
| 70 | } |
| 71 | |
| 72 | using Events = UpdateClient::Observer::Events; |
| 73 | |
| 74 | class MockObserver : public UpdateClient::Observer { |
| 75 | public: |
| 76 | MOCK_METHOD2(OnEvent, void(Events event, const std::string&)); |
| 77 | }; |
| 78 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 79 | } // namespace |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 80 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 81 | using ::testing::_; |
| 82 | using ::testing::AtLeast; |
| 83 | using ::testing::AnyNumber; |
| 84 | using ::testing::DoAll; |
| 85 | using ::testing::InSequence; |
| 86 | using ::testing::Invoke; |
| 87 | using ::testing::Mock; |
| 88 | using ::testing::Return; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 89 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 90 | using std::string; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 91 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 92 | class MockPingManagerImpl : public PingManager { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 93 | public: |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 94 | struct PingData { |
| 95 | std::string id; |
| 96 | base::Version previous_version; |
| 97 | base::Version next_version; |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 98 | ErrorCategory error_category = ErrorCategory::kNone; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 99 | int error_code = 0; |
| 100 | int extra_code1 = 0; |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 101 | ErrorCategory diff_error_category = ErrorCategory::kNone; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 102 | int diff_error_code = 0; |
| 103 | bool diff_update_failed = false; |
| 104 | }; |
| 105 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 106 | explicit MockPingManagerImpl(scoped_refptr<Configurator> config); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 107 | |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 108 | void SendPing(const Component& component, Callback callback) override; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 109 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 110 | const std::vector<PingData>& ping_data() const; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 111 | |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 112 | const std::vector<std::string>& events() const; |
| 113 | |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 114 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 115 | ~MockPingManagerImpl() override; |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 116 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 117 | private: |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 118 | std::vector<PingData> ping_data_; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 119 | std::vector<std::string> events_; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 120 | DISALLOW_COPY_AND_ASSIGN(MockPingManagerImpl); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 121 | }; |
| 122 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 123 | MockPingManagerImpl::MockPingManagerImpl(scoped_refptr<Configurator> config) |
sorin | 958b5d3 | 2016-01-09 02:00:20 | [diff] [blame] | 124 | : PingManager(config) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 125 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 126 | MockPingManagerImpl::~MockPingManagerImpl() {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 127 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 128 | void MockPingManagerImpl::SendPing(const Component& component, |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 129 | Callback callback) { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 130 | PingData ping_data; |
| 131 | ping_data.id = component.id_; |
| 132 | ping_data.previous_version = component.previous_version_; |
| 133 | ping_data.next_version = component.next_version_; |
| 134 | ping_data.error_category = component.error_category_; |
| 135 | ping_data.error_code = component.error_code_; |
| 136 | ping_data.extra_code1 = component.extra_code1_; |
| 137 | ping_data.diff_error_category = component.diff_error_category_; |
| 138 | ping_data.diff_error_code = component.diff_error_code_; |
| 139 | ping_data.diff_update_failed = component.diff_update_failed(); |
| 140 | ping_data_.push_back(ping_data); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 141 | |
| 142 | const auto& events = component.events(); |
| 143 | events_.insert(events_.end(), events.begin(), events.end()); |
| 144 | |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 145 | std::move(callback).Run(0, ""); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 146 | } |
| 147 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 148 | const std::vector<MockPingManagerImpl::PingData>& |
| 149 | MockPingManagerImpl::ping_data() const { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 150 | return ping_data_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 151 | } |
| 152 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 153 | const std::vector<std::string>& MockPingManagerImpl::events() const { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 154 | return events_; |
| 155 | } |
| 156 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 157 | class UpdateClientTest : public testing::Test { |
| 158 | public: |
| 159 | UpdateClientTest(); |
| 160 | ~UpdateClientTest() override; |
| 161 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 162 | protected: |
| 163 | void RunThreads(); |
| 164 | |
| 165 | // Returns the full path to a test file. |
| 166 | static base::FilePath TestFilePath(const char* file); |
| 167 | |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 168 | scoped_refptr<update_client::TestConfigurator> config() { return config_; } |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 169 | update_client::PersistedData* metadata() { return metadata_.get(); } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 170 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 171 | base::OnceClosure quit_closure() { return runloop_.QuitClosure(); } |
sorin | f9f4834d | 2015-04-28 17:15:02 | [diff] [blame] | 172 | |
| 173 | private: |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 174 | static constexpr int kNumWorkerThreads_ = 2; |
sorin | f9f4834d | 2015-04-28 17:15:02 | [diff] [blame] | 175 | |
fdoray | 03349c1 | 2017-05-17 18:06:51 | [diff] [blame] | 176 | base::test::ScopedTaskEnvironment scoped_task_environment_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 177 | base::RunLoop runloop_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 178 | |
Sorin Jianu | cc048f89 | 2017-07-26 02:05:54 | [diff] [blame] | 179 | scoped_refptr<update_client::TestConfigurator> config_ = |
| 180 | base::MakeRefCounted<TestConfigurator>(); |
| 181 | std::unique_ptr<TestingPrefServiceSimple> pref_ = |
Jinho Bang | da4e428 | 2018-01-03 13:21:23 | [diff] [blame] | 182 | std::make_unique<TestingPrefServiceSimple>(); |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 183 | std::unique_ptr<update_client::PersistedData> metadata_; |
sorin | f9f4834d | 2015-04-28 17:15:02 | [diff] [blame] | 184 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 185 | DISALLOW_COPY_AND_ASSIGN(UpdateClientTest); |
| 186 | }; |
| 187 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 188 | constexpr int UpdateClientTest::kNumWorkerThreads_; |
| 189 | |
Sorin Jianu | cc048f89 | 2017-07-26 02:05:54 | [diff] [blame] | 190 | UpdateClientTest::UpdateClientTest() { |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 191 | PersistedData::RegisterPrefs(pref_->registry()); |
Jinho Bang | da4e428 | 2018-01-03 13:21:23 | [diff] [blame] | 192 | metadata_ = std::make_unique<PersistedData>(pref_.get(), nullptr); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 193 | } |
| 194 | |
| 195 | UpdateClientTest::~UpdateClientTest() { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 196 | } |
| 197 | |
| 198 | void UpdateClientTest::RunThreads() { |
| 199 | runloop_.Run(); |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 200 | scoped_task_environment_.RunUntilIdle(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 201 | } |
| 202 | |
| 203 | base::FilePath UpdateClientTest::TestFilePath(const char* file) { |
| 204 | base::FilePath path; |
Avi Drissman | f617d01 | 2018-05-02 18:48:53 | [diff] [blame] | 205 | base::PathService::Get(base::DIR_SOURCE_ROOT, &path); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 206 | return path.AppendASCII("components") |
| 207 | .AppendASCII("test") |
| 208 | .AppendASCII("data") |
| 209 | .AppendASCII("update_client") |
| 210 | .AppendASCII(file); |
| 211 | } |
| 212 | |
| 213 | // Tests the scenario where one update check is done for one CRX. The CRX |
| 214 | // has no update. |
| 215 | TEST_F(UpdateClientTest, OneCrxNoUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 216 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 217 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 218 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 219 | const std::vector<std::string>& ids) { |
| 220 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 221 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 222 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 223 | crx->version = base::Version("0.9"); |
| 224 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 225 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 226 | component.push_back(std::move(crx)); |
| 227 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 228 | } |
| 229 | }; |
| 230 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 231 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 232 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 233 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 234 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 235 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 236 | } |
| 237 | }; |
| 238 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 239 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 240 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 241 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 242 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 243 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 244 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 245 | } |
| 246 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 247 | void CheckForUpdates(const std::string& session_id, |
| 248 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 249 | const IdToComponentPtrMap& components, |
| 250 | const std::string& additional_attributes, |
| 251 | bool enabled_component_updates, |
| 252 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 253 | EXPECT_FALSE(session_id.empty()); |
sorin | 590921d | 2016-08-11 23:48:36 | [diff] [blame] | 254 | EXPECT_TRUE(enabled_component_updates); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 255 | EXPECT_EQ(1u, ids_to_check.size()); |
| 256 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 257 | EXPECT_EQ(id, ids_to_check.front()); |
| 258 | EXPECT_EQ(1u, components.count(id)); |
| 259 | |
| 260 | auto& component = components.at(id); |
| 261 | |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 262 | EXPECT_TRUE(component->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 263 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 264 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 265 | result.extension_id = id; |
| 266 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 267 | |
| 268 | ProtocolParser::Results results; |
| 269 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 270 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 271 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 272 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 273 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 274 | } |
| 275 | }; |
| 276 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 277 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 278 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 279 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 280 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 281 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 282 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 283 | } |
| 284 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 285 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 286 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 287 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 288 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 289 | }; |
| 290 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 291 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 292 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 293 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 294 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 295 | |
| 296 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 297 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 298 | }; |
| 299 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 300 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 301 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 302 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 303 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 304 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 305 | MockObserver observer; |
| 306 | InSequence seq; |
| 307 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 308 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 309 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 310 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 311 | |
| 312 | update_client->AddObserver(&observer); |
| 313 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 314 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 315 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 316 | ids, base::BindOnce(&DataCallbackMock::Callback), true, |
| 317 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 318 | |
| 319 | RunThreads(); |
| 320 | |
| 321 | update_client->RemoveObserver(&observer); |
| 322 | } |
| 323 | |
| 324 | // Tests the scenario where two CRXs are checked for updates. On CRX has |
| 325 | // an update, the other CRX does not. |
| 326 | TEST_F(UpdateClientTest, TwoCrxUpdateNoUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 327 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 328 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 329 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 330 | const std::vector<std::string>& ids) { |
| 331 | std::unique_ptr<CrxComponent> crx1 = std::make_unique<CrxComponent>(); |
| 332 | crx1->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 333 | crx1->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 334 | crx1->version = base::Version("0.9"); |
| 335 | crx1->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 336 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 337 | std::unique_ptr<CrxComponent> crx2 = std::make_unique<CrxComponent>(); |
| 338 | crx2->name = "test_abag"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 339 | crx2->pk_hash.assign(abag_hash, abag_hash + base::size(abag_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 340 | crx2->version = base::Version("2.2"); |
| 341 | crx2->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 342 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 343 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 344 | component.push_back(std::move(crx1)); |
| 345 | component.push_back(std::move(crx2)); |
| 346 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 347 | } |
| 348 | }; |
| 349 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 350 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 351 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 352 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 353 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 354 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 355 | } |
| 356 | }; |
| 357 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 358 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 359 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 360 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 361 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 362 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 363 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 364 | } |
| 365 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 366 | void CheckForUpdates(const std::string& session_id, |
| 367 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 368 | const IdToComponentPtrMap& components, |
| 369 | const std::string& additional_attributes, |
| 370 | bool enabled_component_updates, |
| 371 | UpdateCheckCallback update_check_callback) override { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 372 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 373 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 374 | |
| 375 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 376 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 377 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 378 | <updatecheck status='ok'> |
| 379 | <urls> |
| 380 | <url codebase='http://localhost/download/'/> |
| 381 | </urls> |
| 382 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 383 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 384 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 385 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 386 | 7c9b12cb7cc067667bde87'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 387 | </packages> |
| 388 | </manifest> |
| 389 | </updatecheck> |
| 390 | </app> |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 391 | <app appid='abagagagagagagagagagagagagagagag'> |
| 392 | <updatecheck status='noupdate'/> |
| 393 | </app> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 394 | </response> |
| 395 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 396 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 397 | EXPECT_TRUE(enabled_component_updates); |
| 398 | EXPECT_EQ(2u, ids_to_check.size()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 399 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 400 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 401 | { |
| 402 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 403 | EXPECT_EQ(id, ids_to_check[0]); |
| 404 | EXPECT_EQ(1u, components.count(id)); |
| 405 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 406 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 407 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 408 | package.hash_sha256 = |
| 409 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
| 410 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 411 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 412 | result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 413 | result.status = "ok"; |
| 414 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 415 | result.manifest.version = "1.0"; |
| 416 | result.manifest.browser_min_version = "11.0.1.0"; |
| 417 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 418 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 419 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 420 | EXPECT_FALSE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 421 | } |
| 422 | |
| 423 | { |
| 424 | const std::string id = "abagagagagagagagagagagagagagagag"; |
| 425 | EXPECT_EQ(id, ids_to_check[1]); |
| 426 | EXPECT_EQ(1u, components.count(id)); |
| 427 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 428 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 429 | result.extension_id = id; |
| 430 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 431 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 432 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 433 | EXPECT_FALSE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 434 | } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 435 | |
| 436 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 437 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 438 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 439 | } |
| 440 | }; |
| 441 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 442 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 443 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 444 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 445 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 446 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 447 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 448 | } |
| 449 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 450 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 451 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 452 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 453 | void DoStartDownload(const GURL& url) override { |
| 454 | DownloadMetrics download_metrics; |
| 455 | download_metrics.url = url; |
| 456 | download_metrics.downloader = DownloadMetrics::kNone; |
| 457 | download_metrics.error = 0; |
| 458 | download_metrics.downloaded_bytes = 1843; |
| 459 | download_metrics.total_bytes = 1843; |
| 460 | download_metrics.download_time_ms = 1000; |
| 461 | |
| 462 | FilePath path; |
| 463 | EXPECT_TRUE(MakeTestFile( |
| 464 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 465 | |
| 466 | Result result; |
| 467 | result.error = 0; |
| 468 | result.response = path; |
| 469 | result.downloaded_bytes = 1843; |
| 470 | result.total_bytes = 1843; |
| 471 | |
| 472 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 473 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 474 | base::Unretained(this), result)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 475 | |
| 476 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 477 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 478 | base::Unretained(this), true, result, |
| 479 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 480 | } |
| 481 | }; |
| 482 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 483 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 484 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 485 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 486 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 487 | |
| 488 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 489 | ~MockPingManager() override { |
| 490 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 491 | EXPECT_EQ(1u, ping_data.size()); |
| 492 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 493 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 494 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 495 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 496 | EXPECT_EQ(0, ping_data[0].error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 497 | } |
| 498 | }; |
| 499 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 500 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 501 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 502 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 503 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 504 | |
| 505 | MockObserver observer; |
| 506 | { |
| 507 | InSequence seq; |
| 508 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 509 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 510 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 511 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 512 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 513 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 514 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 515 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 516 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 517 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 518 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 519 | } |
| 520 | { |
| 521 | InSequence seq; |
| 522 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 523 | "abagagagagagagagagagagagagagagag")).Times(1); |
| 524 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 525 | "abagagagagagagagagagagagagagagag")).Times(1); |
| 526 | } |
| 527 | |
| 528 | update_client->AddObserver(&observer); |
| 529 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 530 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 531 | "abagagagagagagagagagagagagagagag"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 532 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 533 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 534 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 535 | |
| 536 | RunThreads(); |
| 537 | |
| 538 | update_client->RemoveObserver(&observer); |
| 539 | } |
| 540 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 541 | // Tests the scenario where two CRXs are checked for updates. One CRX has |
| 542 | // an update but the server ignores the second CRX and returns no response for |
| 543 | // it. The second component gets an |UPDATE_RESPONSE_NOT_FOUND| error and |
| 544 | // transitions to the error state. |
| 545 | TEST_F(UpdateClientTest, TwoCrxUpdateFirstServerIgnoresSecond) { |
| 546 | class DataCallbackMock { |
| 547 | public: |
| 548 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 549 | const std::vector<std::string>& ids) { |
| 550 | std::unique_ptr<CrxComponent> crx1 = std::make_unique<CrxComponent>(); |
| 551 | crx1->name = "test_jebg"; |
| 552 | crx1->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 553 | crx1->version = base::Version("0.9"); |
| 554 | crx1->installer = base::MakeRefCounted<TestInstaller>(); |
| 555 | |
| 556 | std::unique_ptr<CrxComponent> crx2 = std::make_unique<CrxComponent>(); |
| 557 | crx2->name = "test_abag"; |
| 558 | crx2->pk_hash.assign(abag_hash, abag_hash + base::size(abag_hash)); |
| 559 | crx2->version = base::Version("2.2"); |
| 560 | crx2->installer = base::MakeRefCounted<TestInstaller>(); |
| 561 | |
| 562 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 563 | component.push_back(std::move(crx1)); |
| 564 | component.push_back(std::move(crx2)); |
| 565 | return component; |
| 566 | } |
| 567 | }; |
| 568 | |
| 569 | class CompletionCallbackMock { |
| 570 | public: |
| 571 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 572 | EXPECT_EQ(Error::NONE, error); |
| 573 | std::move(quit_closure).Run(); |
| 574 | } |
| 575 | }; |
| 576 | |
| 577 | class MockUpdateChecker : public UpdateChecker { |
| 578 | public: |
| 579 | static std::unique_ptr<UpdateChecker> Create( |
| 580 | scoped_refptr<Configurator> config, |
| 581 | PersistedData* metadata) { |
| 582 | return std::make_unique<MockUpdateChecker>(); |
| 583 | } |
| 584 | |
| 585 | void CheckForUpdates(const std::string& session_id, |
| 586 | const std::vector<std::string>& ids_to_check, |
| 587 | const IdToComponentPtrMap& components, |
| 588 | const std::string& additional_attributes, |
| 589 | bool enabled_component_updates, |
| 590 | UpdateCheckCallback update_check_callback) override { |
| 591 | /* |
| 592 | Mock the following response: |
| 593 | |
| 594 | <?xml version='1.0' encoding='UTF-8'?> |
| 595 | <response protocol='3.1'> |
| 596 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 597 | <updatecheck status='ok'> |
| 598 | <urls> |
| 599 | <url codebase='http://localhost/download/'/> |
| 600 | </urls> |
| 601 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 602 | <packages> |
| 603 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 604 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 605 | 7c9b12cb7cc067667bde87'/> |
| 606 | </packages> |
| 607 | </manifest> |
| 608 | </updatecheck> |
| 609 | </app> |
| 610 | </response> |
| 611 | */ |
| 612 | EXPECT_FALSE(session_id.empty()); |
| 613 | EXPECT_TRUE(enabled_component_updates); |
| 614 | EXPECT_EQ(2u, ids_to_check.size()); |
| 615 | |
| 616 | ProtocolParser::Results results; |
| 617 | { |
| 618 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 619 | EXPECT_EQ(id, ids_to_check[0]); |
| 620 | EXPECT_EQ(1u, components.count(id)); |
| 621 | |
| 622 | ProtocolParser::Result::Manifest::Package package; |
| 623 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 624 | package.hash_sha256 = |
| 625 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
| 626 | |
| 627 | ProtocolParser::Result result; |
| 628 | result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 629 | result.status = "ok"; |
| 630 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 631 | result.manifest.version = "1.0"; |
| 632 | result.manifest.browser_min_version = "11.0.1.0"; |
| 633 | result.manifest.packages.push_back(package); |
| 634 | results.list.push_back(result); |
| 635 | |
| 636 | EXPECT_FALSE(components.at(id)->is_foreground()); |
| 637 | } |
| 638 | |
| 639 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 640 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 641 | ErrorCategory::kNone, 0, 0)); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 642 | } |
| 643 | }; |
| 644 | |
| 645 | class MockCrxDownloader : public CrxDownloader { |
| 646 | public: |
| 647 | static std::unique_ptr<CrxDownloader> Create( |
| 648 | bool is_background_download, |
| 649 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
| 650 | return std::make_unique<MockCrxDownloader>(); |
| 651 | } |
| 652 | |
| 653 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 654 | |
| 655 | private: |
| 656 | void DoStartDownload(const GURL& url) override { |
| 657 | DownloadMetrics download_metrics; |
| 658 | download_metrics.url = url; |
| 659 | download_metrics.downloader = DownloadMetrics::kNone; |
| 660 | download_metrics.error = 0; |
| 661 | download_metrics.downloaded_bytes = 1843; |
| 662 | download_metrics.total_bytes = 1843; |
| 663 | download_metrics.download_time_ms = 1000; |
| 664 | |
| 665 | FilePath path; |
| 666 | EXPECT_TRUE(MakeTestFile( |
| 667 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 668 | |
| 669 | Result result; |
| 670 | result.error = 0; |
| 671 | result.response = path; |
| 672 | result.downloaded_bytes = 1843; |
| 673 | result.total_bytes = 1843; |
| 674 | |
| 675 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 676 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
| 677 | base::Unretained(this), result)); |
| 678 | |
| 679 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 680 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
| 681 | base::Unretained(this), true, result, |
| 682 | download_metrics)); |
| 683 | } |
| 684 | }; |
| 685 | |
| 686 | class MockPingManager : public MockPingManagerImpl { |
| 687 | public: |
| 688 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 689 | : MockPingManagerImpl(config) {} |
| 690 | |
| 691 | protected: |
| 692 | ~MockPingManager() override { |
| 693 | const auto ping_data = MockPingManagerImpl::ping_data(); |
| 694 | EXPECT_EQ(1u, ping_data.size()); |
| 695 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 696 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 697 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
| 698 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
| 699 | EXPECT_EQ(0, ping_data[0].error_code); |
| 700 | } |
| 701 | }; |
| 702 | |
| 703 | scoped_refptr<UpdateClient> update_client = |
| 704 | base::MakeRefCounted<UpdateClientImpl>( |
| 705 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 706 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 707 | |
| 708 | MockObserver observer; |
| 709 | { |
| 710 | InSequence seq; |
| 711 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 712 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 713 | .Times(1); |
| 714 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 715 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 716 | .Times(1); |
| 717 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
| 718 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 719 | .Times(AtLeast(1)); |
| 720 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 721 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 722 | .Times(1); |
| 723 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 724 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 725 | .Times(1); |
| 726 | } |
| 727 | { |
| 728 | InSequence seq; |
| 729 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 730 | "abagagagagagagagagagagagagagagag")) |
| 731 | .Times(1); |
| 732 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 733 | "abagagagagagagagagagagagagagagag")) |
| 734 | .Times(1) |
| 735 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 736 | CrxUpdateItem item; |
| 737 | update_client->GetCrxUpdateState(id, &item); |
| 738 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 739 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 740 | EXPECT_EQ(-10004, item.error_code); |
| 741 | EXPECT_EQ(0, item.extra_code1); |
| 742 | })); |
| 743 | } |
| 744 | |
| 745 | update_client->AddObserver(&observer); |
| 746 | |
| 747 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 748 | "abagagagagagagagagagagagagagagag"}; |
| 749 | update_client->Update( |
| 750 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 751 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
| 752 | |
| 753 | RunThreads(); |
| 754 | |
| 755 | update_client->RemoveObserver(&observer); |
| 756 | } |
| 757 | |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 758 | // Tests the update check for two CRXs scenario when the second CRX does not |
| 759 | // provide a CrxComponent instance. In this case, the update is handled as |
| 760 | // if only one component were provided as an argument to the |Update| call |
| 761 | // with the exception that the second component still fires an event such as |
| 762 | // |COMPONENT_UPDATE_ERROR|. |
| 763 | TEST_F(UpdateClientTest, TwoCrxUpdateNoCrxComponentData) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 764 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 765 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 766 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 767 | const std::vector<std::string>& ids) { |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 768 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 769 | crx->name = "test_jebg"; |
| 770 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 771 | crx->version = base::Version("0.9"); |
| 772 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 773 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 774 | std::vector<std::unique_ptr<CrxComponent>> component; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 775 | component.push_back(std::move(crx)); |
| 776 | component.push_back(std::move(nullptr)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 777 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 778 | } |
| 779 | }; |
| 780 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 781 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 782 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 783 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 784 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 785 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 786 | } |
| 787 | }; |
| 788 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 789 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 790 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 791 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 792 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 793 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 794 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 795 | } |
| 796 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 797 | void CheckForUpdates(const std::string& session_id, |
| 798 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 799 | const IdToComponentPtrMap& components, |
| 800 | const std::string& additional_attributes, |
| 801 | bool enabled_component_updates, |
| 802 | UpdateCheckCallback update_check_callback) override { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 803 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 804 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 805 | |
| 806 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 807 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 808 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 809 | <updatecheck status='ok'> |
| 810 | <urls> |
| 811 | <url codebase='http://localhost/download/'/> |
| 812 | </urls> |
| 813 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 814 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 815 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 816 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 817 | 7c9b12cb7cc067667bde87'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 818 | </packages> |
| 819 | </manifest> |
| 820 | </updatecheck> |
| 821 | </app> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 822 | </response> |
| 823 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 824 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 825 | EXPECT_TRUE(enabled_component_updates); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 826 | EXPECT_EQ(1u, ids_to_check.size()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 827 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 828 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 829 | { |
| 830 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 831 | EXPECT_EQ(id, ids_to_check[0]); |
| 832 | EXPECT_EQ(1u, components.count(id)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 833 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 834 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 835 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 836 | package.hash_sha256 = |
| 837 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 838 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 839 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 840 | result.extension_id = id; |
| 841 | result.status = "ok"; |
| 842 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 843 | result.manifest.version = "1.0"; |
| 844 | result.manifest.browser_min_version = "11.0.1.0"; |
| 845 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 846 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 847 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 848 | EXPECT_FALSE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 849 | } |
| 850 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 851 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 852 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 853 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 854 | } |
| 855 | }; |
| 856 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 857 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 858 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 859 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 860 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 861 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 862 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 863 | } |
| 864 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 865 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 866 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 867 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 868 | void DoStartDownload(const GURL& url) override { |
| 869 | DownloadMetrics download_metrics; |
| 870 | FilePath path; |
| 871 | Result result; |
| 872 | if (url.path() == "/download/jebgalgnebhfojomionfpkfelancnnkf.crx") { |
| 873 | download_metrics.url = url; |
| 874 | download_metrics.downloader = DownloadMetrics::kNone; |
| 875 | download_metrics.error = 0; |
| 876 | download_metrics.downloaded_bytes = 1843; |
| 877 | download_metrics.total_bytes = 1843; |
| 878 | download_metrics.download_time_ms = 1000; |
| 879 | |
| 880 | EXPECT_TRUE(MakeTestFile( |
| 881 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 882 | |
| 883 | result.error = 0; |
| 884 | result.response = path; |
| 885 | result.downloaded_bytes = 1843; |
| 886 | result.total_bytes = 1843; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 887 | } else { |
| 888 | NOTREACHED(); |
| 889 | } |
| 890 | |
| 891 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 892 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 893 | base::Unretained(this), result)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 894 | |
| 895 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 896 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 897 | base::Unretained(this), true, result, |
| 898 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 899 | } |
| 900 | }; |
| 901 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 902 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 903 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 904 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 905 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 906 | |
| 907 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 908 | ~MockPingManager() override { |
| 909 | const auto ping_data = MockPingManagerImpl::ping_data(); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 910 | EXPECT_EQ(1u, ping_data.size()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 911 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 912 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 913 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 914 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 915 | EXPECT_EQ(0, ping_data[0].error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 916 | } |
| 917 | }; |
| 918 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 919 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 920 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 921 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 922 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 923 | |
| 924 | MockObserver observer; |
| 925 | { |
| 926 | InSequence seq; |
| 927 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 928 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 929 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 930 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 931 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 932 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 933 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 934 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 935 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 936 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 937 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 938 | } |
| 939 | { |
| 940 | InSequence seq; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 941 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 942 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 943 | .Times(1); |
| 944 | } |
| 945 | |
| 946 | update_client->AddObserver(&observer); |
| 947 | |
| 948 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 949 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
| 950 | update_client->Update( |
| 951 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 952 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
| 953 | |
| 954 | RunThreads(); |
| 955 | |
| 956 | update_client->RemoveObserver(&observer); |
| 957 | } |
| 958 | |
| 959 | // Tests the update check for two CRXs scenario when no CrxComponent data is |
| 960 | // provided for either component. In this case, no update check occurs, and |
| 961 | // |COMPONENT_UPDATE_ERROR| event fires for both components. |
| 962 | TEST_F(UpdateClientTest, TwoCrxUpdateNoCrxComponentDataAtAll) { |
| 963 | class DataCallbackMock { |
| 964 | public: |
| 965 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 966 | const std::vector<std::string>& ids) { |
| 967 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 968 | component.push_back(std::move(nullptr)); |
| 969 | component.push_back(std::move(nullptr)); |
| 970 | return component; |
| 971 | } |
| 972 | }; |
| 973 | |
| 974 | class CompletionCallbackMock { |
| 975 | public: |
| 976 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 977 | EXPECT_EQ(Error::NONE, error); |
| 978 | std::move(quit_closure).Run(); |
| 979 | } |
| 980 | }; |
| 981 | |
| 982 | class MockUpdateChecker : public UpdateChecker { |
| 983 | public: |
| 984 | static std::unique_ptr<UpdateChecker> Create( |
| 985 | scoped_refptr<Configurator> config, |
| 986 | PersistedData* metadata) { |
| 987 | return std::make_unique<MockUpdateChecker>(); |
| 988 | } |
| 989 | |
| 990 | void CheckForUpdates(const std::string& session_id, |
| 991 | const std::vector<std::string>& ids_to_check, |
| 992 | const IdToComponentPtrMap& components, |
| 993 | const std::string& additional_attributes, |
| 994 | bool enabled_component_updates, |
| 995 | UpdateCheckCallback update_check_callback) override { |
| 996 | NOTREACHED(); |
| 997 | } |
| 998 | }; |
| 999 | |
| 1000 | class MockCrxDownloader : public CrxDownloader { |
| 1001 | public: |
| 1002 | static std::unique_ptr<CrxDownloader> Create( |
| 1003 | bool is_background_download, |
| 1004 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
| 1005 | return std::make_unique<MockCrxDownloader>(); |
| 1006 | } |
| 1007 | |
| 1008 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 1009 | |
| 1010 | private: |
| 1011 | void DoStartDownload(const GURL& url) override { NOTREACHED(); } |
| 1012 | }; |
| 1013 | |
| 1014 | class MockPingManager : public MockPingManagerImpl { |
| 1015 | public: |
| 1016 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1017 | : MockPingManagerImpl(config) {} |
| 1018 | |
| 1019 | protected: |
| 1020 | ~MockPingManager() override { |
| 1021 | EXPECT_EQ(0u, MockPingManagerImpl::ping_data().size()); |
| 1022 | } |
| 1023 | }; |
| 1024 | |
| 1025 | scoped_refptr<UpdateClient> update_client = |
| 1026 | base::MakeRefCounted<UpdateClientImpl>( |
| 1027 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1028 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 1029 | |
| 1030 | MockObserver observer; |
| 1031 | { |
| 1032 | InSequence seq; |
| 1033 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1034 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1035 | .Times(1); |
| 1036 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1037 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1038 | .Times(1); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1039 | } |
| 1040 | |
| 1041 | update_client->AddObserver(&observer); |
| 1042 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1043 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 1044 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1045 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1046 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 1047 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1048 | |
| 1049 | RunThreads(); |
| 1050 | |
| 1051 | update_client->RemoveObserver(&observer); |
| 1052 | } |
| 1053 | |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1054 | // Tests the scenario where there is a download timeout for the first |
| 1055 | // CRX. The update for the first CRX fails. The update client waits before |
| 1056 | // attempting the update for the second CRX. This update succeeds. |
| 1057 | TEST_F(UpdateClientTest, TwoCrxUpdateDownloadTimeout) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1058 | class DataCallbackMock { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1059 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1060 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 1061 | const std::vector<std::string>& ids) { |
| 1062 | std::unique_ptr<CrxComponent> crx1 = std::make_unique<CrxComponent>(); |
| 1063 | crx1->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1064 | crx1->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1065 | crx1->version = base::Version("0.9"); |
| 1066 | crx1->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1067 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1068 | std::unique_ptr<CrxComponent> crx2 = std::make_unique<CrxComponent>(); |
| 1069 | crx2->name = "test_ihfo"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1070 | crx2->pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1071 | crx2->version = base::Version("0.8"); |
| 1072 | crx2->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1073 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1074 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 1075 | component.push_back(std::move(crx1)); |
| 1076 | component.push_back(std::move(crx2)); |
| 1077 | return component; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1078 | } |
| 1079 | }; |
| 1080 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1081 | class CompletionCallbackMock { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1082 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1083 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1084 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1085 | std::move(quit_closure).Run(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1086 | } |
| 1087 | }; |
| 1088 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1089 | class MockUpdateChecker : public UpdateChecker { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1090 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1091 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1092 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1093 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1094 | return std::make_unique<MockUpdateChecker>(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1095 | } |
| 1096 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1097 | void CheckForUpdates(const std::string& session_id, |
| 1098 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1099 | const IdToComponentPtrMap& components, |
| 1100 | const std::string& additional_attributes, |
| 1101 | bool enabled_component_updates, |
| 1102 | UpdateCheckCallback update_check_callback) override { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1103 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1104 | Mock the following response: |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1105 | |
| 1106 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1107 | <response protocol='3.1'> |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1108 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 1109 | <updatecheck status='ok'> |
| 1110 | <urls> |
| 1111 | <url codebase='http://localhost/download/'/> |
| 1112 | </urls> |
| 1113 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1114 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1115 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 1116 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 1117 | 7c9b12cb7cc067667bde87'/> |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1118 | </packages> |
| 1119 | </manifest> |
| 1120 | </updatecheck> |
| 1121 | </app> |
| 1122 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1123 | <updatecheck status='ok'> |
| 1124 | <urls> |
| 1125 | <url codebase='http://localhost/download/'/> |
| 1126 | </urls> |
| 1127 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1128 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1129 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
| 1130 | hash_sha256='813c59747e139a608b3b5fc49633affc6db574373f |
| 1131 | 309f156ea6d27229c0b3f9'/> |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1132 | </packages> |
| 1133 | </manifest> |
| 1134 | </updatecheck> |
| 1135 | </app> |
| 1136 | </response> |
| 1137 | */ |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1138 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1139 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1140 | EXPECT_TRUE(enabled_component_updates); |
| 1141 | EXPECT_EQ(2u, ids_to_check.size()); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1142 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1143 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1144 | { |
| 1145 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 1146 | EXPECT_EQ(id, ids_to_check[0]); |
| 1147 | EXPECT_EQ(1u, components.count(id)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1148 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1149 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1150 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 1151 | package.hash_sha256 = |
| 1152 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1153 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1154 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1155 | result.extension_id = id; |
| 1156 | result.status = "ok"; |
| 1157 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1158 | result.manifest.version = "1.0"; |
| 1159 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1160 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1161 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1162 | } |
| 1163 | |
| 1164 | { |
| 1165 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1166 | EXPECT_EQ(id, ids_to_check[1]); |
| 1167 | EXPECT_EQ(1u, components.count(id)); |
| 1168 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1169 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1170 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
| 1171 | package.hash_sha256 = |
| 1172 | "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9"; |
| 1173 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1174 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1175 | result.extension_id = id; |
| 1176 | result.status = "ok"; |
| 1177 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1178 | result.manifest.version = "1.0"; |
| 1179 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1180 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1181 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1182 | } |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1183 | |
| 1184 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 1185 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 1186 | ErrorCategory::kNone, 0, 0)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1187 | } |
| 1188 | }; |
| 1189 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1190 | class MockCrxDownloader : public CrxDownloader { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1191 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1192 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1193 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 1194 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1195 | return std::make_unique<MockCrxDownloader>(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1196 | } |
| 1197 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1198 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1199 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1200 | private: |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1201 | void DoStartDownload(const GURL& url) override { |
| 1202 | DownloadMetrics download_metrics; |
| 1203 | FilePath path; |
| 1204 | Result result; |
| 1205 | if (url.path() == "/download/jebgalgnebhfojomionfpkfelancnnkf.crx") { |
| 1206 | download_metrics.url = url; |
| 1207 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1208 | download_metrics.error = -118; |
| 1209 | download_metrics.downloaded_bytes = 0; |
| 1210 | download_metrics.total_bytes = 0; |
| 1211 | download_metrics.download_time_ms = 1000; |
| 1212 | |
Sorin Jianu | 52de5fa | 2017-10-09 23:19:33 | [diff] [blame] | 1213 | // The result must not include a file path in the case of errors. |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1214 | result.error = -118; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1215 | result.downloaded_bytes = 0; |
| 1216 | result.total_bytes = 0; |
| 1217 | } else if (url.path() == |
| 1218 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 1219 | download_metrics.url = url; |
| 1220 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1221 | download_metrics.error = 0; |
| 1222 | download_metrics.downloaded_bytes = 53638; |
| 1223 | download_metrics.total_bytes = 53638; |
| 1224 | download_metrics.download_time_ms = 2000; |
| 1225 | |
| 1226 | EXPECT_TRUE(MakeTestFile( |
| 1227 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 1228 | |
| 1229 | result.error = 0; |
| 1230 | result.response = path; |
| 1231 | result.downloaded_bytes = 53638; |
| 1232 | result.total_bytes = 53638; |
| 1233 | } else { |
| 1234 | NOTREACHED(); |
| 1235 | } |
| 1236 | |
| 1237 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1238 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1239 | base::Unretained(this), result)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1240 | |
| 1241 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1242 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1243 | base::Unretained(this), true, result, |
| 1244 | download_metrics)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1245 | } |
| 1246 | }; |
| 1247 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1248 | class MockPingManager : public MockPingManagerImpl { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1249 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1250 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1251 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 1252 | |
| 1253 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1254 | ~MockPingManager() override { |
| 1255 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1256 | EXPECT_EQ(2u, ping_data.size()); |
| 1257 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 1258 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 1259 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1260 | EXPECT_EQ(1, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1261 | EXPECT_EQ(-118, ping_data[0].error_code); |
| 1262 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 1263 | EXPECT_EQ(base::Version("0.8"), ping_data[1].previous_version); |
| 1264 | EXPECT_EQ(base::Version("1.0"), ping_data[1].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1265 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1266 | EXPECT_EQ(0, ping_data[1].error_code); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1267 | } |
| 1268 | }; |
| 1269 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1270 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1271 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1272 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1273 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1274 | |
| 1275 | MockObserver observer; |
| 1276 | { |
| 1277 | InSequence seq; |
| 1278 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1279 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1280 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1281 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1282 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1283 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1284 | .Times(AtLeast(1)); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 1285 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1286 | "jebgalgnebhfojomionfpkfelancnnkf")) |
Sorin Jianu | afcb70dd | 2018-05-16 20:14:15 | [diff] [blame] | 1287 | .Times(1) |
| 1288 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 1289 | CrxUpdateItem item; |
| 1290 | update_client->GetCrxUpdateState(id, &item); |
| 1291 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1292 | EXPECT_EQ(1, static_cast<int>(item.error_category)); |
Sorin Jianu | afcb70dd | 2018-05-16 20:14:15 | [diff] [blame] | 1293 | EXPECT_EQ(-118, item.error_code); |
| 1294 | EXPECT_EQ(0, item.extra_code1); |
| 1295 | })); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1296 | } |
| 1297 | { |
| 1298 | InSequence seq; |
| 1299 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1300 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1301 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1302 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1303 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_WAIT, |
| 1304 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1305 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1306 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1307 | .Times(AtLeast(1)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1308 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1309 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1310 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1311 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1312 | } |
| 1313 | |
| 1314 | update_client->AddObserver(&observer); |
| 1315 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1316 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 1317 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1318 | |
| 1319 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1320 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 1321 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1322 | |
| 1323 | RunThreads(); |
| 1324 | |
| 1325 | update_client->RemoveObserver(&observer); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1326 | } |
| 1327 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1328 | // Tests the differential update scenario for one CRX. |
| 1329 | TEST_F(UpdateClientTest, OneCrxDiffUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1330 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1331 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1332 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 1333 | const std::vector<std::string>& ids) { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1334 | static int num_calls = 0; |
| 1335 | |
| 1336 | // Must use the same stateful installer object. |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1337 | static scoped_refptr<CrxInstaller> installer = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1338 | base::MakeRefCounted<VersionedTestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1339 | |
| 1340 | ++num_calls; |
| 1341 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1342 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 1343 | crx->name = "test_ihfo"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1344 | crx->pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1345 | crx->installer = installer; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1346 | if (num_calls == 1) { |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1347 | crx->version = base::Version("0.8"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1348 | } else if (num_calls == 2) { |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1349 | crx->version = base::Version("1.0"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1350 | } else { |
| 1351 | NOTREACHED(); |
| 1352 | } |
| 1353 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1354 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 1355 | component.push_back(std::move(crx)); |
| 1356 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1357 | } |
| 1358 | }; |
| 1359 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1360 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1361 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1362 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1363 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1364 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1365 | } |
| 1366 | }; |
| 1367 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1368 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1369 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1370 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1371 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1372 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1373 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1374 | } |
| 1375 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1376 | void CheckForUpdates(const std::string& session_id, |
| 1377 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1378 | const IdToComponentPtrMap& components, |
| 1379 | const std::string& additional_attributes, |
| 1380 | bool enabled_component_updates, |
| 1381 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1382 | EXPECT_FALSE(session_id.empty()); |
| 1383 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1384 | static int num_call = 0; |
| 1385 | ++num_call; |
| 1386 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1387 | ProtocolParser::Results results; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1388 | |
| 1389 | if (num_call == 1) { |
| 1390 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1391 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1392 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1393 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1394 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1395 | <updatecheck status='ok'> |
| 1396 | <urls> |
| 1397 | <url codebase='http://localhost/download/'/> |
| 1398 | </urls> |
| 1399 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1400 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1401 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
| 1402 | hash_sha256='813c59747e139a608b3b5fc49633affc6db57437 |
| 1403 | 3f309f156ea6d27229c0b3f9'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1404 | </packages> |
| 1405 | </manifest> |
| 1406 | </updatecheck> |
| 1407 | </app> |
| 1408 | </response> |
| 1409 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1410 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1411 | EXPECT_EQ(id, ids_to_check[0]); |
| 1412 | EXPECT_EQ(1u, components.count(id)); |
| 1413 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1414 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1415 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1416 | package.hash_sha256 = |
| 1417 | "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1418 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1419 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1420 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1421 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1422 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1423 | result.manifest.version = "1.0"; |
| 1424 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1425 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1426 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1427 | } else if (num_call == 2) { |
| 1428 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1429 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1430 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1431 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1432 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1433 | <updatecheck status='ok'> |
| 1434 | <urls> |
| 1435 | <url codebase='http://localhost/download/'/> |
| 1436 | <url codebasediff='http://localhost/download/'/> |
| 1437 | </urls> |
| 1438 | <manifest version='2.0' prodversionmin='11.0.1.0'> |
| 1439 | <packages> |
| 1440 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_2.crx' |
| 1441 | namediff='ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx' |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1442 | hash_sha256='1af337fbd19c72db0f870753bcd7711c3ae9dcaa |
| 1443 | 0ecde26c262bad942b112990' |
| 1444 | fp='22' |
| 1445 | hashdiff_sha256='73c6e2d4f783fc4ca5481e89e0b8bfce7aec |
sorin | 46bdd0b3 | 2016-08-30 22:42:26 | [diff] [blame] | 1446 | 8ead3686290c94792658ec06f2f2'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1447 | </packages> |
| 1448 | </manifest> |
| 1449 | </updatecheck> |
| 1450 | </app> |
| 1451 | </response> |
| 1452 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1453 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1454 | EXPECT_EQ(id, ids_to_check[0]); |
| 1455 | EXPECT_EQ(1u, components.count(id)); |
| 1456 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1457 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1458 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_2.crx"; |
| 1459 | package.namediff = "ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1460 | package.hash_sha256 = |
| 1461 | "1af337fbd19c72db0f870753bcd7711c3ae9dcaa0ecde26c262bad942b112990"; |
| 1462 | package.hashdiff_sha256 = |
| 1463 | "73c6e2d4f783fc4ca5481e89e0b8bfce7aec8ead3686290c94792658ec06f2f2"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1464 | package.fingerprint = "22"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1465 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1466 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1467 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1468 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1469 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1470 | result.crx_diffurls.push_back(GURL("http://localhost/download/")); |
| 1471 | result.manifest.version = "2.0"; |
| 1472 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1473 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1474 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1475 | } else { |
| 1476 | NOTREACHED(); |
| 1477 | } |
| 1478 | |
| 1479 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 1480 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 1481 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1482 | } |
| 1483 | }; |
| 1484 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1485 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1486 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1487 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1488 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 1489 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1490 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1491 | } |
| 1492 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1493 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1494 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1495 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1496 | void DoStartDownload(const GURL& url) override { |
| 1497 | DownloadMetrics download_metrics; |
| 1498 | FilePath path; |
| 1499 | Result result; |
| 1500 | if (url.path() == "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 1501 | download_metrics.url = url; |
| 1502 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1503 | download_metrics.error = 0; |
| 1504 | download_metrics.downloaded_bytes = 53638; |
| 1505 | download_metrics.total_bytes = 53638; |
| 1506 | download_metrics.download_time_ms = 2000; |
| 1507 | |
| 1508 | EXPECT_TRUE(MakeTestFile( |
| 1509 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 1510 | |
| 1511 | result.error = 0; |
| 1512 | result.response = path; |
| 1513 | result.downloaded_bytes = 53638; |
| 1514 | result.total_bytes = 53638; |
| 1515 | } else if (url.path() == |
| 1516 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx") { |
| 1517 | download_metrics.url = url; |
| 1518 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1519 | download_metrics.error = 0; |
| 1520 | download_metrics.downloaded_bytes = 2105; |
| 1521 | download_metrics.total_bytes = 2105; |
| 1522 | download_metrics.download_time_ms = 1000; |
| 1523 | |
| 1524 | EXPECT_TRUE(MakeTestFile( |
| 1525 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx"), &path)); |
| 1526 | |
| 1527 | result.error = 0; |
| 1528 | result.response = path; |
| 1529 | result.downloaded_bytes = 2105; |
| 1530 | result.total_bytes = 2105; |
| 1531 | } else { |
| 1532 | NOTREACHED(); |
| 1533 | } |
| 1534 | |
| 1535 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1536 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1537 | base::Unretained(this), result)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1538 | |
| 1539 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1540 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1541 | base::Unretained(this), true, result, |
| 1542 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1543 | } |
| 1544 | }; |
| 1545 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1546 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1547 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1548 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1549 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 1550 | |
| 1551 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1552 | ~MockPingManager() override { |
| 1553 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1554 | EXPECT_EQ(2u, ping_data.size()); |
| 1555 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[0].id); |
| 1556 | EXPECT_EQ(base::Version("0.8"), ping_data[0].previous_version); |
| 1557 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1558 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1559 | EXPECT_EQ(0, ping_data[0].error_code); |
| 1560 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 1561 | EXPECT_EQ(base::Version("1.0"), ping_data[1].previous_version); |
| 1562 | EXPECT_EQ(base::Version("2.0"), ping_data[1].next_version); |
| 1563 | EXPECT_FALSE(ping_data[1].diff_update_failed); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1564 | EXPECT_EQ(0, static_cast<int>(ping_data[1].diff_error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1565 | EXPECT_EQ(0, ping_data[1].diff_error_code); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1566 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1567 | EXPECT_EQ(0, ping_data[1].error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1568 | } |
| 1569 | }; |
| 1570 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1571 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1572 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1573 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1574 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1575 | |
| 1576 | MockObserver observer; |
| 1577 | { |
| 1578 | InSequence seq; |
| 1579 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1580 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1581 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1582 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1583 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1584 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1585 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1586 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1587 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1588 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1589 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1590 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1591 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1592 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1593 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1594 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1595 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1596 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1597 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1598 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1599 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1600 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1601 | } |
| 1602 | |
| 1603 | update_client->AddObserver(&observer); |
| 1604 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1605 | const std::vector<std::string> ids = {"ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1606 | { |
| 1607 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1608 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 1609 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1610 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1611 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1612 | runloop.Run(); |
| 1613 | } |
| 1614 | |
| 1615 | { |
| 1616 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1617 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 1618 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1619 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1620 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1621 | runloop.Run(); |
| 1622 | } |
| 1623 | |
| 1624 | update_client->RemoveObserver(&observer); |
| 1625 | } |
| 1626 | |
| 1627 | // Tests the update scenario for one CRX where the CRX installer returns |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1628 | // an error. Tests that the |unpack_path| argument refers to a valid path |
| 1629 | // then |Install| is called, then tests that the |unpack| path is deleted |
| 1630 | // by the |update_client| code before the test ends. |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1631 | TEST_F(UpdateClientTest, OneCrxInstallError) { |
| 1632 | class MockInstaller : public CrxInstaller { |
| 1633 | public: |
| 1634 | MOCK_METHOD1(OnUpdateError, void(int error)); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1635 | MOCK_METHOD2(DoInstall, |
Sorin Jianu | 7aa6d1f | 2017-10-13 20:29:29 | [diff] [blame] | 1636 | void(const base::FilePath& unpack_path, |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1637 | const Callback& callback)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1638 | MOCK_METHOD2(GetInstalledFile, |
| 1639 | bool(const std::string& file, base::FilePath* installed_file)); |
| 1640 | MOCK_METHOD0(Uninstall, bool()); |
| 1641 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1642 | void Install(const base::FilePath& unpack_path, |
| 1643 | const std::string& public_key, |
Daniel Cheng | 6784852 | 2018-04-27 22:04:41 | [diff] [blame] | 1644 | Callback callback) override { |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1645 | DoInstall(unpack_path, std::move(callback)); |
| 1646 | |
Sorin Jianu | 23f70f75 | 2017-05-30 16:21:58 | [diff] [blame] | 1647 | unpack_path_ = unpack_path; |
| 1648 | EXPECT_TRUE(base::DirectoryExists(unpack_path_)); |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1649 | base::PostTaskWithTraits( |
| 1650 | FROM_HERE, {base::MayBlock()}, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1651 | base::BindOnce(std::move(callback), |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1652 | CrxInstaller::Result(InstallError::GENERIC_ERROR))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1653 | } |
| 1654 | |
| 1655 | protected: |
Sorin Jianu | 23f70f75 | 2017-05-30 16:21:58 | [diff] [blame] | 1656 | ~MockInstaller() override { |
| 1657 | // The unpack path is deleted unconditionally by the component state code, |
| 1658 | // which is driving this installer. Therefore, the unpack path must not |
| 1659 | // exist when this object is destroyed. |
| 1660 | if (!unpack_path_.empty()) |
| 1661 | EXPECT_FALSE(base::DirectoryExists(unpack_path_)); |
| 1662 | } |
| 1663 | |
| 1664 | private: |
| 1665 | // Contains the |unpack_path| argument of the Install call. |
| 1666 | base::FilePath unpack_path_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1667 | }; |
| 1668 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1669 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1670 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1671 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 1672 | const std::vector<std::string>& ids) { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1673 | scoped_refptr<MockInstaller> installer = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1674 | base::MakeRefCounted<MockInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1675 | |
| 1676 | EXPECT_CALL(*installer, OnUpdateError(_)).Times(0); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1677 | EXPECT_CALL(*installer, DoInstall(_, _)).Times(1); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1678 | EXPECT_CALL(*installer, GetInstalledFile(_, _)).Times(0); |
| 1679 | EXPECT_CALL(*installer, Uninstall()).Times(0); |
| 1680 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1681 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 1682 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1683 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1684 | crx->version = base::Version("0.9"); |
| 1685 | crx->installer = installer; |
| 1686 | |
| 1687 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 1688 | component.push_back(std::move(crx)); |
| 1689 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1690 | } |
| 1691 | }; |
| 1692 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1693 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1694 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1695 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1696 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1697 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1698 | } |
| 1699 | }; |
| 1700 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1701 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1702 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1703 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1704 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1705 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1706 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1707 | } |
| 1708 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1709 | void CheckForUpdates(const std::string& session_id, |
| 1710 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1711 | const IdToComponentPtrMap& components, |
| 1712 | const std::string& additional_attributes, |
| 1713 | bool enabled_component_updates, |
| 1714 | UpdateCheckCallback update_check_callback) override { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1715 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1716 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1717 | |
| 1718 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1719 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1720 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 1721 | <updatecheck status='ok'> |
| 1722 | <urls> |
| 1723 | <url codebase='http://localhost/download/'/> |
| 1724 | </urls> |
| 1725 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1726 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1727 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 1728 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 1729 | 7c9b12cb7cc067667bde87'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1730 | </packages> |
| 1731 | </manifest> |
| 1732 | </updatecheck> |
| 1733 | </app> |
| 1734 | </response> |
| 1735 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1736 | EXPECT_FALSE(session_id.empty()); |
| 1737 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1738 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 1739 | EXPECT_EQ(id, ids_to_check[0]); |
| 1740 | EXPECT_EQ(1u, components.count(id)); |
| 1741 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1742 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1743 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1744 | package.hash_sha256 = |
| 1745 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1746 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1747 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1748 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1749 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1750 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1751 | result.manifest.version = "1.0"; |
| 1752 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1753 | result.manifest.packages.push_back(package); |
| 1754 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1755 | ProtocolParser::Results results; |
| 1756 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1757 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 1758 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 1759 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1760 | } |
| 1761 | }; |
| 1762 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1763 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1764 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1765 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1766 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 1767 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1768 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1769 | } |
| 1770 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1771 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1772 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1773 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1774 | void DoStartDownload(const GURL& url) override { |
| 1775 | DownloadMetrics download_metrics; |
| 1776 | download_metrics.url = url; |
| 1777 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1778 | download_metrics.error = 0; |
| 1779 | download_metrics.downloaded_bytes = 1843; |
| 1780 | download_metrics.total_bytes = 1843; |
| 1781 | download_metrics.download_time_ms = 1000; |
| 1782 | |
| 1783 | FilePath path; |
| 1784 | EXPECT_TRUE(MakeTestFile( |
| 1785 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 1786 | |
| 1787 | Result result; |
| 1788 | result.error = 0; |
| 1789 | result.response = path; |
| 1790 | result.downloaded_bytes = 1843; |
| 1791 | result.total_bytes = 1843; |
| 1792 | |
| 1793 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1794 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1795 | base::Unretained(this), result)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1796 | |
| 1797 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1798 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1799 | base::Unretained(this), true, result, |
| 1800 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1801 | } |
| 1802 | }; |
| 1803 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1804 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1805 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1806 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1807 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 1808 | |
| 1809 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1810 | ~MockPingManager() override { |
| 1811 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1812 | EXPECT_EQ(1u, ping_data.size()); |
| 1813 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 1814 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 1815 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1816 | EXPECT_EQ(3, static_cast<int>(ping_data[0].error_category)); // kInstall. |
| 1817 | EXPECT_EQ(9, ping_data[0].error_code); // kInstallerError. |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1818 | } |
| 1819 | }; |
| 1820 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1821 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1822 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1823 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1824 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1825 | |
| 1826 | MockObserver observer; |
| 1827 | { |
| 1828 | InSequence seq; |
| 1829 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1830 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1831 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1832 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1833 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1834 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1835 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1836 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1837 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 1838 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1839 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1840 | .Times(1); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1841 | } |
| 1842 | |
| 1843 | update_client->AddObserver(&observer); |
| 1844 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1845 | std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1846 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1847 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 1848 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1849 | |
| 1850 | RunThreads(); |
| 1851 | |
| 1852 | update_client->RemoveObserver(&observer); |
| 1853 | } |
| 1854 | |
| 1855 | // Tests the fallback from differential to full update scenario for one CRX. |
| 1856 | TEST_F(UpdateClientTest, OneCrxDiffUpdateFailsFullUpdateSucceeds) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1857 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1858 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1859 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 1860 | const std::vector<std::string>& ids) { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1861 | static int num_calls = 0; |
| 1862 | |
| 1863 | // Must use the same stateful installer object. |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1864 | static scoped_refptr<CrxInstaller> installer = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1865 | base::MakeRefCounted<VersionedTestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1866 | |
| 1867 | ++num_calls; |
| 1868 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1869 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 1870 | crx->name = "test_ihfo"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1871 | crx->pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1872 | crx->installer = installer; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1873 | if (num_calls == 1) { |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1874 | crx->version = base::Version("0.8"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1875 | } else if (num_calls == 2) { |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1876 | crx->version = base::Version("1.0"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1877 | } else { |
| 1878 | NOTREACHED(); |
| 1879 | } |
| 1880 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1881 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 1882 | component.push_back(std::move(crx)); |
| 1883 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1884 | } |
| 1885 | }; |
| 1886 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1887 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1888 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1889 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1890 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1891 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1892 | } |
| 1893 | }; |
| 1894 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1895 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1896 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1897 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1898 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1899 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1900 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1901 | } |
| 1902 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1903 | void CheckForUpdates(const std::string& session_id, |
| 1904 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1905 | const IdToComponentPtrMap& components, |
| 1906 | const std::string& additional_attributes, |
| 1907 | bool enabled_component_updates, |
| 1908 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1909 | EXPECT_FALSE(session_id.empty()); |
| 1910 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1911 | static int num_call = 0; |
| 1912 | ++num_call; |
| 1913 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1914 | ProtocolParser::Results results; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1915 | |
| 1916 | if (num_call == 1) { |
| 1917 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1918 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1919 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1920 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1921 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1922 | <updatecheck status='ok'> |
| 1923 | <urls> |
| 1924 | <url codebase='http://localhost/download/'/> |
| 1925 | </urls> |
| 1926 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1927 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1928 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
| 1929 | hash_sha256='813c59747e139a608b3b5fc49633affc6db57437 |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1930 | 3f309f156ea6d27229c0b3f9' |
| 1931 | fp='1'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1932 | </packages> |
| 1933 | </manifest> |
| 1934 | </updatecheck> |
| 1935 | </app> |
| 1936 | </response> |
| 1937 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1938 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1939 | EXPECT_EQ(id, ids_to_check[0]); |
| 1940 | EXPECT_EQ(1u, components.count(id)); |
| 1941 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1942 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1943 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1944 | package.hash_sha256 = |
| 1945 | "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1946 | package.fingerprint = "1"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1947 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1948 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1949 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1950 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1951 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1952 | result.manifest.version = "1.0"; |
| 1953 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1954 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1955 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1956 | } else if (num_call == 2) { |
| 1957 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1958 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1959 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1960 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1961 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1962 | <updatecheck status='ok'> |
| 1963 | <urls> |
| 1964 | <url codebase='http://localhost/download/'/> |
| 1965 | <url codebasediff='http://localhost/download/'/> |
| 1966 | </urls> |
| 1967 | <manifest version='2.0' prodversionmin='11.0.1.0'> |
| 1968 | <packages> |
| 1969 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_2.crx' |
| 1970 | namediff='ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx' |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1971 | hash_sha256='1af337fbd19c72db0f870753bcd7711c3ae9dcaa |
| 1972 | 0ecde26c262bad942b112990' |
| 1973 | fp='22' |
| 1974 | hashdiff_sha256='73c6e2d4f783fc4ca5481e89e0b8bfce7aec |
sorin | 46bdd0b3 | 2016-08-30 22:42:26 | [diff] [blame] | 1975 | 8ead3686290c94792658ec06f2f2'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1976 | </packages> |
| 1977 | </manifest> |
| 1978 | </updatecheck> |
| 1979 | </app> |
| 1980 | </response> |
| 1981 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1982 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1983 | EXPECT_EQ(id, ids_to_check[0]); |
| 1984 | EXPECT_EQ(1u, components.count(id)); |
| 1985 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1986 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1987 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_2.crx"; |
| 1988 | package.namediff = "ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1989 | package.hash_sha256 = |
| 1990 | "1af337fbd19c72db0f870753bcd7711c3ae9dcaa0ecde26c262bad942b112990"; |
| 1991 | package.hashdiff_sha256 = |
| 1992 | "73c6e2d4f783fc4ca5481e89e0b8bfce7aec8ead3686290c94792658ec06f2f2"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1993 | package.fingerprint = "22"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1994 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1995 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1996 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1997 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1998 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1999 | result.crx_diffurls.push_back(GURL("http://localhost/download/")); |
| 2000 | result.manifest.version = "2.0"; |
| 2001 | result.manifest.browser_min_version = "11.0.1.0"; |
| 2002 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2003 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2004 | } else { |
| 2005 | NOTREACHED(); |
| 2006 | } |
| 2007 | |
| 2008 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2009 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2010 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2011 | } |
| 2012 | }; |
| 2013 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2014 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2015 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2016 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2017 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2018 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2019 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2020 | } |
| 2021 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2022 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2023 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2024 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2025 | void DoStartDownload(const GURL& url) override { |
| 2026 | DownloadMetrics download_metrics; |
| 2027 | FilePath path; |
| 2028 | Result result; |
| 2029 | if (url.path() == "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 2030 | download_metrics.url = url; |
| 2031 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2032 | download_metrics.error = 0; |
| 2033 | download_metrics.downloaded_bytes = 53638; |
| 2034 | download_metrics.total_bytes = 53638; |
| 2035 | download_metrics.download_time_ms = 2000; |
| 2036 | |
| 2037 | EXPECT_TRUE(MakeTestFile( |
| 2038 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 2039 | |
| 2040 | result.error = 0; |
| 2041 | result.response = path; |
| 2042 | result.downloaded_bytes = 53638; |
| 2043 | result.total_bytes = 53638; |
| 2044 | } else if (url.path() == |
| 2045 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx") { |
| 2046 | // A download error is injected on this execution path. |
| 2047 | download_metrics.url = url; |
| 2048 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2049 | download_metrics.error = -1; |
| 2050 | download_metrics.downloaded_bytes = 0; |
| 2051 | download_metrics.total_bytes = 2105; |
| 2052 | download_metrics.download_time_ms = 1000; |
| 2053 | |
Sorin Jianu | 52de5fa | 2017-10-09 23:19:33 | [diff] [blame] | 2054 | // The response must not include a file path in the case of errors. |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2055 | result.error = -1; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2056 | result.downloaded_bytes = 0; |
| 2057 | result.total_bytes = 2105; |
| 2058 | } else if (url.path() == |
| 2059 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx") { |
| 2060 | download_metrics.url = url; |
| 2061 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2062 | download_metrics.error = 0; |
| 2063 | download_metrics.downloaded_bytes = 53855; |
| 2064 | download_metrics.total_bytes = 53855; |
| 2065 | download_metrics.download_time_ms = 1000; |
| 2066 | |
| 2067 | EXPECT_TRUE(MakeTestFile( |
| 2068 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_2.crx"), &path)); |
| 2069 | |
| 2070 | result.error = 0; |
| 2071 | result.response = path; |
| 2072 | result.downloaded_bytes = 53855; |
| 2073 | result.total_bytes = 53855; |
| 2074 | } |
| 2075 | |
| 2076 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2077 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 2078 | base::Unretained(this), result)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2079 | |
| 2080 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2081 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 2082 | base::Unretained(this), true, result, |
| 2083 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2084 | } |
| 2085 | }; |
| 2086 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2087 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2088 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2089 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2090 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2091 | |
| 2092 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2093 | ~MockPingManager() override { |
| 2094 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2095 | EXPECT_EQ(2u, ping_data.size()); |
| 2096 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[0].id); |
| 2097 | EXPECT_EQ(base::Version("0.8"), ping_data[0].previous_version); |
| 2098 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2099 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2100 | EXPECT_EQ(0, ping_data[0].error_code); |
| 2101 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 2102 | EXPECT_EQ(base::Version("1.0"), ping_data[1].previous_version); |
| 2103 | EXPECT_EQ(base::Version("2.0"), ping_data[1].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2104 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2105 | EXPECT_EQ(0, ping_data[1].error_code); |
| 2106 | EXPECT_TRUE(ping_data[1].diff_update_failed); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2107 | EXPECT_EQ(1, static_cast<int>(ping_data[1].diff_error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2108 | EXPECT_EQ(-1, ping_data[1].diff_error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2109 | } |
| 2110 | }; |
| 2111 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2112 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2113 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2114 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2115 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2116 | |
| 2117 | MockObserver observer; |
| 2118 | { |
| 2119 | InSequence seq; |
| 2120 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2121 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2122 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2123 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2124 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2125 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 2126 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2127 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2128 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2129 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 2130 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2131 | |
| 2132 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2133 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2134 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2135 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2136 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2137 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 2138 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2139 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2140 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2141 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 2142 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2143 | } |
| 2144 | |
| 2145 | update_client->AddObserver(&observer); |
| 2146 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2147 | const std::vector<std::string> ids = {"ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2148 | |
| 2149 | { |
| 2150 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2151 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2152 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2153 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2154 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2155 | runloop.Run(); |
| 2156 | } |
| 2157 | |
| 2158 | { |
| 2159 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2160 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2161 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2162 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2163 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2164 | runloop.Run(); |
| 2165 | } |
| 2166 | |
| 2167 | update_client->RemoveObserver(&observer); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2168 | } |
| 2169 | |
| 2170 | // Tests the queuing of update checks. In this scenario, two update checks are |
| 2171 | // done for one CRX. The second update check call is queued up and will run |
| 2172 | // after the first check has completed. The CRX has no updates. |
| 2173 | TEST_F(UpdateClientTest, OneCrxNoUpdateQueuedCall) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2174 | class DataCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2175 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2176 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 2177 | const std::vector<std::string>& ids) { |
| 2178 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 2179 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2180 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2181 | crx->version = base::Version("0.9"); |
| 2182 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 2183 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 2184 | component.push_back(std::move(crx)); |
| 2185 | return component; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2186 | } |
| 2187 | }; |
| 2188 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2189 | class CompletionCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2190 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2191 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2192 | static int num_call = 0; |
| 2193 | ++num_call; |
| 2194 | |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2195 | EXPECT_EQ(Error::NONE, error); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2196 | |
| 2197 | if (num_call == 2) |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2198 | std::move(quit_closure).Run(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2199 | } |
| 2200 | }; |
| 2201 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2202 | class MockUpdateChecker : public UpdateChecker { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2203 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2204 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2205 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2206 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2207 | return std::make_unique<MockUpdateChecker>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2208 | } |
| 2209 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2210 | void CheckForUpdates(const std::string& session_id, |
| 2211 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2212 | const IdToComponentPtrMap& components, |
| 2213 | const std::string& additional_attributes, |
| 2214 | bool enabled_component_updates, |
| 2215 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2216 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2217 | EXPECT_TRUE(enabled_component_updates); |
| 2218 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2219 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2220 | EXPECT_EQ(id, ids_to_check.front()); |
| 2221 | EXPECT_EQ(1u, components.count(id)); |
| 2222 | |
| 2223 | auto& component = components.at(id); |
| 2224 | |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2225 | EXPECT_FALSE(component->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2226 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2227 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2228 | result.extension_id = id; |
| 2229 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2230 | ProtocolParser::Results results; |
| 2231 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2232 | |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2233 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2234 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2235 | ErrorCategory::kNone, 0, 0)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2236 | } |
| 2237 | }; |
| 2238 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2239 | class MockCrxDownloader : public CrxDownloader { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2240 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2241 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2242 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2243 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2244 | return std::make_unique<MockCrxDownloader>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2245 | } |
| 2246 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2247 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2248 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2249 | private: |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2250 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 2251 | }; |
| 2252 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2253 | class MockPingManager : public MockPingManagerImpl { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2254 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2255 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2256 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2257 | |
| 2258 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2259 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2260 | }; |
| 2261 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2262 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2263 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2264 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2265 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2266 | |
| 2267 | MockObserver observer; |
| 2268 | InSequence seq; |
| 2269 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2270 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2271 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2272 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2273 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2274 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2275 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2276 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2277 | |
| 2278 | update_client->AddObserver(&observer); |
| 2279 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2280 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2281 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2282 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 2283 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2284 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2285 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 2286 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2287 | |
| 2288 | RunThreads(); |
| 2289 | |
| 2290 | update_client->RemoveObserver(&observer); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2291 | } |
| 2292 | |
| 2293 | // Tests the install of one CRX. |
| 2294 | TEST_F(UpdateClientTest, OneCrxInstall) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2295 | class DataCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2296 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2297 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 2298 | const std::vector<std::string>& ids) { |
| 2299 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 2300 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2301 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2302 | crx->version = base::Version("0.0"); |
| 2303 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2304 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2305 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 2306 | component.push_back(std::move(crx)); |
| 2307 | return component; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2308 | } |
| 2309 | }; |
| 2310 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2311 | class CompletionCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2312 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2313 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2314 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2315 | std::move(quit_closure).Run(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2316 | } |
| 2317 | }; |
| 2318 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2319 | class MockUpdateChecker : public UpdateChecker { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2320 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2321 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2322 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2323 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2324 | return std::make_unique<MockUpdateChecker>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2325 | } |
| 2326 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2327 | void CheckForUpdates(const std::string& session_id, |
| 2328 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2329 | const IdToComponentPtrMap& components, |
| 2330 | const std::string& additional_attributes, |
| 2331 | bool enabled_component_updates, |
| 2332 | UpdateCheckCallback update_check_callback) override { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2333 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2334 | Mock the following response: |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2335 | |
| 2336 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 2337 | <response protocol='3.1'> |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2338 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 2339 | <updatecheck status='ok'> |
| 2340 | <urls> |
| 2341 | <url codebase='http://localhost/download/'/> |
| 2342 | </urls> |
| 2343 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 2344 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2345 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 2346 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 2347 | 7c9b12cb7cc067667bde87'/> |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2348 | </packages> |
| 2349 | </manifest> |
| 2350 | </updatecheck> |
| 2351 | </app> |
| 2352 | </response> |
| 2353 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2354 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2355 | EXPECT_TRUE(enabled_component_updates); |
| 2356 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2357 | |
| 2358 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2359 | EXPECT_EQ(id, ids_to_check[0]); |
| 2360 | EXPECT_EQ(1u, components.count(id)); |
| 2361 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2362 | ProtocolParser::Result::Manifest::Package package; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2363 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2364 | package.hash_sha256 = |
| 2365 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2366 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2367 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2368 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 2369 | result.status = "ok"; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2370 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 2371 | result.manifest.version = "1.0"; |
| 2372 | result.manifest.browser_min_version = "11.0.1.0"; |
| 2373 | result.manifest.packages.push_back(package); |
| 2374 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2375 | ProtocolParser::Results results; |
| 2376 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2377 | |
| 2378 | // Verify that calling Install sets ondemand. |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2379 | EXPECT_TRUE(components.at(id)->is_foreground()); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2380 | |
| 2381 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2382 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2383 | ErrorCategory::kNone, 0, 0)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2384 | } |
| 2385 | }; |
| 2386 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2387 | class MockCrxDownloader : public CrxDownloader { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2388 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2389 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2390 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2391 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2392 | return std::make_unique<MockCrxDownloader>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2393 | } |
| 2394 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2395 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2396 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2397 | private: |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2398 | void DoStartDownload(const GURL& url) override { |
| 2399 | DownloadMetrics download_metrics; |
| 2400 | FilePath path; |
| 2401 | Result result; |
| 2402 | if (url.path() == "/download/jebgalgnebhfojomionfpkfelancnnkf.crx") { |
| 2403 | download_metrics.url = url; |
| 2404 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2405 | download_metrics.error = 0; |
| 2406 | download_metrics.downloaded_bytes = 1843; |
| 2407 | download_metrics.total_bytes = 1843; |
| 2408 | download_metrics.download_time_ms = 1000; |
| 2409 | |
| 2410 | EXPECT_TRUE(MakeTestFile( |
| 2411 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 2412 | |
| 2413 | result.error = 0; |
| 2414 | result.response = path; |
| 2415 | result.downloaded_bytes = 1843; |
| 2416 | result.total_bytes = 1843; |
| 2417 | } else { |
| 2418 | NOTREACHED(); |
| 2419 | } |
| 2420 | |
| 2421 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2422 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 2423 | base::Unretained(this), result)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2424 | |
| 2425 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2426 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 2427 | base::Unretained(this), true, result, |
| 2428 | download_metrics)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2429 | } |
| 2430 | }; |
| 2431 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2432 | class MockPingManager : public MockPingManagerImpl { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2433 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2434 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2435 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2436 | |
| 2437 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2438 | ~MockPingManager() override { |
| 2439 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2440 | EXPECT_EQ(1u, ping_data.size()); |
| 2441 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 2442 | EXPECT_EQ(base::Version("0.0"), ping_data[0].previous_version); |
| 2443 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2444 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2445 | EXPECT_EQ(0, ping_data[0].error_code); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2446 | } |
| 2447 | }; |
| 2448 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2449 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2450 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2451 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2452 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2453 | |
| 2454 | MockObserver observer; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2455 | InSequence seq; |
| 2456 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2457 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2458 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2459 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2460 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2461 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2462 | .Times(AtLeast(1)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2463 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2464 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2465 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 2466 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2467 | |
| 2468 | update_client->AddObserver(&observer); |
| 2469 | |
| 2470 | update_client->Install( |
| 2471 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2472 | base::BindOnce(&DataCallbackMock::Callback), |
| 2473 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2474 | |
| 2475 | RunThreads(); |
| 2476 | |
| 2477 | update_client->RemoveObserver(&observer); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2478 | } |
| 2479 | |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2480 | // Tests the install of one CRX when no component data is provided. This |
| 2481 | // results in an install error. |
| 2482 | TEST_F(UpdateClientTest, OneCrxInstallNoCrxComponentData) { |
| 2483 | class DataCallbackMock { |
| 2484 | public: |
| 2485 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 2486 | const std::vector<std::string>& ids) { |
| 2487 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 2488 | component.push_back(nullptr); |
| 2489 | return component; |
| 2490 | } |
| 2491 | }; |
| 2492 | |
| 2493 | class CompletionCallbackMock { |
| 2494 | public: |
| 2495 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 2496 | EXPECT_EQ(Error::NONE, error); |
| 2497 | std::move(quit_closure).Run(); |
| 2498 | } |
| 2499 | }; |
| 2500 | |
| 2501 | class MockUpdateChecker : public UpdateChecker { |
| 2502 | public: |
| 2503 | static std::unique_ptr<UpdateChecker> Create( |
| 2504 | scoped_refptr<Configurator> config, |
| 2505 | PersistedData* metadata) { |
| 2506 | return std::make_unique<MockUpdateChecker>(); |
| 2507 | } |
| 2508 | |
| 2509 | void CheckForUpdates(const std::string& session_id, |
| 2510 | const std::vector<std::string>& ids_to_check, |
| 2511 | const IdToComponentPtrMap& components, |
| 2512 | const std::string& additional_attributes, |
| 2513 | bool enabled_component_updates, |
| 2514 | UpdateCheckCallback update_check_callback) override { |
| 2515 | NOTREACHED(); |
| 2516 | } |
| 2517 | }; |
| 2518 | |
| 2519 | class MockCrxDownloader : public CrxDownloader { |
| 2520 | public: |
| 2521 | static std::unique_ptr<CrxDownloader> Create( |
| 2522 | bool is_background_download, |
| 2523 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
| 2524 | return std::make_unique<MockCrxDownloader>(); |
| 2525 | } |
| 2526 | |
| 2527 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 2528 | |
| 2529 | private: |
| 2530 | void DoStartDownload(const GURL& url) override { NOTREACHED(); } |
| 2531 | }; |
| 2532 | |
| 2533 | class MockPingManager : public MockPingManagerImpl { |
| 2534 | public: |
| 2535 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2536 | : MockPingManagerImpl(config) {} |
| 2537 | |
| 2538 | protected: |
| 2539 | ~MockPingManager() override { |
| 2540 | EXPECT_EQ(0u, MockPingManagerImpl::ping_data().size()); |
| 2541 | } |
| 2542 | }; |
| 2543 | |
| 2544 | scoped_refptr<UpdateClient> update_client = |
| 2545 | base::MakeRefCounted<UpdateClientImpl>( |
| 2546 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2547 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 2548 | |
| 2549 | MockObserver observer; |
| 2550 | InSequence seq; |
| 2551 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 2552 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2553 | .Times(1); |
| 2554 | |
| 2555 | update_client->AddObserver(&observer); |
| 2556 | |
| 2557 | update_client->Install( |
| 2558 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
| 2559 | base::BindOnce(&DataCallbackMock::Callback), |
| 2560 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
| 2561 | |
| 2562 | RunThreads(); |
| 2563 | |
| 2564 | update_client->RemoveObserver(&observer); |
| 2565 | } |
| 2566 | |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2567 | // Tests that overlapping installs of the same CRX result in an error. |
| 2568 | TEST_F(UpdateClientTest, ConcurrentInstallSameCRX) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2569 | class DataCallbackMock { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2570 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2571 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 2572 | const std::vector<std::string>& ids) { |
| 2573 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 2574 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2575 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2576 | crx->version = base::Version("0.0"); |
| 2577 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 2578 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 2579 | component.push_back(std::move(crx)); |
| 2580 | return component; |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2581 | } |
| 2582 | }; |
| 2583 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2584 | class CompletionCallbackMock { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2585 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2586 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2587 | static int num_call = 0; |
| 2588 | ++num_call; |
| 2589 | |
| 2590 | EXPECT_LE(num_call, 2); |
| 2591 | |
| 2592 | if (num_call == 1) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2593 | EXPECT_EQ(Error::UPDATE_IN_PROGRESS, error); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2594 | return; |
| 2595 | } |
| 2596 | if (num_call == 2) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2597 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2598 | std::move(quit_closure).Run(); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2599 | } |
| 2600 | } |
| 2601 | }; |
| 2602 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2603 | class MockUpdateChecker : public UpdateChecker { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2604 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2605 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2606 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2607 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2608 | return std::make_unique<MockUpdateChecker>(); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2609 | } |
| 2610 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2611 | void CheckForUpdates(const std::string& session_id, |
| 2612 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2613 | const IdToComponentPtrMap& components, |
| 2614 | const std::string& additional_attributes, |
| 2615 | bool enabled_component_updates, |
| 2616 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2617 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2618 | EXPECT_TRUE(enabled_component_updates); |
| 2619 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2620 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2621 | EXPECT_EQ(id, ids_to_check.front()); |
| 2622 | EXPECT_EQ(1u, components.count(id)); |
| 2623 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2624 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2625 | result.extension_id = id; |
| 2626 | result.status = "noupdate"; |
| 2627 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2628 | ProtocolParser::Results results; |
| 2629 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2630 | |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2631 | // Verify that calling Install sets |is_foreground| for the component. |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2632 | EXPECT_TRUE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2633 | |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2634 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2635 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2636 | ErrorCategory::kNone, 0, 0)); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2637 | } |
| 2638 | }; |
| 2639 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2640 | class MockCrxDownloader : public CrxDownloader { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2641 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2642 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2643 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2644 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2645 | return std::make_unique<MockCrxDownloader>(); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2646 | } |
| 2647 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2648 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2649 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2650 | private: |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2651 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 2652 | }; |
| 2653 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2654 | class MockPingManager : public MockPingManagerImpl { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2655 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2656 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2657 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2658 | |
| 2659 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2660 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2661 | }; |
| 2662 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2663 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2664 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2665 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2666 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2667 | |
| 2668 | MockObserver observer; |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2669 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2670 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2671 | .Times(1); |
| 2672 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2673 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2674 | .Times(1); |
| 2675 | |
| 2676 | update_client->AddObserver(&observer); |
| 2677 | |
| 2678 | update_client->Install( |
| 2679 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2680 | base::BindOnce(&DataCallbackMock::Callback), |
| 2681 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2682 | |
| 2683 | update_client->Install( |
| 2684 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2685 | base::BindOnce(&DataCallbackMock::Callback), |
| 2686 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2687 | |
| 2688 | RunThreads(); |
| 2689 | |
| 2690 | update_client->RemoveObserver(&observer); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2691 | } |
| 2692 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2693 | // Tests that UpdateClient::Update returns Error::INVALID_ARGUMENT when |
| 2694 | // the |ids| parameter is empty. |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2695 | TEST_F(UpdateClientTest, EmptyIdList) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2696 | class DataCallbackMock { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2697 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2698 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 2699 | const std::vector<std::string>& ids) { |
| 2700 | return {}; |
| 2701 | } |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2702 | }; |
| 2703 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2704 | class CompletionCallbackMock { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2705 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2706 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2707 | DCHECK_EQ(Error::INVALID_ARGUMENT, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2708 | std::move(quit_closure).Run(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2709 | } |
| 2710 | }; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2711 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2712 | class MockUpdateChecker : public UpdateChecker { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2713 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2714 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2715 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2716 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2717 | return std::make_unique<MockUpdateChecker>(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2718 | } |
| 2719 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2720 | void CheckForUpdates(const std::string& session_id, |
| 2721 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2722 | const IdToComponentPtrMap& components, |
| 2723 | const std::string& additional_attributes, |
| 2724 | bool enabled_component_updates, |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2725 | UpdateCheckCallback update_check_callback) override { |
| 2726 | NOTREACHED(); |
| 2727 | } |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2728 | }; |
| 2729 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2730 | class MockCrxDownloader : public CrxDownloader { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2731 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2732 | static std::unique_ptr<CrxDownloader> Create( |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2733 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2734 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2735 | return std::make_unique<MockCrxDownloader>(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2736 | } |
| 2737 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2738 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2739 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2740 | private: |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2741 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 2742 | }; |
| 2743 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2744 | class MockPingManager : public MockPingManagerImpl { |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2745 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2746 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2747 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2748 | |
| 2749 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2750 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2751 | }; |
| 2752 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2753 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2754 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2755 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2756 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2757 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2758 | const std::vector<std::string> empty_id_list; |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2759 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2760 | empty_id_list, base::BindOnce(&DataCallbackMock::Callback), false, |
| 2761 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2762 | RunThreads(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 2763 | } |
| 2764 | |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2765 | TEST_F(UpdateClientTest, SendUninstallPing) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2766 | class CompletionCallbackMock { |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 2767 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2768 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 2769 | std::move(quit_closure).Run(); |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 2770 | } |
| 2771 | }; |
| 2772 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2773 | class MockUpdateChecker : public UpdateChecker { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2774 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2775 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2776 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2777 | PersistedData* metadata) { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2778 | return nullptr; |
| 2779 | } |
| 2780 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2781 | void CheckForUpdates(const std::string& session_id, |
| 2782 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2783 | const IdToComponentPtrMap& components, |
| 2784 | const std::string& additional_attributes, |
| 2785 | bool enabled_component_updates, |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2786 | UpdateCheckCallback update_check_callback) override { |
| 2787 | NOTREACHED(); |
| 2788 | } |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2789 | }; |
| 2790 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2791 | class MockCrxDownloader : public CrxDownloader { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2792 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2793 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2794 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2795 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2796 | return nullptr; |
| 2797 | } |
| 2798 | |
| 2799 | private: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2800 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 2801 | ~MockCrxDownloader() override {} |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2802 | |
| 2803 | void DoStartDownload(const GURL& url) override {} |
| 2804 | }; |
| 2805 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2806 | class MockPingManager : public MockPingManagerImpl { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2807 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2808 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2809 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2810 | |
| 2811 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2812 | ~MockPingManager() override { |
| 2813 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2814 | EXPECT_EQ(1u, ping_data.size()); |
| 2815 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
Minh X. Nguyen | 01d3586d | 2018-01-03 21:53:39 | [diff] [blame] | 2816 | EXPECT_EQ(base::Version("1.2.3.4"), ping_data[0].previous_version); |
| 2817 | EXPECT_EQ(base::Version("0"), ping_data[0].next_version); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2818 | EXPECT_EQ(10, ping_data[0].extra_code1); |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2819 | } |
| 2820 | }; |
| 2821 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2822 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2823 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2824 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2825 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2826 | |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 2827 | update_client->SendUninstallPing( |
Minh X. Nguyen | 01d3586d | 2018-01-03 21:53:39 | [diff] [blame] | 2828 | "jebgalgnebhfojomionfpkfelancnnkf", base::Version("1.2.3.4"), 10, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2829 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 2830 | |
| 2831 | RunThreads(); |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 2832 | } |
| 2833 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2834 | TEST_F(UpdateClientTest, RetryAfter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2835 | class DataCallbackMock { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2836 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2837 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 2838 | const std::vector<std::string>& ids) { |
| 2839 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 2840 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2841 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2842 | crx->version = base::Version("0.9"); |
| 2843 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 2844 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 2845 | component.push_back(std::move(crx)); |
| 2846 | return component; |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2847 | } |
| 2848 | }; |
| 2849 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2850 | class CompletionCallbackMock { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2851 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2852 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2853 | static int num_call = 0; |
| 2854 | ++num_call; |
| 2855 | |
| 2856 | EXPECT_LE(num_call, 4); |
| 2857 | |
| 2858 | if (num_call == 1) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2859 | EXPECT_EQ(Error::NONE, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2860 | } else if (num_call == 2) { |
| 2861 | // This request is throttled since the update engine received a |
| 2862 | // positive |retry_after_sec| value in the update check response. |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2863 | EXPECT_EQ(Error::RETRY_LATER, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2864 | } else if (num_call == 3) { |
| 2865 | // This request is a foreground Install, which is never throttled. |
| 2866 | // The update engine received a |retry_after_sec| value of 0, which |
| 2867 | // resets the throttling. |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2868 | EXPECT_EQ(Error::NONE, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2869 | } else if (num_call == 4) { |
| 2870 | // This request succeeds since there is no throttling in effect. |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2871 | EXPECT_EQ(Error::NONE, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2872 | } |
| 2873 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2874 | std::move(quit_closure).Run(); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2875 | } |
| 2876 | }; |
| 2877 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2878 | class MockUpdateChecker : public UpdateChecker { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2879 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2880 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2881 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2882 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2883 | return std::make_unique<MockUpdateChecker>(); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2884 | } |
| 2885 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2886 | void CheckForUpdates(const std::string& session_id, |
| 2887 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2888 | const IdToComponentPtrMap& components, |
| 2889 | const std::string& additional_attributes, |
| 2890 | bool enabled_component_updates, |
| 2891 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2892 | EXPECT_FALSE(session_id.empty()); |
| 2893 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2894 | static int num_call = 0; |
| 2895 | ++num_call; |
| 2896 | |
| 2897 | EXPECT_LE(num_call, 3); |
| 2898 | |
| 2899 | int retry_after_sec(0); |
| 2900 | if (num_call == 1) { |
| 2901 | // Throttle the next call. |
| 2902 | retry_after_sec = 60 * 60; // 1 hour. |
| 2903 | } |
| 2904 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2905 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2906 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2907 | EXPECT_EQ(id, ids_to_check.front()); |
| 2908 | EXPECT_EQ(1u, components.count(id)); |
| 2909 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2910 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2911 | result.extension_id = id; |
| 2912 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2913 | |
| 2914 | ProtocolParser::Results results; |
| 2915 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2916 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2917 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2918 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2919 | ErrorCategory::kNone, 0, retry_after_sec)); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2920 | } |
| 2921 | }; |
| 2922 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2923 | class MockCrxDownloader : public CrxDownloader { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2924 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2925 | static std::unique_ptr<CrxDownloader> Create( |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2926 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 2927 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2928 | return std::make_unique<MockCrxDownloader>(); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2929 | } |
| 2930 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2931 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2932 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2933 | private: |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2934 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 2935 | }; |
| 2936 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2937 | class MockPingManager : public MockPingManagerImpl { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2938 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2939 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2940 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2941 | |
| 2942 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2943 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2944 | }; |
| 2945 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2946 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2947 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2948 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2949 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2950 | |
| 2951 | MockObserver observer; |
| 2952 | |
| 2953 | InSequence seq; |
| 2954 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2955 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2956 | .Times(1); |
| 2957 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2958 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2959 | .Times(1); |
| 2960 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2961 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2962 | .Times(1); |
| 2963 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2964 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2965 | .Times(1); |
| 2966 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2967 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2968 | .Times(1); |
| 2969 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2970 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2971 | .Times(1); |
| 2972 | |
| 2973 | update_client->AddObserver(&observer); |
| 2974 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2975 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2976 | { |
| 2977 | // The engine handles this Update call but responds with a valid |
| 2978 | // |retry_after_sec|, which causes subsequent calls to fail. |
| 2979 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2980 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2981 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2982 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2983 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2984 | runloop.Run(); |
| 2985 | } |
| 2986 | |
| 2987 | { |
| 2988 | // This call will result in a completion callback invoked with |
| 2989 | // Error::ERROR_UPDATE_RETRY_LATER. |
| 2990 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2991 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2992 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2993 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2994 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 2995 | runloop.Run(); |
| 2996 | } |
| 2997 | |
| 2998 | { |
| 2999 | // The Install call is handled, and the throttling is reset due to |
| 3000 | // the value of |retry_after_sec| in the completion callback. |
| 3001 | base::RunLoop runloop; |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3002 | update_client->Install(std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3003 | base::BindOnce(&DataCallbackMock::Callback), |
| 3004 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3005 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3006 | runloop.Run(); |
| 3007 | } |
| 3008 | |
| 3009 | { |
| 3010 | // This call succeeds. |
| 3011 | base::RunLoop runloop; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3012 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 3013 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3014 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3015 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3016 | runloop.Run(); |
| 3017 | } |
| 3018 | |
| 3019 | update_client->RemoveObserver(&observer); |
| 3020 | } |
| 3021 | |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3022 | // Tests the update check for two CRXs scenario. The first component supports |
| 3023 | // the group policy to enable updates, and has its updates disabled. The second |
| 3024 | // component has an update. The server does not honor the "updatedisabled" |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3025 | // attribute and returns updates for both components. However, the update for |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3026 | // the first component is not applied and the client responds with a |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3027 | // (SERVICE_ERROR, UPDATE_DISABLED) |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3028 | TEST_F(UpdateClientTest, TwoCrxUpdateOneUpdateDisabled) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3029 | class DataCallbackMock { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3030 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3031 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 3032 | const std::vector<std::string>& ids) { |
| 3033 | std::unique_ptr<CrxComponent> crx1 = std::make_unique<CrxComponent>(); |
| 3034 | crx1->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 3035 | crx1->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3036 | crx1->version = base::Version("0.9"); |
| 3037 | crx1->installer = base::MakeRefCounted<TestInstaller>(); |
| 3038 | crx1->supports_group_policy_enable_component_updates = true; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3039 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3040 | std::unique_ptr<CrxComponent> crx2 = std::make_unique<CrxComponent>(); |
| 3041 | crx2->name = "test_ihfo"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 3042 | crx2->pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3043 | crx2->version = base::Version("0.8"); |
| 3044 | crx2->installer = base::MakeRefCounted<TestInstaller>(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3045 | |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3046 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 3047 | component.push_back(std::move(crx1)); |
| 3048 | component.push_back(std::move(crx2)); |
| 3049 | return component; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3050 | } |
| 3051 | }; |
| 3052 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3053 | class CompletionCallbackMock { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3054 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3055 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 3056 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3057 | std::move(quit_closure).Run(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3058 | } |
| 3059 | }; |
| 3060 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3061 | class MockUpdateChecker : public UpdateChecker { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3062 | public: |
| 3063 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3064 | scoped_refptr<Configurator> config, |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3065 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3066 | return std::make_unique<MockUpdateChecker>(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3067 | } |
| 3068 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3069 | void CheckForUpdates(const std::string& session_id, |
| 3070 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3071 | const IdToComponentPtrMap& components, |
| 3072 | const std::string& additional_attributes, |
| 3073 | bool enabled_component_updates, |
| 3074 | UpdateCheckCallback update_check_callback) override { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3075 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3076 | Mock the following response: |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3077 | |
| 3078 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 3079 | <response protocol='3.1'> |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3080 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 3081 | <updatecheck status='ok'> |
| 3082 | <urls> |
| 3083 | <url codebase='http://localhost/download/'/> |
| 3084 | </urls> |
| 3085 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 3086 | <packages> |
| 3087 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
| 3088 | hash_sha256='6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd |
| 3089 | 7c9b12cb7cc067667bde87'/> |
| 3090 | </packages> |
| 3091 | </manifest> |
| 3092 | </updatecheck> |
| 3093 | </app> |
| 3094 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 3095 | <updatecheck status='ok'> |
| 3096 | <urls> |
| 3097 | <url codebase='http://localhost/download/'/> |
| 3098 | </urls> |
| 3099 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 3100 | <packages> |
| 3101 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
| 3102 | hash_sha256='813c59747e139a608b3b5fc49633affc6db574373f |
| 3103 | 309f156ea6d27229c0b3f9'/> |
| 3104 | </packages> |
| 3105 | </manifest> |
| 3106 | </updatecheck> |
| 3107 | </app> |
| 3108 | </response> |
| 3109 | */ |
sorin | 590921d | 2016-08-11 23:48:36 | [diff] [blame] | 3110 | |
| 3111 | // UpdateClient reads the state of |enabled_component_updates| from the |
| 3112 | // configurator instance, persists its value in the corresponding |
| 3113 | // update context, and propagates it down to each of the update actions, |
| 3114 | // and further down to the UpdateChecker instance. |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3115 | EXPECT_FALSE(session_id.empty()); |
sorin | 590921d | 2016-08-11 23:48:36 | [diff] [blame] | 3116 | EXPECT_FALSE(enabled_component_updates); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3117 | EXPECT_EQ(2u, ids_to_check.size()); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3118 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3119 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3120 | { |
| 3121 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 3122 | EXPECT_EQ(id, ids_to_check[0]); |
| 3123 | EXPECT_EQ(1u, components.count(id)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3124 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3125 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3126 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 3127 | package.hash_sha256 = |
| 3128 | "6fc4b93fd11134de1300c2c0bb88c12b644a4ec0fd7c9b12cb7cc067667bde87"; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3129 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3130 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3131 | result.extension_id = id; |
| 3132 | result.status = "ok"; |
| 3133 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 3134 | result.manifest.version = "1.0"; |
| 3135 | result.manifest.browser_min_version = "11.0.1.0"; |
| 3136 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3137 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3138 | } |
| 3139 | |
| 3140 | { |
| 3141 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 3142 | EXPECT_EQ(id, ids_to_check[1]); |
| 3143 | EXPECT_EQ(1u, components.count(id)); |
| 3144 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3145 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3146 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
| 3147 | package.hash_sha256 = |
| 3148 | "813c59747e139a608b3b5fc49633affc6db574373f309f156ea6d27229c0b3f9"; |
| 3149 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3150 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3151 | result.extension_id = id; |
| 3152 | result.status = "ok"; |
| 3153 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 3154 | result.manifest.version = "1.0"; |
| 3155 | result.manifest.browser_min_version = "11.0.1.0"; |
| 3156 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3157 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3158 | } |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3159 | |
| 3160 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3161 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 3162 | ErrorCategory::kNone, 0, 0)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3163 | } |
| 3164 | }; |
| 3165 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3166 | class MockCrxDownloader : public CrxDownloader { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3167 | public: |
| 3168 | static std::unique_ptr<CrxDownloader> Create( |
| 3169 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 3170 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3171 | return std::make_unique<MockCrxDownloader>(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3172 | } |
| 3173 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3174 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3175 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3176 | private: |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3177 | void DoStartDownload(const GURL& url) override { |
| 3178 | DownloadMetrics download_metrics; |
| 3179 | FilePath path; |
| 3180 | Result result; |
| 3181 | if (url.path() == "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 3182 | download_metrics.url = url; |
| 3183 | download_metrics.downloader = DownloadMetrics::kNone; |
| 3184 | download_metrics.error = 0; |
| 3185 | download_metrics.downloaded_bytes = 53638; |
| 3186 | download_metrics.total_bytes = 53638; |
| 3187 | download_metrics.download_time_ms = 2000; |
| 3188 | |
| 3189 | EXPECT_TRUE(MakeTestFile( |
| 3190 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 3191 | |
| 3192 | result.error = 0; |
| 3193 | result.response = path; |
| 3194 | result.downloaded_bytes = 53638; |
| 3195 | result.total_bytes = 53638; |
| 3196 | } else { |
| 3197 | NOTREACHED(); |
| 3198 | } |
| 3199 | |
| 3200 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3201 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 3202 | base::Unretained(this), result)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3203 | |
| 3204 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3205 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 3206 | base::Unretained(this), true, result, |
| 3207 | download_metrics)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3208 | } |
| 3209 | }; |
| 3210 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3211 | class MockPingManager : public MockPingManagerImpl { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3212 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3213 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3214 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3215 | |
| 3216 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3217 | ~MockPingManager() override { |
| 3218 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3219 | EXPECT_EQ(2u, ping_data.size()); |
| 3220 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 3221 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 3222 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 3223 | EXPECT_EQ(4, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3224 | EXPECT_EQ(2, ping_data[0].error_code); |
| 3225 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 3226 | EXPECT_EQ(base::Version("0.8"), ping_data[1].previous_version); |
| 3227 | EXPECT_EQ(base::Version("1.0"), ping_data[1].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 3228 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3229 | EXPECT_EQ(0, ping_data[1].error_code); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3230 | } |
| 3231 | }; |
| 3232 | |
| 3233 | // Disables updates for the components declaring support for the group policy. |
| 3234 | config()->SetEnabledComponentUpdates(false); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3235 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3236 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3237 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3238 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3239 | |
| 3240 | MockObserver observer; |
| 3241 | { |
| 3242 | InSequence seq; |
| 3243 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3244 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3245 | .Times(1); |
| 3246 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 3247 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3248 | .Times(1); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 3249 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3250 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3251 | .Times(1); |
| 3252 | } |
| 3253 | { |
| 3254 | InSequence seq; |
| 3255 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3256 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3257 | .Times(1); |
| 3258 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 3259 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3260 | .Times(1); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3261 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
| 3262 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3263 | .Times(AtLeast(1)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3264 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 3265 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3266 | .Times(1); |
| 3267 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 3268 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3269 | .Times(1); |
| 3270 | } |
| 3271 | |
| 3272 | update_client->AddObserver(&observer); |
| 3273 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3274 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 3275 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3276 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3277 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 3278 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3279 | |
| 3280 | RunThreads(); |
| 3281 | |
| 3282 | update_client->RemoveObserver(&observer); |
| 3283 | } |
| 3284 | |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3285 | // Tests the scenario where the update check fails. |
| 3286 | TEST_F(UpdateClientTest, OneCrxUpdateCheckFails) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3287 | class DataCallbackMock { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3288 | public: |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3289 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 3290 | const std::vector<std::string>& ids) { |
| 3291 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 3292 | crx->name = "test_jebg"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 3293 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3294 | crx->version = base::Version("0.9"); |
| 3295 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 3296 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 3297 | component.push_back(std::move(crx)); |
| 3298 | return component; |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3299 | } |
| 3300 | }; |
| 3301 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3302 | class CompletionCallbackMock { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3303 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3304 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3305 | EXPECT_EQ(Error::UPDATE_CHECK_ERROR, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3306 | std::move(quit_closure).Run(); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3307 | } |
| 3308 | }; |
| 3309 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3310 | class MockUpdateChecker : public UpdateChecker { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3311 | public: |
| 3312 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3313 | scoped_refptr<Configurator> config, |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3314 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3315 | return std::make_unique<MockUpdateChecker>(); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3316 | } |
| 3317 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3318 | void CheckForUpdates(const std::string& session_id, |
| 3319 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3320 | const IdToComponentPtrMap& components, |
| 3321 | const std::string& additional_attributes, |
| 3322 | bool enabled_component_updates, |
| 3323 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3324 | EXPECT_FALSE(session_id.empty()); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3325 | EXPECT_TRUE(enabled_component_updates); |
| 3326 | EXPECT_EQ(1u, ids_to_check.size()); |
| 3327 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 3328 | EXPECT_EQ(id, ids_to_check.front()); |
| 3329 | EXPECT_EQ(1u, components.count(id)); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3330 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3331 | FROM_HERE, |
| 3332 | base::BindOnce(std::move(update_check_callback), base::nullopt, |
| 3333 | ErrorCategory::kUpdateCheck, -1, 0)); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3334 | } |
| 3335 | }; |
| 3336 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3337 | class MockCrxDownloader : public CrxDownloader { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3338 | public: |
| 3339 | static std::unique_ptr<CrxDownloader> Create( |
| 3340 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 3341 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3342 | return std::make_unique<MockCrxDownloader>(); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3343 | } |
| 3344 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3345 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3346 | |
| 3347 | private: |
| 3348 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3349 | }; |
| 3350 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3351 | class MockPingManager : public MockPingManagerImpl { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3352 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3353 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3354 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3355 | |
| 3356 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3357 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3358 | }; |
| 3359 | |
| 3360 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3361 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3362 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3363 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3364 | |
| 3365 | MockObserver observer; |
| 3366 | InSequence seq; |
| 3367 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3368 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3369 | .Times(1); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 3370 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3371 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3372 | .Times(1) |
| 3373 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3374 | CrxUpdateItem item; |
| 3375 | update_client->GetCrxUpdateState(id, &item); |
| 3376 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 3377 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
Sorin Jianu | afcb70dd | 2018-05-16 20:14:15 | [diff] [blame] | 3378 | EXPECT_EQ(-1, item.error_code); |
| 3379 | EXPECT_EQ(0, item.extra_code1); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3380 | })); |
| 3381 | |
| 3382 | update_client->AddObserver(&observer); |
| 3383 | |
| 3384 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
| 3385 | update_client->Update( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3386 | ids, base::BindOnce(&DataCallbackMock::Callback), false, |
| 3387 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3388 | |
| 3389 | RunThreads(); |
| 3390 | |
| 3391 | update_client->RemoveObserver(&observer); |
| 3392 | } |
| 3393 | |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3394 | // Tests the scenario where the server responds with different values for |
| 3395 | // application status. |
| 3396 | TEST_F(UpdateClientTest, OneCrxErrorUnknownApp) { |
| 3397 | class DataCallbackMock { |
| 3398 | public: |
| 3399 | static std::vector<std::unique_ptr<CrxComponent>> Callback( |
| 3400 | const std::vector<std::string>& ids) { |
| 3401 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 3402 | |
| 3403 | std::unique_ptr<CrxComponent> crx = std::make_unique<CrxComponent>(); |
| 3404 | crx->name = "test_jebg"; |
| 3405 | crx->pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 3406 | crx->version = base::Version("0.9"); |
| 3407 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 3408 | component.push_back(std::move(crx)); |
| 3409 | |
| 3410 | crx = std::make_unique<CrxComponent>(); |
| 3411 | crx->name = "test_abag"; |
| 3412 | crx->pk_hash.assign(abag_hash, abag_hash + base::size(abag_hash)); |
| 3413 | crx->version = base::Version("0.1"); |
| 3414 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 3415 | component.push_back(std::move(crx)); |
| 3416 | |
| 3417 | crx = std::make_unique<CrxComponent>(); |
| 3418 | crx->name = "test_ihfo"; |
| 3419 | crx->pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
| 3420 | crx->version = base::Version("0.2"); |
| 3421 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 3422 | component.push_back(std::move(crx)); |
| 3423 | |
| 3424 | crx = std::make_unique<CrxComponent>(); |
| 3425 | crx->name = "test_gjpm"; |
| 3426 | crx->pk_hash.assign(gjpm_hash, gjpm_hash + base::size(gjpm_hash)); |
| 3427 | crx->version = base::Version("0.3"); |
| 3428 | crx->installer = base::MakeRefCounted<TestInstaller>(); |
| 3429 | component.push_back(std::move(crx)); |
| 3430 | |
| 3431 | return component; |
| 3432 | } |
| 3433 | }; |
| 3434 | |
| 3435 | class CompletionCallbackMock { |
| 3436 | public: |
| 3437 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 3438 | EXPECT_EQ(Error::NONE, error); |
| 3439 | std::move(quit_closure).Run(); |
| 3440 | } |
| 3441 | }; |
| 3442 | |
| 3443 | class MockUpdateChecker : public UpdateChecker { |
| 3444 | public: |
| 3445 | static std::unique_ptr<UpdateChecker> Create( |
| 3446 | scoped_refptr<Configurator> config, |
| 3447 | PersistedData* metadata) { |
| 3448 | return std::make_unique<MockUpdateChecker>(); |
| 3449 | } |
| 3450 | |
| 3451 | void CheckForUpdates(const std::string& session_id, |
| 3452 | const std::vector<std::string>& ids_to_check, |
| 3453 | const IdToComponentPtrMap& components, |
| 3454 | const std::string& additional_attributes, |
| 3455 | bool enabled_component_updates, |
| 3456 | UpdateCheckCallback update_check_callback) override { |
| 3457 | EXPECT_FALSE(session_id.empty()); |
| 3458 | EXPECT_TRUE(enabled_component_updates); |
| 3459 | EXPECT_EQ(4u, ids_to_check.size()); |
| 3460 | |
| 3461 | const std::string update_response = |
| 3462 | R"(<?xml version="1.0" encoding="UTF-8"?>)" |
| 3463 | R"(<response protocol="3.1">)" |
| 3464 | R"(<app appid="jebgalgnebhfojomionfpkfelancnnkf")" |
| 3465 | R"( status="error-unknownApplication"/>)" |
| 3466 | R"(<app appid="abagagagagagagagagagagagagagagag")" |
| 3467 | R"( status="restricted"/>)" |
| 3468 | R"(<app appid="ihfokbkgjpifnbbojhneepfflplebdkc")" |
| 3469 | R"( status="error-invalidAppId"/>)" |
| 3470 | R"(<app appid="gjpmebpgbhcamgdgjcmnjfhggjpgcimm")" |
| 3471 | R"( status="error-foobarApp"/>)" |
| 3472 | R"(</response>)"; |
| 3473 | |
| 3474 | ProtocolParser parser; |
| 3475 | EXPECT_TRUE(parser.Parse(update_response)); |
| 3476 | |
| 3477 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 3478 | FROM_HERE, |
| 3479 | base::BindOnce(std::move(update_check_callback), parser.results(), |
| 3480 | ErrorCategory::kNone, 0, 0)); |
| 3481 | } |
| 3482 | }; |
| 3483 | |
| 3484 | class MockCrxDownloader : public CrxDownloader { |
| 3485 | public: |
| 3486 | static std::unique_ptr<CrxDownloader> Create( |
| 3487 | bool is_background_download, |
| 3488 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
| 3489 | return std::make_unique<MockCrxDownloader>(); |
| 3490 | } |
| 3491 | |
| 3492 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 3493 | |
| 3494 | private: |
| 3495 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3496 | }; |
| 3497 | |
| 3498 | class MockPingManager : public MockPingManagerImpl { |
| 3499 | public: |
| 3500 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3501 | : MockPingManagerImpl(config) {} |
| 3502 | |
| 3503 | protected: |
| 3504 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
| 3505 | }; |
| 3506 | |
| 3507 | scoped_refptr<UpdateClient> update_client = |
| 3508 | base::MakeRefCounted<UpdateClientImpl>( |
| 3509 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3510 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 3511 | |
| 3512 | MockObserver observer; |
| 3513 | { |
| 3514 | InSequence seq; |
| 3515 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3516 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3517 | .Times(1); |
| 3518 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3519 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3520 | .Times(1) |
| 3521 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3522 | CrxUpdateItem item; |
| 3523 | update_client->GetCrxUpdateState(id, &item); |
| 3524 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3525 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3526 | EXPECT_EQ(-10006, item.error_code); // UNKNOWN_APPPLICATION. |
| 3527 | EXPECT_EQ(0, item.extra_code1); |
| 3528 | })); |
| 3529 | } |
| 3530 | { |
| 3531 | InSequence seq; |
| 3532 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3533 | "abagagagagagagagagagagagagagagag")) |
| 3534 | .Times(1); |
| 3535 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3536 | "abagagagagagagagagagagagagagagag")) |
| 3537 | .Times(1) |
| 3538 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3539 | CrxUpdateItem item; |
| 3540 | update_client->GetCrxUpdateState(id, &item); |
| 3541 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3542 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3543 | EXPECT_EQ(-10007, item.error_code); // RESTRICTED_APPLICATION. |
| 3544 | EXPECT_EQ(0, item.extra_code1); |
| 3545 | })); |
| 3546 | } |
| 3547 | { |
| 3548 | InSequence seq; |
| 3549 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3550 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3551 | .Times(1); |
| 3552 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3553 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3554 | .Times(1) |
| 3555 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3556 | CrxUpdateItem item; |
| 3557 | update_client->GetCrxUpdateState(id, &item); |
| 3558 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3559 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3560 | EXPECT_EQ(-10008, item.error_code); // INVALID_APPID. |
| 3561 | EXPECT_EQ(0, item.extra_code1); |
| 3562 | })); |
| 3563 | } |
| 3564 | { |
| 3565 | InSequence seq; |
| 3566 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3567 | "gjpmebpgbhcamgdgjcmnjfhggjpgcimm")) |
| 3568 | .Times(1); |
| 3569 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3570 | "gjpmebpgbhcamgdgjcmnjfhggjpgcimm")) |
| 3571 | .Times(1) |
| 3572 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3573 | CrxUpdateItem item; |
| 3574 | update_client->GetCrxUpdateState(id, &item); |
| 3575 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3576 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3577 | EXPECT_EQ(-10004, item.error_code); // UPDATE_RESPONSE_NOT_FOUND. |
| 3578 | EXPECT_EQ(0, item.extra_code1); |
| 3579 | })); |
| 3580 | } |
| 3581 | |
| 3582 | update_client->AddObserver(&observer); |
| 3583 | |
| 3584 | const std::vector<std::string> ids = { |
| 3585 | "jebgalgnebhfojomionfpkfelancnnkf", "abagagagagagagagagagagagagagagag", |
| 3586 | "ihfokbkgjpifnbbojhneepfflplebdkc", "gjpmebpgbhcamgdgjcmnjfhggjpgcimm"}; |
| 3587 | update_client->Update( |
| 3588 | ids, base::BindOnce(&DataCallbackMock::Callback), true, |
| 3589 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
| 3590 | |
| 3591 | RunThreads(); |
| 3592 | |
| 3593 | update_client->RemoveObserver(&observer); |
| 3594 | } |
| 3595 | |
Sorin Jianu | 7b00a13 | 2017-06-19 21:56:54 | [diff] [blame] | 3596 | #if defined(OS_WIN) // ActionRun is only implemented on Windows. |
| 3597 | |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3598 | // Tests that a run action in invoked in the CRX install scenario. |
| 3599 | TEST_F(UpdateClientTest, ActionRun_Install) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3600 | class MockUpdateChecker : public UpdateChecker { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3601 | public: |
| 3602 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3603 | scoped_refptr<Configurator> config, |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3604 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3605 | return std::make_unique<MockUpdateChecker>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3606 | } |
| 3607 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3608 | void CheckForUpdates(const std::string& session_id, |
| 3609 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3610 | const IdToComponentPtrMap& components, |
| 3611 | const std::string& additional_attributes, |
| 3612 | bool enabled_component_updates, |
| 3613 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3614 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3615 | Mock the following response: |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3616 | |
| 3617 | <?xml version='1.0' encoding='UTF-8'?> |
| 3618 | <response protocol='3.1'> |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3619 | <app appid='gjpmebpgbhcamgdgjcmnjfhggjpgcimm'> |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3620 | <updatecheck status='ok'> |
| 3621 | <urls> |
| 3622 | <url codebase='http://localhost/download/'/> |
| 3623 | </urls> |
| 3624 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 3625 | <packages> |
| 3626 | <package name='runaction_test_win.crx3' |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3627 | hash_sha256='89290a0d2ff21ca5b45e109c6cc859ab5fe294e19c102d54acd321429c372cea'/> |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3628 | </packages> |
| 3629 | </manifest> |
| 3630 | <actions>" |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3631 | <action run='ChromeRecovery.crx3'/>" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3632 | </actions>" |
| 3633 | </updatecheck> |
| 3634 | </app> |
| 3635 | </response> |
| 3636 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3637 | EXPECT_FALSE(session_id.empty()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3638 | EXPECT_TRUE(enabled_component_updates); |
| 3639 | EXPECT_EQ(1u, ids_to_check.size()); |
| 3640 | |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3641 | const std::string id = "gjpmebpgbhcamgdgjcmnjfhggjpgcimm"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3642 | EXPECT_EQ(id, ids_to_check[0]); |
| 3643 | EXPECT_EQ(1u, components.count(id)); |
| 3644 | |
| 3645 | ProtocolParser::Result::Manifest::Package package; |
| 3646 | package.name = "runaction_test_win.crx3"; |
| 3647 | package.hash_sha256 = |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3648 | "89290a0d2ff21ca5b45e109c6cc859ab5fe294e19c102d54acd321429c372cea"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3649 | |
| 3650 | ProtocolParser::Result result; |
| 3651 | result.extension_id = id; |
| 3652 | result.status = "ok"; |
| 3653 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 3654 | result.manifest.version = "1.0"; |
| 3655 | result.manifest.browser_min_version = "11.0.1.0"; |
| 3656 | result.manifest.packages.push_back(package); |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3657 | result.action_run = "ChromeRecovery.crx3"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3658 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3659 | ProtocolParser::Results results; |
| 3660 | results.list.push_back(result); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3661 | |
| 3662 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3663 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 3664 | ErrorCategory::kNone, 0, 0)); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3665 | } |
| 3666 | }; |
| 3667 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3668 | class MockCrxDownloader : public CrxDownloader { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3669 | public: |
| 3670 | static std::unique_ptr<CrxDownloader> Create( |
| 3671 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 3672 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3673 | return std::make_unique<MockCrxDownloader>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3674 | } |
| 3675 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3676 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3677 | |
| 3678 | private: |
| 3679 | void DoStartDownload(const GURL& url) override { |
| 3680 | DownloadMetrics download_metrics; |
| 3681 | FilePath path; |
| 3682 | Result result; |
| 3683 | if (url.path() == "/download/runaction_test_win.crx3") { |
| 3684 | download_metrics.url = url; |
| 3685 | download_metrics.downloader = DownloadMetrics::kNone; |
| 3686 | download_metrics.error = 0; |
| 3687 | download_metrics.downloaded_bytes = 1843; |
| 3688 | download_metrics.total_bytes = 1843; |
| 3689 | download_metrics.download_time_ms = 1000; |
| 3690 | |
| 3691 | EXPECT_TRUE( |
| 3692 | MakeTestFile(TestFilePath("runaction_test_win.crx3"), &path)); |
| 3693 | |
| 3694 | result.error = 0; |
| 3695 | result.response = path; |
| 3696 | result.downloaded_bytes = 1843; |
| 3697 | result.total_bytes = 1843; |
| 3698 | } else { |
| 3699 | NOTREACHED(); |
| 3700 | } |
| 3701 | |
| 3702 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3703 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 3704 | base::Unretained(this), true, result, |
| 3705 | download_metrics)); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3706 | } |
| 3707 | }; |
| 3708 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3709 | class MockPingManager : public MockPingManagerImpl { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3710 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3711 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3712 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3713 | |
| 3714 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3715 | ~MockPingManager() override { |
| 3716 | const auto& events = MockPingManagerImpl::events(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3717 | EXPECT_EQ(3u, events.size()); |
| 3718 | EXPECT_STREQ( |
| 3719 | "<event eventtype=\"14\" eventresult=\"1\" downloader=\"unknown\" " |
| 3720 | "url=\"http://localhost/download/" |
| 3721 | "runaction_test_win.crx3\" downloaded=\"1843\" " |
Minh X. Nguyen | 01d3586d | 2018-01-03 21:53:39 | [diff] [blame] | 3722 | "total=\"1843\" download_time_ms=\"1000\" previousversion=\"0.0\" " |
| 3723 | "nextversion=\"1.0\"/>", |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3724 | events[0].c_str()); |
| 3725 | EXPECT_STREQ( |
Sorin Jianu | 7b00a13 | 2017-06-19 21:56:54 | [diff] [blame] | 3726 | "<event eventtype=\"42\" eventresult=\"1\" " |
| 3727 | "errorcode=\"1877345072\"/>", |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3728 | events[1].c_str()); |
Minh X. Nguyen | 01d3586d | 2018-01-03 21:53:39 | [diff] [blame] | 3729 | EXPECT_STREQ( |
| 3730 | "<event eventtype=\"3\" eventresult=\"1\" previousversion=\"0.0\" " |
| 3731 | "nextversion=\"1.0\"/>", |
| 3732 | events[2].c_str()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3733 | } |
| 3734 | }; |
| 3735 | |
| 3736 | scoped_refptr<UpdateClient> update_client = |
| 3737 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3738 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3739 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3740 | |
Sorin Jianu | 7b00a13 | 2017-06-19 21:56:54 | [diff] [blame] | 3741 | // The action is a program which returns 1877345072 as a hardcoded value. |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3742 | update_client->Install( |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3743 | std::string("gjpmebpgbhcamgdgjcmnjfhggjpgcimm"), |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3744 | base::BindOnce([](const std::vector<std::string>& ids) { |
| 3745 | auto crx = std::make_unique<CrxComponent>(); |
| 3746 | crx->name = "test_niea"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 3747 | crx->pk_hash.assign(gjpm_hash, gjpm_hash + base::size(gjpm_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3748 | crx->version = base::Version("0.0"); |
| 3749 | crx->installer = base::MakeRefCounted<VersionedTestInstaller>(); |
| 3750 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 3751 | component.push_back(std::move(crx)); |
| 3752 | return component; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3753 | }), |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3754 | base::BindOnce( |
| 3755 | [](base::OnceClosure quit_closure, Error error) { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3756 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3757 | std::move(quit_closure).Run(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3758 | }, |
| 3759 | quit_closure())); |
| 3760 | |
| 3761 | RunThreads(); |
| 3762 | } |
| 3763 | |
| 3764 | // Tests that a run action is invoked in an update scenario when there was |
| 3765 | // no update. |
| 3766 | TEST_F(UpdateClientTest, ActionRun_NoUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3767 | class MockUpdateChecker : public UpdateChecker { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3768 | public: |
| 3769 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3770 | scoped_refptr<Configurator> config, |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3771 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3772 | return std::make_unique<MockUpdateChecker>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3773 | } |
| 3774 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3775 | void CheckForUpdates(const std::string& session_id, |
| 3776 | const std::vector<std::string>& ids_to_check, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3777 | const IdToComponentPtrMap& components, |
| 3778 | const std::string& additional_attributes, |
| 3779 | bool enabled_component_updates, |
| 3780 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3781 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3782 | Mock the following response: |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3783 | |
| 3784 | <?xml version='1.0' encoding='UTF-8'?> |
| 3785 | <response protocol='3.1'> |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3786 | <app appid='gjpmebpgbhcamgdgjcmnjfhggjpgcimm'> |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3787 | <updatecheck status='noupdate'> |
| 3788 | <actions>" |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3789 | <action run=ChromeRecovery.crx3'/>" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3790 | </actions>" |
| 3791 | </updatecheck> |
| 3792 | </app> |
| 3793 | </response> |
| 3794 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3795 | EXPECT_FALSE(session_id.empty()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3796 | EXPECT_EQ(1u, ids_to_check.size()); |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3797 | const std::string id = "gjpmebpgbhcamgdgjcmnjfhggjpgcimm"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3798 | EXPECT_EQ(id, ids_to_check[0]); |
| 3799 | EXPECT_EQ(1u, components.count(id)); |
| 3800 | |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3801 | ProtocolParser::Result result; |
| 3802 | result.extension_id = id; |
| 3803 | result.status = "noupdate"; |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3804 | result.action_run = "ChromeRecovery.crx3"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3805 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3806 | ProtocolParser::Results results; |
| 3807 | results.list.push_back(result); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3808 | |
| 3809 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3810 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 3811 | ErrorCategory::kNone, 0, 0)); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3812 | } |
| 3813 | }; |
| 3814 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3815 | class MockCrxDownloader : public CrxDownloader { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3816 | public: |
| 3817 | static std::unique_ptr<CrxDownloader> Create( |
| 3818 | bool is_background_download, |
Sorin Jianu | 556147d | 2018-01-19 21:55:21 | [diff] [blame] | 3819 | scoped_refptr<net::URLRequestContextGetter> context_getter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3820 | return std::make_unique<MockCrxDownloader>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3821 | } |
| 3822 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3823 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3824 | |
| 3825 | private: |
| 3826 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3827 | }; |
| 3828 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3829 | class MockPingManager : public MockPingManagerImpl { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3830 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3831 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3832 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3833 | |
| 3834 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3835 | ~MockPingManager() override { |
| 3836 | const auto& events = MockPingManagerImpl::events(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3837 | EXPECT_EQ(1u, events.size()); |
| 3838 | EXPECT_STREQ( |
Sorin Jianu | 7b00a13 | 2017-06-19 21:56:54 | [diff] [blame] | 3839 | "<event eventtype=\"42\" eventresult=\"1\" " |
| 3840 | "errorcode=\"1877345072\"/>", |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3841 | events[0].c_str()); |
| 3842 | } |
| 3843 | }; |
| 3844 | |
| 3845 | // Unpack the CRX to mock an existing install to be updated. The payload to |
| 3846 | // run is going to be picked up from this directory. |
| 3847 | base::FilePath unpack_path; |
| 3848 | { |
| 3849 | base::RunLoop runloop; |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3850 | base::OnceClosure quit_closure = runloop.QuitClosure(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3851 | |
Joshua Pawlicki | 6d76442 | 2018-02-21 15:23:10 | [diff] [blame] | 3852 | auto config = base::MakeRefCounted<TestConfigurator>(); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3853 | auto component_unpacker = base::MakeRefCounted<ComponentUnpacker>( |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3854 | std::vector<uint8_t>(std::begin(gjpm_hash), std::end(gjpm_hash)), |
Joshua Pawlicki | 6d76442 | 2018-02-21 15:23:10 | [diff] [blame] | 3855 | TestFilePath("runaction_test_win.crx3"), nullptr, |
| 3856 | config->CreateServiceManagerConnector()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3857 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3858 | component_unpacker->Unpack(base::BindOnce( |
| 3859 | [](base::FilePath* unpack_path, base::OnceClosure quit_closure, |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3860 | const ComponentUnpacker::Result& result) { |
| 3861 | EXPECT_EQ(UnpackerError::kNone, result.error); |
| 3862 | EXPECT_EQ(0, result.extended_error); |
| 3863 | *unpack_path = result.unpack_path; |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3864 | std::move(quit_closure).Run(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3865 | }, |
| 3866 | &unpack_path, runloop.QuitClosure())); |
| 3867 | |
| 3868 | runloop.Run(); |
| 3869 | } |
| 3870 | |
| 3871 | EXPECT_FALSE(unpack_path.empty()); |
| 3872 | EXPECT_TRUE(base::DirectoryExists(unpack_path)); |
| 3873 | int64_t file_size = 0; |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3874 | EXPECT_TRUE(base::GetFileSize(unpack_path.AppendASCII("ChromeRecovery.crx3"), |
| 3875 | &file_size)); |
| 3876 | EXPECT_EQ(44582, file_size); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3877 | |
| 3878 | base::ScopedTempDir unpack_path_owner; |
| 3879 | EXPECT_TRUE(unpack_path_owner.Set(unpack_path)); |
| 3880 | |
| 3881 | scoped_refptr<UpdateClient> update_client = |
| 3882 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3883 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3884 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3885 | |
Sorin Jianu | 7b00a13 | 2017-06-19 21:56:54 | [diff] [blame] | 3886 | // The action is a program which returns 1877345072 as a hardcoded value. |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 3887 | const std::vector<std::string> ids = {"gjpmebpgbhcamgdgjcmnjfhggjpgcimm"}; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3888 | update_client->Update( |
| 3889 | ids, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3890 | base::BindOnce( |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3891 | [](const base::FilePath& unpack_path, |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3892 | const std::vector<std::string>& ids) { |
| 3893 | auto crx = std::make_unique<CrxComponent>(); |
| 3894 | crx->name = "test_niea"; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 3895 | crx->pk_hash.assign(gjpm_hash, gjpm_hash + base::size(gjpm_hash)); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3896 | crx->version = base::Version("1.0"); |
| 3897 | crx->installer = |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3898 | base::MakeRefCounted<ReadOnlyTestInstaller>(unpack_path); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3899 | std::vector<std::unique_ptr<CrxComponent>> component; |
| 3900 | component.push_back(std::move(crx)); |
| 3901 | return component; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3902 | }, |
| 3903 | unpack_path), |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 3904 | false, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3905 | base::BindOnce( |
| 3906 | [](base::OnceClosure quit_closure, Error error) { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3907 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3908 | std::move(quit_closure).Run(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 3909 | }, |
| 3910 | quit_closure())); |
| 3911 | |
| 3912 | RunThreads(); |
| 3913 | } |
| 3914 | |
Sorin Jianu | 7b00a13 | 2017-06-19 21:56:54 | [diff] [blame] | 3915 | #endif // OS_WIN |
| 3916 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 3917 | } // namespace update_client |