[email protected] | f3d3b38 | 2014-03-14 21:19:28 | [diff] [blame] | 1 | // Copyright 2014 The Chromium Authors. All rights reserved. |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
[email protected] | f3d3b38 | 2014-03-14 21:19:28 | [diff] [blame] | 5 | #include "chrome/browser/extensions/pending_extension_manager.h" |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 6 | |
[email protected] | d31e19e | 2012-08-22 00:19:04 | [diff] [blame] | 7 | #include <algorithm> |
| 8 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 9 | #include "base/logging.h" |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 10 | #include "base/version.h" |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 11 | #include "chrome/common/extensions/extension_constants.h" |
[email protected] | c38831a1 | 2011-10-28 12:44:49 | [diff] [blame] | 12 | #include "content/public/browser/browser_thread.h" |
[email protected] | 46f3e10 | 2014-03-25 01:22:45 | [diff] [blame] | 13 | #include "extensions/browser/extension_prefs.h" |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 14 | #include "extensions/browser/extension_registry.h" |
[email protected] | b52f8ca | 2013-11-28 08:25:22 | [diff] [blame] | 15 | #include "extensions/common/extension.h" |
[email protected] | a6483d2 | 2013-07-03 22:11:00 | [diff] [blame] | 16 | #include "url/gurl.h" |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 17 | |
[email protected] | 631bb74 | 2011-11-02 11:29:39 | [diff] [blame] | 18 | using content::BrowserThread; |
| 19 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 20 | namespace { |
| 21 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 22 | // Install predicate used by AddFromExternalUpdateUrl(). |
[email protected] | 8f3bcbd | 2013-06-05 08:42:40 | [diff] [blame] | 23 | bool AlwaysInstall(const extensions::Extension* extension) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 24 | return true; |
| 25 | } |
| 26 | |
[email protected] | c5e4a222 | 2014-01-03 16:06:13 | [diff] [blame] | 27 | std::string GetVersionString(const Version& version) { |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 28 | return version.IsValid() ? version.GetString() : "invalid"; |
| 29 | } |
| 30 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 31 | } // namespace |
| 32 | |
[email protected] | 3f213ad | 2012-07-26 23:39:41 | [diff] [blame] | 33 | namespace extensions { |
| 34 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 35 | PendingExtensionManager::PendingExtensionManager( |
[email protected] | 46f3e10 | 2014-03-25 01:22:45 | [diff] [blame] | 36 | content::BrowserContext* context) |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 37 | : context_(context) {} |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 38 | |
| 39 | PendingExtensionManager::~PendingExtensionManager() {} |
| 40 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 41 | const PendingExtensionInfo* PendingExtensionManager::GetById( |
| 42 | const std::string& id) const { |
| 43 | PendingExtensionList::const_iterator iter; |
| 44 | for (iter = pending_extension_list_.begin(); |
| 45 | iter != pending_extension_list_.end(); |
| 46 | ++iter) { |
| 47 | if (id == iter->id()) |
| 48 | return &(*iter); |
| 49 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 50 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 51 | return NULL; |
| 52 | } |
| 53 | |
| 54 | bool PendingExtensionManager::Remove(const std::string& id) { |
| 55 | PendingExtensionList::iterator iter; |
| 56 | for (iter = pending_extension_list_.begin(); |
| 57 | iter != pending_extension_list_.end(); |
| 58 | ++iter) { |
| 59 | if (id == iter->id()) { |
| 60 | pending_extension_list_.erase(iter); |
| 61 | return true; |
| 62 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 63 | } |
| 64 | |
| 65 | return false; |
| 66 | } |
| 67 | |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 68 | bool PendingExtensionManager::IsIdPending(const std::string& id) const { |
[email protected] | 870f557 | 2013-12-19 12:30:15 | [diff] [blame] | 69 | return GetById(id) != NULL; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 70 | } |
| 71 | |
[email protected] | 9bd9a686 | 2012-11-29 09:24:22 | [diff] [blame] | 72 | bool PendingExtensionManager::HasPendingExtensions() const { |
| 73 | return !pending_extension_list_.empty(); |
| 74 | } |
| 75 | |
[email protected] | d31e19e | 2012-08-22 00:19:04 | [diff] [blame] | 76 | bool PendingExtensionManager::HasPendingExtensionFromSync() const { |
| 77 | PendingExtensionList::const_iterator iter; |
| 78 | for (iter = pending_extension_list_.begin(); |
| 79 | iter != pending_extension_list_.end(); |
| 80 | ++iter) { |
| 81 | if (iter->is_from_sync()) |
| 82 | return true; |
| 83 | } |
| 84 | |
| 85 | return false; |
| 86 | } |
| 87 | |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 88 | bool PendingExtensionManager::AddFromSync( |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 89 | const std::string& id, |
| 90 | const GURL& update_url, |
| 91 | PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 92 | bool install_silently, |
| 93 | bool remote_install) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 94 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 95 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 96 | if (ExtensionRegistry::Get(context_)->GetExtensionById( |
| 97 | id, ExtensionRegistry::EVERYTHING)) { |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 98 | LOG(ERROR) << "Trying to add pending extension " << id |
| 99 | << " which already exists"; |
| 100 | return false; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 101 | } |
| 102 | |
[email protected] | b873cd9 | 2012-02-09 21:51:48 | [diff] [blame] | 103 | // Make sure we don't ever try to install the CWS app, because even though |
| 104 | // it is listed as a syncable app (because its values need to be synced) it |
| 105 | // should already be installed on every instance. |
| 106 | if (id == extension_misc::kWebStoreAppId) { |
| 107 | NOTREACHED(); |
| 108 | return false; |
| 109 | } |
| 110 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 111 | static const bool kIsFromSync = true; |
| 112 | static const Manifest::Location kSyncLocation = Manifest::INTERNAL; |
| 113 | static const bool kMarkAcknowledged = false; |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 114 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 115 | return AddExtensionImpl(id, |
| 116 | std::string(), |
| 117 | update_url, |
| 118 | Version(), |
| 119 | should_allow_install, |
| 120 | kIsFromSync, |
| 121 | install_silently, |
| 122 | kSyncLocation, |
| 123 | Extension::NO_FLAGS, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 124 | kMarkAcknowledged, |
| 125 | remote_install); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 126 | } |
| 127 | |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 128 | bool PendingExtensionManager::AddFromExtensionImport( |
| 129 | const std::string& id, |
| 130 | const GURL& update_url, |
| 131 | PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install) { |
| 132 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 133 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 134 | if (ExtensionRegistry::Get(context_)->GetExtensionById( |
| 135 | id, ExtensionRegistry::EVERYTHING)) { |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 136 | LOG(ERROR) << "Trying to add pending extension " << id |
| 137 | << " which already exists"; |
| 138 | return false; |
| 139 | } |
| 140 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 141 | static const bool kIsFromSync = false; |
| 142 | static const bool kInstallSilently = true; |
| 143 | static const Manifest::Location kManifestLocation = Manifest::INTERNAL; |
| 144 | static const bool kMarkAcknowledged = false; |
| 145 | static const bool kRemoteInstall = false; |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 146 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 147 | return AddExtensionImpl(id, |
| 148 | std::string(), |
| 149 | update_url, |
| 150 | Version(), |
| 151 | should_allow_install, |
| 152 | kIsFromSync, |
| 153 | kInstallSilently, |
| 154 | kManifestLocation, |
| 155 | Extension::NO_FLAGS, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 156 | kMarkAcknowledged, |
| 157 | kRemoteInstall); |
[email protected] | 9f4e4f08 | 2013-06-21 07:11:19 | [diff] [blame] | 158 | } |
| 159 | |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 160 | bool PendingExtensionManager::AddFromExternalUpdateUrl( |
[email protected] | 612a1cb1 | 2012-10-17 13:18:03 | [diff] [blame] | 161 | const std::string& id, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 162 | const std::string& install_parameter, |
[email protected] | 612a1cb1 | 2012-10-17 13:18:03 | [diff] [blame] | 163 | const GURL& update_url, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 164 | Manifest::Location location, |
| 165 | int creation_flags, |
| 166 | bool mark_acknowledged) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 167 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 168 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 169 | static const bool kIsFromSync = false; |
| 170 | static const bool kInstallSilently = true; |
| 171 | static const bool kRemoteInstall = false; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 172 | |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 173 | const Extension* extension = ExtensionRegistry::Get(context_) |
| 174 | ->GetExtensionById(id, ExtensionRegistry::EVERYTHING); |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 175 | if (extension && location == Manifest::GetHigherPriorityLocation( |
| 176 | location, extension->location())) { |
[email protected] | 8a87a533 | 2011-08-11 17:54:59 | [diff] [blame] | 177 | // If the new location has higher priority than the location of an existing |
| 178 | // extension, let the update process overwrite the existing extension. |
| 179 | } else { |
[email protected] | 46f3e10 | 2014-03-25 01:22:45 | [diff] [blame] | 180 | if (ExtensionPrefs::Get(context_)->IsExternalExtensionUninstalled(id)) |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 181 | return false; |
| 182 | |
[email protected] | 8a87a533 | 2011-08-11 17:54:59 | [diff] [blame] | 183 | if (extension) { |
| 184 | LOG(DFATAL) << "Trying to add extension " << id |
| 185 | << " by external update, but it is already installed."; |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 186 | return false; |
[email protected] | 8a87a533 | 2011-08-11 17:54:59 | [diff] [blame] | 187 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 188 | } |
| 189 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 190 | return AddExtensionImpl(id, |
| 191 | install_parameter, |
| 192 | update_url, |
| 193 | Version(), |
| 194 | &AlwaysInstall, |
| 195 | kIsFromSync, |
| 196 | kInstallSilently, |
| 197 | location, |
| 198 | creation_flags, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 199 | mark_acknowledged, |
| 200 | kRemoteInstall); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 201 | } |
| 202 | |
| 203 | |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 204 | bool PendingExtensionManager::AddFromExternalFile( |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 205 | const std::string& id, |
[email protected] | 1d5e58b | 2013-01-31 08:41:40 | [diff] [blame] | 206 | Manifest::Location install_source, |
[email protected] | c5e4a222 | 2014-01-03 16:06:13 | [diff] [blame] | 207 | const Version& version, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 208 | int creation_flags, |
| 209 | bool mark_acknowledged) { |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 210 | // TODO(skerner): AddFromSync() checks to see if the extension is |
| 211 | // installed, but this method assumes that the caller already |
| 212 | // made sure it is not installed. Make all AddFrom*() methods |
| 213 | // consistent. |
[email protected] | 6c9bedf | 2014-05-21 03:55:51 | [diff] [blame^] | 214 | const GURL& kUpdateUrl = GURL::EmptyGURL(); |
| 215 | static const bool kIsFromSync = false; |
| 216 | static const bool kInstallSilently = true; |
| 217 | static const bool kRemoteInstall = false; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 218 | |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 219 | return AddExtensionImpl(id, |
| 220 | std::string(), |
| 221 | kUpdateUrl, |
| 222 | version, |
| 223 | &AlwaysInstall, |
| 224 | kIsFromSync, |
| 225 | kInstallSilently, |
| 226 | install_source, |
| 227 | creation_flags, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 228 | mark_acknowledged, |
| 229 | kRemoteInstall); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 230 | } |
| 231 | |
| 232 | void PendingExtensionManager::GetPendingIdsForUpdateCheck( |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 233 | std::list<std::string>* out_ids_for_update_check) const { |
| 234 | PendingExtensionList::const_iterator iter; |
| 235 | for (iter = pending_extension_list_.begin(); |
| 236 | iter != pending_extension_list_.end(); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 237 | ++iter) { |
[email protected] | 1d5e58b | 2013-01-31 08:41:40 | [diff] [blame] | 238 | Manifest::Location install_source = iter->install_source(); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 239 | |
| 240 | // Some install sources read a CRX from the filesystem. They can |
| 241 | // not be fetched from an update URL, so don't include them in the |
| 242 | // set of ids. |
[email protected] | 1d5e58b | 2013-01-31 08:41:40 | [diff] [blame] | 243 | if (install_source == Manifest::EXTERNAL_PREF || |
| 244 | install_source == Manifest::EXTERNAL_REGISTRY) |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 245 | continue; |
| 246 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 247 | out_ids_for_update_check->push_back(iter->id()); |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 248 | } |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 249 | } |
| 250 | |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 251 | bool PendingExtensionManager::AddExtensionImpl( |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 252 | const std::string& id, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 253 | const std::string& install_parameter, |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 254 | const GURL& update_url, |
[email protected] | c5e4a222 | 2014-01-03 16:06:13 | [diff] [blame] | 255 | const Version& version, |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 256 | PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install, |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 257 | bool is_from_sync, |
| 258 | bool install_silently, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 259 | Manifest::Location install_source, |
| 260 | int creation_flags, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 261 | bool mark_acknowledged, |
| 262 | bool remote_install) { |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 263 | CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); |
| 264 | |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 265 | PendingExtensionInfo info(id, |
[email protected] | d8fd0fd | 2014-03-24 13:16:06 | [diff] [blame] | 266 | install_parameter, |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 267 | update_url, |
| 268 | version, |
| 269 | should_allow_install, |
| 270 | is_from_sync, |
| 271 | install_silently, |
[email protected] | 464213a | 2013-10-15 01:06:48 | [diff] [blame] | 272 | install_source, |
| 273 | creation_flags, |
[email protected] | 21db9ef | 2014-05-16 02:06:27 | [diff] [blame] | 274 | mark_acknowledged, |
| 275 | remote_install); |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 276 | |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 277 | if (const PendingExtensionInfo* pending = GetById(id)) { |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 278 | // Bugs in this code will manifest as sporadic incorrect extension |
| 279 | // locations in situations where multiple install sources run at the |
| 280 | // same time. For example, on first login to a chrome os machine, an |
[email protected] | 9060d8b0 | 2012-01-13 02:14:30 | [diff] [blame] | 281 | // extension may be requested by sync and the default extension set. |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 282 | // The following logging will help diagnose such issues. |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 283 | VLOG(1) << "Extension id " << id |
| 284 | << " was entered for update more than once." |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 285 | << " old location: " << pending->install_source() |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 286 | << " new location: " << install_source |
| 287 | << " old version: " << GetVersionString(pending->version()) |
| 288 | << " new version: " << GetVersionString(version); |
[email protected] | 145a317b | 2011-04-12 16:03:46 | [diff] [blame] | 289 | |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 290 | // Never override an existing extension with an older version. Only |
| 291 | // extensions from local CRX files have a known version; extensions from an |
| 292 | // update URL will get the latest version. |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 293 | |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 294 | // If |pending| has the same or higher precedence than |info| then don't |
| 295 | // install |info| over |pending|. |
| 296 | if (pending->CompareTo(info) >= 0) |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 297 | return false; |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 298 | |
| 299 | VLOG(1) << "Overwrite existing record."; |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 300 | |
| 301 | std::replace(pending_extension_list_.begin(), |
| 302 | pending_extension_list_.end(), |
| 303 | *pending, |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 304 | info); |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 305 | } else { |
[email protected] | 4ec0f4b | 2012-12-07 09:41:46 | [diff] [blame] | 306 | pending_extension_list_.push_back(info); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 307 | } |
| 308 | |
[email protected] | e398785 | 2012-05-04 10:06:30 | [diff] [blame] | 309 | return true; |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 310 | } |
| 311 | |
| 312 | void PendingExtensionManager::AddForTesting( |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 313 | const PendingExtensionInfo& pending_extension_info) { |
[email protected] | 51a3bf8b | 2012-06-08 22:53:06 | [diff] [blame] | 314 | pending_extension_list_.push_back(pending_extension_info); |
[email protected] | b2907fd | 2011-03-25 16:43:37 | [diff] [blame] | 315 | } |
[email protected] | 3f213ad | 2012-07-26 23:39:41 | [diff] [blame] | 316 | |
| 317 | } // namespace extensions |