[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 1 | // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
Sebastien Marchand | f1349f5 | 2019-01-25 03:16:41 | [diff] [blame] | 5 | #include "base/bind.h" |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 6 | #include "chrome/browser/extensions/extension_browsertest.h" |
| 7 | #include "chrome/browser/ui/browser.h" |
[email protected] | 617ee96 | 2013-01-29 20:49:12 | [diff] [blame] | 8 | #include "chrome/browser/ui/tabs/tab_strip_model.h" |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 9 | #include "chrome/common/url_constants.h" |
| 10 | #include "chrome/test/base/ui_test_utils.h" |
| 11 | #include "content/public/browser/web_contents.h" |
[email protected] | 7d478cb | 2012-07-24 17:19:42 | [diff] [blame] | 12 | #include "content/public/test/browser_test_utils.h" |
[email protected] | 885c0e9 | 2012-11-13 20:27:42 | [diff] [blame] | 13 | #include "extensions/common/constants.h" |
[email protected] | e4452d3 | 2013-11-15 23:07:41 | [diff] [blame] | 14 | #include "extensions/common/extension.h" |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 15 | #include "net/test/embedded_test_server/embedded_test_server.h" |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 16 | |
| 17 | using content::WebContents; |
Devlin Cronin | 836f545d | 2018-05-09 00:25:05 | [diff] [blame] | 18 | |
| 19 | namespace extensions { |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 20 | |
| 21 | namespace { |
| 22 | |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 23 | const char kSubscribePage[] = "/subscribe.html"; |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 24 | const char kFeedPageMultiRel[] = "/feeds/feed_multi_rel.html"; |
| 25 | const char kValidFeedNoLinks[] = "/feeds/feed_nolinks.xml"; |
| 26 | const char kValidFeed0[] = "/feeds/feed_script.xml"; |
| 27 | const char kValidFeed1[] = "/feeds/feed1.xml"; |
| 28 | const char kValidFeed2[] = "/feeds/feed2.xml"; |
| 29 | const char kValidFeed3[] = "/feeds/feed3.xml"; |
| 30 | const char kValidFeed4[] = "/feeds/feed4.xml"; |
| 31 | const char kValidFeed5[] = "/feeds/feed5.xml"; |
| 32 | const char kValidFeed6[] = "/feeds/feed6.xml"; |
| 33 | const char kInvalidFeed1[] = "/feeds/feed_invalid1.xml"; |
| 34 | const char kInvalidFeed2[] = "/feeds/feed_invalid2.xml"; |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 35 | // We need a triple encoded string to prove that we are not decoding twice in |
| 36 | // subscribe.js because one layer is also stripped off when subscribe.js passes |
| 37 | // it to the XMLHttpRequest object. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 38 | const char kFeedTripleEncoded[] = "/feeds/url%25255Fdecoding.html"; |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 39 | |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 40 | static const char kScriptFeedTitle[] = |
| 41 | "window.domAutomationController.send(" |
| 42 | " document.getElementById('title') ? " |
| 43 | " document.getElementById('title').textContent : " |
| 44 | " \"element 'title' not found\"" |
| 45 | ");"; |
| 46 | static const char kScriptAnchor[] = |
| 47 | "window.domAutomationController.send(" |
| 48 | " document.getElementById('anchor_0') ? " |
| 49 | " document.getElementById('anchor_0').textContent : " |
| 50 | " \"element 'anchor_0' not found\"" |
| 51 | ");"; |
| 52 | static const char kScriptDesc[] = |
| 53 | "window.domAutomationController.send(" |
| 54 | " document.getElementById('desc_0') ? " |
| 55 | " document.getElementById('desc_0').textContent : " |
| 56 | " \"element 'desc_0' not found\"" |
| 57 | ");"; |
| 58 | static const char kScriptError[] = |
| 59 | "window.domAutomationController.send(" |
| 60 | " document.getElementById('error') ? " |
| 61 | " document.getElementById('error').textContent : " |
| 62 | " \"No error\"" |
| 63 | ");"; |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 64 | |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 65 | GURL GetFeedUrl(net::EmbeddedTestServer* server, |
| 66 | const std::string& feed_page, |
| 67 | bool direct_url, |
| 68 | std::string extension_id) { |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 69 | GURL feed_url = server->GetURL(feed_page); |
| 70 | if (direct_url) { |
| 71 | // We navigate directly to the subscribe page for feeds where the feed |
| 72 | // sniffing won't work, in other words, as is the case for malformed feeds. |
Devlin Cronin | 836f545d | 2018-05-09 00:25:05 | [diff] [blame] | 73 | return GURL(std::string(kExtensionScheme) + url::kStandardSchemeSeparator + |
| 74 | extension_id + std::string(kSubscribePage) + std::string("?") + |
| 75 | feed_url.spec() + std::string("&synchronous")); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 76 | } else { |
| 77 | // Navigate to the feed content (which will cause the extension to try to |
| 78 | // sniff the type and display the subscribe page in another tab. |
| 79 | return GURL(feed_url.spec()); |
| 80 | } |
| 81 | } |
| 82 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 83 | bool ValidatePageElement(content::RenderFrameHost* frame, |
[email protected] | 06bc5d9 | 2013-01-02 22:44:13 | [diff] [blame] | 84 | const std::string& javascript, |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 85 | const std::string& expected_value) { |
| 86 | std::string returned_value; |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 87 | |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 88 | if (!content::ExecuteScriptAndExtractString(frame, |
| 89 | javascript, |
| 90 | &returned_value)) |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 91 | return false; |
| 92 | |
| 93 | EXPECT_STREQ(expected_value.c_str(), returned_value.c_str()); |
| 94 | return expected_value == returned_value; |
| 95 | } |
| 96 | |
| 97 | // Navigates to a feed page and, if |sniff_xml_type| is set, wait for the |
| 98 | // extension to kick in, detect the feed and redirect to a feed preview page. |
| 99 | // |sniff_xml_type| is generally set to true if the feed is sniffable and false |
| 100 | // for invalid feeds. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 101 | void NavigateToFeedAndValidate(net::EmbeddedTestServer* server, |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 102 | const std::string& url, |
| 103 | Browser* browser, |
| 104 | std::string extension_id, |
| 105 | bool sniff_xml_type, |
| 106 | const std::string& expected_feed_title, |
| 107 | const std::string& expected_item_title, |
| 108 | const std::string& expected_item_desc, |
| 109 | const std::string& expected_error) { |
| 110 | if (sniff_xml_type) { |
| 111 | // TODO(finnur): Implement this is a non-flaky way. |
| 112 | } |
| 113 | |
| 114 | // Navigate to the subscribe page directly. |
| 115 | ui_test_utils::NavigateToURL(browser, |
| 116 | GetFeedUrl(server, url, true, extension_id)); |
| 117 | |
[email protected] | 617ee96 | 2013-01-29 20:49:12 | [diff] [blame] | 118 | WebContents* tab = browser->tab_strip_model()->GetActiveWebContents(); |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 119 | content::RenderFrameHost* frame = content::FrameMatchingPredicate( |
| 120 | tab, base::Bind(&content::FrameIsChildOfMainFrame)); |
[email protected] | 007b3f8 | 2013-04-09 08:46:45 | [diff] [blame] | 121 | ASSERT_TRUE(ValidatePageElement( |
[email protected] | b27c362 | 2014-03-22 00:26:55 | [diff] [blame] | 122 | tab->GetMainFrame(), kScriptFeedTitle, expected_feed_title)); |
| 123 | ASSERT_TRUE(ValidatePageElement(frame, kScriptAnchor, expected_item_title)); |
| 124 | ASSERT_TRUE(ValidatePageElement(frame, kScriptDesc, expected_item_desc)); |
| 125 | ASSERT_TRUE(ValidatePageElement(frame, kScriptError, expected_error)); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 126 | } |
| 127 | |
| 128 | } // namespace |
| 129 | |
| 130 | // Makes sure that the RSS detects RSS feed links, even when rel tag contains |
| 131 | // more than just "alternate". |
| 132 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, RSSMultiRelLink) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 133 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 134 | |
| 135 | ASSERT_TRUE(LoadExtension( |
| 136 | test_data_dir_.AppendASCII("subscribe_page_action"))); |
| 137 | |
| 138 | ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(0)); |
| 139 | |
| 140 | // Navigate to the feed page. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 141 | GURL feed_url = embedded_test_server()->GetURL(kFeedPageMultiRel); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 142 | ui_test_utils::NavigateToURL(browser(), feed_url); |
| 143 | // We should now have one page action ready to go in the LocationBar. |
| 144 | ASSERT_TRUE(WaitForPageActionVisibilityChangeTo(1)); |
| 145 | } |
| 146 | |
[email protected] | b1258c8 | 2014-02-03 20:32:11 | [diff] [blame] | 147 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 148 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed1) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 149 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 150 | |
| 151 | const Extension* extension = LoadExtension( |
| 152 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 153 | ASSERT_TRUE(extension); |
| 154 | std::string id = extension->id(); |
| 155 | |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 156 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeed1, browser(), id, |
| 157 | true, "Feed for MyFeedTitle", "Title 1", "Desc", |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 158 | "No error"); |
| 159 | } |
| 160 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 161 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 162 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed2) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 163 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 164 | |
| 165 | const Extension* extension = LoadExtension( |
| 166 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 167 | ASSERT_TRUE(extension); |
| 168 | std::string id = extension->id(); |
| 169 | |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 170 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeed2, browser(), id, |
| 171 | true, "Feed for MyFeed2", "My item title1", |
| 172 | "This is a summary.", "No error"); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 173 | } |
| 174 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 175 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 176 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed3) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 177 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 178 | |
| 179 | const Extension* extension = LoadExtension( |
| 180 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 181 | ASSERT_TRUE(extension); |
| 182 | std::string id = extension->id(); |
| 183 | |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 184 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeed3, browser(), id, |
| 185 | true, "Feed for Google Code buglist rss feed", |
| 186 | "My dear title", "My dear content", "No error"); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 187 | } |
| 188 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 189 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 190 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed4) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 191 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 192 | |
| 193 | const Extension* extension = LoadExtension( |
| 194 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 195 | ASSERT_TRUE(extension); |
| 196 | std::string id = extension->id(); |
| 197 | |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 198 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeed4, browser(), id, |
| 199 | true, "Feed for Title chars <script> %23 stop", |
| 200 | "Title chars %23 stop", "My dear content %23 stop", |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 201 | "No error"); |
| 202 | } |
| 203 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 204 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 205 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed0) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 206 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 207 | |
| 208 | const Extension* extension = LoadExtension( |
| 209 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 210 | ASSERT_TRUE(extension); |
| 211 | std::string id = extension->id(); |
| 212 | |
| 213 | // Try a feed with a link with an onclick handler (before r27440 this would |
| 214 | // trigger a NOTREACHED). |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 215 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeed0, browser(), id, |
| 216 | true, "Feed for MyFeedTitle", "Title 1", |
| 217 | "Desc VIDEO", "No error"); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 218 | } |
| 219 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 220 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 221 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed5) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 222 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 223 | |
| 224 | const Extension* extension = LoadExtension( |
| 225 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 226 | ASSERT_TRUE(extension); |
| 227 | std::string id = extension->id(); |
| 228 | |
| 229 | // Feed with valid but mostly empty xml. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 230 | NavigateToFeedAndValidate( |
| 231 | embedded_test_server(), kValidFeed5, browser(), id, true, |
| 232 | "Feed for Unknown feed name", "element 'anchor_0' not found", |
| 233 | "element 'desc_0' not found", "This feed contains no entries."); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 234 | } |
| 235 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 236 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 237 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, DISABLED_RSSParseFeedValidFeed6) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 238 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 239 | |
| 240 | const Extension* extension = LoadExtension( |
| 241 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 242 | ASSERT_TRUE(extension); |
| 243 | std::string id = extension->id(); |
| 244 | |
| 245 | // Feed that is technically invalid but still parseable. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 246 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeed6, browser(), id, |
| 247 | true, "Feed for MyFeedTitle", "Title 1", "Desc", |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 248 | "No error"); |
| 249 | } |
| 250 | |
[email protected] | efe5ba2 | 2014-01-07 13:23:27 | [diff] [blame] | 251 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, RSSParseFeedInvalidFeed1) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 252 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 253 | |
| 254 | const Extension* extension = LoadExtension( |
| 255 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 256 | ASSERT_TRUE(extension); |
| 257 | std::string id = extension->id(); |
| 258 | |
| 259 | // Try an empty feed. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 260 | NavigateToFeedAndValidate( |
| 261 | embedded_test_server(), kInvalidFeed1, browser(), id, false, |
| 262 | "Feed for Unknown feed name", "element 'anchor_0' not found", |
| 263 | "element 'desc_0' not found", "This feed contains no entries."); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 264 | } |
| 265 | |
[email protected] | efe5ba2 | 2014-01-07 13:23:27 | [diff] [blame] | 266 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, RSSParseFeedInvalidFeed2) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 267 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 268 | |
| 269 | const Extension* extension = LoadExtension( |
| 270 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 271 | ASSERT_TRUE(extension); |
| 272 | std::string id = extension->id(); |
| 273 | |
| 274 | // Try a garbage feed. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 275 | NavigateToFeedAndValidate( |
| 276 | embedded_test_server(), kInvalidFeed2, browser(), id, false, |
| 277 | "Feed for Unknown feed name", "element 'anchor_0' not found", |
| 278 | "element 'desc_0' not found", "This feed contains no entries."); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 279 | } |
| 280 | |
[email protected] | efe5ba2 | 2014-01-07 13:23:27 | [diff] [blame] | 281 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, RSSParseFeedInvalidFeed3) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 282 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 283 | |
| 284 | const Extension* extension = LoadExtension( |
| 285 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 286 | ASSERT_TRUE(extension); |
| 287 | std::string id = extension->id(); |
| 288 | |
| 289 | // Try a feed that doesn't exist. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 290 | NavigateToFeedAndValidate( |
| 291 | embedded_test_server(), "/foo.xml", browser(), id, false, |
| 292 | "Feed for Unknown feed name", "element 'anchor_0' not found", |
| 293 | "element 'desc_0' not found", "This feed contains no entries."); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 294 | } |
| 295 | |
[email protected] | efe5ba2 | 2014-01-07 13:23:27 | [diff] [blame] | 296 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, RSSParseFeedInvalidFeed4) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 297 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 298 | |
| 299 | const Extension* extension = LoadExtension( |
| 300 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 301 | ASSERT_TRUE(extension); |
| 302 | std::string id = extension->id(); |
| 303 | |
| 304 | // subscribe.js shouldn't double-decode the URL passed in. Otherwise feed |
| 305 | // links such as http://search.twitter.com/search.atom?lang=en&q=%23chrome |
| 306 | // will result in no feed being downloaded because %23 gets decoded to # and |
| 307 | // therefore #chrome is not treated as part of the Twitter query. This test |
| 308 | // uses an underscore instead of a hash, but the principle is the same. If |
| 309 | // we start erroneously double decoding again, the path (and the feed) will |
| 310 | // become valid resulting in a failure for this test. |
| 311 | NavigateToFeedAndValidate( |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 312 | embedded_test_server(), kFeedTripleEncoded, browser(), id, true, |
| 313 | "Feed for Unknown feed name", "element 'anchor_0' not found", |
| 314 | "element 'desc_0' not found", "This feed contains no entries."); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 315 | } |
| 316 | |
Mattias Nissler | d3cba30 | 2015-03-20 09:07:44 | [diff] [blame] | 317 | // This test is flaky on all platforms; see http://crbug.com/340354 |
| 318 | IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, |
| 319 | DISABLED_RSSParseFeedValidFeedNoLinks) { |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 320 | ASSERT_TRUE(embedded_test_server()->Start()); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 321 | |
| 322 | const Extension* extension = LoadExtension( |
| 323 | test_data_dir_.AppendASCII("subscribe_page_action")); |
| 324 | ASSERT_TRUE(extension); |
| 325 | std::string id = extension->id(); |
| 326 | |
| 327 | // Valid feed but containing no links. |
svaldez | a01f7d9 | 2015-11-18 17:47:56 | [diff] [blame] | 328 | NavigateToFeedAndValidate(embedded_test_server(), kValidFeedNoLinks, |
| 329 | browser(), id, true, "Feed for MyFeedTitle", |
| 330 | "Title with no link", "Desc", "No error"); |
[email protected] | fad7367 | 2012-06-15 23:26:06 | [diff] [blame] | 331 | } |
Devlin Cronin | 836f545d | 2018-05-09 00:25:05 | [diff] [blame] | 332 | |
| 333 | } // namespace extensions |