blob: 4807c72b95acb6cee5cd7912cb0f2f3d3baddad3 [file] [log] [blame] [view]
asankaddd5dc22015-03-20 15:52:401# Chrome Network Bug Triage : Suggested Workflow
2
3[TOC]
4
asankaddd5dc22015-03-20 15:52:405## Identifying unlabeled network bugs on the tracker
6
davidbenbeccd432016-06-22 18:13:187* Look at new unconfirmed bugs since noon PST on the last triager's rotation.
asankaddd5dc22015-03-20 15:52:408 [Use this issue tracker
asankaa30864c2016-12-13 19:28:579 query](https://bugs.chromium.org/p/chromium/issues/list?q=status%3Aunconfirmed&sort=-id&num=1000).
asankaddd5dc22015-03-20 15:52:4010
eroman4cb6246c2016-02-23 04:00:2711* Read the title of the bug.
asankaddd5dc22015-03-20 15:52:4012
asankaa30864c2016-12-13 19:28:5713* If a bug looks like it might be network related, middle click (or
14 command-click on OSX) to open it in a new tab.
asankaddd5dc22015-03-20 15:52:4015
16* If a user provides a crash ID for a crasher for a bug that could be
Eric Roman661816b92018-05-14 23:04:1217 net-related, see the [internal instructions on dealing with a crash ID](https://goto.google.com/network_triage_internal#dealing-with-a-crash-id)
asankaddd5dc22015-03-20 15:52:4018
Matt Menkeae32850c2018-03-20 16:40:5519* If network causes are possible, ask for a net-export log (If it's not a
asankaddd5dc22015-03-20 15:52:4020 browser crash) and attach the most specific internals-network label that's
eroman96211952016-02-22 21:42:0321 applicable. If there isn't an applicable narrower component, a clear owner
22 for the issue, or there are multiple possibilities, attach the
23 Internals>Network component and proceed with further investigation.
asankaddd5dc22015-03-20 15:52:4024
eroman96211952016-02-22 21:42:0325* If non-network causes also seem possible, attach those components as well.
asankaddd5dc22015-03-20 15:52:4026
eroman96211952016-02-22 21:42:0327## Investigating component=Internals>Network bugs
asankaddd5dc22015-03-20 15:52:4028
rdsmith27684e692017-04-28 21:23:4429* Note that you may want to investigate Needs-Feedback bugs first, as
Matt Menkeae32850c2018-03-20 16:40:5530 that may result in some bugs being added to this list.
rdsmith27684e692017-04-28 21:23:4431
asankaddd5dc22015-03-20 15:52:4032* It's recommended that while on triage duty, you subscribe to the
eroman12372dc2016-02-22 20:08:1033 Internals>Network component (but not its subcomponents). To do this, go
34 to the issue tracker and then click "Saved Queries".
35 Add a query with these settings:
eroman4cb6246c2016-02-23 04:00:2736 * Saved query name: Network Bug Triage
37 * Project: chromium
38 * Query: component=Internals>Network
39 * Subscription options: Notify Immediately
asankaddd5dc22015-03-20 15:52:4040
davidbenbeccd432016-06-22 18:13:1841* Look through unconfirmed and untriaged component=Internals>Network bugs,
asankaddd5dc22015-03-20 15:52:4042 prioritizing those updated within the last week. [Use this issue tracker
mmenke212fe432016-03-10 16:51:3343 query](https://bugs.chromium.org/p/chromium/issues/list?can=2&q=component%3DInternals%3ENetwork+status%3AUnconfirmed,Untriaged+-label:Needs-Feedback&sort=-modified).
asankaddd5dc22015-03-20 15:52:4044
45* If more information is needed from the reporter, ask for it and add the
mmenke212fe432016-03-10 16:51:3346 Needs-Feedback label.
asankaddd5dc22015-03-20 15:52:4047
48* While investigating a new issue, change the status to Untriaged.
49
50* If a bug is a potential security issue (Allows for code execution from remote
51 site, allows crossing security boundaries, unchecked array bounds, etc) mark
52 it Type-Bug-Security. If it has privacy implication (History, cookies
53 discoverable by an entity that shouldn't be able to do so, incognito state
54 being saved in memory or on disk beyond the lifetime of incognito tabs, etc),
eroman96211952016-02-22 21:42:0355 mark it with component Privacy.
asankaddd5dc22015-03-20 15:52:4056
eroman96211952016-02-22 21:42:0357* For bugs that already have a more specific network component, go ahead and
mmenke212fe432016-03-10 16:51:3358 remove the Internals>Network component to get them off the next triager's
59 radar and move on.
asankaddd5dc22015-03-20 15:52:4060
61* Try to figure out if it's really a network bug. See common non-network
eroman96211952016-02-22 21:42:0362 components section for description of common components for issues incorrectly
63 tagged as Internals>Network.
asankaddd5dc22015-03-20 15:52:4064
eroman96211952016-02-22 21:42:0365* If it's not, attach appropriate labels/components and go no further.
asankaddd5dc22015-03-20 15:52:4066
eroman96211952016-02-22 21:42:0367* If it may be a network bug, attach additional possibly relevant component if
asankaddd5dc22015-03-20 15:52:4068 any, and continue investigating. Once you either determine it's a
eroman96211952016-02-22 21:42:0369 non-network bug, or figure out accurate more specific network components, your
Matt Menkeae32850c2018-03-20 16:40:5570 job is done, though you should still ask for a net-export dump if it seems
asankaddd5dc22015-03-20 15:52:4071 likely to be useful.
72
derat817105082017-02-22 17:57:5573* Note that Chrome-OS-specific network-related code (Captive portal detection,
asankaddd5dc22015-03-20 15:52:4074 connectivity detection, login, etc) may not all have appropriate more
eroman96211952016-02-22 21:42:0375 specific subcomponents, but are not in areas handled by the network stack
76 team. Just make sure those have the OS-Chrome label, and any more specific
77 labels if applicable, and then move on.
asankaddd5dc22015-03-20 15:52:4078
79* Gather data and investigate.
80 * Remember to add the Needs-Feedback label whenever waiting for the user to
81 respond with more information, and remove it when not waiting on the
82 user.
83 * Try to reproduce locally. If you can, and it's a regression, use
84 src/tools/bisect-builds.py to figure out when it regressed.
Matt Menkeae32850c2018-03-20 16:40:5585 * Ask more data from the user as needed (net-export dumps, repro case,
86 crash ID from chrome://crashes, run tests, etc).
87 * If asking for a chrome://net-export dump, provide this link:
asankaddd5dc22015-03-20 15:52:4088 https://sites.google.com/a/chromium.org/dev/for-testers/providing-network-details.
asankaddd5dc22015-03-20 15:52:4089
eroman96211952016-02-22 21:42:0390* Try to figure out what's going on, and which more specific network component
91 is most appropriate.
asankaddd5dc22015-03-20 15:52:4092
93* If it's a regression, browse through the git history of relevant files to try
94 and figure out when it regressed. CC authors / primary reviewers of any
95 strongly suspect CLs.
96
97* If you are having trouble with an issue, particularly for help understanding
Matt Menkeae32850c2018-03-20 16:40:5598 net-export logs, email the public [email protected] list for help
asankaddd5dc22015-03-20 15:52:4099 debugging. If it's a crasher, or for some other reason discussion needs to
Eric Roman661816b92018-05-14 23:04:12100 be done in private, see [internal documentation for details](https://goto.google.com/network_triage_internal#getting-help-with-a-bug)
asankaddd5dc22015-03-20 15:52:40101
102* If it appears to be a bug in the unowned core of the network stack (i.e. no
eroman96211952016-02-22 21:42:03103 subcomponent applies, or only the Internals>Network>HTTP subcomponent
104 applies, and there's no clear owner), try to figure out the exact cause.
asankaddd5dc22015-03-20 15:52:40105
Eric Roman661816b92018-05-14 23:04:12106## Crashes
mmenke212fe432016-03-10 16:51:33107
Eric Roman661816b92018-05-14 23:04:12108For guidance on crashes see the internal documentation:
mmenke212fe432016-03-10 16:51:33109
Eric Roman661816b92018-05-14 23:04:12110* [Dealing with a crash ID](https://goto.google.com/network_triage_internal#dealing-with-a-crash-id)
111* [Looking for new crashers](https://goto.google.com/network_triage_internal#looking-for-new-crashers)
112* [Investigating crashers](https://goto.google.com/network_triage_internal#investigating-crashers)