Yulan Lin | 55ae6a3 | 2020-07-31 17:58:29 | [diff] [blame] | 1 | # Mandatory Code-Review and OWNERS |
| 2 | |
| 3 | Beginning in Q1 2021, committers@ of Chromium will no longer be able |
| 4 | to circumvent code review and OWNERS approval on CLs. |
| 5 | |
| 6 | Currently, these are circumventable by self-code-review and because the |
| 7 | enforcement is done by presumit, although rarely done by external |
| 8 | contributors. In Q1, Gerrit will disallow both bypasses. As part of the |
| 9 | transition, an audit service will automatically file bugs for CLs that |
| 10 | land with only self-approval, launching in Q4 2020. Within Google, where |
| 11 | these bypasses are more common, Googlers can find Google-specific |
| 12 | information in the internal announcements and landing site. |
| 13 | |
| 14 | Periodic updates and FAQs will be sent to chromium-dev@chromium.org |
Joe Mason | cffd2d7 | 2021-03-08 22:22:39 | [diff] [blame^] | 15 | and updated on this page. |
| 16 | |
| 17 | ## FAQS |
| 18 | |
| 19 | Q: Do I need a reviewer to merge CL's to another branch, even though they were |
| 20 | already reviewed on main? |
| 21 | |
| 22 | A: Yes, but within 7 days of the original change you can add the Rubber-Stamper |
| 23 | bot ([email protected]) as the reviewer. |