asanka | ddd5dc2 | 2015-03-20 15:52:40 | [diff] [blame^] | 1 | # Chrome Network Bug Triage : Labels |
| 2 | |
| 3 | ## Some network label caveats |
| 4 | |
| 5 | **Cr-UI-Browser-Downloads** |
| 6 | : Despite the name, this covers all issues related to downloading a file except |
| 7 | saving entire pages (which is **Cr-Blink-SavePage**), not just UI issues. |
| 8 | Most downloads bugs will have the word "download" or "save as" in the |
| 9 | description. Issues with the HTTP server for the Chrome binaries are not |
| 10 | downloads bugs. |
| 11 | |
| 12 | **Cr-UI-Browser-SafeBrowsing** |
| 13 | : Bugs that have to do with the process by which a URL or file is determined to |
| 14 | be dangerous based on our databases, or the resulting interstitials. |
| 15 | Determination of danger based purely on content-type or file extension |
| 16 | belongs in **Cr-UI-Browser-Downloads**, not SafeBrowsing. |
| 17 | |
| 18 | **Cr-Internals-Network-SSL** |
| 19 | : This includes issues that should be also tagged as **Cr-Security-UX** |
| 20 | (certificate error pages or other security interstitials, omnibox indicators |
| 21 | that a page is secure), and more general SSL issues. If you see requests |
| 22 | that die in the SSL negotiation phase, in particular, this is often the |
| 23 | correct label. |
| 24 | |
| 25 | **Cr-Internals-Network-DataProxy** |
| 26 | : Flywheel / the Data Reduction Proxy. Issues require "Reduce Data Usage" be |
| 27 | turned on. Proxy url is [https://proxy.googlezip.net:443](), with |
| 28 | [http://compress.googlezip.net:80]() as a fallback. Currently Android and |
| 29 | iOS only. |
| 30 | |
| 31 | **Cr-Internals-Network-Cache** |
| 32 | : The cache is the layer that handles most range request logic (Though range |
| 33 | requests may also be issued by the PDF plugin, XHRs, or other components). |
| 34 | |
| 35 | **Cr-Internals-Network-SPDY** |
| 36 | : Covers HTTP2 as well. |
| 37 | |
| 38 | **Cr-Internals-Network-HTTP** |
| 39 | : Typically not used. Unclear what it covers, and there's no specific HTTP |
| 40 | owner. |
| 41 | |
| 42 | **Cr-Internals-Network-Logging** |
| 43 | : Covers **about:net-internals**, **about:net-export** as well as the what's |
| 44 | sent to the NetLog. |
| 45 | |
| 46 | **Cr-Internals-Network-Connectivity** |
| 47 | : Issues related to switching between networks, ERR_NETWORK_CHANGED, Chrome |
| 48 | thinking it's online when it's not / navigator.onLine inaccuracies, etc. |
| 49 | |
| 50 | **Cr-Internals-Network-Filters** |
| 51 | : Covers SDCH and gzip issues. ERR_CONTENT_DECODING_FAILED indicates a problem |
| 52 | at this layer, and bugs here can also cause response body corruption. |
| 53 | |
| 54 | ## Common non-network labels |
| 55 | |
| 56 | Bugs in these areas often receive the **Cr-Internals-Network** label, though |
| 57 | they fall largely outside the purview of the network stack team: |
| 58 | |
| 59 | **Cr-Blink-Forms** |
| 60 | : Issues submitting forms, forms having weird data, forms sending the wrong |
| 61 | method, etc. |
| 62 | |
| 63 | **Cr-Blink-Loader** |
| 64 | : Cross origin issues are sometimes loader related. Blink also has an |
| 65 | in-memory cache, and when it's used, requests don't appear in |
| 66 | about:net-internals. Requests for the same URL are also often merged there |
| 67 | as well. This does *not* cover issues with content/browser/loader/ files. |
| 68 | |
| 69 | **Cr-Blink-ServiceWorker** |
| 70 | |
| 71 | **Cr-Blink-Storage-AppCache** |
| 72 | |
| 73 | **Cr-Blink-WebSockets** |
| 74 | |
| 75 | **Cr-Blink-XHR** |
| 76 | : Generic issues with sync/async XHR requests - missing request or response |
| 77 | headers, multiple headers, etc. These will often run into issues in certain |
| 78 | corner cases (Cross origin / CORS, proxy, whatever). Attach all labels that |
| 79 | seem appropriate. |
| 80 | |
| 81 | **Cr-Services-Sync** |
| 82 | : Sharing data/tabs/history/passwords/etc between machines not working. |
| 83 | |
| 84 | **Cr-Services-Chromoting** |
| 85 | |
| 86 | **Cr-Platform-Extensions** |
| 87 | : Issues extensions loading / not loading / hanging. |
| 88 | |
| 89 | **Cr-Platform-Extensions-API** |
| 90 | : Issues with network related extension APIs should have this label. |
| 91 | chrome.webRequest is the big one, I believe, but there are others. |
| 92 | |
| 93 | **Cr-Internals-Plugins-Pepper[-SDK]** |
| 94 | |
| 95 | **Cr-UI-Browser-Omnibox** |
| 96 | : Basically any issue with the omnibox. URLs being treated as search queries |
| 97 | rather than navigations, dropdown results being weird, not handling certain |
| 98 | unicode characters, etc. If the issue is new TLDs not being recognized by |
| 99 | the omnibox, that's due to Chrome's TLD list being out of date, and not an |
| 100 | omnibox issue. Such TLD issues should be duped against |
| 101 | http://crbug.com/37436. |
| 102 | |
| 103 | **Cr-Internals-Media-Network** |
| 104 | : Issues related to media. These often run into the 6 requests per hostname |
| 105 | issue, and also have fun interactions with the cache, particularly in the |
| 106 | range request case. |
| 107 | |
| 108 | **Cr-Internals-Plugins-PDF** |
| 109 | : Issues loading pdf files. These are often related to range requests, which |
| 110 | also have some logic at the Internals-Network-Cache layer. |
| 111 | |
| 112 | **Cr-UI-Browser-Navigation** |
| 113 | |
| 114 | **Cr-UI-Browser-History** |
| 115 | : Issues which only appear with forward/back navigation. |
| 116 | |
| 117 | **Cr-OS-Systems-Network** / **Cr-OS-Systems-Mobile** / **Cr-OS-Systems-Bluetooth** |
| 118 | : These should be used for issues with ChromeOS's platform network code, and |
| 119 | not net/ issues on ChromeOS. |
| 120 | |
| 121 | **Cr-Blink-SecurityFeature** |
| 122 | : CORS / Cross origin issues. Main frame cross-origin navigation issues are |
| 123 | often actually **Cr-UI-Browser-Navigation** issues. |
| 124 | |
| 125 | **Cr-Privacy** |
| 126 | : Privacy related bug (History, cookies discoverable by an entity that |
| 127 | shouldn't be able to do so, incognito state being saved in memory or on disk |
| 128 | beyond the lifetime of incognito tabs, etc). Generally used in conjunction |
| 129 | with other labels. |
| 130 | |
| 131 | **Type-Bug-Security** |
| 132 | : Security related bug (Allows for code execution from remote site, allows |
| 133 | crossing security boundaries, unchecked array bounds, |
| 134 | etc). |