blob: 790a98846b76898441c962170a14f2e53c21738d [file] [log] [blame]
sorin395c2ac2014-09-16 21:31:071// Copyright 2014 The Chromium Authors. All rights reserved.
2// Use of this source code is governed by a BSD-style license that can be
3// found in the LICENSE file.
4
dchengd0fc6aa92016-04-22 18:03:125#include "components/update_client/request_sender.h"
6
7#include <memory>
Sorin Jianua8ef73d2017-11-02 16:55:178#include <utility>
dchengd0fc6aa92016-04-22 18:03:129
Sebastien Marchand53801a32019-01-25 16:26:1110#include "base/bind.h"
sorin5cb1f5492014-09-23 04:07:4411#include "base/macros.h"
sorin9797aba2015-04-17 17:15:0312#include "base/memory/ref_counted.h"
davidben74f67442016-10-01 01:45:2213#include "base/path_service.h"
sorin395c2ac2014-09-16 21:31:0714#include "base/run_loop.h"
sorin1bc5eff2016-02-17 18:45:1715#include "base/strings/string_util.h"
Gabriel Charettec7108742019-08-23 03:31:4016#include "base/test/task_environment.h"
gab7966d312016-05-11 20:35:0117#include "base/threading/thread_task_runner_handle.h"
Sorin Jianu86ee558e2019-02-18 17:01:5018#include "components/update_client/net/url_loader_post_interceptor.h"
sorinb120440b2015-04-27 16:34:1519#include "components/update_client/test_configurator.h"
sorin395c2ac2014-09-16 21:31:0720#include "testing/gtest/include/gtest/gtest.h"
21
sorin52ac0882015-01-24 01:15:0022namespace update_client {
sorin395c2ac2014-09-16 21:31:0723
24namespace {
25
26const char kUrl1[] = "https://localhost2/path1";
27const char kUrl2[] = "https://localhost2/path2";
sorin395c2ac2014-09-16 21:31:0728
sorin1bc5eff2016-02-17 18:45:1729// TODO(sorin): refactor as a utility function for unit tests.
30base::FilePath test_file(const char* file) {
31 base::FilePath path;
Avi Drissmanf617d012018-05-02 18:48:5332 base::PathService::Get(base::DIR_SOURCE_ROOT, &path);
sorin1bc5eff2016-02-17 18:45:1733 return path.AppendASCII("components")
34 .AppendASCII("test")
35 .AppendASCII("data")
36 .AppendASCII("update_client")
37 .AppendASCII(file);
38}
39
sorin395c2ac2014-09-16 21:31:0740} // namespace
41
Sorin Jianud907dbf62018-02-21 17:18:2942class RequestSenderTest : public testing::Test,
43 public ::testing::WithParamInterface<bool> {
sorin395c2ac2014-09-16 21:31:0744 public:
45 RequestSenderTest();
dcheng30a1b1542014-10-29 21:27:5046 ~RequestSenderTest() override;
sorin395c2ac2014-09-16 21:31:0747
48 // Overrides from testing::Test.
dcheng30a1b1542014-10-29 21:27:5049 void SetUp() override;
50 void TearDown() override;
sorin395c2ac2014-09-16 21:31:0751
sorinfccbf2d2016-04-04 20:34:3452 void RequestSenderComplete(int error,
53 const std::string& response,
54 int retry_after_sec);
sorin395c2ac2014-09-16 21:31:0755
56 protected:
57 void Quit();
58 void RunThreads();
Francois Dorayff8a6452017-07-27 17:11:5859
Gabriel Charettedfa36042019-08-19 17:30:1160 base::test::TaskEnvironment task_environment_;
sorin395c2ac2014-09-16 21:31:0761
sorin9797aba2015-04-17 17:15:0362 scoped_refptr<TestConfigurator> config_;
dchengd0fc6aa92016-04-22 18:03:1263 std::unique_ptr<RequestSender> request_sender_;
sorin395c2ac2014-09-16 21:31:0764
Antonio Gomesb6162502018-06-28 20:21:5565 std::unique_ptr<URLLoaderPostInterceptor> post_interceptor_;
sorin395c2ac2014-09-16 21:31:0766
sorin519656c2017-04-28 22:39:3467 int error_ = 0;
sorin1bc5eff2016-02-17 18:45:1768 std::string response_;
sorin395c2ac2014-09-16 21:31:0769
70 private:
Sorin Jianua8ef73d2017-11-02 16:55:1771 base::OnceClosure quit_closure_;
sorin395c2ac2014-09-16 21:31:0772
73 DISALLOW_COPY_AND_ASSIGN(RequestSenderTest);
74};
75
Victor Costan1559fac2019-02-13 13:29:5076INSTANTIATE_TEST_SUITE_P(IsForeground, RequestSenderTest, ::testing::Bool());
Sorin Jianud907dbf62018-02-21 17:18:2977
Francois Dorayff8a6452017-07-27 17:11:5878RequestSenderTest::RequestSenderTest()
Gabriel Charettedfa36042019-08-19 17:30:1179 : task_environment_(base::test::TaskEnvironment::MainThreadType::IO) {}
sorin395c2ac2014-09-16 21:31:0780
Sorin Jianu30881152020-03-16 14:31:1981RequestSenderTest::~RequestSenderTest() = default;
sorin395c2ac2014-09-16 21:31:0782
83void RequestSenderTest::SetUp() {
Sorin Jianucc048f892017-07-26 02:05:5484 config_ = base::MakeRefCounted<TestConfigurator>();
Sorin Jianu015681f2018-04-04 16:43:3385 request_sender_ = std::make_unique<RequestSender>(config_);
86
Antonio Gomesb6162502018-06-28 20:21:5587 std::vector<GURL> urls;
88 urls.push_back(GURL(kUrl1));
89 urls.push_back(GURL(kUrl2));
90
91 post_interceptor_ = std::make_unique<URLLoaderPostInterceptor>(
92 urls, config_->test_url_loader_factory());
93 EXPECT_TRUE(post_interceptor_);
sorin395c2ac2014-09-16 21:31:0794}
95
96void RequestSenderTest::TearDown() {
sorin519656c2017-04-28 22:39:3497 request_sender_ = nullptr;
sorin395c2ac2014-09-16 21:31:0798
Antonio Gomesb6162502018-06-28 20:21:5599 post_interceptor_.reset();
sorin395c2ac2014-09-16 21:31:07100
Sorin Jianuf805c222017-09-20 22:36:21101 // Run the threads until they are idle to allow the clean up
102 // of the network interceptors on the IO thread.
Gabriel Charettedfa36042019-08-19 17:30:11103 task_environment_.RunUntilIdle();
sorin9797aba2015-04-17 17:15:03104 config_ = nullptr;
sorin395c2ac2014-09-16 21:31:07105}
106
107void RequestSenderTest::RunThreads() {
108 base::RunLoop runloop;
109 quit_closure_ = runloop.QuitClosure();
110 runloop.Run();
sorin395c2ac2014-09-16 21:31:07111}
112
113void RequestSenderTest::Quit() {
114 if (!quit_closure_.is_null())
Sorin Jianua8ef73d2017-11-02 16:55:17115 std::move(quit_closure_).Run();
sorin395c2ac2014-09-16 21:31:07116}
117
sorin1bc5eff2016-02-17 18:45:17118void RequestSenderTest::RequestSenderComplete(int error,
sorinfccbf2d2016-04-04 20:34:34119 const std::string& response,
120 int retry_after_sec) {
sorin1bc5eff2016-02-17 18:45:17121 error_ = error;
122 response_ = response;
123
sorin395c2ac2014-09-16 21:31:07124 Quit();
125}
126
127// Tests that when a request to the first url succeeds, the subsequent urls are
128// not tried.
Sorin Jianud907dbf62018-02-21 17:18:29129TEST_P(RequestSenderTest, RequestSendSuccess) {
Sorin Jianu015681f2018-04-04 16:43:33130 EXPECT_TRUE(
Antonio Gomesb6162502018-06-28 20:21:55131 post_interceptor_->ExpectRequest(std::make_unique<PartialMatch>("test"),
Joshua Pawlicki8ac39322019-04-04 21:22:46132 test_file("updatecheck_reply_1.json")));
sorin395c2ac2014-09-16 21:31:07133
Sorin Jianud907dbf62018-02-21 17:18:29134 const bool is_foreground = GetParam();
Sorin Jianua8ef73d2017-11-02 16:55:17135 request_sender_->Send(
Sorin Jianu015681f2018-04-04 16:43:33136 {GURL(kUrl1), GURL(kUrl2)},
137 {{"X-Goog-Update-Interactivity", is_foreground ? "fg" : "bg"}}, "test",
138 false,
Sorin Jianua8ef73d2017-11-02 16:55:17139 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
140 base::Unretained(this)));
sorin395c2ac2014-09-16 21:31:07141 RunThreads();
142
Antonio Gomesb6162502018-06-28 20:21:55143 EXPECT_EQ(1, post_interceptor_->GetHitCount())
144 << post_interceptor_->GetRequestsAsString();
145 EXPECT_EQ(1, post_interceptor_->GetCount())
146 << post_interceptor_->GetRequestsAsString();
sorin395c2ac2014-09-16 21:31:07147
Antonio Gomesb6162502018-06-28 20:21:55148 EXPECT_EQ(0, post_interceptor_->GetHitCountForURL(GURL(kUrl2)))
149 << post_interceptor_->GetRequestsAsString();
sorin30474f02017-04-27 00:45:48150
sorin1bc5eff2016-02-17 18:45:17151 // Sanity check the request.
Antonio Gomesb6162502018-06-28 20:21:55152 EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
sorin1bc5eff2016-02-17 18:45:17153
154 // Check the response post conditions.
155 EXPECT_EQ(0, error_);
Joshua Pawlicki8ac39322019-04-04 21:22:46156 EXPECT_EQ(419ul, response_.size());
Sorin Jianuf805c222017-09-20 22:36:21157
Sorin Jianud907dbf62018-02-21 17:18:29158 // Check the interactivity header value.
159 const auto extra_request_headers =
Antonio Gomesb6162502018-06-28 20:21:55160 std::get<1>(post_interceptor_->GetRequests()[0]);
Sorin Jianu1ab71d12018-03-12 18:11:39161 EXPECT_TRUE(extra_request_headers.HasHeader("X-Goog-Update-Interactivity"));
Sorin Jianud907dbf62018-02-21 17:18:29162 std::string header;
Sorin Jianu1ab71d12018-03-12 18:11:39163 extra_request_headers.GetHeader("X-Goog-Update-Interactivity", &header);
Sorin Jianud907dbf62018-02-21 17:18:29164 EXPECT_STREQ(is_foreground ? "fg" : "bg", header.c_str());
sorin395c2ac2014-09-16 21:31:07165}
166
167// Tests that the request succeeds using the second url after the first url
168// has failed.
169TEST_F(RequestSenderTest, RequestSendSuccessWithFallback) {
Antonio Gomesb6162502018-06-28 20:21:55170 EXPECT_TRUE(post_interceptor_->ExpectRequest(
171 std::make_unique<PartialMatch>("test"), net::HTTP_FORBIDDEN));
172 EXPECT_TRUE(
173 post_interceptor_->ExpectRequest(std::make_unique<PartialMatch>("test")));
sorin395c2ac2014-09-16 21:31:07174
Sorin Jianua8ef73d2017-11-02 16:55:17175 request_sender_->Send(
Sorin Jianu015681f2018-04-04 16:43:33176 {GURL(kUrl1), GURL(kUrl2)}, {}, "test", false,
Sorin Jianua8ef73d2017-11-02 16:55:17177 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
178 base::Unretained(this)));
sorin395c2ac2014-09-16 21:31:07179 RunThreads();
180
Antonio Gomesb6162502018-06-28 20:21:55181 EXPECT_EQ(2, post_interceptor_->GetHitCount())
182 << post_interceptor_->GetRequestsAsString();
183 EXPECT_EQ(2, post_interceptor_->GetCount())
184 << post_interceptor_->GetRequestsAsString();
185 EXPECT_EQ(1, post_interceptor_->GetHitCountForURL(GURL(kUrl1)))
186 << post_interceptor_->GetRequestsAsString();
187 EXPECT_EQ(1, post_interceptor_->GetHitCountForURL(GURL(kUrl2)))
188 << post_interceptor_->GetRequestsAsString();
sorin395c2ac2014-09-16 21:31:07189
Antonio Gomesb6162502018-06-28 20:21:55190 EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
191 EXPECT_STREQ("test", post_interceptor_->GetRequestBody(1).c_str());
sorin1bc5eff2016-02-17 18:45:17192 EXPECT_EQ(0, error_);
sorin395c2ac2014-09-16 21:31:07193}
194
195// Tests that the request fails when both urls have failed.
196TEST_F(RequestSenderTest, RequestSendFailed) {
Antonio Gomesb6162502018-06-28 20:21:55197 EXPECT_TRUE(post_interceptor_->ExpectRequest(
198 std::make_unique<PartialMatch>("test"), net::HTTP_FORBIDDEN));
199 EXPECT_TRUE(post_interceptor_->ExpectRequest(
200 std::make_unique<PartialMatch>("test"), net::HTTP_FORBIDDEN));
sorin395c2ac2014-09-16 21:31:07201
sorin519656c2017-04-28 22:39:34202 const std::vector<GURL> urls = {GURL(kUrl1), GURL(kUrl2)};
Jinho Bangda4e4282018-01-03 13:21:23203 request_sender_ = std::make_unique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17204 request_sender_->Send(
Sorin Jianua64a1e52018-02-28 16:53:34205 urls, {}, "test", false,
Sorin Jianua8ef73d2017-11-02 16:55:17206 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
207 base::Unretained(this)));
sorin395c2ac2014-09-16 21:31:07208 RunThreads();
209
Antonio Gomesb6162502018-06-28 20:21:55210 EXPECT_EQ(2, post_interceptor_->GetHitCount())
211 << post_interceptor_->GetRequestsAsString();
212 EXPECT_EQ(2, post_interceptor_->GetCount())
213 << post_interceptor_->GetRequestsAsString();
214 EXPECT_EQ(1, post_interceptor_->GetHitCountForURL(GURL(kUrl1)))
215 << post_interceptor_->GetRequestsAsString();
216 EXPECT_EQ(1, post_interceptor_->GetHitCountForURL(GURL(kUrl2)))
217 << post_interceptor_->GetRequestsAsString();
sorin395c2ac2014-09-16 21:31:07218
Antonio Gomesb6162502018-06-28 20:21:55219 EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
220 EXPECT_STREQ("test", post_interceptor_->GetRequestBody(1).c_str());
sorin1bc5eff2016-02-17 18:45:17221 EXPECT_EQ(403, error_);
sorin395c2ac2014-09-16 21:31:07222}
223
sorin5cabcf0b2015-06-09 00:54:44224// Tests that the request fails when no urls are provided.
225TEST_F(RequestSenderTest, RequestSendFailedNoUrls) {
226 std::vector<GURL> urls;
Jinho Bangda4e4282018-01-03 13:21:23227 request_sender_ = std::make_unique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17228 request_sender_->Send(
Sorin Jianuc303bf42018-09-07 16:19:33229 urls, {}, "test", false,
Sorin Jianua8ef73d2017-11-02 16:55:17230 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
231 base::Unretained(this)));
sorin5cabcf0b2015-06-09 00:54:44232 RunThreads();
233
Sorin Jianu888ec292018-06-01 15:35:42234 EXPECT_EQ(-10002, error_);
sorin1bc5eff2016-02-17 18:45:17235}
236
237// Tests that a CUP request fails if the response is not signed.
238TEST_F(RequestSenderTest, RequestSendCupError) {
Sorin Jianu015681f2018-04-04 16:43:33239 EXPECT_TRUE(
Antonio Gomesb6162502018-06-28 20:21:55240 post_interceptor_->ExpectRequest(std::make_unique<PartialMatch>("test"),
Joshua Pawlicki8ac39322019-04-04 21:22:46241 test_file("updatecheck_reply_1.json")));
sorin1bc5eff2016-02-17 18:45:17242
sorin519656c2017-04-28 22:39:34243 const std::vector<GURL> urls = {GURL(kUrl1)};
Jinho Bangda4e4282018-01-03 13:21:23244 request_sender_ = std::make_unique<RequestSender>(config_);
Sorin Jianua8ef73d2017-11-02 16:55:17245 request_sender_->Send(
Sorin Jianua64a1e52018-02-28 16:53:34246 urls, {}, "test", true,
Sorin Jianua8ef73d2017-11-02 16:55:17247 base::BindOnce(&RequestSenderTest::RequestSenderComplete,
248 base::Unretained(this)));
sorin1bc5eff2016-02-17 18:45:17249 RunThreads();
250
Antonio Gomesb6162502018-06-28 20:21:55251 EXPECT_EQ(1, post_interceptor_->GetHitCount())
252 << post_interceptor_->GetRequestsAsString();
253 EXPECT_EQ(1, post_interceptor_->GetCount())
254 << post_interceptor_->GetRequestsAsString();
sorin1bc5eff2016-02-17 18:45:17255
Antonio Gomesb6162502018-06-28 20:21:55256 EXPECT_STREQ("test", post_interceptor_->GetRequestBody(0).c_str());
Sorin Jianu888ec292018-06-01 15:35:42257 EXPECT_EQ(-10000, error_);
sorin1bc5eff2016-02-17 18:45:17258 EXPECT_TRUE(response_.empty());
sorin5cabcf0b2015-06-09 00:54:44259}
260
sorin52ac0882015-01-24 01:15:00261} // namespace update_client