sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1 | // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 | // Use of this source code is governed by a BSD-style license that can be |
| 3 | // found in the LICENSE file. |
| 4 | |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 5 | #include <memory> |
dcheng | 51ace48a | 2015-12-26 22:45:17 | [diff] [blame] | 6 | #include <utility> |
| 7 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 8 | #include "base/bind.h" |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 9 | #include "base/containers/flat_map.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 10 | #include "base/files/file_path.h" |
| 11 | #include "base/files/file_util.h" |
| 12 | #include "base/location.h" |
avi | 5dd91f8 | 2015-12-25 22:30:46 | [diff] [blame] | 13 | #include "base/macros.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 14 | #include "base/memory/ref_counted.h" |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 15 | #include "base/optional.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 16 | #include "base/path_service.h" |
| 17 | #include "base/run_loop.h" |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 18 | #include "base/stl_util.h" |
Gabriel Charette | 44db142 | 2018-08-06 11:19:33 | [diff] [blame] | 19 | #include "base/task/post_task.h" |
| 20 | #include "base/task/task_traits.h" |
Gabriel Charette | dd8d5985e | 2020-02-26 18:38:35 | [diff] [blame] | 21 | #include "base/task/thread_pool.h" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 22 | #include "base/test/scoped_path_override.h" |
Gabriel Charette | c710874 | 2019-08-23 03:31:40 | [diff] [blame] | 23 | #include "base/test/task_environment.h" |
gab | 7966d31 | 2016-05-11 20:35:01 | [diff] [blame] | 24 | #include "base/threading/thread_task_runner_handle.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 25 | #include "base/values.h" |
| 26 | #include "base/version.h" |
Sorin Jianu | 18890707 | 2018-01-22 18:42:22 | [diff] [blame] | 27 | #include "build/build_config.h" |
Joshua Pawlicki | f4b33f38 | 2018-08-17 17:36:51 | [diff] [blame] | 28 | #include "components/crx_file/crx_verifier.h" |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 29 | #include "components/prefs/testing_pref_service.h" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 30 | #include "components/update_client/component_unpacker.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 31 | #include "components/update_client/crx_update_item.h" |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 32 | #include "components/update_client/network.h" |
Joshua Pawlicki | d5409e1 | 2019-04-06 00:23:11 | [diff] [blame] | 33 | #include "components/update_client/patcher.h" |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 34 | #include "components/update_client/persisted_data.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 35 | #include "components/update_client/ping_manager.h" |
Joshua Pawlicki | 8ac3932 | 2019-04-04 21:22:46 | [diff] [blame] | 36 | #include "components/update_client/protocol_handler.h" |
sorin | b120440b | 2015-04-27 16:34:15 | [diff] [blame] | 37 | #include "components/update_client/test_configurator.h" |
| 38 | #include "components/update_client/test_installer.h" |
Joshua Pawlicki | d5409e1 | 2019-04-06 00:23:11 | [diff] [blame] | 39 | #include "components/update_client/unzipper.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 40 | #include "components/update_client/update_checker.h" |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 41 | #include "components/update_client/update_client_errors.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 42 | #include "components/update_client/update_client_internal.h" |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 43 | #include "testing/gmock/include/gmock/gmock.h" |
| 44 | #include "testing/gtest/include/gtest/gtest.h" |
| 45 | #include "url/gurl.h" |
| 46 | |
| 47 | namespace update_client { |
| 48 | |
| 49 | namespace { |
| 50 | |
| 51 | using base::FilePath; |
| 52 | |
| 53 | // Makes a copy of the file specified by |from_path| in a temporary directory |
| 54 | // and returns the path of the copy. Returns true if successful. Cleans up if |
| 55 | // there was an error creating the copy. |
| 56 | bool MakeTestFile(const FilePath& from_path, FilePath* to_path) { |
| 57 | FilePath temp_dir; |
| 58 | bool result = |
| 59 | CreateNewTempDirectory(FILE_PATH_LITERAL("update_client"), &temp_dir); |
| 60 | if (!result) |
| 61 | return false; |
| 62 | |
| 63 | FilePath temp_file; |
| 64 | result = CreateTemporaryFileInDir(temp_dir, &temp_file); |
| 65 | if (!result) |
| 66 | return false; |
| 67 | |
| 68 | result = CopyFile(from_path, temp_file); |
| 69 | if (!result) { |
| 70 | DeleteFile(temp_file, false); |
| 71 | return false; |
| 72 | } |
| 73 | |
| 74 | *to_path = temp_file; |
| 75 | return true; |
| 76 | } |
| 77 | |
| 78 | using Events = UpdateClient::Observer::Events; |
| 79 | |
| 80 | class MockObserver : public UpdateClient::Observer { |
| 81 | public: |
| 82 | MOCK_METHOD2(OnEvent, void(Events event, const std::string&)); |
| 83 | }; |
| 84 | |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 85 | class MockActionHandler : public ActionHandler { |
| 86 | public: |
| 87 | MockActionHandler() = default; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 88 | MockActionHandler(const MockActionHandler&) = delete; |
| 89 | MockActionHandler& operator=(const MockActionHandler&) = delete; |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 90 | |
| 91 | MOCK_METHOD3(Handle, |
| 92 | void(const base::FilePath&, const std::string&, Callback)); |
| 93 | |
| 94 | private: |
| 95 | ~MockActionHandler() override = default; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 96 | }; |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 97 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 98 | class MockCrxStateChangeReceiver |
| 99 | : public base::RefCounted<MockCrxStateChangeReceiver> { |
| 100 | public: |
| 101 | MOCK_METHOD(void, Receive, (CrxUpdateItem)); |
| 102 | |
| 103 | private: |
| 104 | friend class base::RefCounted<MockCrxStateChangeReceiver>; |
| 105 | |
| 106 | ~MockCrxStateChangeReceiver() = default; |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 107 | }; |
| 108 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 109 | } // namespace |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 110 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 111 | using ::testing::_; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 112 | using ::testing::AnyNumber; |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 113 | using ::testing::AtLeast; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 114 | using ::testing::DoAll; |
| 115 | using ::testing::InSequence; |
| 116 | using ::testing::Invoke; |
| 117 | using ::testing::Mock; |
| 118 | using ::testing::Return; |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 119 | using ::testing::Unused; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 120 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 121 | using std::string; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 122 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 123 | class MockPingManagerImpl : public PingManager { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 124 | public: |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 125 | struct PingData { |
| 126 | std::string id; |
| 127 | base::Version previous_version; |
| 128 | base::Version next_version; |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 129 | ErrorCategory error_category = ErrorCategory::kNone; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 130 | int error_code = 0; |
| 131 | int extra_code1 = 0; |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 132 | ErrorCategory diff_error_category = ErrorCategory::kNone; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 133 | int diff_error_code = 0; |
| 134 | bool diff_update_failed = false; |
| 135 | }; |
| 136 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 137 | explicit MockPingManagerImpl(scoped_refptr<Configurator> config); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 138 | |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 139 | void SendPing(const Component& component, Callback callback) override; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 140 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 141 | const std::vector<PingData>& ping_data() const; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 142 | |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 143 | const std::vector<base::Value>& events() const; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 144 | |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 145 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 146 | ~MockPingManagerImpl() override; |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 147 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 148 | private: |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 149 | std::vector<PingData> ping_data_; |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 150 | std::vector<base::Value> events_; |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 151 | DISALLOW_COPY_AND_ASSIGN(MockPingManagerImpl); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 152 | }; |
| 153 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 154 | MockPingManagerImpl::MockPingManagerImpl(scoped_refptr<Configurator> config) |
sorin | 958b5d3 | 2016-01-09 02:00:20 | [diff] [blame] | 155 | : PingManager(config) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 156 | |
Sorin Jianu | 3088115 | 2020-03-16 14:31:19 | [diff] [blame] | 157 | MockPingManagerImpl::~MockPingManagerImpl() = default; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 158 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 159 | void MockPingManagerImpl::SendPing(const Component& component, |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 160 | Callback callback) { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 161 | PingData ping_data; |
| 162 | ping_data.id = component.id_; |
| 163 | ping_data.previous_version = component.previous_version_; |
| 164 | ping_data.next_version = component.next_version_; |
| 165 | ping_data.error_category = component.error_category_; |
| 166 | ping_data.error_code = component.error_code_; |
| 167 | ping_data.extra_code1 = component.extra_code1_; |
| 168 | ping_data.diff_error_category = component.diff_error_category_; |
| 169 | ping_data.diff_error_code = component.diff_error_code_; |
| 170 | ping_data.diff_update_failed = component.diff_update_failed(); |
| 171 | ping_data_.push_back(ping_data); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 172 | |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 173 | events_ = component.GetEvents(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 174 | |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 175 | std::move(callback).Run(0, ""); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 176 | } |
| 177 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 178 | const std::vector<MockPingManagerImpl::PingData>& |
| 179 | MockPingManagerImpl::ping_data() const { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 180 | return ping_data_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 181 | } |
| 182 | |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 183 | const std::vector<base::Value>& MockPingManagerImpl::events() const { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 184 | return events_; |
| 185 | } |
| 186 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 187 | class UpdateClientTest : public testing::Test { |
| 188 | public: |
| 189 | UpdateClientTest(); |
| 190 | ~UpdateClientTest() override; |
| 191 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 192 | protected: |
| 193 | void RunThreads(); |
| 194 | |
| 195 | // Returns the full path to a test file. |
| 196 | static base::FilePath TestFilePath(const char* file); |
| 197 | |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 198 | scoped_refptr<update_client::TestConfigurator> config() { return config_; } |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 199 | update_client::PersistedData* metadata() { return metadata_.get(); } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 200 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 201 | base::OnceClosure quit_closure() { return runloop_.QuitClosure(); } |
sorin | f9f4834d | 2015-04-28 17:15:02 | [diff] [blame] | 202 | |
| 203 | private: |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 204 | static constexpr int kNumWorkerThreads_ = 2; |
sorin | f9f4834d | 2015-04-28 17:15:02 | [diff] [blame] | 205 | |
Gabriel Charette | dfa3604 | 2019-08-19 17:30:11 | [diff] [blame] | 206 | base::test::TaskEnvironment task_environment_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 207 | base::RunLoop runloop_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 208 | |
Sorin Jianu | cc048f89 | 2017-07-26 02:05:54 | [diff] [blame] | 209 | std::unique_ptr<TestingPrefServiceSimple> pref_ = |
Jinho Bang | da4e428 | 2018-01-03 13:21:23 | [diff] [blame] | 210 | std::make_unique<TestingPrefServiceSimple>(); |
Sorin Jianu | b925867 | 2020-02-19 16:52:17 | [diff] [blame] | 211 | scoped_refptr<update_client::TestConfigurator> config_ = |
| 212 | base::MakeRefCounted<TestConfigurator>(pref_.get()); |
| 213 | std::unique_ptr<update_client::PersistedData> metadata_ = |
| 214 | std::make_unique<PersistedData>(pref_.get(), nullptr); |
sorin | f9f4834d | 2015-04-28 17:15:02 | [diff] [blame] | 215 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 216 | DISALLOW_COPY_AND_ASSIGN(UpdateClientTest); |
| 217 | }; |
| 218 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 219 | constexpr int UpdateClientTest::kNumWorkerThreads_; |
| 220 | |
Sorin Jianu | cc048f89 | 2017-07-26 02:05:54 | [diff] [blame] | 221 | UpdateClientTest::UpdateClientTest() { |
waffles | d2d9a33 | 2016-04-09 01:59:57 | [diff] [blame] | 222 | PersistedData::RegisterPrefs(pref_->registry()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 223 | } |
| 224 | |
Sorin Jianu | 3088115 | 2020-03-16 14:31:19 | [diff] [blame] | 225 | UpdateClientTest::~UpdateClientTest() = default; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 226 | |
| 227 | void UpdateClientTest::RunThreads() { |
| 228 | runloop_.Run(); |
Gabriel Charette | dfa3604 | 2019-08-19 17:30:11 | [diff] [blame] | 229 | task_environment_.RunUntilIdle(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 230 | } |
| 231 | |
| 232 | base::FilePath UpdateClientTest::TestFilePath(const char* file) { |
| 233 | base::FilePath path; |
Avi Drissman | f617d01 | 2018-05-02 18:48:53 | [diff] [blame] | 234 | base::PathService::Get(base::DIR_SOURCE_ROOT, &path); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 235 | return path.AppendASCII("components") |
| 236 | .AppendASCII("test") |
| 237 | .AppendASCII("data") |
| 238 | .AppendASCII("update_client") |
| 239 | .AppendASCII(file); |
| 240 | } |
| 241 | |
| 242 | // Tests the scenario where one update check is done for one CRX. The CRX |
| 243 | // has no update. |
| 244 | TEST_F(UpdateClientTest, OneCrxNoUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 245 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 246 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 247 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 248 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 249 | CrxComponent crx; |
| 250 | crx.name = "test_jebg"; |
| 251 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 252 | crx.version = base::Version("0.9"); |
| 253 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 254 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 255 | std::vector<base::Optional<CrxComponent>> component = {crx}; |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 256 | return component; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 257 | } |
| 258 | }; |
| 259 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 260 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 261 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 262 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 263 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 264 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 265 | } |
| 266 | }; |
| 267 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 268 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 269 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 270 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 271 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 272 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 273 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 274 | } |
| 275 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 276 | void CheckForUpdates( |
| 277 | const std::string& session_id, |
| 278 | const std::vector<std::string>& ids_to_check, |
| 279 | const IdToComponentPtrMap& components, |
| 280 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 281 | bool enabled_component_updates, |
| 282 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 283 | EXPECT_FALSE(session_id.empty()); |
sorin | 590921d | 2016-08-11 23:48:36 | [diff] [blame] | 284 | EXPECT_TRUE(enabled_component_updates); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 285 | EXPECT_EQ(1u, ids_to_check.size()); |
| 286 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 287 | EXPECT_EQ(id, ids_to_check.front()); |
| 288 | EXPECT_EQ(1u, components.count(id)); |
| 289 | |
| 290 | auto& component = components.at(id); |
| 291 | |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 292 | EXPECT_TRUE(component->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 293 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 294 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 295 | result.extension_id = id; |
| 296 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 297 | |
| 298 | ProtocolParser::Results results; |
| 299 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 300 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 301 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 302 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 303 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 304 | } |
| 305 | }; |
| 306 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 307 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 308 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 309 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 310 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 311 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 312 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 313 | } |
| 314 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 315 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 316 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 317 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 318 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 319 | }; |
| 320 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 321 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 322 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 323 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 324 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 325 | |
| 326 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 327 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 328 | }; |
| 329 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 330 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 331 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 332 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 333 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 334 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 335 | MockObserver observer; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 336 | { |
| 337 | InSequence seq; |
| 338 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 339 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 340 | .Times(1); |
| 341 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 342 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 343 | .Times(1); |
| 344 | } |
| 345 | |
| 346 | std::vector<CrxUpdateItem> items; |
| 347 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 348 | EXPECT_CALL(*receiver, Receive(_)) |
| 349 | .WillRepeatedly( |
| 350 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 351 | |
| 352 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 353 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 354 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 355 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 356 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), true, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 357 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 358 | RunThreads(); |
| 359 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 360 | EXPECT_EQ(2u, items.size()); |
| 361 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 362 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 363 | EXPECT_EQ(ComponentState::kUpToDate, items[1].state); |
| 364 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[1].id.c_str()); |
| 365 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 366 | update_client->RemoveObserver(&observer); |
| 367 | } |
| 368 | |
| 369 | // Tests the scenario where two CRXs are checked for updates. On CRX has |
| 370 | // an update, the other CRX does not. |
| 371 | TEST_F(UpdateClientTest, TwoCrxUpdateNoUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 372 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 373 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 374 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 375 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 376 | CrxComponent crx1; |
| 377 | crx1.name = "test_jebg"; |
| 378 | crx1.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 379 | crx1.version = base::Version("0.9"); |
| 380 | crx1.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 381 | crx1.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 382 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 383 | CrxComponent crx2; |
| 384 | crx2.name = "test_abag"; |
| 385 | crx2.pk_hash.assign(abag_hash, abag_hash + base::size(abag_hash)); |
| 386 | crx2.version = base::Version("2.2"); |
| 387 | crx2.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 388 | crx2.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 389 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 390 | return {crx1, crx2}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 391 | } |
| 392 | }; |
| 393 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 394 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 395 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 396 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 397 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 398 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 399 | } |
| 400 | }; |
| 401 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 402 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 403 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 404 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 405 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 406 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 407 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 408 | } |
| 409 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 410 | void CheckForUpdates( |
| 411 | const std::string& session_id, |
| 412 | const std::vector<std::string>& ids_to_check, |
| 413 | const IdToComponentPtrMap& components, |
| 414 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 415 | bool enabled_component_updates, |
| 416 | UpdateCheckCallback update_check_callback) override { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 417 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 418 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 419 | |
| 420 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 421 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 422 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 423 | <updatecheck status='ok'> |
| 424 | <urls> |
| 425 | <url codebase='http://localhost/download/'/> |
| 426 | </urls> |
| 427 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 428 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 429 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 430 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 431 | a284a7cd8059c3409ce0498'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 432 | </packages> |
| 433 | </manifest> |
| 434 | </updatecheck> |
| 435 | </app> |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 436 | <app appid='abagagagagagagagagagagagagagagag'> |
| 437 | <updatecheck status='noupdate'/> |
| 438 | </app> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 439 | </response> |
| 440 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 441 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 442 | EXPECT_TRUE(enabled_component_updates); |
| 443 | EXPECT_EQ(2u, ids_to_check.size()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 444 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 445 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 446 | { |
| 447 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 448 | EXPECT_EQ(id, ids_to_check[0]); |
| 449 | EXPECT_EQ(1u, components.count(id)); |
| 450 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 451 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 452 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 453 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 454 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 455 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 456 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 457 | result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 458 | result.status = "ok"; |
| 459 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 460 | result.manifest.version = "1.0"; |
| 461 | result.manifest.browser_min_version = "11.0.1.0"; |
| 462 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 463 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 464 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 465 | EXPECT_FALSE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 466 | } |
| 467 | |
| 468 | { |
| 469 | const std::string id = "abagagagagagagagagagagagagagagag"; |
| 470 | EXPECT_EQ(id, ids_to_check[1]); |
| 471 | EXPECT_EQ(1u, components.count(id)); |
| 472 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 473 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 474 | result.extension_id = id; |
| 475 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 476 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 477 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 478 | EXPECT_FALSE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 479 | } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 480 | |
| 481 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 482 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 483 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 484 | } |
| 485 | }; |
| 486 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 487 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 488 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 489 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 490 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 491 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 492 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 493 | } |
| 494 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 495 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 496 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 497 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 498 | void DoStartDownload(const GURL& url) override { |
| 499 | DownloadMetrics download_metrics; |
| 500 | download_metrics.url = url; |
| 501 | download_metrics.downloader = DownloadMetrics::kNone; |
| 502 | download_metrics.error = 0; |
| 503 | download_metrics.downloaded_bytes = 1843; |
| 504 | download_metrics.total_bytes = 1843; |
| 505 | download_metrics.download_time_ms = 1000; |
| 506 | |
| 507 | FilePath path; |
| 508 | EXPECT_TRUE(MakeTestFile( |
| 509 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 510 | |
| 511 | Result result; |
| 512 | result.error = 0; |
| 513 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 514 | |
| 515 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 516 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 517 | base::Unretained(this))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 518 | |
| 519 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 520 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 521 | base::Unretained(this), true, result, |
| 522 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 523 | } |
| 524 | }; |
| 525 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 526 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 527 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 528 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 529 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 530 | |
| 531 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 532 | ~MockPingManager() override { |
| 533 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 534 | EXPECT_EQ(1u, ping_data.size()); |
| 535 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 536 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 537 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 538 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 539 | EXPECT_EQ(0, ping_data[0].error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 540 | } |
| 541 | }; |
| 542 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 543 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 544 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 545 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 546 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 547 | |
| 548 | MockObserver observer; |
| 549 | { |
| 550 | InSequence seq; |
| 551 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 552 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 553 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 554 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 555 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 556 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 557 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 558 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 559 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 560 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 561 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 562 | } |
| 563 | { |
| 564 | InSequence seq; |
| 565 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 566 | "abagagagagagagagagagagagagagagag")).Times(1); |
| 567 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 568 | "abagagagagagagagagagagagagagagag")).Times(1); |
| 569 | } |
| 570 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 571 | std::vector<CrxUpdateItem> items; |
| 572 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 573 | EXPECT_CALL(*receiver, Receive(_)) |
| 574 | .WillRepeatedly( |
| 575 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 576 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 577 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 578 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 579 | "abagagagagagagagagagagagagagagag"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 580 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 581 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 582 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 583 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 584 | RunThreads(); |
| 585 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 586 | EXPECT_EQ(8u, items.size()); |
| 587 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 588 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 589 | EXPECT_EQ(ComponentState::kChecking, items[1].state); |
| 590 | EXPECT_STREQ("abagagagagagagagagagagagagagagag", items[1].id.c_str()); |
| 591 | EXPECT_EQ(ComponentState::kCanUpdate, items[2].state); |
| 592 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 593 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 594 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 595 | EXPECT_EQ(ComponentState::kDownloading, items[4].state); |
| 596 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[4].id.c_str()); |
| 597 | EXPECT_EQ(ComponentState::kUpdating, items[5].state); |
| 598 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[5].id.c_str()); |
| 599 | EXPECT_EQ(ComponentState::kUpdated, items[6].state); |
| 600 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[6].id.c_str()); |
| 601 | EXPECT_EQ(ComponentState::kUpToDate, items[7].state); |
| 602 | EXPECT_STREQ("abagagagagagagagagagagagagagagag", items[7].id.c_str()); |
| 603 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 604 | update_client->RemoveObserver(&observer); |
| 605 | } |
| 606 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 607 | // Tests the scenario where two CRXs are checked for updates. One CRX has |
| 608 | // an update but the server ignores the second CRX and returns no response for |
| 609 | // it. The second component gets an |UPDATE_RESPONSE_NOT_FOUND| error and |
| 610 | // transitions to the error state. |
| 611 | TEST_F(UpdateClientTest, TwoCrxUpdateFirstServerIgnoresSecond) { |
| 612 | class DataCallbackMock { |
| 613 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 614 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 615 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 616 | CrxComponent crx1; |
| 617 | crx1.name = "test_jebg"; |
| 618 | crx1.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 619 | crx1.version = base::Version("0.9"); |
| 620 | crx1.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 621 | crx1.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 622 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 623 | CrxComponent crx2; |
| 624 | crx2.name = "test_abag"; |
| 625 | crx2.pk_hash.assign(abag_hash, abag_hash + base::size(abag_hash)); |
| 626 | crx2.version = base::Version("2.2"); |
| 627 | crx2.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 628 | crx2.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 629 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 630 | return {crx1, crx2}; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 631 | } |
| 632 | }; |
| 633 | |
| 634 | class CompletionCallbackMock { |
| 635 | public: |
| 636 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 637 | EXPECT_EQ(Error::NONE, error); |
| 638 | std::move(quit_closure).Run(); |
| 639 | } |
| 640 | }; |
| 641 | |
| 642 | class MockUpdateChecker : public UpdateChecker { |
| 643 | public: |
| 644 | static std::unique_ptr<UpdateChecker> Create( |
| 645 | scoped_refptr<Configurator> config, |
| 646 | PersistedData* metadata) { |
| 647 | return std::make_unique<MockUpdateChecker>(); |
| 648 | } |
| 649 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 650 | void CheckForUpdates( |
| 651 | const std::string& session_id, |
| 652 | const std::vector<std::string>& ids_to_check, |
| 653 | const IdToComponentPtrMap& components, |
| 654 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 655 | bool enabled_component_updates, |
| 656 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 657 | /* |
| 658 | Mock the following response: |
| 659 | |
| 660 | <?xml version='1.0' encoding='UTF-8'?> |
| 661 | <response protocol='3.1'> |
| 662 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 663 | <updatecheck status='ok'> |
| 664 | <urls> |
| 665 | <url codebase='http://localhost/download/'/> |
| 666 | </urls> |
| 667 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 668 | <packages> |
| 669 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 670 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 671 | a284a7cd8059c3409ce0498'/> |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 672 | </packages> |
| 673 | </manifest> |
| 674 | </updatecheck> |
| 675 | </app> |
| 676 | </response> |
| 677 | */ |
| 678 | EXPECT_FALSE(session_id.empty()); |
| 679 | EXPECT_TRUE(enabled_component_updates); |
| 680 | EXPECT_EQ(2u, ids_to_check.size()); |
| 681 | |
| 682 | ProtocolParser::Results results; |
| 683 | { |
| 684 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 685 | EXPECT_EQ(id, ids_to_check[0]); |
| 686 | EXPECT_EQ(1u, components.count(id)); |
| 687 | |
| 688 | ProtocolParser::Result::Manifest::Package package; |
| 689 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 690 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 691 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 692 | |
| 693 | ProtocolParser::Result result; |
| 694 | result.extension_id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 695 | result.status = "ok"; |
| 696 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 697 | result.manifest.version = "1.0"; |
| 698 | result.manifest.browser_min_version = "11.0.1.0"; |
| 699 | result.manifest.packages.push_back(package); |
| 700 | results.list.push_back(result); |
| 701 | |
| 702 | EXPECT_FALSE(components.at(id)->is_foreground()); |
| 703 | } |
| 704 | |
| 705 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 706 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 707 | ErrorCategory::kNone, 0, 0)); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 708 | } |
| 709 | }; |
| 710 | |
| 711 | class MockCrxDownloader : public CrxDownloader { |
| 712 | public: |
| 713 | static std::unique_ptr<CrxDownloader> Create( |
| 714 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 715 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 716 | return std::make_unique<MockCrxDownloader>(); |
| 717 | } |
| 718 | |
| 719 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 720 | |
| 721 | private: |
| 722 | void DoStartDownload(const GURL& url) override { |
| 723 | DownloadMetrics download_metrics; |
| 724 | download_metrics.url = url; |
| 725 | download_metrics.downloader = DownloadMetrics::kNone; |
| 726 | download_metrics.error = 0; |
| 727 | download_metrics.downloaded_bytes = 1843; |
| 728 | download_metrics.total_bytes = 1843; |
| 729 | download_metrics.download_time_ms = 1000; |
| 730 | |
| 731 | FilePath path; |
| 732 | EXPECT_TRUE(MakeTestFile( |
| 733 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 734 | |
| 735 | Result result; |
| 736 | result.error = 0; |
| 737 | result.response = path; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 738 | |
| 739 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 740 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 741 | base::Unretained(this))); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 742 | |
| 743 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 744 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
| 745 | base::Unretained(this), true, result, |
| 746 | download_metrics)); |
| 747 | } |
| 748 | }; |
| 749 | |
| 750 | class MockPingManager : public MockPingManagerImpl { |
| 751 | public: |
| 752 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 753 | : MockPingManagerImpl(config) {} |
| 754 | |
| 755 | protected: |
| 756 | ~MockPingManager() override { |
| 757 | const auto ping_data = MockPingManagerImpl::ping_data(); |
| 758 | EXPECT_EQ(1u, ping_data.size()); |
| 759 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 760 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 761 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
| 762 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
| 763 | EXPECT_EQ(0, ping_data[0].error_code); |
| 764 | } |
| 765 | }; |
| 766 | |
| 767 | scoped_refptr<UpdateClient> update_client = |
| 768 | base::MakeRefCounted<UpdateClientImpl>( |
| 769 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 770 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 771 | |
| 772 | MockObserver observer; |
| 773 | { |
| 774 | InSequence seq; |
| 775 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 776 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 777 | .Times(1); |
| 778 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 779 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 780 | .Times(1); |
| 781 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
| 782 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 783 | .Times(AtLeast(1)); |
| 784 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 785 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 786 | .Times(1); |
| 787 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 788 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 789 | .Times(1); |
| 790 | } |
| 791 | { |
| 792 | InSequence seq; |
| 793 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 794 | "abagagagagagagagagagagagagagagag")) |
| 795 | .Times(1); |
| 796 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 797 | "abagagagagagagagagagagagagagagag")) |
| 798 | .Times(1) |
| 799 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 800 | CrxUpdateItem item; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 801 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 802 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 803 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 804 | EXPECT_EQ(-10004, item.error_code); |
| 805 | EXPECT_EQ(0, item.extra_code1); |
| 806 | })); |
| 807 | } |
| 808 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 809 | std::vector<CrxUpdateItem> items; |
| 810 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 811 | EXPECT_CALL(*receiver, Receive(_)) |
| 812 | .WillRepeatedly( |
| 813 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 814 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 815 | update_client->AddObserver(&observer); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 816 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 817 | "abagagagagagagagagagagagagagagag"}; |
| 818 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 819 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 820 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 821 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 822 | RunThreads(); |
| 823 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 824 | EXPECT_EQ(8u, items.size()); |
| 825 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 826 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 827 | EXPECT_EQ(ComponentState::kChecking, items[1].state); |
| 828 | EXPECT_STREQ("abagagagagagagagagagagagagagagag", items[1].id.c_str()); |
| 829 | EXPECT_EQ(ComponentState::kCanUpdate, items[2].state); |
| 830 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 831 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 832 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 833 | EXPECT_EQ(ComponentState::kDownloading, items[4].state); |
| 834 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[4].id.c_str()); |
| 835 | EXPECT_EQ(ComponentState::kUpdating, items[5].state); |
| 836 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[5].id.c_str()); |
| 837 | EXPECT_EQ(ComponentState::kUpdated, items[6].state); |
| 838 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[6].id.c_str()); |
| 839 | EXPECT_EQ(ComponentState::kUpdateError, items[7].state); |
| 840 | EXPECT_STREQ("abagagagagagagagagagagagagagagag", items[7].id.c_str()); |
| 841 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 842 | update_client->RemoveObserver(&observer); |
| 843 | } |
| 844 | |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 845 | // Tests the update check for two CRXs scenario when the second CRX does not |
| 846 | // provide a CrxComponent instance. In this case, the update is handled as |
| 847 | // if only one component were provided as an argument to the |Update| call |
| 848 | // with the exception that the second component still fires an event such as |
| 849 | // |COMPONENT_UPDATE_ERROR|. |
| 850 | TEST_F(UpdateClientTest, TwoCrxUpdateNoCrxComponentData) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 851 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 852 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 853 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 854 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 855 | CrxComponent crx; |
| 856 | crx.name = "test_jebg"; |
| 857 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 858 | crx.version = base::Version("0.9"); |
| 859 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 860 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 861 | return {crx, base::nullopt}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 862 | } |
| 863 | }; |
| 864 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 865 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 866 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 867 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 868 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 869 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 870 | } |
| 871 | }; |
| 872 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 873 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 874 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 875 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 876 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 877 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 878 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 879 | } |
| 880 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 881 | void CheckForUpdates( |
| 882 | const std::string& session_id, |
| 883 | const std::vector<std::string>& ids_to_check, |
| 884 | const IdToComponentPtrMap& components, |
| 885 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 886 | bool enabled_component_updates, |
| 887 | UpdateCheckCallback update_check_callback) override { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 888 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 889 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 890 | |
| 891 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 892 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 893 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 894 | <updatecheck status='ok'> |
| 895 | <urls> |
| 896 | <url codebase='http://localhost/download/'/> |
| 897 | </urls> |
| 898 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 899 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 900 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 901 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 902 | a284a7cd8059c3409ce0498'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 903 | </packages> |
| 904 | </manifest> |
| 905 | </updatecheck> |
| 906 | </app> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 907 | </response> |
| 908 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 909 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 910 | EXPECT_TRUE(enabled_component_updates); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 911 | EXPECT_EQ(1u, ids_to_check.size()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 912 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 913 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 914 | { |
| 915 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 916 | EXPECT_EQ(id, ids_to_check[0]); |
| 917 | EXPECT_EQ(1u, components.count(id)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 918 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 919 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 920 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 921 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 922 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 923 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 924 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 925 | result.extension_id = id; |
| 926 | result.status = "ok"; |
| 927 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 928 | result.manifest.version = "1.0"; |
| 929 | result.manifest.browser_min_version = "11.0.1.0"; |
| 930 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 931 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 932 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 933 | EXPECT_FALSE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 934 | } |
| 935 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 936 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 937 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 938 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 939 | } |
| 940 | }; |
| 941 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 942 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 943 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 944 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 945 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 946 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 947 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 948 | } |
| 949 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 950 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 951 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 952 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 953 | void DoStartDownload(const GURL& url) override { |
| 954 | DownloadMetrics download_metrics; |
| 955 | FilePath path; |
| 956 | Result result; |
| 957 | if (url.path() == "/download/jebgalgnebhfojomionfpkfelancnnkf.crx") { |
| 958 | download_metrics.url = url; |
| 959 | download_metrics.downloader = DownloadMetrics::kNone; |
| 960 | download_metrics.error = 0; |
| 961 | download_metrics.downloaded_bytes = 1843; |
| 962 | download_metrics.total_bytes = 1843; |
| 963 | download_metrics.download_time_ms = 1000; |
| 964 | |
| 965 | EXPECT_TRUE(MakeTestFile( |
| 966 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 967 | |
| 968 | result.error = 0; |
| 969 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 970 | } else { |
| 971 | NOTREACHED(); |
| 972 | } |
| 973 | |
| 974 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 975 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 976 | base::Unretained(this))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 977 | |
| 978 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 979 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 980 | base::Unretained(this), true, result, |
| 981 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 982 | } |
| 983 | }; |
| 984 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 985 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 986 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 987 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 988 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 989 | |
| 990 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 991 | ~MockPingManager() override { |
| 992 | const auto ping_data = MockPingManagerImpl::ping_data(); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 993 | EXPECT_EQ(1u, ping_data.size()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 994 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 995 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 996 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 997 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 998 | EXPECT_EQ(0, ping_data[0].error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 999 | } |
| 1000 | }; |
| 1001 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1002 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1003 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1004 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1005 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1006 | |
| 1007 | MockObserver observer; |
| 1008 | { |
| 1009 | InSequence seq; |
| 1010 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1011 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1012 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1013 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1014 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1015 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1016 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1017 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1018 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1019 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1020 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1021 | } |
| 1022 | { |
| 1023 | InSequence seq; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1024 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1025 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1026 | .Times(1); |
| 1027 | } |
| 1028 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1029 | std::vector<CrxUpdateItem> items; |
| 1030 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 1031 | EXPECT_CALL(*receiver, Receive(_)) |
| 1032 | .WillRepeatedly( |
| 1033 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1034 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1035 | update_client->AddObserver(&observer); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1036 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 1037 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
| 1038 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1039 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 1040 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 1041 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1042 | RunThreads(); |
| 1043 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1044 | EXPECT_EQ(7u, items.size()); |
| 1045 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 1046 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 1047 | EXPECT_EQ(ComponentState::kUpdateError, items[1].state); |
| 1048 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 1049 | EXPECT_EQ(ComponentState::kCanUpdate, items[2].state); |
| 1050 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 1051 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 1052 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 1053 | EXPECT_EQ(ComponentState::kDownloading, items[4].state); |
| 1054 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[4].id.c_str()); |
| 1055 | EXPECT_EQ(ComponentState::kUpdating, items[5].state); |
| 1056 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[5].id.c_str()); |
| 1057 | EXPECT_EQ(ComponentState::kUpdated, items[6].state); |
| 1058 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[6].id.c_str()); |
| 1059 | |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1060 | update_client->RemoveObserver(&observer); |
| 1061 | } |
| 1062 | |
| 1063 | // Tests the update check for two CRXs scenario when no CrxComponent data is |
| 1064 | // provided for either component. In this case, no update check occurs, and |
| 1065 | // |COMPONENT_UPDATE_ERROR| event fires for both components. |
| 1066 | TEST_F(UpdateClientTest, TwoCrxUpdateNoCrxComponentDataAtAll) { |
| 1067 | class DataCallbackMock { |
| 1068 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1069 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1070 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1071 | return {base::nullopt, base::nullopt}; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1072 | } |
| 1073 | }; |
| 1074 | |
| 1075 | class CompletionCallbackMock { |
| 1076 | public: |
| 1077 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 1078 | EXPECT_EQ(Error::NONE, error); |
| 1079 | std::move(quit_closure).Run(); |
| 1080 | } |
| 1081 | }; |
| 1082 | |
| 1083 | class MockUpdateChecker : public UpdateChecker { |
| 1084 | public: |
| 1085 | static std::unique_ptr<UpdateChecker> Create( |
| 1086 | scoped_refptr<Configurator> config, |
| 1087 | PersistedData* metadata) { |
| 1088 | return std::make_unique<MockUpdateChecker>(); |
| 1089 | } |
| 1090 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 1091 | void CheckForUpdates( |
| 1092 | const std::string& session_id, |
| 1093 | const std::vector<std::string>& ids_to_check, |
| 1094 | const IdToComponentPtrMap& components, |
| 1095 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 1096 | bool enabled_component_updates, |
| 1097 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1098 | NOTREACHED(); |
| 1099 | } |
| 1100 | }; |
| 1101 | |
| 1102 | class MockCrxDownloader : public CrxDownloader { |
| 1103 | public: |
| 1104 | static std::unique_ptr<CrxDownloader> Create( |
| 1105 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 1106 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 1107 | return std::make_unique<MockCrxDownloader>(); |
| 1108 | } |
| 1109 | |
| 1110 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 1111 | |
| 1112 | private: |
| 1113 | void DoStartDownload(const GURL& url) override { NOTREACHED(); } |
| 1114 | }; |
| 1115 | |
| 1116 | class MockPingManager : public MockPingManagerImpl { |
| 1117 | public: |
| 1118 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1119 | : MockPingManagerImpl(config) {} |
| 1120 | |
| 1121 | protected: |
| 1122 | ~MockPingManager() override { |
| 1123 | EXPECT_EQ(0u, MockPingManagerImpl::ping_data().size()); |
| 1124 | } |
| 1125 | }; |
| 1126 | |
| 1127 | scoped_refptr<UpdateClient> update_client = |
| 1128 | base::MakeRefCounted<UpdateClientImpl>( |
| 1129 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1130 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 1131 | |
| 1132 | MockObserver observer; |
| 1133 | { |
| 1134 | InSequence seq; |
| 1135 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1136 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1137 | .Times(1); |
| 1138 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1139 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1140 | .Times(1); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1141 | } |
| 1142 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1143 | std::vector<CrxUpdateItem> items; |
| 1144 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 1145 | EXPECT_CALL(*receiver, Receive(_)) |
| 1146 | .WillRepeatedly( |
| 1147 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1148 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1149 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1150 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 1151 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1152 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1153 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 1154 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 1155 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1156 | RunThreads(); |
| 1157 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1158 | EXPECT_EQ(2u, items.size()); |
| 1159 | EXPECT_EQ(ComponentState::kUpdateError, items[0].state); |
| 1160 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 1161 | EXPECT_EQ(ComponentState::kUpdateError, items[1].state); |
| 1162 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 1163 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1164 | update_client->RemoveObserver(&observer); |
| 1165 | } |
| 1166 | |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1167 | // Tests the scenario where there is a download timeout for the first |
| 1168 | // CRX. The update for the first CRX fails. The update client waits before |
| 1169 | // attempting the update for the second CRX. This update succeeds. |
| 1170 | TEST_F(UpdateClientTest, TwoCrxUpdateDownloadTimeout) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1171 | class DataCallbackMock { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1172 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1173 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1174 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1175 | CrxComponent crx1; |
| 1176 | crx1.name = "test_jebg"; |
| 1177 | crx1.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 1178 | crx1.version = base::Version("0.9"); |
| 1179 | crx1.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1180 | crx1.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1181 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1182 | CrxComponent crx2; |
| 1183 | crx2.name = "test_ihfo"; |
| 1184 | crx2.pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
| 1185 | crx2.version = base::Version("0.8"); |
| 1186 | crx2.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1187 | crx2.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1188 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1189 | return {crx1, crx2}; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1190 | } |
| 1191 | }; |
| 1192 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1193 | class CompletionCallbackMock { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1194 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1195 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1196 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1197 | std::move(quit_closure).Run(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1198 | } |
| 1199 | }; |
| 1200 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1201 | class MockUpdateChecker : public UpdateChecker { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1202 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1203 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1204 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1205 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1206 | return std::make_unique<MockUpdateChecker>(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1207 | } |
| 1208 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 1209 | void CheckForUpdates( |
| 1210 | const std::string& session_id, |
| 1211 | const std::vector<std::string>& ids_to_check, |
| 1212 | const IdToComponentPtrMap& components, |
| 1213 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 1214 | bool enabled_component_updates, |
| 1215 | UpdateCheckCallback update_check_callback) override { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1216 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1217 | Mock the following response: |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1218 | |
| 1219 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1220 | <response protocol='3.1'> |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1221 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 1222 | <updatecheck status='ok'> |
| 1223 | <urls> |
| 1224 | <url codebase='http://localhost/download/'/> |
| 1225 | </urls> |
| 1226 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1227 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1228 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1229 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 1230 | a284a7cd8059c3409ce0498'/> |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1231 | </packages> |
| 1232 | </manifest> |
| 1233 | </updatecheck> |
| 1234 | </app> |
| 1235 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1236 | <updatecheck status='ok'> |
| 1237 | <urls> |
| 1238 | <url codebase='http://localhost/download/'/> |
| 1239 | </urls> |
| 1240 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1241 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1242 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1243 | hash_sha256='8f5aa190311237cae00675af87ff457f278cd1a05 |
| 1244 | 895470ac5d46647d4a3c2ea'/> |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1245 | </packages> |
| 1246 | </manifest> |
| 1247 | </updatecheck> |
| 1248 | </app> |
| 1249 | </response> |
| 1250 | */ |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1251 | |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1252 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1253 | EXPECT_TRUE(enabled_component_updates); |
| 1254 | EXPECT_EQ(2u, ids_to_check.size()); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1255 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1256 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1257 | { |
| 1258 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 1259 | EXPECT_EQ(id, ids_to_check[0]); |
| 1260 | EXPECT_EQ(1u, components.count(id)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1261 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1262 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1263 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 1264 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1265 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1266 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1267 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1268 | result.extension_id = id; |
| 1269 | result.status = "ok"; |
| 1270 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1271 | result.manifest.version = "1.0"; |
| 1272 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1273 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1274 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1275 | } |
| 1276 | |
| 1277 | { |
| 1278 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1279 | EXPECT_EQ(id, ids_to_check[1]); |
| 1280 | EXPECT_EQ(1u, components.count(id)); |
| 1281 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1282 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1283 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
| 1284 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1285 | "8f5aa190311237cae00675af87ff457f278cd1a05895470ac5d46647d4a3c2ea"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1286 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1287 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1288 | result.extension_id = id; |
| 1289 | result.status = "ok"; |
| 1290 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1291 | result.manifest.version = "1.0"; |
| 1292 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1293 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1294 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1295 | } |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1296 | |
| 1297 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 1298 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 1299 | ErrorCategory::kNone, 0, 0)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1300 | } |
| 1301 | }; |
| 1302 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1303 | class MockCrxDownloader : public CrxDownloader { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1304 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1305 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1306 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 1307 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1308 | return std::make_unique<MockCrxDownloader>(); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1309 | } |
| 1310 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1311 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1312 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1313 | private: |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1314 | void DoStartDownload(const GURL& url) override { |
| 1315 | DownloadMetrics download_metrics; |
| 1316 | FilePath path; |
| 1317 | Result result; |
| 1318 | if (url.path() == "/download/jebgalgnebhfojomionfpkfelancnnkf.crx") { |
| 1319 | download_metrics.url = url; |
| 1320 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1321 | download_metrics.error = -118; |
| 1322 | download_metrics.downloaded_bytes = 0; |
| 1323 | download_metrics.total_bytes = 0; |
| 1324 | download_metrics.download_time_ms = 1000; |
| 1325 | |
Sorin Jianu | 52de5fa | 2017-10-09 23:19:33 | [diff] [blame] | 1326 | // The result must not include a file path in the case of errors. |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1327 | result.error = -118; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1328 | } else if (url.path() == |
| 1329 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 1330 | download_metrics.url = url; |
| 1331 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1332 | download_metrics.error = 0; |
| 1333 | download_metrics.downloaded_bytes = 53638; |
| 1334 | download_metrics.total_bytes = 53638; |
| 1335 | download_metrics.download_time_ms = 2000; |
| 1336 | |
| 1337 | EXPECT_TRUE(MakeTestFile( |
| 1338 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 1339 | |
| 1340 | result.error = 0; |
| 1341 | result.response = path; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1342 | } else { |
| 1343 | NOTREACHED(); |
| 1344 | } |
| 1345 | |
| 1346 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1347 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 1348 | base::Unretained(this))); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1349 | |
| 1350 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1351 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1352 | base::Unretained(this), true, result, |
| 1353 | download_metrics)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1354 | } |
| 1355 | }; |
| 1356 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1357 | class MockPingManager : public MockPingManagerImpl { |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1358 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1359 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1360 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 1361 | |
| 1362 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1363 | ~MockPingManager() override { |
| 1364 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1365 | EXPECT_EQ(2u, ping_data.size()); |
| 1366 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 1367 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 1368 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1369 | EXPECT_EQ(1, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1370 | EXPECT_EQ(-118, ping_data[0].error_code); |
| 1371 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 1372 | EXPECT_EQ(base::Version("0.8"), ping_data[1].previous_version); |
| 1373 | EXPECT_EQ(base::Version("1.0"), ping_data[1].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1374 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1375 | EXPECT_EQ(0, ping_data[1].error_code); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1376 | } |
| 1377 | }; |
| 1378 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1379 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1380 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1381 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1382 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1383 | |
| 1384 | MockObserver observer; |
| 1385 | { |
| 1386 | InSequence seq; |
| 1387 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1388 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1389 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1390 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 1391 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1392 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 1393 | .Times(AtLeast(1)); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 1394 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 1395 | "jebgalgnebhfojomionfpkfelancnnkf")) |
Sorin Jianu | afcb70dd | 2018-05-16 20:14:15 | [diff] [blame] | 1396 | .Times(1) |
| 1397 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 1398 | CrxUpdateItem item; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1399 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
Sorin Jianu | afcb70dd | 2018-05-16 20:14:15 | [diff] [blame] | 1400 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1401 | EXPECT_EQ(1, static_cast<int>(item.error_category)); |
Sorin Jianu | afcb70dd | 2018-05-16 20:14:15 | [diff] [blame] | 1402 | EXPECT_EQ(-118, item.error_code); |
| 1403 | EXPECT_EQ(0, item.extra_code1); |
| 1404 | })); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1405 | } |
| 1406 | { |
| 1407 | InSequence seq; |
| 1408 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1409 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1410 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1411 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1412 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_WAIT, |
| 1413 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1414 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1415 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1416 | .Times(AtLeast(1)); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1417 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1418 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1419 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1420 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1421 | } |
| 1422 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1423 | std::vector<CrxUpdateItem> items; |
| 1424 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 1425 | EXPECT_CALL(*receiver, Receive(_)) |
| 1426 | .WillRepeatedly( |
| 1427 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1428 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1429 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1430 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 1431 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1432 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1433 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 1434 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 1435 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1436 | RunThreads(); |
| 1437 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1438 | EXPECT_EQ(11u, items.size()); |
| 1439 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 1440 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 1441 | EXPECT_EQ(ComponentState::kChecking, items[1].state); |
| 1442 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 1443 | EXPECT_EQ(ComponentState::kCanUpdate, items[2].state); |
| 1444 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 1445 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 1446 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 1447 | EXPECT_EQ(ComponentState::kDownloading, items[4].state); |
| 1448 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[4].id.c_str()); |
| 1449 | EXPECT_EQ(ComponentState::kUpdateError, items[5].state); |
| 1450 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[5].id.c_str()); |
| 1451 | EXPECT_EQ(ComponentState::kCanUpdate, items[6].state); |
| 1452 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[6].id.c_str()); |
| 1453 | EXPECT_EQ(ComponentState::kDownloading, items[7].state); |
| 1454 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[7].id.c_str()); |
| 1455 | EXPECT_EQ(ComponentState::kDownloading, items[8].state); |
| 1456 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[8].id.c_str()); |
| 1457 | EXPECT_EQ(ComponentState::kUpdating, items[9].state); |
| 1458 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[9].id.c_str()); |
| 1459 | EXPECT_EQ(ComponentState::kUpdated, items[10].state); |
| 1460 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[10].id.c_str()); |
| 1461 | |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1462 | update_client->RemoveObserver(&observer); |
sorin | 6bb8de4 | 2015-06-03 00:23:27 | [diff] [blame] | 1463 | } |
| 1464 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1465 | // Tests the differential update scenario for one CRX. |
| 1466 | TEST_F(UpdateClientTest, OneCrxDiffUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1467 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1468 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1469 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1470 | const std::vector<std::string>& ids) { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1471 | static int num_calls = 0; |
| 1472 | |
| 1473 | // Must use the same stateful installer object. |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1474 | static scoped_refptr<CrxInstaller> installer = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1475 | base::MakeRefCounted<VersionedTestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1476 | |
| 1477 | ++num_calls; |
| 1478 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1479 | CrxComponent crx; |
| 1480 | crx.name = "test_ihfo"; |
| 1481 | crx.pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
| 1482 | crx.installer = installer; |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1483 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1484 | if (num_calls == 1) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1485 | crx.version = base::Version("0.8"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1486 | } else if (num_calls == 2) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1487 | crx.version = base::Version("1.0"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1488 | } else { |
| 1489 | NOTREACHED(); |
| 1490 | } |
| 1491 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1492 | return {crx}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1493 | } |
| 1494 | }; |
| 1495 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1496 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1497 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1498 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1499 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1500 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1501 | } |
| 1502 | }; |
| 1503 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1504 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1505 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1506 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1507 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1508 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1509 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1510 | } |
| 1511 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 1512 | void CheckForUpdates( |
| 1513 | const std::string& session_id, |
| 1514 | const std::vector<std::string>& ids_to_check, |
| 1515 | const IdToComponentPtrMap& components, |
| 1516 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 1517 | bool enabled_component_updates, |
| 1518 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1519 | EXPECT_FALSE(session_id.empty()); |
| 1520 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1521 | static int num_call = 0; |
| 1522 | ++num_call; |
| 1523 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1524 | ProtocolParser::Results results; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1525 | |
| 1526 | if (num_call == 1) { |
| 1527 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1528 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1529 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1530 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1531 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1532 | <updatecheck status='ok'> |
| 1533 | <urls> |
| 1534 | <url codebase='http://localhost/download/'/> |
| 1535 | </urls> |
| 1536 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1537 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1538 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
| 1539 | hash_sha256='813c59747e139a608b3b5fc49633affc6db57437 |
| 1540 | 3f309f156ea6d27229c0b3f9'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1541 | </packages> |
| 1542 | </manifest> |
| 1543 | </updatecheck> |
| 1544 | </app> |
| 1545 | </response> |
| 1546 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1547 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1548 | EXPECT_EQ(id, ids_to_check[0]); |
| 1549 | EXPECT_EQ(1u, components.count(id)); |
| 1550 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1551 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1552 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1553 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1554 | "8f5aa190311237cae00675af87ff457f278cd1a05895470ac5d46647d4a3c2ea"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1555 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1556 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1557 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1558 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1559 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1560 | result.manifest.version = "1.0"; |
| 1561 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1562 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1563 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1564 | } else if (num_call == 2) { |
| 1565 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1566 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1567 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1568 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1569 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 1570 | <updatecheck status='ok'> |
| 1571 | <urls> |
| 1572 | <url codebase='http://localhost/download/'/> |
| 1573 | <url codebasediff='http://localhost/download/'/> |
| 1574 | </urls> |
| 1575 | <manifest version='2.0' prodversionmin='11.0.1.0'> |
| 1576 | <packages> |
| 1577 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_2.crx' |
| 1578 | namediff='ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1579 | hash_sha256='c87d8742c3ff3d7a0cb6f3c91aa2fcf3dea6361 |
| 1580 | 8086a7db1c5be5300e1d4d6b6' |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1581 | fp='22' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1582 | hashdiff_sha256='0fd48a5dd87006a709756cfc47198cbc4c4 |
| 1583 | 928f33ac4277d79573c15164a33eb'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1584 | </packages> |
| 1585 | </manifest> |
| 1586 | </updatecheck> |
| 1587 | </app> |
| 1588 | </response> |
| 1589 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1590 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 1591 | EXPECT_EQ(id, ids_to_check[0]); |
| 1592 | EXPECT_EQ(1u, components.count(id)); |
| 1593 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1594 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1595 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_2.crx"; |
| 1596 | package.namediff = "ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1597 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1598 | "c87d8742c3ff3d7a0cb6f3c91aa2fcf3dea63618086a7db1c5be5300e1d4d6b6"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1599 | package.hashdiff_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1600 | "0fd48a5dd87006a709756cfc47198cbc4c4928f33ac4277d79573c15164a33eb"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1601 | package.fingerprint = "22"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1602 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1603 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1604 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1605 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1606 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1607 | result.crx_diffurls.push_back(GURL("http://localhost/download/")); |
| 1608 | result.manifest.version = "2.0"; |
| 1609 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1610 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1611 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1612 | } else { |
| 1613 | NOTREACHED(); |
| 1614 | } |
| 1615 | |
| 1616 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 1617 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 1618 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1619 | } |
| 1620 | }; |
| 1621 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1622 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1623 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1624 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1625 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 1626 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1627 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1628 | } |
| 1629 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1630 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1631 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1632 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1633 | void DoStartDownload(const GURL& url) override { |
| 1634 | DownloadMetrics download_metrics; |
| 1635 | FilePath path; |
| 1636 | Result result; |
| 1637 | if (url.path() == "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 1638 | download_metrics.url = url; |
| 1639 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1640 | download_metrics.error = 0; |
| 1641 | download_metrics.downloaded_bytes = 53638; |
| 1642 | download_metrics.total_bytes = 53638; |
| 1643 | download_metrics.download_time_ms = 2000; |
| 1644 | |
| 1645 | EXPECT_TRUE(MakeTestFile( |
| 1646 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 1647 | |
| 1648 | result.error = 0; |
| 1649 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1650 | } else if (url.path() == |
| 1651 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx") { |
| 1652 | download_metrics.url = url; |
| 1653 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1654 | download_metrics.error = 0; |
| 1655 | download_metrics.downloaded_bytes = 2105; |
| 1656 | download_metrics.total_bytes = 2105; |
| 1657 | download_metrics.download_time_ms = 1000; |
| 1658 | |
| 1659 | EXPECT_TRUE(MakeTestFile( |
| 1660 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx"), &path)); |
| 1661 | |
| 1662 | result.error = 0; |
| 1663 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1664 | } else { |
| 1665 | NOTREACHED(); |
| 1666 | } |
| 1667 | |
| 1668 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1669 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 1670 | base::Unretained(this))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1671 | |
| 1672 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1673 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1674 | base::Unretained(this), true, result, |
| 1675 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1676 | } |
| 1677 | }; |
| 1678 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1679 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1680 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1681 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1682 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 1683 | |
| 1684 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1685 | ~MockPingManager() override { |
| 1686 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1687 | EXPECT_EQ(2u, ping_data.size()); |
| 1688 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[0].id); |
| 1689 | EXPECT_EQ(base::Version("0.8"), ping_data[0].previous_version); |
| 1690 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1691 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1692 | EXPECT_EQ(0, ping_data[0].error_code); |
| 1693 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 1694 | EXPECT_EQ(base::Version("1.0"), ping_data[1].previous_version); |
| 1695 | EXPECT_EQ(base::Version("2.0"), ping_data[1].next_version); |
| 1696 | EXPECT_FALSE(ping_data[1].diff_update_failed); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1697 | EXPECT_EQ(0, static_cast<int>(ping_data[1].diff_error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1698 | EXPECT_EQ(0, ping_data[1].diff_error_code); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1699 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1700 | EXPECT_EQ(0, ping_data[1].error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1701 | } |
| 1702 | }; |
| 1703 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1704 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1705 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1706 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1707 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1708 | |
| 1709 | MockObserver observer; |
| 1710 | { |
| 1711 | InSequence seq; |
| 1712 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1713 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1714 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1715 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1716 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1717 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1718 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1719 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1720 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1721 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1722 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1723 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 1724 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1725 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 1726 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1727 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1728 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 1729 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1730 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 1731 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1732 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 1733 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 1734 | } |
| 1735 | |
| 1736 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1737 | const std::vector<std::string> ids = {"ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1738 | { |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1739 | std::vector<CrxUpdateItem> items; |
| 1740 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 1741 | EXPECT_CALL(*receiver, Receive(_)) |
| 1742 | .WillRepeatedly( |
| 1743 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
| 1744 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1745 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1746 | update_client->Update( |
| 1747 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 1748 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 1749 | false, |
| 1750 | base::BindOnce(&CompletionCallbackMock::Callback, |
| 1751 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1752 | runloop.Run(); |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1753 | |
| 1754 | EXPECT_EQ(6u, items.size()); |
| 1755 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 1756 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[0].id.c_str()); |
| 1757 | EXPECT_EQ(ComponentState::kCanUpdate, items[1].state); |
| 1758 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 1759 | EXPECT_EQ(ComponentState::kDownloading, items[2].state); |
| 1760 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[2].id.c_str()); |
| 1761 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 1762 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[3].id.c_str()); |
| 1763 | EXPECT_EQ(ComponentState::kUpdating, items[4].state); |
| 1764 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[4].id.c_str()); |
| 1765 | EXPECT_EQ(ComponentState::kUpdated, items[5].state); |
| 1766 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[5].id.c_str()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1767 | } |
| 1768 | |
| 1769 | { |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1770 | std::vector<CrxUpdateItem> items; |
| 1771 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 1772 | EXPECT_CALL(*receiver, Receive(_)) |
| 1773 | .WillRepeatedly( |
| 1774 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
| 1775 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1776 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1777 | update_client->Update( |
| 1778 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 1779 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 1780 | false, |
| 1781 | base::BindOnce(&CompletionCallbackMock::Callback, |
| 1782 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1783 | runloop.Run(); |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 1784 | |
| 1785 | EXPECT_EQ(6u, items.size()); |
| 1786 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 1787 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[0].id.c_str()); |
| 1788 | EXPECT_EQ(ComponentState::kCanUpdate, items[1].state); |
| 1789 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 1790 | EXPECT_EQ(ComponentState::kDownloadingDiff, items[2].state); |
| 1791 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[2].id.c_str()); |
| 1792 | EXPECT_EQ(ComponentState::kDownloadingDiff, items[3].state); |
| 1793 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[3].id.c_str()); |
| 1794 | EXPECT_EQ(ComponentState::kUpdatingDiff, items[4].state); |
| 1795 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[4].id.c_str()); |
| 1796 | EXPECT_EQ(ComponentState::kUpdated, items[5].state); |
| 1797 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[5].id.c_str()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1798 | } |
| 1799 | |
| 1800 | update_client->RemoveObserver(&observer); |
| 1801 | } |
| 1802 | |
| 1803 | // Tests the update scenario for one CRX where the CRX installer returns |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1804 | // an error. Tests that the |unpack_path| argument refers to a valid path |
| 1805 | // then |Install| is called, then tests that the |unpack| path is deleted |
| 1806 | // by the |update_client| code before the test ends. |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1807 | TEST_F(UpdateClientTest, OneCrxInstallError) { |
| 1808 | class MockInstaller : public CrxInstaller { |
| 1809 | public: |
| 1810 | MOCK_METHOD1(OnUpdateError, void(int error)); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1811 | MOCK_METHOD2(DoInstall, |
Sorin Jianu | 7aa6d1f | 2017-10-13 20:29:29 | [diff] [blame] | 1812 | void(const base::FilePath& unpack_path, |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1813 | const Callback& callback)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1814 | MOCK_METHOD2(GetInstalledFile, |
| 1815 | bool(const std::string& file, base::FilePath* installed_file)); |
| 1816 | MOCK_METHOD0(Uninstall, bool()); |
| 1817 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1818 | void Install(const base::FilePath& unpack_path, |
| 1819 | const std::string& public_key, |
Sorin Jianu | 9d64af67 | 2020-02-05 19:14:34 | [diff] [blame] | 1820 | std::unique_ptr<InstallParams> /*install_params*/, |
Daniel Cheng | 6784852 | 2018-04-27 22:04:41 | [diff] [blame] | 1821 | Callback callback) override { |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1822 | DoInstall(unpack_path, std::move(callback)); |
| 1823 | |
Sorin Jianu | 23f70f75 | 2017-05-30 16:21:58 | [diff] [blame] | 1824 | unpack_path_ = unpack_path; |
| 1825 | EXPECT_TRUE(base::DirectoryExists(unpack_path_)); |
Gabriel Charette | dd8d5985e | 2020-02-26 18:38:35 | [diff] [blame] | 1826 | base::ThreadPool::PostTask( |
| 1827 | FROM_HERE, {base::MayBlock()}, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1828 | base::BindOnce(std::move(callback), |
Sorin Jianu | f40ab4b3 | 2017-10-06 22:53:41 | [diff] [blame] | 1829 | CrxInstaller::Result(InstallError::GENERIC_ERROR))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1830 | } |
| 1831 | |
| 1832 | protected: |
Sorin Jianu | 23f70f75 | 2017-05-30 16:21:58 | [diff] [blame] | 1833 | ~MockInstaller() override { |
| 1834 | // The unpack path is deleted unconditionally by the component state code, |
| 1835 | // which is driving this installer. Therefore, the unpack path must not |
| 1836 | // exist when this object is destroyed. |
| 1837 | if (!unpack_path_.empty()) |
| 1838 | EXPECT_FALSE(base::DirectoryExists(unpack_path_)); |
| 1839 | } |
| 1840 | |
| 1841 | private: |
| 1842 | // Contains the |unpack_path| argument of the Install call. |
| 1843 | base::FilePath unpack_path_; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1844 | }; |
| 1845 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1846 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1847 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1848 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1849 | const std::vector<std::string>& ids) { |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1850 | scoped_refptr<MockInstaller> installer = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1851 | base::MakeRefCounted<MockInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1852 | |
| 1853 | EXPECT_CALL(*installer, OnUpdateError(_)).Times(0); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1854 | EXPECT_CALL(*installer, DoInstall(_, _)).Times(1); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1855 | EXPECT_CALL(*installer, GetInstalledFile(_, _)).Times(0); |
| 1856 | EXPECT_CALL(*installer, Uninstall()).Times(0); |
| 1857 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1858 | CrxComponent crx; |
| 1859 | crx.name = "test_jebg"; |
| 1860 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 1861 | crx.version = base::Version("0.9"); |
| 1862 | crx.installer = installer; |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1863 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 1864 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 1865 | return {crx}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1866 | } |
| 1867 | }; |
| 1868 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1869 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1870 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1871 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 1872 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 1873 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1874 | } |
| 1875 | }; |
| 1876 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1877 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1878 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1879 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 1880 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 1881 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1882 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1883 | } |
| 1884 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 1885 | void CheckForUpdates( |
| 1886 | const std::string& session_id, |
| 1887 | const std::vector<std::string>& ids_to_check, |
| 1888 | const IdToComponentPtrMap& components, |
| 1889 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 1890 | bool enabled_component_updates, |
| 1891 | UpdateCheckCallback update_check_callback) override { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1892 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1893 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1894 | |
| 1895 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 1896 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1897 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 1898 | <updatecheck status='ok'> |
| 1899 | <urls> |
| 1900 | <url codebase='http://localhost/download/'/> |
| 1901 | </urls> |
| 1902 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 1903 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1904 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1905 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 1906 | a284a7cd8059c3409ce0498'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1907 | </packages> |
| 1908 | </manifest> |
| 1909 | </updatecheck> |
| 1910 | </app> |
| 1911 | </response> |
| 1912 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 1913 | EXPECT_FALSE(session_id.empty()); |
| 1914 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1915 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 1916 | EXPECT_EQ(id, ids_to_check[0]); |
| 1917 | EXPECT_EQ(1u, components.count(id)); |
| 1918 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1919 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1920 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 1921 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 1922 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1923 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 1924 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1925 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 1926 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1927 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 1928 | result.manifest.version = "1.0"; |
| 1929 | result.manifest.browser_min_version = "11.0.1.0"; |
| 1930 | result.manifest.packages.push_back(package); |
| 1931 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 1932 | ProtocolParser::Results results; |
| 1933 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1934 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 1935 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 1936 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1937 | } |
| 1938 | }; |
| 1939 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1940 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1941 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 1942 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1943 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 1944 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1945 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1946 | } |
| 1947 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1948 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1949 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1950 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1951 | void DoStartDownload(const GURL& url) override { |
| 1952 | DownloadMetrics download_metrics; |
| 1953 | download_metrics.url = url; |
| 1954 | download_metrics.downloader = DownloadMetrics::kNone; |
| 1955 | download_metrics.error = 0; |
| 1956 | download_metrics.downloaded_bytes = 1843; |
| 1957 | download_metrics.total_bytes = 1843; |
| 1958 | download_metrics.download_time_ms = 1000; |
| 1959 | |
| 1960 | FilePath path; |
| 1961 | EXPECT_TRUE(MakeTestFile( |
| 1962 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 1963 | |
| 1964 | Result result; |
| 1965 | result.error = 0; |
| 1966 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1967 | |
| 1968 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1969 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 1970 | base::Unretained(this))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1971 | |
| 1972 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1973 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 1974 | base::Unretained(this), true, result, |
| 1975 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1976 | } |
| 1977 | }; |
| 1978 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1979 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1980 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1981 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 1982 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 1983 | |
| 1984 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1985 | ~MockPingManager() override { |
| 1986 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1987 | EXPECT_EQ(1u, ping_data.size()); |
| 1988 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 1989 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 1990 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 1991 | EXPECT_EQ(3, static_cast<int>(ping_data[0].error_category)); // kInstall. |
| 1992 | EXPECT_EQ(9, ping_data[0].error_code); // kInstallerError. |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 1993 | } |
| 1994 | }; |
| 1995 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 1996 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 1997 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 1998 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 1999 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2000 | |
| 2001 | MockObserver observer; |
| 2002 | { |
| 2003 | InSequence seq; |
| 2004 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2005 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2006 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2007 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
| 2008 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2009 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2010 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2011 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2012 | "jebgalgnebhfojomionfpkfelancnnkf")).Times(1); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 2013 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 2014 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2015 | .Times(1); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2016 | } |
| 2017 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2018 | std::vector<CrxUpdateItem> items; |
| 2019 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2020 | EXPECT_CALL(*receiver, Receive(_)) |
| 2021 | .WillRepeatedly( |
| 2022 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2023 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2024 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2025 | std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2026 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2027 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 2028 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 2029 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2030 | RunThreads(); |
| 2031 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2032 | EXPECT_EQ(6u, items.size()); |
| 2033 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 2034 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 2035 | EXPECT_EQ(ComponentState::kCanUpdate, items[1].state); |
| 2036 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[1].id.c_str()); |
| 2037 | EXPECT_EQ(ComponentState::kDownloading, items[2].state); |
| 2038 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 2039 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 2040 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 2041 | EXPECT_EQ(ComponentState::kUpdating, items[4].state); |
| 2042 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[4].id.c_str()); |
| 2043 | EXPECT_EQ(ComponentState::kUpdateError, items[5].state); |
| 2044 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[5].id.c_str()); |
| 2045 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2046 | update_client->RemoveObserver(&observer); |
| 2047 | } |
| 2048 | |
| 2049 | // Tests the fallback from differential to full update scenario for one CRX. |
| 2050 | TEST_F(UpdateClientTest, OneCrxDiffUpdateFailsFullUpdateSucceeds) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2051 | class DataCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2052 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2053 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2054 | const std::vector<std::string>& ids) { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2055 | static int num_calls = 0; |
| 2056 | |
| 2057 | // Must use the same stateful installer object. |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2058 | static scoped_refptr<CrxInstaller> installer = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2059 | base::MakeRefCounted<VersionedTestInstaller>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2060 | |
| 2061 | ++num_calls; |
| 2062 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2063 | CrxComponent crx; |
| 2064 | crx.name = "test_ihfo"; |
| 2065 | crx.pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
| 2066 | crx.installer = installer; |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2067 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2068 | if (num_calls == 1) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2069 | crx.version = base::Version("0.8"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2070 | } else if (num_calls == 2) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2071 | crx.version = base::Version("1.0"); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2072 | } else { |
| 2073 | NOTREACHED(); |
| 2074 | } |
| 2075 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2076 | return {crx}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2077 | } |
| 2078 | }; |
| 2079 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2080 | class CompletionCallbackMock { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2081 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2082 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2083 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2084 | std::move(quit_closure).Run(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2085 | } |
| 2086 | }; |
| 2087 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2088 | class MockUpdateChecker : public UpdateChecker { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2089 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2090 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2091 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2092 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2093 | return std::make_unique<MockUpdateChecker>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2094 | } |
| 2095 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 2096 | void CheckForUpdates( |
| 2097 | const std::string& session_id, |
| 2098 | const std::vector<std::string>& ids_to_check, |
| 2099 | const IdToComponentPtrMap& components, |
| 2100 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 2101 | bool enabled_component_updates, |
| 2102 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2103 | EXPECT_FALSE(session_id.empty()); |
| 2104 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2105 | static int num_call = 0; |
| 2106 | ++num_call; |
| 2107 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2108 | ProtocolParser::Results results; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2109 | |
| 2110 | if (num_call == 1) { |
| 2111 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2112 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2113 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 2114 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2115 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 2116 | <updatecheck status='ok'> |
| 2117 | <urls> |
| 2118 | <url codebase='http://localhost/download/'/> |
| 2119 | </urls> |
| 2120 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 2121 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2122 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
| 2123 | hash_sha256='813c59747e139a608b3b5fc49633affc6db57437 |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2124 | 3f309f156ea6d27229c0b3f9' |
| 2125 | fp='1'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2126 | </packages> |
| 2127 | </manifest> |
| 2128 | </updatecheck> |
| 2129 | </app> |
| 2130 | </response> |
| 2131 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2132 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 2133 | EXPECT_EQ(id, ids_to_check[0]); |
| 2134 | EXPECT_EQ(1u, components.count(id)); |
| 2135 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2136 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2137 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2138 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2139 | "8f5aa190311237cae00675af87ff457f278cd1a05895470ac5d46647d4a3c2ea"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2140 | package.fingerprint = "1"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2141 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2142 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2143 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 2144 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2145 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 2146 | result.manifest.version = "1.0"; |
| 2147 | result.manifest.browser_min_version = "11.0.1.0"; |
| 2148 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2149 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2150 | } else if (num_call == 2) { |
| 2151 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2152 | Mock the following response: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2153 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 2154 | <response protocol='3.1'> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2155 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 2156 | <updatecheck status='ok'> |
| 2157 | <urls> |
| 2158 | <url codebase='http://localhost/download/'/> |
| 2159 | <url codebasediff='http://localhost/download/'/> |
| 2160 | </urls> |
| 2161 | <manifest version='2.0' prodversionmin='11.0.1.0'> |
| 2162 | <packages> |
| 2163 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_2.crx' |
| 2164 | namediff='ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2165 | hash_sha256='c87d8742c3ff3d7a0cb6f3c91aa2fcf3dea6361 |
| 2166 | 8086a7db1c5be5300e1d4d6b6' |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2167 | fp='22' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2168 | hashdiff_sha256='0fd48a5dd87006a709756cfc47198cbc4c4 |
| 2169 | 928f33ac4277d79573c15164a33eb'/> |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2170 | </packages> |
| 2171 | </manifest> |
| 2172 | </updatecheck> |
| 2173 | </app> |
| 2174 | </response> |
| 2175 | */ |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2176 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 2177 | EXPECT_EQ(id, ids_to_check[0]); |
| 2178 | EXPECT_EQ(1u, components.count(id)); |
| 2179 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2180 | ProtocolParser::Result::Manifest::Package package; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2181 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_2.crx"; |
| 2182 | package.namediff = "ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2183 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2184 | "c87d8742c3ff3d7a0cb6f3c91aa2fcf3dea63618086a7db1c5be5300e1d4d6b6"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2185 | package.hashdiff_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2186 | "0fd48a5dd87006a709756cfc47198cbc4c4928f33ac4277d79573c15164a33eb"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2187 | package.fingerprint = "22"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2188 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2189 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2190 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 2191 | result.status = "ok"; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2192 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 2193 | result.crx_diffurls.push_back(GURL("http://localhost/download/")); |
| 2194 | result.manifest.version = "2.0"; |
| 2195 | result.manifest.browser_min_version = "11.0.1.0"; |
| 2196 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2197 | results.list.push_back(result); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2198 | } else { |
| 2199 | NOTREACHED(); |
| 2200 | } |
| 2201 | |
| 2202 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2203 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2204 | ErrorCategory::kNone, 0, 0)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2205 | } |
| 2206 | }; |
| 2207 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2208 | class MockCrxDownloader : public CrxDownloader { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2209 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2210 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2211 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 2212 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2213 | return std::make_unique<MockCrxDownloader>(); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2214 | } |
| 2215 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2216 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2217 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2218 | private: |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2219 | void DoStartDownload(const GURL& url) override { |
| 2220 | DownloadMetrics download_metrics; |
| 2221 | FilePath path; |
| 2222 | Result result; |
| 2223 | if (url.path() == "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 2224 | download_metrics.url = url; |
| 2225 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2226 | download_metrics.error = 0; |
| 2227 | download_metrics.downloaded_bytes = 53638; |
| 2228 | download_metrics.total_bytes = 53638; |
| 2229 | download_metrics.download_time_ms = 2000; |
| 2230 | |
| 2231 | EXPECT_TRUE(MakeTestFile( |
| 2232 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 2233 | |
| 2234 | result.error = 0; |
| 2235 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2236 | } else if (url.path() == |
| 2237 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1to2.crx") { |
| 2238 | // A download error is injected on this execution path. |
| 2239 | download_metrics.url = url; |
| 2240 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2241 | download_metrics.error = -1; |
| 2242 | download_metrics.downloaded_bytes = 0; |
| 2243 | download_metrics.total_bytes = 2105; |
| 2244 | download_metrics.download_time_ms = 1000; |
| 2245 | |
Sorin Jianu | 52de5fa | 2017-10-09 23:19:33 | [diff] [blame] | 2246 | // The response must not include a file path in the case of errors. |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2247 | result.error = -1; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2248 | } else if (url.path() == |
| 2249 | "/download/ihfokbkgjpifnbbojhneepfflplebdkc_2.crx") { |
| 2250 | download_metrics.url = url; |
| 2251 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2252 | download_metrics.error = 0; |
| 2253 | download_metrics.downloaded_bytes = 53855; |
| 2254 | download_metrics.total_bytes = 53855; |
| 2255 | download_metrics.download_time_ms = 1000; |
| 2256 | |
| 2257 | EXPECT_TRUE(MakeTestFile( |
| 2258 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_2.crx"), &path)); |
| 2259 | |
| 2260 | result.error = 0; |
| 2261 | result.response = path; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2262 | } |
| 2263 | |
| 2264 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2265 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 2266 | base::Unretained(this))); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2267 | |
| 2268 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2269 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 2270 | base::Unretained(this), true, result, |
| 2271 | download_metrics)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2272 | } |
| 2273 | }; |
| 2274 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2275 | class MockPingManager : public MockPingManagerImpl { |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2276 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2277 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2278 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2279 | |
| 2280 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2281 | ~MockPingManager() override { |
| 2282 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2283 | EXPECT_EQ(2u, ping_data.size()); |
| 2284 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[0].id); |
| 2285 | EXPECT_EQ(base::Version("0.8"), ping_data[0].previous_version); |
| 2286 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2287 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2288 | EXPECT_EQ(0, ping_data[0].error_code); |
| 2289 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 2290 | EXPECT_EQ(base::Version("1.0"), ping_data[1].previous_version); |
| 2291 | EXPECT_EQ(base::Version("2.0"), ping_data[1].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2292 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2293 | EXPECT_EQ(0, ping_data[1].error_code); |
| 2294 | EXPECT_TRUE(ping_data[1].diff_update_failed); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2295 | EXPECT_EQ(1, static_cast<int>(ping_data[1].diff_error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2296 | EXPECT_EQ(-1, ping_data[1].diff_error_code); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2297 | } |
| 2298 | }; |
| 2299 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2300 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2301 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2302 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2303 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2304 | |
| 2305 | MockObserver observer; |
| 2306 | { |
| 2307 | InSequence seq; |
| 2308 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2309 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2310 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2311 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2312 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2313 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 2314 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2315 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2316 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2317 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 2318 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2319 | |
| 2320 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2321 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2322 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2323 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2324 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2325 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 2326 | .Times(AtLeast(1)); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2327 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2328 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2329 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 2330 | "ihfokbkgjpifnbbojhneepfflplebdkc")).Times(1); |
| 2331 | } |
| 2332 | |
| 2333 | update_client->AddObserver(&observer); |
| 2334 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2335 | const std::vector<std::string> ids = {"ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2336 | |
| 2337 | { |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2338 | std::vector<CrxUpdateItem> items; |
| 2339 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2340 | EXPECT_CALL(*receiver, Receive(_)) |
| 2341 | .WillRepeatedly( |
| 2342 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
| 2343 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2344 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2345 | update_client->Update( |
| 2346 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 2347 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 2348 | false, |
| 2349 | base::BindOnce(&CompletionCallbackMock::Callback, |
| 2350 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2351 | runloop.Run(); |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2352 | EXPECT_EQ(6u, items.size()); |
| 2353 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 2354 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[0].id.c_str()); |
| 2355 | EXPECT_EQ(ComponentState::kCanUpdate, items[1].state); |
| 2356 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 2357 | EXPECT_EQ(ComponentState::kDownloading, items[2].state); |
| 2358 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[2].id.c_str()); |
| 2359 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 2360 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[3].id.c_str()); |
| 2361 | EXPECT_EQ(ComponentState::kUpdating, items[4].state); |
| 2362 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[4].id.c_str()); |
| 2363 | EXPECT_EQ(ComponentState::kUpdated, items[5].state); |
| 2364 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[5].id.c_str()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2365 | } |
| 2366 | |
| 2367 | { |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2368 | std::vector<CrxUpdateItem> items; |
| 2369 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2370 | EXPECT_CALL(*receiver, Receive(_)) |
| 2371 | .WillRepeatedly( |
| 2372 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
| 2373 | |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2374 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2375 | update_client->Update( |
| 2376 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 2377 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 2378 | false, |
| 2379 | base::BindOnce(&CompletionCallbackMock::Callback, |
| 2380 | runloop.QuitClosure())); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2381 | runloop.Run(); |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2382 | |
| 2383 | EXPECT_EQ(8u, items.size()); |
| 2384 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 2385 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[0].id.c_str()); |
| 2386 | EXPECT_EQ(ComponentState::kCanUpdate, items[1].state); |
| 2387 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 2388 | EXPECT_EQ(ComponentState::kDownloadingDiff, items[2].state); |
| 2389 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[2].id.c_str()); |
| 2390 | EXPECT_EQ(ComponentState::kDownloadingDiff, items[3].state); |
| 2391 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[3].id.c_str()); |
| 2392 | EXPECT_EQ(ComponentState::kDownloading, items[4].state); |
| 2393 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[4].id.c_str()); |
| 2394 | EXPECT_EQ(ComponentState::kDownloading, items[5].state); |
| 2395 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[5].id.c_str()); |
| 2396 | EXPECT_EQ(ComponentState::kUpdating, items[6].state); |
| 2397 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[6].id.c_str()); |
| 2398 | EXPECT_EQ(ComponentState::kUpdated, items[7].state); |
| 2399 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[7].id.c_str()); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2400 | } |
| 2401 | |
| 2402 | update_client->RemoveObserver(&observer); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2403 | } |
| 2404 | |
| 2405 | // Tests the queuing of update checks. In this scenario, two update checks are |
| 2406 | // done for one CRX. The second update check call is queued up and will run |
| 2407 | // after the first check has completed. The CRX has no updates. |
| 2408 | TEST_F(UpdateClientTest, OneCrxNoUpdateQueuedCall) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2409 | class DataCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2410 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2411 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2412 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2413 | CrxComponent crx; |
| 2414 | crx.name = "test_jebg"; |
| 2415 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 2416 | crx.version = base::Version("0.9"); |
| 2417 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2418 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2419 | return {crx}; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2420 | } |
| 2421 | }; |
| 2422 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2423 | class CompletionCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2424 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2425 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2426 | static int num_call = 0; |
| 2427 | ++num_call; |
| 2428 | |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2429 | EXPECT_EQ(Error::NONE, error); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2430 | |
| 2431 | if (num_call == 2) |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2432 | std::move(quit_closure).Run(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2433 | } |
| 2434 | }; |
| 2435 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2436 | class MockUpdateChecker : public UpdateChecker { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2437 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2438 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2439 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2440 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2441 | return std::make_unique<MockUpdateChecker>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2442 | } |
| 2443 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 2444 | void CheckForUpdates( |
| 2445 | const std::string& session_id, |
| 2446 | const std::vector<std::string>& ids_to_check, |
| 2447 | const IdToComponentPtrMap& components, |
| 2448 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 2449 | bool enabled_component_updates, |
| 2450 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2451 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2452 | EXPECT_TRUE(enabled_component_updates); |
| 2453 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2454 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2455 | EXPECT_EQ(id, ids_to_check.front()); |
| 2456 | EXPECT_EQ(1u, components.count(id)); |
| 2457 | |
| 2458 | auto& component = components.at(id); |
| 2459 | |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2460 | EXPECT_FALSE(component->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2461 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2462 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2463 | result.extension_id = id; |
| 2464 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2465 | ProtocolParser::Results results; |
| 2466 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2467 | |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2468 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2469 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2470 | ErrorCategory::kNone, 0, 0)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2471 | } |
| 2472 | }; |
| 2473 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2474 | class MockCrxDownloader : public CrxDownloader { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2475 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2476 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2477 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 2478 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2479 | return std::make_unique<MockCrxDownloader>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2480 | } |
| 2481 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2482 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2483 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2484 | private: |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2485 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 2486 | }; |
| 2487 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2488 | class MockPingManager : public MockPingManagerImpl { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2489 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2490 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2491 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2492 | |
| 2493 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2494 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2495 | }; |
| 2496 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2497 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2498 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2499 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2500 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2501 | |
| 2502 | MockObserver observer; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2503 | { |
| 2504 | InSequence seq; |
| 2505 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2506 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2507 | .Times(1); |
| 2508 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2509 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2510 | .Times(1); |
| 2511 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2512 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2513 | .Times(1); |
| 2514 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 2515 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2516 | .Times(1); |
| 2517 | } |
| 2518 | |
| 2519 | std::vector<CrxUpdateItem> items1; |
| 2520 | auto receiver1 = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2521 | EXPECT_CALL(*receiver1, Receive(_)) |
| 2522 | .WillRepeatedly( |
| 2523 | [&items1](const CrxUpdateItem& item) { items1.push_back(item); }); |
| 2524 | |
| 2525 | std::vector<CrxUpdateItem> items2; |
| 2526 | auto receiver2 = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2527 | EXPECT_CALL(*receiver2, Receive(_)) |
| 2528 | .WillRepeatedly( |
| 2529 | [&items2](const CrxUpdateItem& item) { items2.push_back(item); }); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2530 | |
| 2531 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2532 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2533 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2534 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 2535 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver1), |
| 2536 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2537 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2538 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 2539 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver2), |
| 2540 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2541 | RunThreads(); |
| 2542 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2543 | EXPECT_EQ(2u, items1.size()); |
| 2544 | EXPECT_EQ(ComponentState::kChecking, items1[0].state); |
| 2545 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items1[0].id.c_str()); |
| 2546 | EXPECT_EQ(ComponentState::kUpToDate, items1[1].state); |
| 2547 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items1[1].id.c_str()); |
| 2548 | |
| 2549 | EXPECT_EQ(2u, items2.size()); |
| 2550 | EXPECT_EQ(ComponentState::kChecking, items2[0].state); |
| 2551 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items2[0].id.c_str()); |
| 2552 | EXPECT_EQ(ComponentState::kUpToDate, items2[1].state); |
| 2553 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items2[1].id.c_str()); |
| 2554 | |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2555 | update_client->RemoveObserver(&observer); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2556 | } |
| 2557 | |
Sorin Jianu | 9d64af67 | 2020-02-05 19:14:34 | [diff] [blame] | 2558 | // Tests the install of one CRX. Tests the installer is invoked with the |
Sorin Jianu | b925867 | 2020-02-19 16:52:17 | [diff] [blame] | 2559 | // run and arguments values of the manifest object. Tests that "pv" and "fp" |
| 2560 | // are persisted. |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2561 | TEST_F(UpdateClientTest, OneCrxInstall) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2562 | class DataCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2563 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2564 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2565 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2566 | CrxComponent crx; |
| 2567 | crx.name = "test_jebg"; |
| 2568 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 2569 | crx.version = base::Version("0.0"); |
| 2570 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2571 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2572 | return {crx}; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2573 | } |
| 2574 | }; |
| 2575 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2576 | class CompletionCallbackMock { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2577 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2578 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2579 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2580 | std::move(quit_closure).Run(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2581 | } |
| 2582 | }; |
| 2583 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2584 | class MockUpdateChecker : public UpdateChecker { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2585 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2586 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2587 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2588 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2589 | return std::make_unique<MockUpdateChecker>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2590 | } |
| 2591 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 2592 | void CheckForUpdates( |
| 2593 | const std::string& session_id, |
| 2594 | const std::vector<std::string>& ids_to_check, |
| 2595 | const IdToComponentPtrMap& components, |
| 2596 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 2597 | bool enabled_component_updates, |
| 2598 | UpdateCheckCallback update_check_callback) override { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2599 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2600 | Mock the following response: |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2601 | |
| 2602 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 2603 | <response protocol='3.1'> |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2604 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 2605 | <updatecheck status='ok'> |
| 2606 | <urls> |
| 2607 | <url codebase='http://localhost/download/'/> |
| 2608 | </urls> |
Sorin Jianu | 9d64af67 | 2020-02-05 19:14:34 | [diff] [blame] | 2609 | <manifest version='1.0' prodversionmin='11.0.1.0' |
| 2610 | run='UpdaterSetup.exe' arguments='--arg1 --arg2'> |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2611 | <packages> |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2612 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2613 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 2614 | a284a7cd8059c3409ce0498'/> |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2615 | </packages> |
| 2616 | </manifest> |
| 2617 | </updatecheck> |
| 2618 | </app> |
| 2619 | </response> |
| 2620 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2621 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2622 | EXPECT_TRUE(enabled_component_updates); |
| 2623 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2624 | |
| 2625 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2626 | EXPECT_EQ(id, ids_to_check[0]); |
| 2627 | EXPECT_EQ(1u, components.count(id)); |
| 2628 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2629 | ProtocolParser::Result::Manifest::Package package; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2630 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
sorin | 74e7067 | 2016-02-03 03:13:10 | [diff] [blame] | 2631 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2632 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
Sorin Jianu | b925867 | 2020-02-19 16:52:17 | [diff] [blame] | 2633 | package.fingerprint = "some-fingerprint"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2634 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2635 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2636 | result.extension_id = id; |
sorin | 9ef301c | 2017-02-16 20:29:17 | [diff] [blame] | 2637 | result.status = "ok"; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2638 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 2639 | result.manifest.version = "1.0"; |
| 2640 | result.manifest.browser_min_version = "11.0.1.0"; |
Sorin Jianu | 9d64af67 | 2020-02-05 19:14:34 | [diff] [blame] | 2641 | result.manifest.run = "UpdaterSetup.exe"; |
| 2642 | result.manifest.arguments = "--arg1 --arg2"; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2643 | result.manifest.packages.push_back(package); |
| 2644 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2645 | ProtocolParser::Results results; |
| 2646 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2647 | |
| 2648 | // Verify that calling Install sets ondemand. |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2649 | EXPECT_TRUE(components.at(id)->is_foreground()); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2650 | |
| 2651 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2652 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2653 | ErrorCategory::kNone, 0, 0)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2654 | } |
| 2655 | }; |
| 2656 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2657 | class MockCrxDownloader : public CrxDownloader { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2658 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2659 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2660 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 2661 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2662 | return std::make_unique<MockCrxDownloader>(); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2663 | } |
| 2664 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2665 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2666 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2667 | private: |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2668 | void DoStartDownload(const GURL& url) override { |
| 2669 | DownloadMetrics download_metrics; |
| 2670 | FilePath path; |
| 2671 | Result result; |
| 2672 | if (url.path() == "/download/jebgalgnebhfojomionfpkfelancnnkf.crx") { |
| 2673 | download_metrics.url = url; |
| 2674 | download_metrics.downloader = DownloadMetrics::kNone; |
| 2675 | download_metrics.error = 0; |
| 2676 | download_metrics.downloaded_bytes = 1843; |
| 2677 | download_metrics.total_bytes = 1843; |
| 2678 | download_metrics.download_time_ms = 1000; |
| 2679 | |
| 2680 | EXPECT_TRUE(MakeTestFile( |
| 2681 | TestFilePath("jebgalgnebhfojomionfpkfelancnnkf.crx"), &path)); |
| 2682 | |
| 2683 | result.error = 0; |
| 2684 | result.response = path; |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2685 | } else { |
| 2686 | NOTREACHED(); |
| 2687 | } |
| 2688 | |
| 2689 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2690 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 2691 | base::Unretained(this))); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2692 | |
| 2693 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2694 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 2695 | base::Unretained(this), true, result, |
| 2696 | download_metrics)); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2697 | } |
| 2698 | }; |
| 2699 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2700 | class MockPingManager : public MockPingManagerImpl { |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2701 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2702 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2703 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 2704 | |
| 2705 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2706 | ~MockPingManager() override { |
| 2707 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2708 | EXPECT_EQ(1u, ping_data.size()); |
| 2709 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 2710 | EXPECT_EQ(base::Version("0.0"), ping_data[0].previous_version); |
| 2711 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 2712 | EXPECT_EQ(0, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2713 | EXPECT_EQ(0, ping_data[0].error_code); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2714 | } |
| 2715 | }; |
| 2716 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2717 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 2718 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2719 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2720 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
Sorin Jianu | b925867 | 2020-02-19 16:52:17 | [diff] [blame] | 2721 | { |
| 2722 | EXPECT_FALSE(config()->GetPrefService()->FindPreference( |
| 2723 | "updateclientdata.apps.jebgalgnebhfojomionfpkfelancnnkf.pv")); |
| 2724 | EXPECT_FALSE(config()->GetPrefService()->FindPreference( |
| 2725 | "updateclientdata.apps.jebgalgnebhfojomionfpkfelancnnkf.fp")); |
| 2726 | } |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2727 | |
| 2728 | MockObserver observer; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2729 | { |
| 2730 | InSequence seq; |
| 2731 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 2732 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2733 | .Times(1); |
| 2734 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 2735 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2736 | .Times(1); |
| 2737 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
| 2738 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2739 | .Times(AtLeast(1)); |
| 2740 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 2741 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2742 | .Times(1); |
| 2743 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 2744 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2745 | .Times(1) |
| 2746 | .WillOnce(Invoke([update_client](Events event, const std::string& id) { |
| 2747 | CrxUpdateItem update_item; |
| 2748 | ASSERT_TRUE(update_client->GetCrxUpdateState(id, &update_item)); |
| 2749 | ASSERT_TRUE(update_item.component); |
| 2750 | const auto* test_installer = static_cast<TestInstaller*>( |
| 2751 | update_item.component->installer.get()); |
| 2752 | EXPECT_STREQ("UpdaterSetup.exe", |
| 2753 | test_installer->install_params()->run.c_str()); |
| 2754 | EXPECT_STREQ("--arg1 --arg2", |
| 2755 | test_installer->install_params()->arguments.c_str()); |
| 2756 | })); |
| 2757 | } |
| 2758 | |
| 2759 | std::vector<CrxUpdateItem> items; |
| 2760 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2761 | EXPECT_CALL(*receiver, Receive(_)) |
| 2762 | .WillRepeatedly( |
| 2763 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2764 | |
| 2765 | update_client->AddObserver(&observer); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2766 | update_client->Install( |
| 2767 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2768 | base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2769 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2770 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2771 | RunThreads(); |
| 2772 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2773 | EXPECT_EQ(6u, items.size()); |
| 2774 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 2775 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 2776 | EXPECT_EQ(ComponentState::kCanUpdate, items[1].state); |
| 2777 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[1].id.c_str()); |
| 2778 | EXPECT_EQ(ComponentState::kDownloading, items[2].state); |
| 2779 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 2780 | EXPECT_EQ(ComponentState::kDownloading, items[3].state); |
| 2781 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 2782 | EXPECT_EQ(ComponentState::kUpdating, items[4].state); |
| 2783 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[4].id.c_str()); |
| 2784 | EXPECT_EQ(ComponentState::kUpdated, items[5].state); |
| 2785 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[5].id.c_str()); |
| 2786 | |
Sorin Jianu | b925867 | 2020-02-19 16:52:17 | [diff] [blame] | 2787 | const base::DictionaryValue* dict = |
| 2788 | config()->GetPrefService()->GetDictionary("updateclientdata"); |
| 2789 | std::string pv; |
| 2790 | dict->GetString("apps.jebgalgnebhfojomionfpkfelancnnkf.pv", &pv); |
| 2791 | EXPECT_STREQ("1.0", pv.c_str()); |
| 2792 | std::string fingerprint; |
| 2793 | dict->GetString("apps.jebgalgnebhfojomionfpkfelancnnkf.fp", &fingerprint); |
| 2794 | EXPECT_STREQ("some-fingerprint", fingerprint.c_str()); |
| 2795 | |
sorin | 7c71762 | 2015-05-26 19:59:09 | [diff] [blame] | 2796 | update_client->RemoveObserver(&observer); |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 2797 | } |
| 2798 | |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2799 | // Tests the install of one CRX when no component data is provided. This |
| 2800 | // results in an install error. |
| 2801 | TEST_F(UpdateClientTest, OneCrxInstallNoCrxComponentData) { |
| 2802 | class DataCallbackMock { |
| 2803 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2804 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2805 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2806 | return {base::nullopt}; |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2807 | } |
| 2808 | }; |
| 2809 | |
| 2810 | class CompletionCallbackMock { |
| 2811 | public: |
| 2812 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 2813 | EXPECT_EQ(Error::NONE, error); |
| 2814 | std::move(quit_closure).Run(); |
| 2815 | } |
| 2816 | }; |
| 2817 | |
| 2818 | class MockUpdateChecker : public UpdateChecker { |
| 2819 | public: |
| 2820 | static std::unique_ptr<UpdateChecker> Create( |
| 2821 | scoped_refptr<Configurator> config, |
| 2822 | PersistedData* metadata) { |
| 2823 | return std::make_unique<MockUpdateChecker>(); |
| 2824 | } |
| 2825 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 2826 | void CheckForUpdates( |
| 2827 | const std::string& session_id, |
| 2828 | const std::vector<std::string>& ids_to_check, |
| 2829 | const IdToComponentPtrMap& components, |
| 2830 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 2831 | bool enabled_component_updates, |
| 2832 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2833 | NOTREACHED(); |
| 2834 | } |
| 2835 | }; |
| 2836 | |
| 2837 | class MockCrxDownloader : public CrxDownloader { |
| 2838 | public: |
| 2839 | static std::unique_ptr<CrxDownloader> Create( |
| 2840 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 2841 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2842 | return std::make_unique<MockCrxDownloader>(); |
| 2843 | } |
| 2844 | |
| 2845 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 2846 | |
| 2847 | private: |
| 2848 | void DoStartDownload(const GURL& url) override { NOTREACHED(); } |
| 2849 | }; |
| 2850 | |
| 2851 | class MockPingManager : public MockPingManagerImpl { |
| 2852 | public: |
| 2853 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2854 | : MockPingManagerImpl(config) {} |
| 2855 | |
| 2856 | protected: |
| 2857 | ~MockPingManager() override { |
| 2858 | EXPECT_EQ(0u, MockPingManagerImpl::ping_data().size()); |
| 2859 | } |
| 2860 | }; |
| 2861 | |
| 2862 | scoped_refptr<UpdateClient> update_client = |
| 2863 | base::MakeRefCounted<UpdateClientImpl>( |
| 2864 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 2865 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 2866 | |
| 2867 | MockObserver observer; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2868 | { |
| 2869 | InSequence seq; |
| 2870 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 2871 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 2872 | .Times(1) |
| 2873 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 2874 | // Tests that the state of the component when the CrxComponent data |
| 2875 | // is not provided. In this case, the optional |item.component| |
| 2876 | // instance is not present. |
| 2877 | CrxUpdateItem item; |
| 2878 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
| 2879 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 2880 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", item.id.c_str()); |
| 2881 | EXPECT_FALSE(item.component); |
| 2882 | EXPECT_EQ(ErrorCategory::kService, item.error_category); |
| 2883 | EXPECT_EQ(static_cast<int>(Error::CRX_NOT_FOUND), item.error_code); |
| 2884 | EXPECT_EQ(0, item.extra_code1); |
| 2885 | })); |
| 2886 | } |
| 2887 | |
| 2888 | std::vector<CrxUpdateItem> items; |
| 2889 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 2890 | EXPECT_CALL(*receiver, Receive(_)) |
| 2891 | .WillRepeatedly( |
| 2892 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2893 | |
| 2894 | update_client->AddObserver(&observer); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2895 | update_client->Install( |
| 2896 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
| 2897 | base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2898 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2899 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2900 | RunThreads(); |
| 2901 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 2902 | EXPECT_EQ(1u, items.size()); |
| 2903 | EXPECT_EQ(ComponentState::kUpdateError, items[0].state); |
| 2904 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 2905 | |
Sorin Jianu | cb4431a | 2018-04-30 20:59:24 | [diff] [blame] | 2906 | update_client->RemoveObserver(&observer); |
| 2907 | } |
| 2908 | |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2909 | // Tests that overlapping installs of the same CRX result in an error. |
| 2910 | TEST_F(UpdateClientTest, ConcurrentInstallSameCRX) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2911 | class DataCallbackMock { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2912 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2913 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 2914 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2915 | CrxComponent crx; |
| 2916 | crx.name = "test_jebg"; |
| 2917 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 2918 | crx.version = base::Version("0.0"); |
| 2919 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 2920 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 2921 | return {crx}; |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2922 | } |
| 2923 | }; |
| 2924 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2925 | class CompletionCallbackMock { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2926 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2927 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2928 | static int num_call = 0; |
| 2929 | ++num_call; |
| 2930 | |
| 2931 | EXPECT_LE(num_call, 2); |
| 2932 | |
| 2933 | if (num_call == 1) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2934 | EXPECT_EQ(Error::UPDATE_IN_PROGRESS, error); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2935 | return; |
| 2936 | } |
| 2937 | if (num_call == 2) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 2938 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 2939 | std::move(quit_closure).Run(); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2940 | } |
| 2941 | } |
| 2942 | }; |
| 2943 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2944 | class MockUpdateChecker : public UpdateChecker { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2945 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2946 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 2947 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 2948 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2949 | return std::make_unique<MockUpdateChecker>(); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2950 | } |
| 2951 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 2952 | void CheckForUpdates( |
| 2953 | const std::string& session_id, |
| 2954 | const std::vector<std::string>& ids_to_check, |
| 2955 | const IdToComponentPtrMap& components, |
| 2956 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 2957 | bool enabled_component_updates, |
| 2958 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 2959 | EXPECT_FALSE(session_id.empty()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2960 | EXPECT_TRUE(enabled_component_updates); |
| 2961 | EXPECT_EQ(1u, ids_to_check.size()); |
| 2962 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 2963 | EXPECT_EQ(id, ids_to_check.front()); |
| 2964 | EXPECT_EQ(1u, components.count(id)); |
| 2965 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 2966 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2967 | result.extension_id = id; |
| 2968 | result.status = "noupdate"; |
| 2969 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2970 | ProtocolParser::Results results; |
| 2971 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2972 | |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 2973 | // Verify that calling Install sets |is_foreground| for the component. |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 2974 | EXPECT_TRUE(components.at(id)->is_foreground()); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2975 | |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2976 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 2977 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 2978 | ErrorCategory::kNone, 0, 0)); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2979 | } |
| 2980 | }; |
| 2981 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2982 | class MockCrxDownloader : public CrxDownloader { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2983 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 2984 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2985 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 2986 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2987 | return std::make_unique<MockCrxDownloader>(); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2988 | } |
| 2989 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2990 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2991 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 2992 | private: |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2993 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 2994 | }; |
| 2995 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2996 | class MockPingManager : public MockPingManagerImpl { |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 2997 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 2998 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 2999 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3000 | |
| 3001 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3002 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3003 | }; |
| 3004 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3005 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3006 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3007 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3008 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3009 | |
| 3010 | MockObserver observer; |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3011 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3012 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3013 | .Times(1); |
| 3014 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 3015 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3016 | .Times(1); |
| 3017 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3018 | std::vector<CrxUpdateItem> items1; |
| 3019 | auto receiver1 = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 3020 | EXPECT_CALL(*receiver1, Receive(_)) |
| 3021 | .WillRepeatedly( |
| 3022 | [&items1](const CrxUpdateItem& item) { items1.push_back(item); }); |
| 3023 | |
| 3024 | std::vector<CrxUpdateItem> items2; |
| 3025 | auto receiver2 = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 3026 | EXPECT_CALL(*receiver2, Receive(_)) |
| 3027 | .WillRepeatedly( |
| 3028 | [&items2](const CrxUpdateItem& item) { items2.push_back(item); }); |
| 3029 | |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3030 | update_client->AddObserver(&observer); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3031 | update_client->Install( |
| 3032 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3033 | base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3034 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver1), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3035 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3036 | update_client->Install( |
| 3037 | std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3038 | base::BindOnce(&DataCallbackMock::Callback), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3039 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver2), |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3040 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3041 | RunThreads(); |
| 3042 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3043 | EXPECT_EQ(2u, items1.size()); |
| 3044 | EXPECT_EQ(ComponentState::kChecking, items1[0].state); |
| 3045 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items1[0].id.c_str()); |
| 3046 | EXPECT_EQ(ComponentState::kUpToDate, items1[1].state); |
| 3047 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items1[1].id.c_str()); |
| 3048 | |
| 3049 | EXPECT_TRUE(items2.empty()); |
| 3050 | |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3051 | update_client->RemoveObserver(&observer); |
sorin | 08d153c | 2015-10-30 00:04:20 | [diff] [blame] | 3052 | } |
| 3053 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3054 | // Tests that UpdateClient::Update returns Error::INVALID_ARGUMENT when |
| 3055 | // the |ids| parameter is empty. |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3056 | TEST_F(UpdateClientTest, EmptyIdList) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3057 | class DataCallbackMock { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3058 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3059 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3060 | const std::vector<std::string>& ids) { |
| 3061 | return {}; |
| 3062 | } |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3063 | }; |
| 3064 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3065 | class CompletionCallbackMock { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3066 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3067 | static void Callback(base::OnceClosure quit_closure, Error error) { |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3068 | EXPECT_EQ(Error::INVALID_ARGUMENT, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3069 | std::move(quit_closure).Run(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3070 | } |
| 3071 | }; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3072 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3073 | class MockUpdateChecker : public UpdateChecker { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3074 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 3075 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3076 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 3077 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3078 | return std::make_unique<MockUpdateChecker>(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3079 | } |
| 3080 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 3081 | void CheckForUpdates( |
| 3082 | const std::string& session_id, |
| 3083 | const std::vector<std::string>& ids_to_check, |
| 3084 | const IdToComponentPtrMap& components, |
| 3085 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 3086 | bool enabled_component_updates, |
| 3087 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3088 | NOTREACHED(); |
| 3089 | } |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3090 | }; |
| 3091 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3092 | class MockCrxDownloader : public CrxDownloader { |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3093 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 3094 | static std::unique_ptr<CrxDownloader> Create( |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3095 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 3096 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3097 | return std::make_unique<MockCrxDownloader>(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3098 | } |
| 3099 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3100 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3101 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3102 | private: |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3103 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3104 | }; |
| 3105 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3106 | class MockPingManager : public MockPingManagerImpl { |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3107 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3108 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3109 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3110 | |
| 3111 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3112 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3113 | }; |
| 3114 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3115 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3116 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3117 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3118 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3119 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3120 | const std::vector<std::string> empty_id_list; |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3121 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3122 | empty_id_list, base::BindOnce(&DataCallbackMock::Callback), {}, false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3123 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3124 | RunThreads(); |
asargent | e90363b | 2015-09-09 22:40:07 | [diff] [blame] | 3125 | } |
| 3126 | |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3127 | TEST_F(UpdateClientTest, SendUninstallPing) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3128 | class CompletionCallbackMock { |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 3129 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3130 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 3131 | std::move(quit_closure).Run(); |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 3132 | } |
| 3133 | }; |
| 3134 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3135 | class MockUpdateChecker : public UpdateChecker { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3136 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 3137 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3138 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 3139 | PersistedData* metadata) { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3140 | return nullptr; |
| 3141 | } |
| 3142 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 3143 | void CheckForUpdates( |
| 3144 | const std::string& session_id, |
| 3145 | const std::vector<std::string>& ids_to_check, |
| 3146 | const IdToComponentPtrMap& components, |
| 3147 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 3148 | bool enabled_component_updates, |
| 3149 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3150 | NOTREACHED(); |
| 3151 | } |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3152 | }; |
| 3153 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3154 | class MockCrxDownloader : public CrxDownloader { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3155 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 3156 | static std::unique_ptr<CrxDownloader> Create( |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3157 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 3158 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3159 | return nullptr; |
| 3160 | } |
| 3161 | |
| 3162 | private: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3163 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
Sorin Jianu | 3088115 | 2020-03-16 14:31:19 | [diff] [blame] | 3164 | ~MockCrxDownloader() override = default; |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3165 | |
| 3166 | void DoStartDownload(const GURL& url) override {} |
| 3167 | }; |
| 3168 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3169 | class MockPingManager : public MockPingManagerImpl { |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3170 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3171 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3172 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3173 | |
| 3174 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3175 | ~MockPingManager() override { |
| 3176 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3177 | EXPECT_EQ(1u, ping_data.size()); |
| 3178 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
Minh X. Nguyen | 01d3586d | 2018-01-03 21:53:39 | [diff] [blame] | 3179 | EXPECT_EQ(base::Version("1.2.3.4"), ping_data[0].previous_version); |
| 3180 | EXPECT_EQ(base::Version("0"), ping_data[0].next_version); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3181 | EXPECT_EQ(10, ping_data[0].extra_code1); |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3182 | } |
| 3183 | }; |
| 3184 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3185 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3186 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3187 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3188 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3189 | |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 3190 | update_client->SendUninstallPing( |
Minh X. Nguyen | 01d3586d | 2018-01-03 21:53:39 | [diff] [blame] | 3191 | "jebgalgnebhfojomionfpkfelancnnkf", base::Version("1.2.3.4"), 10, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3192 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 8037ac8c | 2017-04-19 16:28:00 | [diff] [blame] | 3193 | |
| 3194 | RunThreads(); |
sorin | 805aa0311 | 2016-01-14 23:01:31 | [diff] [blame] | 3195 | } |
| 3196 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3197 | TEST_F(UpdateClientTest, RetryAfter) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3198 | class DataCallbackMock { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3199 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3200 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3201 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3202 | CrxComponent crx; |
| 3203 | crx.name = "test_jebg"; |
| 3204 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 3205 | crx.version = base::Version("0.9"); |
| 3206 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3207 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3208 | return {crx}; |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3209 | } |
| 3210 | }; |
| 3211 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3212 | class CompletionCallbackMock { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3213 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3214 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3215 | static int num_call = 0; |
| 3216 | ++num_call; |
| 3217 | |
| 3218 | EXPECT_LE(num_call, 4); |
| 3219 | |
| 3220 | if (num_call == 1) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 3221 | EXPECT_EQ(Error::NONE, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3222 | } else if (num_call == 2) { |
| 3223 | // This request is throttled since the update engine received a |
| 3224 | // positive |retry_after_sec| value in the update check response. |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 3225 | EXPECT_EQ(Error::RETRY_LATER, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3226 | } else if (num_call == 3) { |
| 3227 | // This request is a foreground Install, which is never throttled. |
| 3228 | // The update engine received a |retry_after_sec| value of 0, which |
| 3229 | // resets the throttling. |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 3230 | EXPECT_EQ(Error::NONE, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3231 | } else if (num_call == 4) { |
| 3232 | // This request succeeds since there is no throttling in effect. |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 3233 | EXPECT_EQ(Error::NONE, error); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3234 | } |
| 3235 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3236 | std::move(quit_closure).Run(); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3237 | } |
| 3238 | }; |
| 3239 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3240 | class MockUpdateChecker : public UpdateChecker { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3241 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 3242 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3243 | scoped_refptr<Configurator> config, |
waffles | e7dff73 | 2016-04-15 23:51:49 | [diff] [blame] | 3244 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3245 | return std::make_unique<MockUpdateChecker>(); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3246 | } |
| 3247 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 3248 | void CheckForUpdates( |
| 3249 | const std::string& session_id, |
| 3250 | const std::vector<std::string>& ids_to_check, |
| 3251 | const IdToComponentPtrMap& components, |
| 3252 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 3253 | bool enabled_component_updates, |
| 3254 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3255 | EXPECT_FALSE(session_id.empty()); |
| 3256 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3257 | static int num_call = 0; |
| 3258 | ++num_call; |
| 3259 | |
| 3260 | EXPECT_LE(num_call, 3); |
| 3261 | |
| 3262 | int retry_after_sec(0); |
| 3263 | if (num_call == 1) { |
| 3264 | // Throttle the next call. |
| 3265 | retry_after_sec = 60 * 60; // 1 hour. |
| 3266 | } |
| 3267 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3268 | EXPECT_EQ(1u, ids_to_check.size()); |
| 3269 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 3270 | EXPECT_EQ(id, ids_to_check.front()); |
| 3271 | EXPECT_EQ(1u, components.count(id)); |
| 3272 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3273 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3274 | result.extension_id = id; |
| 3275 | result.status = "noupdate"; |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3276 | |
| 3277 | ProtocolParser::Results results; |
| 3278 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3279 | |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3280 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3281 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 3282 | ErrorCategory::kNone, 0, retry_after_sec)); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3283 | } |
| 3284 | }; |
| 3285 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3286 | class MockCrxDownloader : public CrxDownloader { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3287 | public: |
dcheng | d0fc6aa9 | 2016-04-22 18:03:12 | [diff] [blame] | 3288 | static std::unique_ptr<CrxDownloader> Create( |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3289 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 3290 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3291 | return std::make_unique<MockCrxDownloader>(); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3292 | } |
| 3293 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3294 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3295 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3296 | private: |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3297 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3298 | }; |
| 3299 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3300 | class MockPingManager : public MockPingManagerImpl { |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3301 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3302 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3303 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3304 | |
| 3305 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3306 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3307 | }; |
| 3308 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3309 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3310 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3311 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3312 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3313 | |
| 3314 | MockObserver observer; |
| 3315 | |
| 3316 | InSequence seq; |
| 3317 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3318 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3319 | .Times(1); |
| 3320 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 3321 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3322 | .Times(1); |
| 3323 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3324 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3325 | .Times(1); |
| 3326 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 3327 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3328 | .Times(1); |
| 3329 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3330 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3331 | .Times(1); |
| 3332 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_NOT_UPDATED, |
| 3333 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3334 | .Times(1); |
| 3335 | |
| 3336 | update_client->AddObserver(&observer); |
| 3337 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3338 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3339 | { |
| 3340 | // The engine handles this Update call but responds with a valid |
| 3341 | // |retry_after_sec|, which causes subsequent calls to fail. |
| 3342 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3343 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), {}, |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 3344 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3345 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3346 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3347 | runloop.Run(); |
| 3348 | } |
| 3349 | |
| 3350 | { |
| 3351 | // This call will result in a completion callback invoked with |
| 3352 | // Error::ERROR_UPDATE_RETRY_LATER. |
| 3353 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3354 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), {}, |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 3355 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3356 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3357 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3358 | runloop.Run(); |
| 3359 | } |
| 3360 | |
| 3361 | { |
| 3362 | // The Install call is handled, and the throttling is reset due to |
| 3363 | // the value of |retry_after_sec| in the completion callback. |
| 3364 | base::RunLoop runloop; |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3365 | update_client->Install(std::string("jebgalgnebhfojomionfpkfelancnnkf"), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3366 | base::BindOnce(&DataCallbackMock::Callback), {}, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3367 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3368 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3369 | runloop.Run(); |
| 3370 | } |
| 3371 | |
| 3372 | { |
| 3373 | // This call succeeds. |
| 3374 | base::RunLoop runloop; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3375 | update_client->Update(ids, base::BindOnce(&DataCallbackMock::Callback), {}, |
Sorin Jianu | b41a592a | 2018-03-02 16:30:27 | [diff] [blame] | 3376 | false, |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3377 | base::BindOnce(&CompletionCallbackMock::Callback, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3378 | runloop.QuitClosure())); |
sorin | fccbf2d | 2016-04-04 20:34:34 | [diff] [blame] | 3379 | runloop.Run(); |
| 3380 | } |
| 3381 | |
| 3382 | update_client->RemoveObserver(&observer); |
| 3383 | } |
| 3384 | |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3385 | // Tests the update check for two CRXs scenario. The first component supports |
| 3386 | // the group policy to enable updates, and has its updates disabled. The second |
| 3387 | // component has an update. The server does not honor the "updatedisabled" |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3388 | // attribute and returns updates for both components. However, the update for |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3389 | // the first component is not applied and the client responds with a |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3390 | // (SERVICE_ERROR, UPDATE_DISABLED) |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3391 | TEST_F(UpdateClientTest, TwoCrxUpdateOneUpdateDisabled) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3392 | class DataCallbackMock { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3393 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3394 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3395 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3396 | CrxComponent crx1; |
| 3397 | crx1.name = "test_jebg"; |
| 3398 | crx1.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 3399 | crx1.version = base::Version("0.9"); |
| 3400 | crx1.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3401 | crx1.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3402 | crx1.supports_group_policy_enable_component_updates = true; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3403 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3404 | CrxComponent crx2; |
| 3405 | crx2.name = "test_ihfo"; |
| 3406 | crx2.pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
| 3407 | crx2.version = base::Version("0.8"); |
| 3408 | crx2.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3409 | crx2.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3410 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3411 | return {crx1, crx2}; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3412 | } |
| 3413 | }; |
| 3414 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3415 | class CompletionCallbackMock { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3416 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3417 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 7b865052 | 2016-11-02 18:23:41 | [diff] [blame] | 3418 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3419 | std::move(quit_closure).Run(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3420 | } |
| 3421 | }; |
| 3422 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3423 | class MockUpdateChecker : public UpdateChecker { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3424 | public: |
| 3425 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3426 | scoped_refptr<Configurator> config, |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3427 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3428 | return std::make_unique<MockUpdateChecker>(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3429 | } |
| 3430 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 3431 | void CheckForUpdates( |
| 3432 | const std::string& session_id, |
| 3433 | const std::vector<std::string>& ids_to_check, |
| 3434 | const IdToComponentPtrMap& components, |
| 3435 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 3436 | bool enabled_component_updates, |
| 3437 | UpdateCheckCallback update_check_callback) override { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3438 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3439 | Mock the following response: |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3440 | |
| 3441 | <?xml version='1.0' encoding='UTF-8'?> |
sorin | 3985280 | 2017-05-01 22:46:28 | [diff] [blame] | 3442 | <response protocol='3.1'> |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3443 | <app appid='jebgalgnebhfojomionfpkfelancnnkf'> |
| 3444 | <updatecheck status='ok'> |
| 3445 | <urls> |
| 3446 | <url codebase='http://localhost/download/'/> |
| 3447 | </urls> |
| 3448 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 3449 | <packages> |
| 3450 | <package name='jebgalgnebhfojomionfpkfelancnnkf.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3451 | hash_sha256='7ab32f071cd9b5ef8e0d7913be161f532d98b3e9f |
| 3452 | a284a7cd8059c3409ce0498'/> |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3453 | </packages> |
| 3454 | </manifest> |
| 3455 | </updatecheck> |
| 3456 | </app> |
| 3457 | <app appid='ihfokbkgjpifnbbojhneepfflplebdkc'> |
| 3458 | <updatecheck status='ok'> |
| 3459 | <urls> |
| 3460 | <url codebase='http://localhost/download/'/> |
| 3461 | </urls> |
| 3462 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 3463 | <packages> |
| 3464 | <package name='ihfokbkgjpifnbbojhneepfflplebdkc_1.crx' |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3465 | hash_sha256='8f5aa190311237cae00675af87ff457f278cd1a05 |
| 3466 | 895470ac5d46647d4a3c2ea'/> |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3467 | </packages> |
| 3468 | </manifest> |
| 3469 | </updatecheck> |
| 3470 | </app> |
| 3471 | </response> |
| 3472 | */ |
sorin | 590921d | 2016-08-11 23:48:36 | [diff] [blame] | 3473 | |
| 3474 | // UpdateClient reads the state of |enabled_component_updates| from the |
| 3475 | // configurator instance, persists its value in the corresponding |
| 3476 | // update context, and propagates it down to each of the update actions, |
| 3477 | // and further down to the UpdateChecker instance. |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3478 | EXPECT_FALSE(session_id.empty()); |
sorin | 590921d | 2016-08-11 23:48:36 | [diff] [blame] | 3479 | EXPECT_FALSE(enabled_component_updates); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3480 | EXPECT_EQ(2u, ids_to_check.size()); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3481 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3482 | ProtocolParser::Results results; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3483 | { |
| 3484 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 3485 | EXPECT_EQ(id, ids_to_check[0]); |
| 3486 | EXPECT_EQ(1u, components.count(id)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3487 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3488 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3489 | package.name = "jebgalgnebhfojomionfpkfelancnnkf.crx"; |
| 3490 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3491 | "7ab32f071cd9b5ef8e0d7913be161f532d98b3e9fa284a7cd8059c3409ce0498"; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3492 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3493 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3494 | result.extension_id = id; |
| 3495 | result.status = "ok"; |
| 3496 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 3497 | result.manifest.version = "1.0"; |
| 3498 | result.manifest.browser_min_version = "11.0.1.0"; |
| 3499 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3500 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3501 | } |
| 3502 | |
| 3503 | { |
| 3504 | const std::string id = "ihfokbkgjpifnbbojhneepfflplebdkc"; |
| 3505 | EXPECT_EQ(id, ids_to_check[1]); |
| 3506 | EXPECT_EQ(1u, components.count(id)); |
| 3507 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3508 | ProtocolParser::Result::Manifest::Package package; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3509 | package.name = "ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"; |
| 3510 | package.hash_sha256 = |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3511 | "8f5aa190311237cae00675af87ff457f278cd1a05895470ac5d46647d4a3c2ea"; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3512 | |
sorin | 7cff6e5 | 2017-05-17 16:37:23 | [diff] [blame] | 3513 | ProtocolParser::Result result; |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3514 | result.extension_id = id; |
| 3515 | result.status = "ok"; |
| 3516 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 3517 | result.manifest.version = "1.0"; |
| 3518 | result.manifest.browser_min_version = "11.0.1.0"; |
| 3519 | result.manifest.packages.push_back(package); |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3520 | results.list.push_back(result); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3521 | } |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3522 | |
| 3523 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3524 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 3525 | ErrorCategory::kNone, 0, 0)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3526 | } |
| 3527 | }; |
| 3528 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3529 | class MockCrxDownloader : public CrxDownloader { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3530 | public: |
| 3531 | static std::unique_ptr<CrxDownloader> Create( |
| 3532 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 3533 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3534 | return std::make_unique<MockCrxDownloader>(); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3535 | } |
| 3536 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3537 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3538 | |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3539 | private: |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3540 | void DoStartDownload(const GURL& url) override { |
| 3541 | DownloadMetrics download_metrics; |
| 3542 | FilePath path; |
| 3543 | Result result; |
| 3544 | if (url.path() == "/download/ihfokbkgjpifnbbojhneepfflplebdkc_1.crx") { |
| 3545 | download_metrics.url = url; |
| 3546 | download_metrics.downloader = DownloadMetrics::kNone; |
| 3547 | download_metrics.error = 0; |
| 3548 | download_metrics.downloaded_bytes = 53638; |
| 3549 | download_metrics.total_bytes = 53638; |
| 3550 | download_metrics.download_time_ms = 2000; |
| 3551 | |
| 3552 | EXPECT_TRUE(MakeTestFile( |
| 3553 | TestFilePath("ihfokbkgjpifnbbojhneepfflplebdkc_1.crx"), &path)); |
| 3554 | |
| 3555 | result.error = 0; |
| 3556 | result.response = path; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3557 | } else { |
| 3558 | NOTREACHED(); |
| 3559 | } |
| 3560 | |
| 3561 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3562 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadProgress, |
Antonio Gomes | 31237fb | 2018-08-27 19:11:03 | [diff] [blame] | 3563 | base::Unretained(this))); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3564 | |
| 3565 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3566 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 3567 | base::Unretained(this), true, result, |
| 3568 | download_metrics)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3569 | } |
| 3570 | }; |
| 3571 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3572 | class MockPingManager : public MockPingManagerImpl { |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3573 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3574 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3575 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3576 | |
| 3577 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3578 | ~MockPingManager() override { |
| 3579 | const auto ping_data = MockPingManagerImpl::ping_data(); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3580 | EXPECT_EQ(2u, ping_data.size()); |
| 3581 | EXPECT_EQ("jebgalgnebhfojomionfpkfelancnnkf", ping_data[0].id); |
| 3582 | EXPECT_EQ(base::Version("0.9"), ping_data[0].previous_version); |
| 3583 | EXPECT_EQ(base::Version("1.0"), ping_data[0].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 3584 | EXPECT_EQ(4, static_cast<int>(ping_data[0].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3585 | EXPECT_EQ(2, ping_data[0].error_code); |
| 3586 | EXPECT_EQ("ihfokbkgjpifnbbojhneepfflplebdkc", ping_data[1].id); |
| 3587 | EXPECT_EQ(base::Version("0.8"), ping_data[1].previous_version); |
| 3588 | EXPECT_EQ(base::Version("1.0"), ping_data[1].next_version); |
Minh X. Nguyen | a4640cb | 2018-05-23 21:29:10 | [diff] [blame] | 3589 | EXPECT_EQ(0, static_cast<int>(ping_data[1].error_category)); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3590 | EXPECT_EQ(0, ping_data[1].error_code); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3591 | } |
| 3592 | }; |
| 3593 | |
| 3594 | // Disables updates for the components declaring support for the group policy. |
| 3595 | config()->SetEnabledComponentUpdates(false); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3596 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3597 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3598 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3599 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3600 | |
| 3601 | MockObserver observer; |
| 3602 | { |
| 3603 | InSequence seq; |
| 3604 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3605 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3606 | .Times(1); |
| 3607 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 3608 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3609 | .Times(1); |
Sorin Jianu | cbb10e1 | 2018-01-23 18:01:44 | [diff] [blame] | 3610 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3611 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3612 | .Times(1); |
| 3613 | } |
| 3614 | { |
| 3615 | InSequence seq; |
| 3616 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3617 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3618 | .Times(1); |
| 3619 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_FOUND, |
| 3620 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3621 | .Times(1); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3622 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_DOWNLOADING, |
| 3623 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3624 | .Times(AtLeast(1)); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3625 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_READY, |
| 3626 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3627 | .Times(1); |
| 3628 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATED, |
| 3629 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3630 | .Times(1); |
| 3631 | } |
| 3632 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3633 | std::vector<CrxUpdateItem> items; |
| 3634 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 3635 | EXPECT_CALL(*receiver, Receive(_)) |
| 3636 | .WillRepeatedly( |
| 3637 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3638 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3639 | update_client->AddObserver(&observer); |
sorin | 30474f0 | 2017-04-27 00:45:48 | [diff] [blame] | 3640 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf", |
| 3641 | "ihfokbkgjpifnbbojhneepfflplebdkc"}; |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3642 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3643 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 3644 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 3645 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3646 | RunThreads(); |
| 3647 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3648 | EXPECT_EQ(9u, items.size()); |
| 3649 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 3650 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 3651 | EXPECT_EQ(ComponentState::kChecking, items[1].state); |
| 3652 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[1].id.c_str()); |
| 3653 | EXPECT_EQ(ComponentState::kCanUpdate, items[2].state); |
| 3654 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[2].id.c_str()); |
| 3655 | EXPECT_EQ(ComponentState::kUpdateError, items[3].state); |
| 3656 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[3].id.c_str()); |
| 3657 | EXPECT_EQ(ComponentState::kCanUpdate, items[4].state); |
| 3658 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[4].id.c_str()); |
| 3659 | EXPECT_EQ(ComponentState::kDownloading, items[5].state); |
| 3660 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[5].id.c_str()); |
| 3661 | EXPECT_EQ(ComponentState::kDownloading, items[6].state); |
| 3662 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[6].id.c_str()); |
| 3663 | EXPECT_EQ(ComponentState::kUpdating, items[7].state); |
| 3664 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[7].id.c_str()); |
| 3665 | EXPECT_EQ(ComponentState::kUpdated, items[8].state); |
| 3666 | EXPECT_STREQ("ihfokbkgjpifnbbojhneepfflplebdkc", items[8].id.c_str()); |
| 3667 | |
sorin | e84ff70 | 2016-08-04 01:22:02 | [diff] [blame] | 3668 | update_client->RemoveObserver(&observer); |
| 3669 | } |
| 3670 | |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3671 | // Tests the scenario where the update check fails. |
| 3672 | TEST_F(UpdateClientTest, OneCrxUpdateCheckFails) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3673 | class DataCallbackMock { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3674 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3675 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 3676 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3677 | CrxComponent crx; |
| 3678 | crx.name = "test_jebg"; |
| 3679 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 3680 | crx.version = base::Version("0.9"); |
| 3681 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3682 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3683 | return {crx}; |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3684 | } |
| 3685 | }; |
| 3686 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3687 | class CompletionCallbackMock { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3688 | public: |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3689 | static void Callback(base::OnceClosure quit_closure, Error error) { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3690 | EXPECT_EQ(Error::UPDATE_CHECK_ERROR, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 3691 | std::move(quit_closure).Run(); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3692 | } |
| 3693 | }; |
| 3694 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3695 | class MockUpdateChecker : public UpdateChecker { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3696 | public: |
| 3697 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 3698 | scoped_refptr<Configurator> config, |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3699 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3700 | return std::make_unique<MockUpdateChecker>(); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3701 | } |
| 3702 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 3703 | void CheckForUpdates( |
| 3704 | const std::string& session_id, |
| 3705 | const std::vector<std::string>& ids_to_check, |
| 3706 | const IdToComponentPtrMap& components, |
| 3707 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 3708 | bool enabled_component_updates, |
| 3709 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 3710 | EXPECT_FALSE(session_id.empty()); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3711 | EXPECT_TRUE(enabled_component_updates); |
| 3712 | EXPECT_EQ(1u, ids_to_check.size()); |
| 3713 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 3714 | EXPECT_EQ(id, ids_to_check.front()); |
| 3715 | EXPECT_EQ(1u, components.count(id)); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3716 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 3717 | FROM_HERE, |
| 3718 | base::BindOnce(std::move(update_check_callback), base::nullopt, |
| 3719 | ErrorCategory::kUpdateCheck, -1, 0)); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3720 | } |
| 3721 | }; |
| 3722 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3723 | class MockCrxDownloader : public CrxDownloader { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3724 | public: |
| 3725 | static std::unique_ptr<CrxDownloader> Create( |
| 3726 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 3727 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3728 | return std::make_unique<MockCrxDownloader>(); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3729 | } |
| 3730 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3731 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3732 | |
| 3733 | private: |
| 3734 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3735 | }; |
| 3736 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3737 | class MockPingManager : public MockPingManagerImpl { |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3738 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3739 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3740 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 3741 | |
| 3742 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3743 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3744 | }; |
| 3745 | |
| 3746 | scoped_refptr<UpdateClient> update_client = |
Taiju Tsuiki | 36c517d | 2017-05-18 06:45:43 | [diff] [blame] | 3747 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 3748 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3749 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3750 | |
| 3751 | MockObserver observer; |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3752 | { |
| 3753 | InSequence seq; |
| 3754 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3755 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3756 | .Times(1); |
| 3757 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3758 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3759 | .Times(1) |
| 3760 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3761 | CrxUpdateItem item; |
| 3762 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
| 3763 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3764 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3765 | EXPECT_EQ(-1, item.error_code); |
| 3766 | EXPECT_EQ(0, item.extra_code1); |
| 3767 | })); |
| 3768 | } |
| 3769 | |
| 3770 | std::vector<CrxUpdateItem> items; |
| 3771 | auto receiver = base::MakeRefCounted<MockCrxStateChangeReceiver>(); |
| 3772 | EXPECT_CALL(*receiver, Receive(_)) |
| 3773 | .WillRepeatedly( |
| 3774 | [&items](const CrxUpdateItem& item) { items.push_back(item); }); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3775 | |
| 3776 | update_client->AddObserver(&observer); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3777 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
| 3778 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3779 | ids, base::BindOnce(&DataCallbackMock::Callback), |
| 3780 | base::BindRepeating(&MockCrxStateChangeReceiver::Receive, receiver), |
| 3781 | false, base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3782 | RunThreads(); |
| 3783 | |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3784 | EXPECT_EQ(2u, items.size()); |
| 3785 | EXPECT_EQ(ComponentState::kChecking, items[0].state); |
| 3786 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[0].id.c_str()); |
| 3787 | EXPECT_EQ(ComponentState::kUpdateError, items[1].state); |
| 3788 | EXPECT_STREQ("jebgalgnebhfojomionfpkfelancnnkf", items[1].id.c_str()); |
| 3789 | |
sorin | 03ec5b7 | 2017-05-01 23:14:24 | [diff] [blame] | 3790 | update_client->RemoveObserver(&observer); |
| 3791 | } |
| 3792 | |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3793 | // Tests the scenario where the server responds with different values for |
| 3794 | // application status. |
| 3795 | TEST_F(UpdateClientTest, OneCrxErrorUnknownApp) { |
| 3796 | class DataCallbackMock { |
| 3797 | public: |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3798 | static std::vector<base::Optional<CrxComponent>> Callback( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3799 | const std::vector<std::string>& ids) { |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3800 | std::vector<base::Optional<CrxComponent>> component; |
| 3801 | { |
| 3802 | CrxComponent crx; |
| 3803 | crx.name = "test_jebg"; |
| 3804 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 3805 | crx.version = base::Version("0.9"); |
| 3806 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3807 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3808 | component.push_back(crx); |
| 3809 | } |
| 3810 | { |
| 3811 | CrxComponent crx; |
| 3812 | crx.name = "test_abag"; |
| 3813 | crx.pk_hash.assign(abag_hash, abag_hash + base::size(abag_hash)); |
| 3814 | crx.version = base::Version("0.1"); |
| 3815 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3816 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3817 | component.push_back(crx); |
| 3818 | } |
| 3819 | { |
| 3820 | CrxComponent crx; |
| 3821 | crx.name = "test_ihfo"; |
| 3822 | crx.pk_hash.assign(ihfo_hash, ihfo_hash + base::size(ihfo_hash)); |
| 3823 | crx.version = base::Version("0.2"); |
| 3824 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3825 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3826 | component.push_back(crx); |
| 3827 | } |
| 3828 | { |
| 3829 | CrxComponent crx; |
| 3830 | crx.name = "test_gjpm"; |
| 3831 | crx.pk_hash.assign(gjpm_hash, gjpm_hash + base::size(gjpm_hash)); |
| 3832 | crx.version = base::Version("0.3"); |
| 3833 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 3834 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3835 | component.push_back(crx); |
| 3836 | } |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3837 | return component; |
| 3838 | } |
| 3839 | }; |
| 3840 | |
| 3841 | class CompletionCallbackMock { |
| 3842 | public: |
| 3843 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 3844 | EXPECT_EQ(Error::NONE, error); |
| 3845 | std::move(quit_closure).Run(); |
| 3846 | } |
| 3847 | }; |
| 3848 | |
| 3849 | class MockUpdateChecker : public UpdateChecker { |
| 3850 | public: |
| 3851 | static std::unique_ptr<UpdateChecker> Create( |
| 3852 | scoped_refptr<Configurator> config, |
| 3853 | PersistedData* metadata) { |
| 3854 | return std::make_unique<MockUpdateChecker>(); |
| 3855 | } |
| 3856 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 3857 | void CheckForUpdates( |
| 3858 | const std::string& session_id, |
| 3859 | const std::vector<std::string>& ids_to_check, |
| 3860 | const IdToComponentPtrMap& components, |
| 3861 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 3862 | bool enabled_component_updates, |
| 3863 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3864 | EXPECT_FALSE(session_id.empty()); |
| 3865 | EXPECT_TRUE(enabled_component_updates); |
| 3866 | EXPECT_EQ(4u, ids_to_check.size()); |
| 3867 | |
| 3868 | const std::string update_response = |
Joshua Pawlicki | 8ac3932 | 2019-04-04 21:22:46 | [diff] [blame] | 3869 | ")]}'" |
| 3870 | R"({"response": {)" |
| 3871 | R"( "protocol": "3.1",)" |
| 3872 | R"( "app": [)" |
| 3873 | R"({"appid": "jebgalgnebhfojomionfpkfelancnnkf",)" |
| 3874 | R"( "status": "error-unknownApplication"},)" |
| 3875 | R"({"appid": "abagagagagagagagagagagagagagagag",)" |
| 3876 | R"( "status": "restricted"},)" |
| 3877 | R"({"appid": "ihfokbkgjpifnbbojhneepfflplebdkc",)" |
| 3878 | R"( "status": "error-invalidAppId"},)" |
| 3879 | R"({"appid": "gjpmebpgbhcamgdgjcmnjfhggjpgcimm",)" |
| 3880 | R"( "status": "error-foobarApp"})" |
| 3881 | R"(]}})"; |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3882 | |
Joshua Pawlicki | 8ac3932 | 2019-04-04 21:22:46 | [diff] [blame] | 3883 | const auto parser = ProtocolHandlerFactoryJSON().CreateParser(); |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 3884 | EXPECT_TRUE(parser->Parse(update_response)); |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3885 | |
| 3886 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 3887 | FROM_HERE, |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 3888 | base::BindOnce(std::move(update_check_callback), parser->results(), |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3889 | ErrorCategory::kNone, 0, 0)); |
| 3890 | } |
| 3891 | }; |
| 3892 | |
| 3893 | class MockCrxDownloader : public CrxDownloader { |
| 3894 | public: |
| 3895 | static std::unique_ptr<CrxDownloader> Create( |
| 3896 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 3897 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3898 | return std::make_unique<MockCrxDownloader>(); |
| 3899 | } |
| 3900 | |
| 3901 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 3902 | |
| 3903 | private: |
| 3904 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 3905 | }; |
| 3906 | |
| 3907 | class MockPingManager : public MockPingManagerImpl { |
| 3908 | public: |
| 3909 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 3910 | : MockPingManagerImpl(config) {} |
| 3911 | |
| 3912 | protected: |
| 3913 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
| 3914 | }; |
| 3915 | |
| 3916 | scoped_refptr<UpdateClient> update_client = |
| 3917 | base::MakeRefCounted<UpdateClientImpl>( |
| 3918 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 3919 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 3920 | |
| 3921 | MockObserver observer; |
| 3922 | { |
| 3923 | InSequence seq; |
| 3924 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3925 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3926 | .Times(1); |
| 3927 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3928 | "jebgalgnebhfojomionfpkfelancnnkf")) |
| 3929 | .Times(1) |
| 3930 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3931 | CrxUpdateItem item; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3932 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3933 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3934 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3935 | EXPECT_EQ(-10006, item.error_code); // UNKNOWN_APPPLICATION. |
| 3936 | EXPECT_EQ(0, item.extra_code1); |
| 3937 | })); |
| 3938 | } |
| 3939 | { |
| 3940 | InSequence seq; |
| 3941 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3942 | "abagagagagagagagagagagagagagagag")) |
| 3943 | .Times(1); |
| 3944 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3945 | "abagagagagagagagagagagagagagagag")) |
| 3946 | .Times(1) |
| 3947 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3948 | CrxUpdateItem item; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3949 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3950 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3951 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3952 | EXPECT_EQ(-10007, item.error_code); // RESTRICTED_APPLICATION. |
| 3953 | EXPECT_EQ(0, item.extra_code1); |
| 3954 | })); |
| 3955 | } |
| 3956 | { |
| 3957 | InSequence seq; |
| 3958 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3959 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3960 | .Times(1); |
| 3961 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3962 | "ihfokbkgjpifnbbojhneepfflplebdkc")) |
| 3963 | .Times(1) |
| 3964 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3965 | CrxUpdateItem item; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3966 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3967 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3968 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3969 | EXPECT_EQ(-10008, item.error_code); // INVALID_APPID. |
| 3970 | EXPECT_EQ(0, item.extra_code1); |
| 3971 | })); |
| 3972 | } |
| 3973 | { |
| 3974 | InSequence seq; |
| 3975 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_CHECKING_FOR_UPDATES, |
| 3976 | "gjpmebpgbhcamgdgjcmnjfhggjpgcimm")) |
| 3977 | .Times(1); |
| 3978 | EXPECT_CALL(observer, OnEvent(Events::COMPONENT_UPDATE_ERROR, |
| 3979 | "gjpmebpgbhcamgdgjcmnjfhggjpgcimm")) |
| 3980 | .Times(1) |
| 3981 | .WillOnce(Invoke([&update_client](Events event, const std::string& id) { |
| 3982 | CrxUpdateItem item; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 3983 | EXPECT_TRUE(update_client->GetCrxUpdateState(id, &item)); |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3984 | EXPECT_EQ(ComponentState::kUpdateError, item.state); |
| 3985 | EXPECT_EQ(5, static_cast<int>(item.error_category)); |
| 3986 | EXPECT_EQ(-10004, item.error_code); // UPDATE_RESPONSE_NOT_FOUND. |
| 3987 | EXPECT_EQ(0, item.extra_code1); |
| 3988 | })); |
| 3989 | } |
| 3990 | |
| 3991 | update_client->AddObserver(&observer); |
| 3992 | |
| 3993 | const std::vector<std::string> ids = { |
| 3994 | "jebgalgnebhfojomionfpkfelancnnkf", "abagagagagagagagagagagagagagagag", |
| 3995 | "ihfokbkgjpifnbbojhneepfflplebdkc", "gjpmebpgbhcamgdgjcmnjfhggjpgcimm"}; |
| 3996 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 3997 | ids, base::BindOnce(&DataCallbackMock::Callback), {}, true, |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 3998 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
| 3999 | |
| 4000 | RunThreads(); |
| 4001 | |
| 4002 | update_client->RemoveObserver(&observer); |
| 4003 | } |
| 4004 | |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4005 | // Tests that a run action in invoked in the CRX install scenario. |
| 4006 | TEST_F(UpdateClientTest, ActionRun_Install) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4007 | class MockUpdateChecker : public UpdateChecker { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4008 | public: |
| 4009 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 4010 | scoped_refptr<Configurator> config, |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4011 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4012 | return std::make_unique<MockUpdateChecker>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4013 | } |
| 4014 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 4015 | void CheckForUpdates( |
| 4016 | const std::string& session_id, |
| 4017 | const std::vector<std::string>& ids_to_check, |
| 4018 | const IdToComponentPtrMap& components, |
| 4019 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 4020 | bool enabled_component_updates, |
| 4021 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4022 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4023 | Mock the following response: |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4024 | |
| 4025 | <?xml version='1.0' encoding='UTF-8'?> |
| 4026 | <response protocol='3.1'> |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4027 | <app appid='gjpmebpgbhcamgdgjcmnjfhggjpgcimm'> |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4028 | <updatecheck status='ok'> |
| 4029 | <urls> |
| 4030 | <url codebase='http://localhost/download/'/> |
| 4031 | </urls> |
| 4032 | <manifest version='1.0' prodversionmin='11.0.1.0'> |
| 4033 | <packages> |
| 4034 | <package name='runaction_test_win.crx3' |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4035 | hash_sha256='89290a0d2ff21ca5b45e109c6cc859ab5fe294e19c102d54acd321429c372cea'/> |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4036 | </packages> |
| 4037 | </manifest> |
| 4038 | <actions>" |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4039 | <action run='ChromeRecovery.crx3'/>" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4040 | </actions>" |
| 4041 | </updatecheck> |
| 4042 | </app> |
| 4043 | </response> |
| 4044 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 4045 | EXPECT_FALSE(session_id.empty()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4046 | EXPECT_TRUE(enabled_component_updates); |
| 4047 | EXPECT_EQ(1u, ids_to_check.size()); |
| 4048 | |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4049 | const std::string id = "gjpmebpgbhcamgdgjcmnjfhggjpgcimm"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4050 | EXPECT_EQ(id, ids_to_check[0]); |
| 4051 | EXPECT_EQ(1u, components.count(id)); |
| 4052 | |
| 4053 | ProtocolParser::Result::Manifest::Package package; |
| 4054 | package.name = "runaction_test_win.crx3"; |
| 4055 | package.hash_sha256 = |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4056 | "89290a0d2ff21ca5b45e109c6cc859ab5fe294e19c102d54acd321429c372cea"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4057 | |
| 4058 | ProtocolParser::Result result; |
| 4059 | result.extension_id = id; |
| 4060 | result.status = "ok"; |
| 4061 | result.crx_urls.push_back(GURL("http://localhost/download/")); |
| 4062 | result.manifest.version = "1.0"; |
| 4063 | result.manifest.browser_min_version = "11.0.1.0"; |
| 4064 | result.manifest.packages.push_back(package); |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4065 | result.action_run = "ChromeRecovery.crx3"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4066 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 4067 | ProtocolParser::Results results; |
| 4068 | results.list.push_back(result); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4069 | |
| 4070 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 4071 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 4072 | ErrorCategory::kNone, 0, 0)); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4073 | } |
| 4074 | }; |
| 4075 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4076 | class MockCrxDownloader : public CrxDownloader { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4077 | public: |
| 4078 | static std::unique_ptr<CrxDownloader> Create( |
| 4079 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 4080 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4081 | return std::make_unique<MockCrxDownloader>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4082 | } |
| 4083 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4084 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4085 | |
| 4086 | private: |
| 4087 | void DoStartDownload(const GURL& url) override { |
| 4088 | DownloadMetrics download_metrics; |
| 4089 | FilePath path; |
| 4090 | Result result; |
| 4091 | if (url.path() == "/download/runaction_test_win.crx3") { |
| 4092 | download_metrics.url = url; |
| 4093 | download_metrics.downloader = DownloadMetrics::kNone; |
| 4094 | download_metrics.error = 0; |
| 4095 | download_metrics.downloaded_bytes = 1843; |
| 4096 | download_metrics.total_bytes = 1843; |
| 4097 | download_metrics.download_time_ms = 1000; |
| 4098 | |
| 4099 | EXPECT_TRUE( |
| 4100 | MakeTestFile(TestFilePath("runaction_test_win.crx3"), &path)); |
| 4101 | |
| 4102 | result.error = 0; |
| 4103 | result.response = path; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4104 | } else { |
| 4105 | NOTREACHED(); |
| 4106 | } |
| 4107 | |
| 4108 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4109 | FROM_HERE, base::BindOnce(&MockCrxDownloader::OnDownloadComplete, |
Sorin Jianu | ebd65246 | 2017-07-23 02:00:58 | [diff] [blame] | 4110 | base::Unretained(this), true, result, |
| 4111 | download_metrics)); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4112 | } |
| 4113 | }; |
| 4114 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4115 | class MockPingManager : public MockPingManagerImpl { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4116 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4117 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 4118 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 4119 | |
| 4120 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4121 | ~MockPingManager() override { |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 4122 | EXPECT_EQ(3u, events().size()); |
| 4123 | |
| 4124 | /* |
| 4125 | "<event eventtype="14" eventresult="1" downloader="unknown" " |
| 4126 | "url="http://localhost/download/runaction_test_win.crx3" |
Sorin Jianu | 55587d3 | 2018-11-14 21:43:27 | [diff] [blame] | 4127 | "downloaded=1843 " |
| 4128 | "total=1843 download_time_ms="1000" previousversion="0.0" " |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 4129 | "nextversion="1.0"/>" |
| 4130 | */ |
| 4131 | const auto& event0 = events()[0]; |
| 4132 | EXPECT_EQ(14, event0.FindKey("eventtype")->GetInt()); |
| 4133 | EXPECT_EQ(1, event0.FindKey("eventresult")->GetInt()); |
| 4134 | EXPECT_EQ("unknown", event0.FindKey("downloader")->GetString()); |
| 4135 | EXPECT_EQ("http://localhost/download/runaction_test_win.crx3", |
| 4136 | event0.FindKey("url")->GetString()); |
Sorin Jianu | 55587d3 | 2018-11-14 21:43:27 | [diff] [blame] | 4137 | EXPECT_EQ(1843, event0.FindKey("downloaded")->GetDouble()); |
| 4138 | EXPECT_EQ(1843, event0.FindKey("total")->GetDouble()); |
| 4139 | EXPECT_EQ(1000, event0.FindKey("download_time_ms")->GetDouble()); |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 4140 | EXPECT_EQ("0.0", event0.FindKey("previousversion")->GetString()); |
| 4141 | EXPECT_EQ("1.0", event0.FindKey("nextversion")->GetString()); |
| 4142 | |
| 4143 | // "<event eventtype="42" eventresult="1" errorcode="1877345072"/>" |
| 4144 | const auto& event1 = events()[1]; |
| 4145 | EXPECT_EQ(42, event1.FindKey("eventtype")->GetInt()); |
| 4146 | EXPECT_EQ(1, event1.FindKey("eventresult")->GetInt()); |
| 4147 | EXPECT_EQ(1877345072, event1.FindKey("errorcode")->GetInt()); |
| 4148 | |
| 4149 | // "<event eventtype=\"3\" eventresult=\"1\" previousversion=\"0.0\" " |
| 4150 | // "nextversion=\"1.0\"/>", |
| 4151 | const auto& event2 = events()[2]; |
| 4152 | EXPECT_EQ(3, event2.FindKey("eventtype")->GetInt()); |
| 4153 | EXPECT_EQ(1, event1.FindKey("eventresult")->GetInt()); |
| 4154 | EXPECT_EQ("0.0", event0.FindKey("previousversion")->GetString()); |
| 4155 | EXPECT_EQ("1.0", event0.FindKey("nextversion")->GetString()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4156 | } |
| 4157 | }; |
| 4158 | |
| 4159 | scoped_refptr<UpdateClient> update_client = |
| 4160 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4161 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 4162 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4163 | |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4164 | update_client->Install( |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4165 | std::string("gjpmebpgbhcamgdgjcmnjfhggjpgcimm"), |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 4166 | base::BindOnce([](const std::vector<std::string>& ids) { |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 4167 | auto action_handler = base::MakeRefCounted<MockActionHandler>(); |
| 4168 | EXPECT_CALL(*action_handler, Handle(_, _, _)) |
| 4169 | .WillOnce([](const base::FilePath& action, |
| 4170 | const std::string& session_id, |
| 4171 | ActionHandler::Callback callback) { |
| 4172 | EXPECT_EQ("ChromeRecovery.crx3", |
| 4173 | action.BaseName().MaybeAsASCII()); |
| 4174 | EXPECT_TRUE(!session_id.empty()); |
| 4175 | std::move(callback).Run(true, 1877345072, 0); |
| 4176 | }); |
| 4177 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 4178 | CrxComponent crx; |
| 4179 | crx.name = "test_niea"; |
| 4180 | crx.pk_hash.assign(gjpm_hash, gjpm_hash + base::size(gjpm_hash)); |
| 4181 | crx.version = base::Version("0.0"); |
| 4182 | crx.installer = base::MakeRefCounted<VersionedTestInstaller>(); |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 4183 | crx.action_handler = action_handler; |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 4184 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 4185 | return std::vector<base::Optional<CrxComponent>>{crx}; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4186 | }), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 4187 | {}, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4188 | base::BindOnce( |
| 4189 | [](base::OnceClosure quit_closure, Error error) { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4190 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4191 | std::move(quit_closure).Run(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4192 | }, |
| 4193 | quit_closure())); |
| 4194 | |
| 4195 | RunThreads(); |
| 4196 | } |
| 4197 | |
| 4198 | // Tests that a run action is invoked in an update scenario when there was |
| 4199 | // no update. |
| 4200 | TEST_F(UpdateClientTest, ActionRun_NoUpdate) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4201 | class MockUpdateChecker : public UpdateChecker { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4202 | public: |
| 4203 | static std::unique_ptr<UpdateChecker> Create( |
Sorin Jianu | 4912633 | 2018-02-13 17:07:42 | [diff] [blame] | 4204 | scoped_refptr<Configurator> config, |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4205 | PersistedData* metadata) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4206 | return std::make_unique<MockUpdateChecker>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4207 | } |
| 4208 | |
Sorin Jianu | c303bf4 | 2018-09-07 16:19:33 | [diff] [blame] | 4209 | void CheckForUpdates( |
| 4210 | const std::string& session_id, |
| 4211 | const std::vector<std::string>& ids_to_check, |
| 4212 | const IdToComponentPtrMap& components, |
| 4213 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 4214 | bool enabled_component_updates, |
| 4215 | UpdateCheckCallback update_check_callback) override { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4216 | /* |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4217 | Mock the following response: |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4218 | |
| 4219 | <?xml version='1.0' encoding='UTF-8'?> |
| 4220 | <response protocol='3.1'> |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4221 | <app appid='gjpmebpgbhcamgdgjcmnjfhggjpgcimm'> |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4222 | <updatecheck status='noupdate'> |
| 4223 | <actions>" |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4224 | <action run=ChromeRecovery.crx3'/>" |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4225 | </actions>" |
| 4226 | </updatecheck> |
| 4227 | </app> |
| 4228 | </response> |
| 4229 | */ |
Sorin Jianu | d69d437 | 2018-02-07 19:44:22 | [diff] [blame] | 4230 | EXPECT_FALSE(session_id.empty()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4231 | EXPECT_EQ(1u, ids_to_check.size()); |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4232 | const std::string id = "gjpmebpgbhcamgdgjcmnjfhggjpgcimm"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4233 | EXPECT_EQ(id, ids_to_check[0]); |
| 4234 | EXPECT_EQ(1u, components.count(id)); |
| 4235 | |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4236 | ProtocolParser::Result result; |
| 4237 | result.extension_id = id; |
| 4238 | result.status = "noupdate"; |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4239 | result.action_run = "ChromeRecovery.crx3"; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4240 | |
Sorin Jianu | 888ec29 | 2018-06-01 15:35:42 | [diff] [blame] | 4241 | ProtocolParser::Results results; |
| 4242 | results.list.push_back(result); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4243 | |
| 4244 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
Sorin Jianu | aa416553 | 2018-06-08 19:46:46 | [diff] [blame] | 4245 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 4246 | ErrorCategory::kNone, 0, 0)); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4247 | } |
| 4248 | }; |
| 4249 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4250 | class MockCrxDownloader : public CrxDownloader { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4251 | public: |
| 4252 | static std::unique_ptr<CrxDownloader> Create( |
| 4253 | bool is_background_download, |
Sorin Jianu | 75e6bf2 | 2019-02-12 16:07:12 | [diff] [blame] | 4254 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4255 | return std::make_unique<MockCrxDownloader>(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4256 | } |
| 4257 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4258 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4259 | |
| 4260 | private: |
| 4261 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 4262 | }; |
| 4263 | |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4264 | class MockPingManager : public MockPingManagerImpl { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4265 | public: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4266 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 4267 | : MockPingManagerImpl(config) {} |
Sorin Jianu | 560d502 | 2018-02-12 23:11:54 | [diff] [blame] | 4268 | |
| 4269 | protected: |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4270 | ~MockPingManager() override { |
Sorin Jianu | 039032b | 2018-10-12 21:48:13 | [diff] [blame] | 4271 | EXPECT_EQ(1u, events().size()); |
| 4272 | |
| 4273 | // "<event eventtype="42" eventresult="1" errorcode="1877345072"/>" |
| 4274 | const auto& event = events()[0]; |
| 4275 | EXPECT_EQ(42, event.FindKey("eventtype")->GetInt()); |
| 4276 | EXPECT_EQ(1, event.FindKey("eventresult")->GetInt()); |
| 4277 | EXPECT_EQ(1877345072, event.FindKey("errorcode")->GetInt()); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4278 | } |
| 4279 | }; |
| 4280 | |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 4281 | // Unpack the CRX to mock an existing install to be updated. The action to |
| 4282 | // run is going to be resolved relative to this directory. |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4283 | base::FilePath unpack_path; |
| 4284 | { |
| 4285 | base::RunLoop runloop; |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4286 | base::OnceClosure quit_closure = runloop.QuitClosure(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4287 | |
Joshua Pawlicki | 6d76442 | 2018-02-21 15:23:10 | [diff] [blame] | 4288 | auto config = base::MakeRefCounted<TestConfigurator>(); |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 4289 | auto component_unpacker = base::MakeRefCounted<ComponentUnpacker>( |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4290 | std::vector<uint8_t>(std::begin(gjpm_hash), std::end(gjpm_hash)), |
Joshua Pawlicki | 6d76442 | 2018-02-21 15:23:10 | [diff] [blame] | 4291 | TestFilePath("runaction_test_win.crx3"), nullptr, |
Joshua Pawlicki | d5409e1 | 2019-04-06 00:23:11 | [diff] [blame] | 4292 | config->GetUnzipperFactory()->Create(), |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 4293 | config->GetPatcherFactory()->Create(), crx_file::VerifierFormat::CRX3); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4294 | |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4295 | component_unpacker->Unpack(base::BindOnce( |
| 4296 | [](base::FilePath* unpack_path, base::OnceClosure quit_closure, |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4297 | const ComponentUnpacker::Result& result) { |
| 4298 | EXPECT_EQ(UnpackerError::kNone, result.error); |
| 4299 | EXPECT_EQ(0, result.extended_error); |
| 4300 | *unpack_path = result.unpack_path; |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4301 | std::move(quit_closure).Run(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4302 | }, |
| 4303 | &unpack_path, runloop.QuitClosure())); |
| 4304 | |
| 4305 | runloop.Run(); |
| 4306 | } |
| 4307 | |
| 4308 | EXPECT_FALSE(unpack_path.empty()); |
| 4309 | EXPECT_TRUE(base::DirectoryExists(unpack_path)); |
| 4310 | int64_t file_size = 0; |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4311 | EXPECT_TRUE(base::GetFileSize(unpack_path.AppendASCII("ChromeRecovery.crx3"), |
| 4312 | &file_size)); |
| 4313 | EXPECT_EQ(44582, file_size); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4314 | |
| 4315 | base::ScopedTempDir unpack_path_owner; |
| 4316 | EXPECT_TRUE(unpack_path_owner.Set(unpack_path)); |
| 4317 | |
| 4318 | scoped_refptr<UpdateClient> update_client = |
| 4319 | base::MakeRefCounted<UpdateClientImpl>( |
Sorin Jianu | a8926bf | 2018-03-09 21:02:53 | [diff] [blame] | 4320 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 4321 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4322 | |
Sorin Jianu | e5bfb5b | 2017-06-20 21:30:56 | [diff] [blame] | 4323 | const std::vector<std::string> ids = {"gjpmebpgbhcamgdgjcmnjfhggjpgcimm"}; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4324 | update_client->Update( |
| 4325 | ids, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4326 | base::BindOnce( |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4327 | [](const base::FilePath& unpack_path, |
Sorin Jianu | 7c22795b | 2018-04-26 22:16:52 | [diff] [blame] | 4328 | const std::vector<std::string>& ids) { |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 4329 | auto action_handler = base::MakeRefCounted<MockActionHandler>(); |
| 4330 | EXPECT_CALL(*action_handler, Handle(_, _, _)) |
| 4331 | .WillOnce([](const base::FilePath& action, |
| 4332 | const std::string& session_id, |
| 4333 | ActionHandler::Callback callback) { |
| 4334 | EXPECT_EQ("ChromeRecovery.crx3", |
| 4335 | action.BaseName().MaybeAsASCII()); |
| 4336 | EXPECT_TRUE(!session_id.empty()); |
| 4337 | std::move(callback).Run(true, 1877345072, 0); |
| 4338 | }); |
| 4339 | |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 4340 | CrxComponent crx; |
| 4341 | crx.name = "test_niea"; |
| 4342 | crx.pk_hash.assign(gjpm_hash, gjpm_hash + base::size(gjpm_hash)); |
| 4343 | crx.version = base::Version("1.0"); |
| 4344 | crx.installer = |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4345 | base::MakeRefCounted<ReadOnlyTestInstaller>(unpack_path); |
Sorin Jianu | 2fe49a0 | 2019-11-25 19:15:56 | [diff] [blame] | 4346 | crx.action_handler = action_handler; |
Joshua Pawlicki | afaa292 | 2019-09-03 18:50:23 | [diff] [blame] | 4347 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
Sorin Jianu | 7390024 | 2018-08-17 01:11:53 | [diff] [blame] | 4348 | return std::vector<base::Optional<CrxComponent>>{crx}; |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4349 | }, |
| 4350 | unpack_path), |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 4351 | {}, false, |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4352 | base::BindOnce( |
| 4353 | [](base::OnceClosure quit_closure, Error error) { |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4354 | EXPECT_EQ(Error::NONE, error); |
Sorin Jianu | a8ef73d | 2017-11-02 16:55:17 | [diff] [blame] | 4355 | std::move(quit_closure).Run(); |
Sorin Jianu | 4ab7c29 | 2017-06-15 18:40:21 | [diff] [blame] | 4356 | }, |
| 4357 | quit_closure())); |
| 4358 | |
| 4359 | RunThreads(); |
| 4360 | } |
| 4361 | |
Joshua Pawlicki | ca4f8fa1 | 2020-02-25 23:46:06 | [diff] [blame] | 4362 | // Tests that custom response attributes are visible to observers. |
| 4363 | TEST_F(UpdateClientTest, CustomAttributeNoUpdate) { |
| 4364 | class DataCallbackMock { |
| 4365 | public: |
| 4366 | static std::vector<base::Optional<CrxComponent>> Callback( |
| 4367 | const std::vector<std::string>& ids) { |
| 4368 | CrxComponent crx; |
| 4369 | crx.name = "test_jebg"; |
| 4370 | crx.pk_hash.assign(jebg_hash, jebg_hash + base::size(jebg_hash)); |
| 4371 | crx.version = base::Version("0.9"); |
| 4372 | crx.installer = base::MakeRefCounted<TestInstaller>(); |
| 4373 | crx.crx_format_requirement = crx_file::VerifierFormat::CRX3; |
| 4374 | std::vector<base::Optional<CrxComponent>> component = {crx}; |
| 4375 | return component; |
| 4376 | } |
| 4377 | }; |
| 4378 | |
| 4379 | class CompletionCallbackMock { |
| 4380 | public: |
| 4381 | static void Callback(base::OnceClosure quit_closure, Error error) { |
| 4382 | EXPECT_EQ(Error::NONE, error); |
| 4383 | std::move(quit_closure).Run(); |
| 4384 | } |
| 4385 | }; |
| 4386 | |
| 4387 | class MockUpdateChecker : public UpdateChecker { |
| 4388 | public: |
| 4389 | static std::unique_ptr<UpdateChecker> Create( |
| 4390 | scoped_refptr<Configurator> config, |
| 4391 | PersistedData* metadata) { |
| 4392 | return std::make_unique<MockUpdateChecker>(); |
| 4393 | } |
| 4394 | |
| 4395 | void CheckForUpdates( |
| 4396 | const std::string& session_id, |
| 4397 | const std::vector<std::string>& ids_to_check, |
| 4398 | const IdToComponentPtrMap& components, |
| 4399 | const base::flat_map<std::string, std::string>& additional_attributes, |
| 4400 | bool enabled_component_updates, |
| 4401 | UpdateCheckCallback update_check_callback) override { |
| 4402 | EXPECT_FALSE(session_id.empty()); |
| 4403 | EXPECT_TRUE(enabled_component_updates); |
| 4404 | EXPECT_EQ(1u, ids_to_check.size()); |
| 4405 | const std::string id = "jebgalgnebhfojomionfpkfelancnnkf"; |
| 4406 | EXPECT_EQ(id, ids_to_check.front()); |
| 4407 | EXPECT_EQ(1u, components.count(id)); |
| 4408 | |
| 4409 | auto& component = components.at(id); |
| 4410 | |
| 4411 | EXPECT_TRUE(component->is_foreground()); |
| 4412 | |
| 4413 | ProtocolParser::Result result; |
| 4414 | result.extension_id = id; |
| 4415 | result.status = "noupdate"; |
| 4416 | result.custom_attributes["_example"] = "example_value"; |
| 4417 | |
| 4418 | ProtocolParser::Results results; |
| 4419 | results.list.push_back(result); |
| 4420 | |
| 4421 | base::ThreadTaskRunnerHandle::Get()->PostTask( |
| 4422 | FROM_HERE, base::BindOnce(std::move(update_check_callback), results, |
| 4423 | ErrorCategory::kNone, 0, 0)); |
| 4424 | } |
| 4425 | }; |
| 4426 | |
| 4427 | class MockCrxDownloader : public CrxDownloader { |
| 4428 | public: |
| 4429 | static std::unique_ptr<CrxDownloader> Create( |
| 4430 | bool is_background_download, |
| 4431 | scoped_refptr<NetworkFetcherFactory> network_fetcher_factory) { |
| 4432 | return std::make_unique<MockCrxDownloader>(); |
| 4433 | } |
| 4434 | |
| 4435 | MockCrxDownloader() : CrxDownloader(nullptr) {} |
| 4436 | |
| 4437 | private: |
| 4438 | void DoStartDownload(const GURL& url) override { EXPECT_TRUE(false); } |
| 4439 | }; |
| 4440 | |
| 4441 | class MockPingManager : public MockPingManagerImpl { |
| 4442 | public: |
| 4443 | explicit MockPingManager(scoped_refptr<Configurator> config) |
| 4444 | : MockPingManagerImpl(config) {} |
| 4445 | |
| 4446 | protected: |
| 4447 | ~MockPingManager() override { EXPECT_TRUE(ping_data().empty()); } |
| 4448 | }; |
| 4449 | |
| 4450 | scoped_refptr<UpdateClient> update_client = |
| 4451 | base::MakeRefCounted<UpdateClientImpl>( |
| 4452 | config(), base::MakeRefCounted<MockPingManager>(config()), |
| 4453 | &MockUpdateChecker::Create, &MockCrxDownloader::Create); |
| 4454 | |
| 4455 | class Observer : public UpdateClient::Observer { |
| 4456 | public: |
| 4457 | explicit Observer(scoped_refptr<UpdateClient> update_client) |
| 4458 | : update_client_(update_client) {} |
| 4459 | |
| 4460 | void OnEvent(Events event, const std::string& id) override { |
| 4461 | if (event != Events::COMPONENT_NOT_UPDATED) |
| 4462 | return; |
| 4463 | ++calls; |
| 4464 | CrxUpdateItem item; |
| 4465 | EXPECT_TRUE(update_client_->GetCrxUpdateState( |
| 4466 | "jebgalgnebhfojomionfpkfelancnnkf", &item)); |
| 4467 | EXPECT_EQ("example_value", item.custom_updatecheck_data["_example"]); |
| 4468 | } |
| 4469 | |
| 4470 | int calls = 0; |
| 4471 | |
| 4472 | private: |
| 4473 | scoped_refptr<UpdateClient> update_client_; |
| 4474 | }; |
| 4475 | |
| 4476 | Observer observer(update_client); |
| 4477 | update_client->AddObserver(&observer); |
| 4478 | |
| 4479 | const std::vector<std::string> ids = {"jebgalgnebhfojomionfpkfelancnnkf"}; |
| 4480 | update_client->Update( |
Sorin Jianu | dfb12a4 | 2020-03-10 04:12:03 | [diff] [blame] | 4481 | ids, base::BindOnce(&DataCallbackMock::Callback), {}, true, |
Joshua Pawlicki | ca4f8fa1 | 2020-02-25 23:46:06 | [diff] [blame] | 4482 | base::BindOnce(&CompletionCallbackMock::Callback, quit_closure())); |
| 4483 | |
| 4484 | RunThreads(); |
| 4485 | |
| 4486 | update_client->RemoveObserver(&observer); |
| 4487 | |
| 4488 | EXPECT_EQ(1, observer.calls); |
| 4489 | } |
sorin | 9797aba | 2015-04-17 17:15:03 | [diff] [blame] | 4490 | } // namespace update_client |