Andrew Grieve | 7dd4aaf | 2021-04-27 21:47:08 | [diff] [blame] | 1 | #!/usr/bin/env python3 |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 2 | |
Avi Drissman | 7519809 | 2022-09-08 20:33:38 | [diff] [blame] | 3 | # Copyright 2017 The Chromium Authors |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 4 | # Use of this source code is governed by a BSD-style license that can be |
| 5 | # found in the LICENSE file. |
| 6 | |
| 7 | """Merges dependency Android manifests into a root manifest.""" |
| 8 | |
| 9 | import argparse |
Andrew Grieve | 282403e | 2023-02-06 18:44:52 | [diff] [blame^] | 10 | import collections |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 11 | import contextlib |
| 12 | import os |
| 13 | import sys |
| 14 | import tempfile |
Eric Stevenson | 8045827 | 2019-02-04 20:57:58 | [diff] [blame] | 15 | import xml.etree.ElementTree as ElementTree |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 16 | |
| 17 | from util import build_utils |
Tibor Goldschwendt | 228bd4c | 2019-06-17 20:32:02 | [diff] [blame] | 18 | from util import manifest_utils |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 19 | |
Eric Stevenson | 8045827 | 2019-02-04 20:57:58 | [diff] [blame] | 20 | _MANIFEST_MERGER_MAIN_CLASS = 'com.android.manifmerger.Merger' |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 21 | |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 22 | |
| 23 | @contextlib.contextmanager |
Andrew Grieve | 8abcf5b | 2023-02-03 14:46:46 | [diff] [blame] | 24 | def _ProcessMainManifest(manifest_path, min_sdk_version, target_sdk_version, |
| 25 | max_sdk_version, manifest_package): |
| 26 | """Patches the main Android manifest""" |
Tibor Goldschwendt | 228bd4c | 2019-06-17 20:32:02 | [diff] [blame] | 27 | doc, manifest, _ = manifest_utils.ParseManifest(manifest_path) |
Andrew Grieve | 8abcf5b | 2023-02-03 14:46:46 | [diff] [blame] | 28 | manifest_utils.SetUsesSdk(manifest, target_sdk_version, min_sdk_version, |
| 29 | max_sdk_version) |
Tibor Goldschwendt | fda1594 | 2019-06-24 21:57:47 | [diff] [blame] | 30 | assert manifest_utils.GetPackage(manifest) or manifest_package, \ |
| 31 | 'Must set manifest package in GN or in AndroidManifest.xml' |
Tibor Goldschwendt | fda1594 | 2019-06-24 21:57:47 | [diff] [blame] | 32 | if manifest_package: |
| 33 | manifest.set('package', manifest_package) |
Andrew Grieve | ff1bc2e | 2022-06-13 15:01:19 | [diff] [blame] | 34 | tmp_prefix = manifest_path.replace(os.path.sep, '-') |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 35 | with tempfile.NamedTemporaryFile(prefix=tmp_prefix) as patched_manifest: |
Tibor Goldschwendt | 228bd4c | 2019-06-17 20:32:02 | [diff] [blame] | 36 | manifest_utils.SaveManifest(doc, patched_manifest.name) |
Tibor Goldschwendt | fda1594 | 2019-06-24 21:57:47 | [diff] [blame] | 37 | yield patched_manifest.name, manifest_utils.GetPackage(manifest) |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 38 | |
| 39 | |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 40 | @contextlib.contextmanager |
Andrew Grieve | 282403e | 2023-02-06 18:44:52 | [diff] [blame^] | 41 | def _ProcessOtherManifest(manifest_path, target_sdk_version, |
| 42 | seen_package_names): |
| 43 | """Patches non-main AndroidManifest.xml if necessary.""" |
| 44 | # 1. Ensure targetSdkVersion is set to the expected value to avoid |
| 45 | # spurious permissions being added (b/222331337). |
| 46 | # 2. Ensure all manifests have a unique package name so that the merger |
| 47 | # does not fail when this happens. |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 48 | doc, manifest, _ = manifest_utils.ParseManifest(manifest_path) |
Andrew Grieve | 282403e | 2023-02-06 18:44:52 | [diff] [blame^] | 49 | |
| 50 | changed_api = manifest_utils.SetTargetApiIfUnset(manifest, target_sdk_version) |
| 51 | |
| 52 | package_name = manifest_utils.GetPackage(manifest) |
| 53 | package_count = seen_package_names[package_name] |
| 54 | seen_package_names[package_name] += 1 |
| 55 | if package_count > 0: |
| 56 | manifest.set('package', f'{package_name}_{package_count}') |
| 57 | |
| 58 | if package_count > 0 or changed_api: |
Andrew Grieve | 8abcf5b | 2023-02-03 14:46:46 | [diff] [blame] | 59 | tmp_prefix = manifest_path.replace(os.path.sep, '-') |
| 60 | with tempfile.NamedTemporaryFile(prefix=tmp_prefix) as patched_manifest: |
| 61 | manifest_utils.SaveManifest(doc, patched_manifest.name) |
| 62 | yield patched_manifest.name |
| 63 | else: |
| 64 | yield manifest_path |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 65 | |
| 66 | |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 67 | def main(argv): |
| 68 | argv = build_utils.ExpandFileArgs(argv) |
| 69 | parser = argparse.ArgumentParser(description=__doc__) |
Andrew Grieve | 9ce44b9 | 2017-07-25 02:43:05 | [diff] [blame] | 70 | build_utils.AddDepfileOption(parser) |
Peter Wen | ae5986f | 2022-07-04 15:40:51 | [diff] [blame] | 71 | parser.add_argument('--manifest-merger-jar', |
| 72 | help='Path to SDK\'s manifest merger jar.', |
| 73 | required=True) |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 74 | parser.add_argument('--root-manifest', |
| 75 | help='Root manifest which to merge into', |
| 76 | required=True) |
| 77 | parser.add_argument('--output', help='Output manifest path', required=True) |
| 78 | parser.add_argument('--extras', |
| 79 | help='GN list of additional manifest to merge') |
Tibor Goldschwendt | 228bd4c | 2019-06-17 20:32:02 | [diff] [blame] | 80 | parser.add_argument( |
| 81 | '--min-sdk-version', |
| 82 | required=True, |
| 83 | help='android:minSdkVersion for merging.') |
| 84 | parser.add_argument( |
| 85 | '--target-sdk-version', |
| 86 | required=True, |
| 87 | help='android:targetSdkVersion for merging.') |
Tibor Goldschwendt | fda1594 | 2019-06-24 21:57:47 | [diff] [blame] | 88 | parser.add_argument( |
Tibor Goldschwendt | 1760440 | 2019-07-11 14:44:10 | [diff] [blame] | 89 | '--max-sdk-version', help='android:maxSdkVersion for merging.') |
| 90 | parser.add_argument( |
Tibor Goldschwendt | fda1594 | 2019-06-24 21:57:47 | [diff] [blame] | 91 | '--manifest-package', |
| 92 | help='Package name of the merged AndroidManifest.xml.') |
Andrew Grieve | e9cae1e | 2020-08-21 18:34:16 | [diff] [blame] | 93 | parser.add_argument('--warnings-as-errors', |
| 94 | action='store_true', |
| 95 | help='Treat all warnings as errors.') |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 96 | args = parser.parse_args(argv) |
| 97 | |
Eric Stevenson | 8045827 | 2019-02-04 20:57:58 | [diff] [blame] | 98 | with build_utils.AtomicOutput(args.output) as output: |
Sam Maier | 299c891 | 2023-01-25 18:25:01 | [diff] [blame] | 99 | cmd = build_utils.JavaCmd() + [ |
Eric Stevenson | 8045827 | 2019-02-04 20:57:58 | [diff] [blame] | 100 | '-cp', |
Peter Wen | ae5986f | 2022-07-04 15:40:51 | [diff] [blame] | 101 | args.manifest_merger_jar, |
Eric Stevenson | 8045827 | 2019-02-04 20:57:58 | [diff] [blame] | 102 | _MANIFEST_MERGER_MAIN_CLASS, |
| 103 | '--out', |
| 104 | output.name, |
Tibor Goldschwendt | 1760440 | 2019-07-11 14:44:10 | [diff] [blame] | 105 | '--property', |
| 106 | 'MIN_SDK_VERSION=' + args.min_sdk_version, |
| 107 | '--property', |
| 108 | 'TARGET_SDK_VERSION=' + args.target_sdk_version, |
Takuto Ikuta | 61fee73 | 2018-07-06 05:44:45 | [diff] [blame] | 109 | ] |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 110 | |
Tibor Goldschwendt | 1760440 | 2019-07-11 14:44:10 | [diff] [blame] | 111 | if args.max_sdk_version: |
| 112 | cmd += [ |
| 113 | '--property', |
| 114 | 'MAX_SDK_VERSION=' + args.max_sdk_version, |
| 115 | ] |
| 116 | |
Takuto Ikuta | 61fee73 | 2018-07-06 05:44:45 | [diff] [blame] | 117 | extras = build_utils.ParseGnList(args.extras) |
Takuto Ikuta | 61fee73 | 2018-07-06 05:44:45 | [diff] [blame] | 118 | |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 119 | with contextlib.ExitStack() as stack: |
| 120 | root_manifest, package = stack.enter_context( |
Andrew Grieve | 8abcf5b | 2023-02-03 14:46:46 | [diff] [blame] | 121 | _ProcessMainManifest(args.root_manifest, args.min_sdk_version, |
| 122 | args.target_sdk_version, args.max_sdk_version, |
| 123 | args.manifest_package)) |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 124 | if extras: |
Andrew Grieve | 282403e | 2023-02-06 18:44:52 | [diff] [blame^] | 125 | seen_package_names = collections.Counter() |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 126 | extras_processed = [ |
Andrew Grieve | 8abcf5b | 2023-02-03 14:46:46 | [diff] [blame] | 127 | stack.enter_context( |
Andrew Grieve | 282403e | 2023-02-06 18:44:52 | [diff] [blame^] | 128 | _ProcessOtherManifest(e, args.target_sdk_version, |
| 129 | seen_package_names)) for e in extras |
Sam Maier | 9760d5b | 2022-04-22 21:04:05 | [diff] [blame] | 130 | ] |
| 131 | cmd += ['--libs', ':'.join(extras_processed)] |
Tibor Goldschwendt | 228bd4c | 2019-06-17 20:32:02 | [diff] [blame] | 132 | cmd += [ |
| 133 | '--main', |
| 134 | root_manifest, |
| 135 | '--property', |
| 136 | 'PACKAGE=' + package, |
Mohamed Heikal | 9ec8d82 | 2021-05-11 19:18:20 | [diff] [blame] | 137 | '--remove-tools-declarations', |
Tibor Goldschwendt | 228bd4c | 2019-06-17 20:32:02 | [diff] [blame] | 138 | ] |
Andrew Grieve | e9cae1e | 2020-08-21 18:34:16 | [diff] [blame] | 139 | build_utils.CheckOutput( |
| 140 | cmd, |
| 141 | # https://issuetracker.google.com/issues/63514300: |
| 142 | # The merger doesn't set a nonzero exit code for failures. |
| 143 | fail_func=lambda returncode, stderr: returncode != 0 or build_utils. |
| 144 | IsTimeStale(output.name, [root_manifest] + extras), |
| 145 | fail_on_output=args.warnings_as_errors) |
Eric Stevenson | 59bf3c6 | 2019-01-23 23:30:49 | [diff] [blame] | 146 | |
Andrew Grieve | 9ce44b9 | 2017-07-25 02:43:05 | [diff] [blame] | 147 | if args.depfile: |
Peter Wen | ae5986f | 2022-07-04 15:40:51 | [diff] [blame] | 148 | build_utils.WriteDepfile(args.depfile, args.output, inputs=extras) |
Ingemar Ådahl | 6ada47b | 2017-07-10 17:14:01 | [diff] [blame] | 149 | |
| 150 | |
| 151 | if __name__ == '__main__': |
| 152 | main(sys.argv[1:]) |