Opened 3 months ago

Closed 13 hours ago

#36377 closed New feature (fixed)

support `hints` for postgres contrib operations

Reported by: anthony sottile Owned by: Anthony Sottile
Component: Migrations Version: 5.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by anthony sottile)

since they are ~effectively specialized RunSql operations it would be nice if they support hints=... as well. at sentry we utilize this in our database router to properly target sql-like operations during migrations. without hints we don't know what database to apply the migration operation to

something like:

operations = [BtreeGistExtension(hints={'tables': ['sentry_whatever']})]

(and updating the allow_migrate(...) calls inside CreateExtension)

Change History (8)

comment:1 by anthony sottile, 3 months ago

Description: modified (diff)

comment:2 by Simon Charette, 3 months ago

Component: Uncategorized → Migrations
Easy pickings: set
Triage Stage: Unreviewed → Accepted

That makes sense.

comment:4 by Simon Charette, 3 months ago

Owner: set to Anthony Sottile
Status: new → assigned

comment:5 by Sarah Boyce, 2 months ago

Needs documentation: set

comment:6 by Anthony Sottile, 2 days ago

Needs documentation: unset

updating the "Needs documentation" box as I believe I have addressed the docs updates requested in ​the PR

comment:7 by Mariusz Felisiak, 26 hours ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Mariusz Felisiak <felisiak.mariusz@…>, 13 hours ago

Resolution: → fixed
Status: assigned → closed

In 5488530a:

Fixed #36377 -- Added hints support to CreateExtension and subclasses.

Note: See TracTickets for help on using tickets.
Back to Top