Add CI for PDF generation#90
Conversation
|
@rcalixte thank you very much! I will take a look tomorrow morning |
|
@rcalixte I tested it and it looks really great! Thank you a lot. I have just two little suggestions that I'll describe in the next comments. |
There was a problem hiding this comment.
Can we move this and all related scripts below, pandoc configuration and so on to ./scripts/pdf directory or something like this?
There was a problem hiding this comment.
We should be able to move things around. I'll include this in the update as well.
There was a problem hiding this comment.
This works but it's kind of hacky in that the scripts still expect to be run from the subdirectory while the contents are a different level from the root. I opted for this behavior in the scripts since I think most folks running the scripts locally would do so from the directory itself. We can refactor if you think that assumption isn't fair.
There was a problem hiding this comment.
@rcalixte yes, thank you. I think it is pretty ok to me.
There was a problem hiding this comment.
I tested, works great.
To avoid the issue you mentioned, can you please just add:
# The pandoc-*.yaml configs and the paths inside them are relative to this
# script's directory, so always run from there regardless of where the
# script was invoked from.
cd "$(dirname "$0")" || exit 1to the top of the pandoc.sh. It will make it work from both dirs, and from root dir and from the scripts dir.
There was a problem hiding this comment.
Great fix! Just when I thought I'd seen it all!
There was a problem hiding this comment.
After discussing with a friend, I opted for pushd/popd over cd but I can revert if you want.
There was a problem hiding this comment.
After discussing with a friend, I opted for pushd/popd over cd but I can revert if you want.
No no, it is cool!
cc091dc to
9c93155
Compare
|
@rcalixte thank you for the update. In general looks good to me! I will just test it a bit later today/tomorrow and if everything is good lets merge |
|
@rcalixte Only little comment about pandoc.sh, can you please add it and let's merge! |
2addd38 to
dfba97b
Compare
* Closes #21
|
@rcalixte thank you a lot for your contribution! Merging. |
Description
Add CI to automatically generate PDFs on pushes to master with a manual trigger for creation as well.
A CI job sample run is here the forked repository contains a release asset with the PDF as well.
Changes proposed in this pull request:
Content modifications are to support PDF generation:
Related issues