Skip to content

Add support for Zapier CLI#337

Merged
SimonBarendse merged 3 commits into
1Password:mainfrom
rajapri28613:zapier
Jul 25, 2023
Merged

Add support for Zapier CLI#337
SimonBarendse merged 3 commits into
1Password:mainfrom
rajapri28613:zapier

Conversation

@rajapri28613

Copy link
Copy Markdown
Contributor

Overview

Add support for Zapier CLI. The shell plugin provisions a configuration file at ~/.zapierrc. The shell plugin also imports the deploy key from the same file at the same path, if it exists.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

Related Issue(s)

  • Resolves: #
  • Relates: #

How To Test

  • Install Zapier CLI and set up the shell plugin.
  • Create a Zapier project with zapier init and enter that Zapier folder.
  • Test with zapier register. You should get a response asking for ? What is the title of your integration? Any other response is an indication of a failure of the provisioner.

Changelog

Additional information

@techcraver

techcraver commented Jun 30, 2023

Copy link
Copy Markdown

Hello @rajapri28613 ! Don't forget to also write an accompanying blog post on Hashnode with the tags 1Password and BuildWith1Password (not just putting #1Password in the text - but use the Hashnode tags in the CMS. :)

The full instructions are here.

The blog post is due by midnight Pacific (San Francisco) time - so you have about 8 hours from now.

@rajapri28613

Copy link
Copy Markdown
Contributor Author

Thank you, @techcraver. I will be submitting a few more shell plugins that I had been working on. Can I submit one blog post for all shell plugins?

@techcraver

Copy link
Copy Markdown

Thank you, @techcraver. I will be submitting a few more shell plugins that I had been working on. Can I submit one blog post for all shell plugins?

That's awesome!
It's best to do separate blog posts for each shell plugin - it maximizes visibility and chances at winning.

@rajapri28613

Copy link
Copy Markdown
Contributor Author

@techcraver

techcraver commented Jul 1, 2023 via email

Copy link
Copy Markdown

@arunsathiya arunsathiya added waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th labels Jul 3, 2023
@hculea
hculea self-requested a review July 5, 2023 07:32

@hculea hculea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Only a nit and a suggestion.

Comment thread plugins/zapier/deploy_key.go Outdated
Comment thread plugins/zapier/deploy_key.go Outdated
@hculea
hculea self-requested a review July 5, 2023 10:09
@hculea

hculea commented Jul 7, 2023

Copy link
Copy Markdown
Member

Hey @rajapri28613 , I see there hasn't been any activity on this PR in a bit, is there anything that we can help you with?

We'd love to get this to the finish line together! 🚀

@hculea hculea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great! @arunsathiya can I ask you to take this for a functional spin as well?

@arunsathiya arunsathiya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally works well, thanks @rajapri28613!

@arunsathiya arunsathiya added waiting-on-sec-review and removed waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member labels Jul 19, 2023
@SimonBarendse
SimonBarendse merged commit 96ae561 into 1Password:main Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashnode hackathon Ideas and inspiration for the hackathon running from June 1st - June 30th

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants