Skip to content

Implementing bitcode. - #1

Merged
JonoYang merged 7 commits into
aboutcode-org:mainfrom
35C4n0r:dev
Jul 14, 2023
Merged

Implementing bitcode.#1
JonoYang merged 7 commits into
aboutcode-org:mainfrom
35C4n0r:dev

Conversation

@35C4n0r

@35C4n0r 35C4n0r commented Jun 28, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR Implements the pure python variant of intbitset.

Class:

  • intbitset

Methods:

  • add
  • clear
  • copy
  • difference
  • difference_update
  • discard
  • extract_finite_list
  • fastdump
  • fastload
  • get_allocated
  • get_size
  • get_wordbitsize
  • get_wordbytesize
  • intersection
  • intersection_update
  • isdisjoint
  • issubset
  • issuprset
  • is_infinite
  • pop
  • remove
  • strbits
  • symetric_difference
  • symetric_difference_update
  • tolist
  • union
  • union_update
  • update
  • update_with_signs

35C4n0r added 2 commits June 28, 2023 10:24
@35C4n0r
add: added intbitset.py
06cc8a3 
- added intbitset class and it's methods.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r
add: added remaining methods
25ca86f 
- added the remaining methods for intbitset class.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r 35C4n0r self-assigned this Jun 29, 2023
JonoYang
JonoYang requested changes Jul 1, 2023
View reviewed changes

@JonoYang JonoYang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@35C4n0r Just pointing out a few small things

Comment thread src/bitcode/intbitset.py Outdated
Comment thread src/bitcode/intbitset.py Outdated
Comment thread src/bitcode/intbitset.py Outdated
35C4n0r and others added 3 commits July 1, 2023 13:08
@35C4n0r @JonoYang
Update src/bitcode/intbitset.py
f32f82f 
Refactoring Typos.

Co-authored-by: Jono Yang <JonoYang@users.noreply.github.com>
@35C4n0r @JonoYang
Update src/bitcode/intbitset.py
2fd0012 
Refactoring Typos.

Co-authored-by: Jono Yang <JonoYang@users.noreply.github.com>
@35C4n0r
add: added tests and GitHub workflow
8532ac5 
- added new tests for the intbitset class.
- updated README.rst.
- Tried adding workflows.

Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r
35C4n0r marked this pull request as ready for review July 1, 2023 14:08
@35C4n0r
35C4n0r requested a review from JonoYang July 1, 2023 14:10
@35C4n0r
ref: minor refactoring in comments.
b897e99 
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r

35C4n0r commented Jul 1, 2023

Copy link
Copy Markdown
Collaborator Author

@JonoYang, thanks for the review. I have added the changes, a few tests, and I also tried adding the github workflow to run the test.

@JonoYang

JonoYang commented Jul 3, 2023

Copy link
Copy Markdown
Member

@35C4n0r I've enabled Azure Pipelines for CI testing on the ahocode and bitcode repos

@35C4n0r
ref: removed GitHub workflows.
bb5e172 
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
@35C4n0r

35C4n0r commented Jul 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@JonoYang I have removed the github workflows, and i don't thin i need to make any changes in the azure-pipelines.yml
The PR is ready for review.

@35C4n0r

35C4n0r commented Jul 9, 2023

Copy link
Copy Markdown
Collaborator Author

@JonoYang also please make a repo for lxml so that I can start working on it.

@35C4n0r 35C4n0r mentioned this pull request Jul 9, 2023
Closed
@35C4n0r 35C4n0r linked an issue Jul 9, 2023 that may be closed by this pull request
Pure python fallback dependancy for intbitset. aboutcode-org/scancode-toolkit#3449
Closed
@JonoYang

JonoYang commented Jul 11, 2023

Copy link
Copy Markdown
Member

@35C4n0r I've created the xml fallback library repo at https://github.com/nexb/sanexml

@JonoYang

JonoYang commented Jul 13, 2023

Copy link
Copy Markdown
Member

@35C4n0r Is there anything else you need to add to this PR, otherwise I will merge it.

@35C4n0r

35C4n0r commented Jul 14, 2023

Copy link
Copy Markdown
Collaborator Author

@JonoYang, I don't have anything more to add to PR.

@JonoYang

JonoYang commented Jul 14, 2023

Copy link
Copy Markdown
Member

@35C4n0r I will merge the PR. Thanks for the contributions!

@JonoYang
JonoYang merged commit d980d98 into aboutcode-org:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pombredanne pombredanne Awaiting requested review from pombredanne
@AyanSinhaMahapatra AyanSinhaMahapatra Awaiting requested review from AyanSinhaMahapatra
@JonoYang JonoYang Awaiting requested review from JonoYang

Assignees

@35C4n0r 35C4n0r

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Pure python fallback dependancy for intbitset.

2 participants

@35C4n0r @JonoYang