fix: fixed the len magic method. - #3
Merged
Merged
Conversation
- Added magic method to perform bitwise or. - Fixed the logic to return bitset length. Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
JonoYang
requested changes
Jul 31, 2023
| bitset = self.bitset | ||
| size = 0 | ||
| while bitset != 0: | ||
| print(bitset) |
Member
There was a problem hiding this comment.
Suggested change
| print(bitset) |
Member
There was a problem hiding this comment.
I don't think this should be printed in this method?
| new.bitset = self.bitset & other.bitset | ||
| return new | ||
|
|
||
| def __or__(self, other): |
Member
There was a problem hiding this comment.
I think it would be good to have a test for this, like you do for len().
| ans += "])" | ||
| return ans | ||
|
|
||
| def __getitem__(self, item): |
Member
There was a problem hiding this comment.
It would be good to have a test for this too
Signed-off-by: 35C4n0r <jaykumar20march@gmail.com>
Member
|
@35C4n0r LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor updates.