Make scheduled_queries/ directory configurable from global.json#1209
Merged
Conversation
ryandeivert
approved these changes
Mar 26, 2020
ryandeivert
left a comment
Contributor
There was a problem hiding this comment.
one request be otherwise LGTM
| def load_packs(cls): | ||
| import_folders(PACKS_DIRECTORY) | ||
| def load_packs(cls, directories): | ||
| for dir in directories: |
Contributor
There was a problem hiding this comment.
import_folders takes an arbitrary # of args (using *args).. all you have to do here is use list expansion:
def load_packs(cls, directories):
import_folders(*directories)
Contributor
|
@Ryxias would you also mind adding an update to docs? http://streamalert.io/config-global.html#general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to: @ryandeivert
cc: @airbnb/streamalert-maintainers
Changes
It's now configurable under the node
scheduled_query_locationsin theglobal.jsonfile