Skip to content

Conversation

@refactormachine
Copy link
Contributor

Performed extract class operation for MetricSearcher. Extracted fields: charset, maxLinesReturn. Extracted Methods: readMetricsInOneFileByEndTime, readMetricsInOneFile, readMetricsByEndTime.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2018

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #103 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #103      +/-   ##
============================================
- Coverage     45.98%   45.79%   -0.19%     
+ Complexity      557      556       -1     
============================================
  Files           113      114       +1     
  Lines          3806     3813       +7     
  Branches        530      531       +1     
============================================
- Hits           1750     1746       -4     
- Misses         1846     1856      +10     
- Partials        210      211       +1
Impacted Files Coverage Δ Complexity Δ
...ibaba/csp/sentinel/node/metric/MetricSearcher.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...libaba/csp/sentinel/node/metric/MetricsReader.java 0% <0%> (ø) 0 <0> (?)
...ibaba/csp/sentinel/eagleeye/EagleEyeLogDaemon.java 24.24% <0%> (-6.07%) 5% <0%> (-1%)
...libaba/csp/sentinel/slots/block/flow/FlowRule.java 58.77% <0%> (-1.59%) 31% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8a72c4...33cf59e. Read the comment docs.

@tigerMoon
Copy link
Contributor

about CLA check. you can set your git commit email set in your gitHub account. use 'git log' to see your commit email.

@sczyh30 sczyh30 requested a review from CarpenterLee August 28, 2018 14:51
@sczyh30 sczyh30 added the to-review To review label Aug 28, 2018
@@ -0,0 +1,117 @@
package com.alibaba.csp.sentinel.node.metric;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Copyright and License here. Just copy the following:

/*
 * Copyright 1999-2018 Alibaba Group Holding Ltd.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

for (; i < fileNames.size(); i++) {
String fileName = fileNames.get(i);
long offset = findOffset(beginTimeMs, fileName,
fileName + MetricWriter.METRIC_FILE_INDEX_SUFFIX, offsetInIndex);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help me replace fileName + MetricWriter.METRIC_FILE_INDEX_SUFFIX with MetricWriter.formIndexFileName(fileName)

@refactormachine
Copy link
Contributor Author

Thanks for the review! both me and the commiter signed the CLA.

Copy link
Contributor

@CarpenterLee CarpenterLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CarpenterLee CarpenterLee merged commit 2772f18 into alibaba:master Aug 29, 2018
@sczyh30 sczyh30 removed the to-review To review label Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants