Skip to content

Conversation

@fangwentong
Copy link
Contributor

Describe what this PR does / why we need it

StatisticNode#maxSuccessQps returns maxSuccess of sliding windows, it should divide the window's interval to get correct QPS result

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@claassistantio
Copy link

claassistantio commented Dec 12, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #1196 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1196      +/-   ##
===========================================
+ Coverage     43.01%   43.1%   +0.08%     
- Complexity     1570    1572       +2     
===========================================
  Files           337     337              
  Lines          9877    9878       +1     
  Branches       1332    1332              
===========================================
+ Hits           4249    4258       +9     
+ Misses         5100    5094       -6     
+ Partials        528     526       -2
Impacted Files Coverage Δ Complexity Δ
...a/com/alibaba/csp/sentinel/node/StatisticNode.java 55.55% <100%> (+0.49%) 28 <1> (+1) ⬆️
...tinel/slots/block/flow/param/ParamFlowChecker.java 55.4% <0%> (+2.02%) 29% <0%> (ø) ⬇️
...ava/com/alibaba/csp/sentinel/node/ClusterNode.java 100% <0%> (+3.44%) 11% <0%> (+1%) ⬆️
...p/sentinel/datasource/consul/ConsulDataSource.java 69.56% <0%> (+5.79%) 7% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00dbb5c...3407063. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Dec 13, 2019
@sczyh30
Copy link
Member

sczyh30 commented Dec 13, 2019

@fangwentong
Copy link
Contributor Author

@sczyh30 CLA signed

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 0e110c6 into alibaba:master Dec 20, 2019
@sczyh30 sczyh30 added kind/bug Category issues or prs related to bug. and removed to-review To review labels Dec 20, 2019
@sczyh30 sczyh30 added this to the 1.7.1 milestone Dec 20, 2019
@sczyh30
Copy link
Member

sczyh30 commented Dec 20, 2019

Thanks for contributing!

hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Category issues or prs related to bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants