Skip to content

Conversation

@aalmiray
Copy link
Contributor

Describe what this PR does / why we need it

Makes build times faster by reducing the time some tests have to wait.

Does this pull request fix one issue?

Fixes #416

Describe how you did it

https://github.com/awaitility/awaitility is applied instead of fixed waiting times using of Thread.sleep()

Describe how to verify it

Without this a normal build takes approximately 3:46minutes.
With this fix a normal build takes approximately 1:16minutes.

Special notes for reviews

You can see the build times on OracleJDK8 and OracleJDK11 at https://travis-ci.org/aalmiray/Sentinel
Code produced during Hackergarten Basel 24.01.2019 http://hackergarten.net/

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Jan 24, 2019

Codecov Report

Merging #449 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #449      +/-   ##
============================================
+ Coverage     37.72%   37.76%   +0.04%     
- Complexity      982      984       +2     
============================================
  Files           235      235              
  Lines          7409     7409              
  Branches       1016     1016              
============================================
+ Hits           2795     2798       +3     
+ Misses         4253     4246       -7     
- Partials        361      365       +4
Impacted Files Coverage Δ Complexity Δ
...a/com/alibaba/csp/sentinel/eagleeye/StatEntry.java 20.21% <0%> (+2.12%) 8% <0%> (+1%) ⬆️
...alibaba/csp/sentinel/eagleeye/StatRollingData.java 73.52% <0%> (+2.94%) 9% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f6de9...3f5528c. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Jan 25, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit e893dd8 into alibaba:master Jan 29, 2019
@sczyh30
Copy link
Member

sczyh30 commented Jan 29, 2019

Awesome, thanks for contributing! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test Issue or PR related to test cases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce static waiting time in tests

4 participants