-
Notifications
You must be signed in to change notification settings - Fork 8.2k
[Feature]Support configure heartbeat api path of dashboard #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]Support configure heartbeat api path of dashboard #515
Conversation
…and fix edit rule issue when cancel (#370) - Make fallbackToLocalWhenFail of cluster rules configurable in dashboard - Fix edit rule when hit cancel button (object share problem solved by deep copy) - Add metric table td header's title for friendly prompt info
Signed-off-by: Eric Zhao <[email protected]>
…g description Signed-off-by: Eric Zhao <[email protected]>
- implement `SentinelPreFilter`, `SentinelPostFilter` and `SentinelErrorFilter` - support fallback
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
…WarmUpRateLimiterController Signed-off-by: Carpenter Lee <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Carpenter Lee <[email protected]>
… ClassNotFoundException thrown by Nacos client (#438)
Signed-off-by: Eric Zhao <[email protected]>
…r when loading SPI Signed-off-by: Eric Zhao <[email protected]>
…text in Tracer Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
…#465) - reuse old map size to avoid rearrange and rehash the map
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
- Apply awaitility to core tests - Cache maven local repo in Travis
Signed-off-by: Eric Zhao <[email protected]>
… and add basic test cases Signed-off-by: Eric Zhao <[email protected]>
* Extract getRule in BlockException and refine override methods in subclasses Signed-off-by: Eric Zhao <[email protected]>
- The NPE will occur when multiple threads are trying to create the connection group for the same namespace Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
同步远程仓库最近代码
Signed-off-by: Eric Zhao <[email protected]>
…riter of Sentinel cluster (#495) Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
…n DefaultController (#460)
Codecov Report
@@ Coverage Diff @@
## master #515 +/- ##
============================================
- Coverage 41.71% 37.68% -4.04%
+ Complexity 1376 1100 -276
============================================
Files 304 259 -45
Lines 8764 8174 -590
Branches 1182 1113 -69
============================================
- Hits 3656 3080 -576
- Misses 4662 4700 +38
+ Partials 446 394 -52
Continue to review full report at Codecov.
|
|
May I ask that what's the scenario for add a prefix path? Kinds of virtual path? |
See #332 (though it's rare). Maybe the property item could be used for the arbitrary registry URL path, not just for the prefix. |
sczyh30
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks for contributing! I'll improve the related code later. |
Describe what this PR does / why we need it
Sentinel transport module does not support configuring API path of dashboard heartbeat.
Does this pull request fix one issue?
Resolves #332
Describe how you did it
add a property item (
-Dcsp.sentinel.heartbeat.api.path) to support thisDescribe how to verify it
run the test case
Special notes for reviews