Skip to content

Conversation

@nick-tan
Copy link
Contributor

@nick-tan nick-tan commented Feb 24, 2019

Describe what this PR does / why we need it

Sentinel transport module does not support configuring API path of dashboard heartbeat.

Does this pull request fix one issue?

Resolves #332

Describe how you did it

add a property item (-Dcsp.sentinel.heartbeat.api.path) to support this

Describe how to verify it

run the test case

Special notes for reviews

all4you and others added 30 commits February 10, 2019 16:05
…and fix edit rule issue when cancel (#370)

- Make fallbackToLocalWhenFail of cluster rules configurable in dashboard
- Fix edit rule when hit cancel button (object share problem solved by deep copy)
- Add metric table td header's title for friendly prompt info
- implement `SentinelPreFilter`, `SentinelPostFilter` and `SentinelErrorFilter`
- support fallback
…WarmUpRateLimiterController

Signed-off-by: Carpenter Lee <[email protected]>
… ClassNotFoundException thrown by Nacos client (#438)
…#465)

- reuse old map size to avoid rearrange and rehash the map
- Apply awaitility to core tests
- Cache maven local repo in Travis
sczyh30 and others added 15 commits February 10, 2019 16:05
* Extract getRule in BlockException and refine override methods in subclasses

Signed-off-by: Eric Zhao <[email protected]>
- The NPE will occur when multiple threads are trying to create the connection group for the same namespace

Signed-off-by: Eric Zhao <[email protected]>
同步远程仓库最近代码
)

- fix ConcurrentModificationException of listResourcesOfApp method
@codecov-io
Copy link

codecov-io commented Feb 24, 2019

Codecov Report

Merging #515 into master will decrease coverage by 4.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #515      +/-   ##
============================================
- Coverage     41.71%   37.68%   -4.04%     
+ Complexity     1376     1100     -276     
============================================
  Files           304      259      -45     
  Lines          8764     8174     -590     
  Branches       1182     1113      -69     
============================================
- Hits           3656     3080     -576     
- Misses         4662     4700      +38     
+ Partials        446      394      -52
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/alibaba/csp/sentinel/util/IdUtil.java 0% <0%> (-100%) 0% <0%> (-6%)
.../sentinel/adapter/dubbo/DubboAppContextFilter.java 0% <0%> (-100%) 0% <0%> (-3%)
...sp/sentinel/adapter/dubbo/AbstractDubboFilter.java 0% <0%> (-100%) 0% <0%> (-4%)
...alibaba/csp/sentinel/adapter/dubbo/DubboUtils.java 0% <0%> (-66.67%) 0% <0%> (-2%)
...nel/adapter/dubbo/SentinelDubboProviderFilter.java 0% <0%> (-64%) 0% <0%> (-2%)
...nel/adapter/dubbo/SentinelDubboConsumerFilter.java 0% <0%> (-57.15%) 0% <0%> (-2%)
...va/com/alibaba/csp/sentinel/init/InitExecutor.java 12.82% <0%> (-47.71%) 2% <0%> (-4%)
...java/com/alibaba/csp/sentinel/util/StringUtil.java 15.38% <0%> (-32.7%) 10% <0%> (-18%)
...src/main/java/com/alibaba/csp/sentinel/Tracer.java 0% <0%> (-31.15%) 0% <0%> (-12%)
...ntinel/slots/block/flow/param/ParameterMetric.java 50% <0%> (-25%) 27% <0%> (-2%)
... and 159 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062385f...83af836. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Feb 25, 2019
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2019

CLA assistant check
All committers have signed the CLA.

@jasonjoo2010
Copy link
Collaborator

May I ask that what's the scenario for add a prefix path? Kinds of virtual path?

@sczyh30 sczyh30 added the kind/enhancement Category issues or prs related to enhancement. label Dec 9, 2019
@sczyh30
Copy link
Member

sczyh30 commented Dec 9, 2019

May I ask that what's the scenario for add a prefix path? Kinds of virtual path?

See #332 (though it's rare). Maybe the property item could be used for the arbitrary registry URL path, not just for the prefix.

Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 9beb655 into alibaba:master Dec 10, 2019
@sczyh30
Copy link
Member

sczyh30 commented Dec 10, 2019

Thanks for contributing! I'll improve the related code later.

@sczyh30 sczyh30 removed the to-review To review label Dec 10, 2019
@sczyh30 sczyh30 added this to the 1.7.1 milestone Dec 10, 2019
hughpearse pushed a commit to hughpearse/Sentinel that referenced this pull request Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Category issues or prs related to enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

关于sentinel dashboard启动设置了contextpath,客户端无法连接的问题