-
Notifications
You must be signed in to change notification settings - Fork 8.2k
Solve the issue sleeping based tests are not stable #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e5f461d to
d34348d
Compare
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
============================================
+ Coverage 37.68% 37.93% +0.25%
- Complexity 1102 1109 +7
============================================
Files 259 259
Lines 8171 8171
Branches 1113 1113
============================================
+ Hits 3079 3100 +21
+ Misses 4695 4666 -29
- Partials 397 405 +8
Continue to review full report at Codecov.
|
sczyh30
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also reformat the relevant code.
d34348d to
60dbfb1
Compare
60dbfb1 to
0f99fd7
Compare
sczyh30
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Nice, thanks for contributing! |
Describe what this PR does / why we need it
By mock the class
TimeUtilwe can precisely control thesleepdelay.Not only the tests become stable but they would take less time to finish.
Does this pull request fix one issue?
Resolves #541