Skip to content

Conversation

@kexianjun
Copy link
Contributor

Describe what this PR does / why we need it

add zookeeper flow rule publisher sample for dashboard

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-io
Copy link

Codecov Report

Merging #714 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #714      +/-   ##
============================================
- Coverage      40.4%   40.37%   -0.03%     
+ Complexity     1312     1311       -1     
============================================
  Files           297      297              
  Lines          8591     8591              
  Branches       1156     1156              
============================================
- Hits           3471     3469       -2     
- Misses         4695     4697       +2     
  Partials        425      425
Impacted Files Coverage Δ Complexity Δ
...m/alibaba/csp/sentinel/log/DateFileLogHandler.java 54.54% <0%> (-3.04%) 6% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf4822...0d3ae8c. Read the comment docs.

@sczyh30 sczyh30 added area/dashboard Issues or PRs about Sentinel Dashboard to-review To review labels Apr 28, 2019
Copy link
Member

@sczyh30 sczyh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sczyh30 sczyh30 merged commit 1d1878c into alibaba:master Apr 29, 2019
@sczyh30 sczyh30 removed the to-review To review label Apr 29, 2019
@sczyh30
Copy link
Member

sczyh30 commented Apr 29, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dashboard Issues or PRs about Sentinel Dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants