feat: support PDFusion ratio scheduler with DP#1179
Open
HoniiTro19 wants to merge 1 commit into
Open
Conversation
Collaborator
AI Code Review - PR #1179Status: BLOCKING Summary: P0/0 · P1/1 · P2/0 · P3/0 Blocking IssuesP1
Checklist Violations (3 fail / 72 total)General Principles Checklist
RTP-LLM Checklist
Strengths
|
f969e99 to
57a2b5f
Compare
Collaborator
AI Code Review - PR #1179Status: BLOCKING Summary: P0/0 · P1/1 · P2/0 · P3/0 Blocking IssuesP1
Checklist Violations (3 fail / 72 total)General Principles Checklist
RTP-LLM Checklist
Strengths
|
57a2b5f to
82e5703
Compare
Collaborator
AI Code Review - PR #1179Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist ✅ (72 items passed)Strengths
|
82e5703 to
e1c9cfd
Compare
Collaborator
AI Code Review - PR #1179Status: LGTM Summary: P0/0 · P1/0 · P2/0 · P3/0 lgtm ready to ci Checklist ✅ (72 items passed)Strengths
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
PDFusion Ratio Scheduler previously enforced
dp_size <= 1, preventing ratio scheduling from being used with Data Parallelism.The existing DP execution path already uses fake streams to align prefill and decode execution across DP ranks, so this restriction can now be removed.
Changes
dp_size <= 1restriction from PDFusion Ratio Scheduler.