dyups: fixed bug of deleting wrong upstream check dynamic peers#1648
Merged
Conversation
…le IP addresses, call them
|
zhusy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Member
|
Nice catch, For source detail, add peer occurs in: tengine/src/http/ngx_http_upstream_round_robin.c Lines 116 to 123 in 67c72d5 |
Member
|
After this #1660 merged, all related test case passed. (dyups.t) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…le IP addresses, call them
如果upstrem下的server是域名的情况下,并且这个域名解析出来对应的多个ip地址,这里需要分别调用多次
因为添加的时候对多个ip分别进行了添加,启动定时器去做健康检查功能,所以删除的时候也需要同步删除。不然会存在定时器泄露,而定时器里面访问相关变量时会奔溃