Skip to content

dyups: fixed bug of deleting wrong upstream check dynamic peers#1648

Merged
chobits merged 1 commit into
alibaba:masterfrom
shuiuii:f_modify_http_upstream_dyups
Oct 26, 2022
Merged

dyups: fixed bug of deleting wrong upstream check dynamic peers#1648
chobits merged 1 commit into
alibaba:masterfrom
shuiuii:f_modify_http_upstream_dyups

Conversation

@shuiuii

@shuiuii shuiuii commented Sep 29, 2022

Copy link
Copy Markdown
Contributor

…le IP addresses, call them

如果upstrem下的server是域名的情况下,并且这个域名解析出来对应的多个ip地址,这里需要分别调用多次
因为添加的时候对多个ip分别进行了添加,启动定时器去做健康检查功能,所以删除的时候也需要同步删除。不然会存在定时器泄露,而定时器里面访问相关变量时会奔溃

@CLAassistant

CLAassistant commented Sep 29, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


zhusy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@chobits

chobits commented Oct 23, 2022

Copy link
Copy Markdown
Member

Nice catch,

For source detail, add peer occurs in:

#if (NGX_HTTP_UPSTREAM_CHECK)
if (!server[i].down) {
peer[n].check_index =
ngx_http_upstream_check_add_peer(cf, us,
&server[i].addrs[j]);
} else {
peer[n].check_index = (ngx_uint_t) NGX_ERROR;
}

@chobits chobits added the bug label Oct 23, 2022
@chobits chobits added this to the 2.3.5 milestone Oct 23, 2022
@chobits

chobits commented Oct 26, 2022

Copy link
Copy Markdown
Member

After this #1660 merged, all related test case passed. (dyups.t)

@chobits
chobits merged commit 6ad5e5a into alibaba:master Oct 26, 2022
@chobits chobits changed the title Fix(ngx_http_upstream_dyups_module): If a domain name contains multip… dyups: fixed bug of deleting wrong upstream check dynamic peers Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants