fixed dynamic_resolver_port.t: cannot listen on dns server port#1677
Merged
Conversation
Use "resolver 127.0.0.01:8xxx" instead of "resolver 127.0.0.1:8xxxx". Otherwise, port() in Nginx.pm will listen on that port firstly.
Member
Author
|
cc @wangfakang |
chobits
commented
Nov 5, 2022
|
|
||
| $t->run_daemon(\&dns_daemon, 8900, $t); | ||
| $t->waitforfile($t->testdir . '/dns_server.pid') | ||
| or die "\n+ failed to create dns server!\n\n"; |
Member
Author
There was a problem hiding this comment.
if dns server failed to be created, stop the case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "resolver 127.0.0.01:8xxx" instead of "resolver 127.0.0.1:8xxxx". Otherwise, write_file_expand()/port() in Nginx.pm will listen on that port firstly.