optimise dyups module mutex compete#1691
Merged
Merged
Conversation
chobits
reviewed
Nov 19, 2022
|
|
||
| ngx_add_timer(timer, dmcf->read_msg_timeout); | ||
| /* | ||
| * when init process, break up timer, in case of shpool->mutex compete |
Member
There was a problem hiding this comment.
Can you describe in detail the problem you encountered?
Contributor
Author
There was a problem hiding this comment.
if every worker process start timer at the same time, ngx_shmtx_lock (in timer's handler) may mutex compete in all processes , there ere hang in the process of not getting mutex. When break up the start time of timer , avoid mutex compete in all processes.
Contributor
Author
There was a problem hiding this comment.
srandom(seed) has removed
chobits
reviewed
Nov 20, 2022
zjd87
commented
Nov 20, 2022
zjd87
left a comment
Contributor
Author
There was a problem hiding this comment.
srandom(seed) has removed
|
|
||
| ngx_add_timer(timer, dmcf->read_msg_timeout); | ||
| /* | ||
| * when init process, break up timer, in case of shpool->mutex compete |
Contributor
Author
There was a problem hiding this comment.
srandom(seed) has removed
chobits
reviewed
Nov 20, 2022
chobits
self-requested a review
November 20, 2022 02:38
chobits
approved these changes
Nov 20, 2022
Member
|
Thanks, have merged with minor fix on the commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.