feat: Remove deprecated properties from IAccount interface and fix JSON property name typo#819
Merged
Merged
Conversation
…ON property name typo - Removed `IsDayPatternTrader` and `DayTradeCount` properties from the `IAccount` interface due to changes in the Alpaca Trading API. - Fixed a typo in the JSON property name for `NonMarginableBuyingPower` to ensure correct population. - Updated compatibility suppressions to reflect the removal of the deprecated properties.
SpenserJ
approved these changes
Jul 8, 2026
SpenserJ
requested changes
Jul 8, 2026
SpenserJ
approved these changes
Jul 8, 2026
SpenserJ
left a comment
There was a problem hiding this comment.
Approving so we can cut a hotfix for the reported crash, and we can handle the other deprecated properties in the v8 branch. The one I flagged defaults to null so it shouldn't break anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IsDayPatternTraderandDayTradeCountproperties from theIAccountinterface due to changes in the Alpaca Trading API.NonMarginableBuyingPowerto ensure correct population.Fixes # (issue)
Type of change
Checklist: