Set completion-styles via setq-local rather than by let-binding#514
Open
oantolin wants to merge 1 commit into
Open
Set completion-styles via setq-local rather than by let-binding#514oantolin wants to merge 1 commit into
oantolin wants to merge 1 commit into
Conversation
When the completion-styles are bound they affect all recursive minibuffers as well, overriding the user's completion setup! Using setq-local instead ensures the org-ql completion settings are only applied for the org-ql-completing-read minibuffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the completion-styles are bound they affect all recursive minibuffers as well, overriding the user's completion setup! Using setq-local instead ensures the org-ql completion settings are only applied for the org-ql-completing-read minibuffer.
I would have run across this problem simply because I tend to use recursive minibuffers, but this also is a problem for people who do not enable recursive minibuffers but use Embark to, say, refile a heading from org-ql-find (Embark temporarily activates recursive minibuffers).