JaCoP JNI wrapper stores FindClass local refs instead of global refs #282

Summary

The JaCoP JNI helpers keep FindClass results as JNI local references on a thread that creates the JVM and stays attached. Locals are not released when these C++ functions return.

The same header already provides GlobalRef / NewGlobalRef, but class cache and several call sites do not use them.

1. Class::DoInit caches a local jclass

void DoInit(Env env) {
  class_ = env.FindClass(Info::name());
  ctor_ = env.GetMethod(class_, "<init>", Info::ctor_sig());
}

class_ is a long-lived member. A local reference is only valid on the creating thread and only while that thread remains attached. It should be promoted with NewGlobalRef (or stored in GlobalRef) and deleted with DeleteGlobalRef in the destructor.

This also occupies a local-reference table slot for the life of the Class object.

2. Env::NewObject(class_name, ...) drops the class local ref

jclass cls = FindClass(class_name);
jmethodID ctor = GetMethod(cls, "<init>", ctor_sig);
jobject result = env_->NewObjectV(cls, ctor, args);
return Check(result, "NewObjectV");

cls is never DeleteLocalRef'd. The returned jobject is an ownership transfer and is fine. Each call through this overload leaves one extra jclass local on the attached thread.

3. Env::Throw leaves two locals

• The temporary from FindClass("java/lang/Object") is not deleted.
• String only calls ReleaseStringUTFChars in its destructor; it does not DeleteLocalRef the jstring from toString().

JavaError also stores the jthrowable from ExceptionOccurred(), which is still a local reference.

This path is not a hot loop; the class-cache and NewObject(class_name, ...) issues matter more.

Suggested fix

• In DoInit, store NewGlobalRef(FindClass(...)) (or a GlobalRef member). Delete it in ~ClassBase.
• After GetMethod in Env::NewObject(const char *, ...), DeleteLocalRef(cls).
• In Throw, keep the FindClass result in a variable, wrap/delete the toString jstring, and convert the throwable with NewGlobalRef if it must outlive the JNI call.