Adds a date selection model - #17363
Conversation
mmalerba
left a comment
There was a problem hiding this comment.
You'll need to run bazel run //tools/public_api_guard:material/core.d.ts_api.accept to mark that the API changes in this PR are intentional
| import {Subject} from 'rxjs'; | ||
|
|
||
| export abstract class MatDateSelectionModel<D> { | ||
| valueChangesSubject = new Subject<void>(); |
There was a problem hiding this comment.
This should be private and we still need the valueChanges Observable for the public API. Just when you're calling .complete() and .next() those methods only exist on the Subject
There was a problem hiding this comment.
Since it's a private property, I won't be able to call this._valueChangesSubject in the derived classes.
There was a problem hiding this comment.
oh sorry, then you can make it protected, the important thing is its not part of the public API
|
My local tests all passed, not sure why the tests here are failing :-( |
|
I'm pretty sure that failure is just a flake, restarting it |
mmalerba
left a comment
There was a problem hiding this comment.
LGTM - good to go once the tests are green
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.