Trying to incorporate the new type definition - #17942
Merged
mmalerba merged 5 commits intoDec 20, 2019
Merged
Conversation
mmalerba
reviewed
Dec 12, 2019
xlou978
force-pushed
the
date-selection-model
branch
from
December 16, 2019 22:44
23866f2 to
bf7d246
Compare
mmalerba
force-pushed
the
date-selection-model
branch
from
December 19, 2019 23:10
bf7d246 to
e5c342f
Compare
crisbeto
pushed a commit
to crisbeto/material2
that referenced
this pull request
Jan 2, 2020
* incoporate new type definition * fix test and clean up the types a bit * update api gold * fix some nits * fix lint Co-authored-by: mmalerba <mmalerba@google.com>
mmalerba
added a commit
that referenced
this pull request
Jan 7, 2020
* Adds a date selection model (#17363) * Adds a date selection model * Adds a date selection model * Use MatDateSelectionModel to model the selected value in MatDatepickerInput (#17497) * Make the selection model injectable and add an `overlaps` method (#17766) * Adds a date selection model (#17363) * Adds a date selection model * Adds a date selection model * Add overlaps function to date selection model * Trying to incorporate the new type definition (#17942) * incoporate new type definition * fix test and clean up the types a bit * update api gold * fix some nits * fix lint Co-authored-by: mmalerba <mmalerba@google.com> * refactor(datepicker): implement date selection model provider Reworks the datepicker-related directives to move the source of the value into the new datepicker selection provider. Co-authored-by: xlou978 <51772166+xlou978@users.noreply.github.com> Co-authored-by: jaguima <jaguima@gmail.com> Co-authored-by: mmalerba <mmalerba@google.com>
mmalerba
added a commit
that referenced
this pull request
Jan 7, 2020
* Adds a date selection model (#17363) * Adds a date selection model * Adds a date selection model * Use MatDateSelectionModel to model the selected value in MatDatepickerInput (#17497) * Make the selection model injectable and add an `overlaps` method (#17766) * Adds a date selection model (#17363) * Adds a date selection model * Adds a date selection model * Add overlaps function to date selection model * Trying to incorporate the new type definition (#17942) * incoporate new type definition * fix test and clean up the types a bit * update api gold * fix some nits * fix lint Co-authored-by: mmalerba <mmalerba@google.com> * refactor(datepicker): implement date selection model provider Reworks the datepicker-related directives to move the source of the value into the new datepicker selection provider. Co-authored-by: xlou978 <51772166+xlou978@users.noreply.github.com> Co-authored-by: jaguima <jaguima@gmail.com> Co-authored-by: mmalerba <mmalerba@google.com> Co-authored-by: roboshoes <mail@mathias-paumgarten.com> Co-authored-by: goldblatt <suzgoldblatt@gmail.com>
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 11, 2020
…r#18090) * Adds a date selection model (angular#17363) * Adds a date selection model * Adds a date selection model * Use MatDateSelectionModel to model the selected value in MatDatepickerInput (angular#17497) * Make the selection model injectable and add an `overlaps` method (angular#17766) * Adds a date selection model (angular#17363) * Adds a date selection model * Adds a date selection model * Add overlaps function to date selection model * Trying to incorporate the new type definition (angular#17942) * incoporate new type definition * fix test and clean up the types a bit * update api gold * fix some nits * fix lint Co-authored-by: mmalerba <mmalerba@google.com> * refactor(datepicker): implement date selection model provider Reworks the datepicker-related directives to move the source of the value into the new datepicker selection provider. Co-authored-by: xlou978 <51772166+xlou978@users.noreply.github.com> Co-authored-by: jaguima <jaguima@gmail.com> Co-authored-by: mmalerba <mmalerba@google.com> Co-authored-by: roboshoes <mail@mathias-paumgarten.com> Co-authored-by: goldblatt <suzgoldblatt@gmail.com>
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jan 11, 2020
…r#18090) * Adds a date selection model (angular#17363) * Adds a date selection model * Adds a date selection model * Use MatDateSelectionModel to model the selected value in MatDatepickerInput (angular#17497) * Make the selection model injectable and add an `overlaps` method (angular#17766) * Adds a date selection model (angular#17363) * Adds a date selection model * Adds a date selection model * Add overlaps function to date selection model * Trying to incorporate the new type definition (angular#17942) * incoporate new type definition * fix test and clean up the types a bit * update api gold * fix some nits * fix lint Co-authored-by: mmalerba <mmalerba@google.com> * refactor(datepicker): implement date selection model provider Reworks the datepicker-related directives to move the source of the value into the new datepicker selection provider. Co-authored-by: xlou978 <51772166+xlou978@users.noreply.github.com> Co-authored-by: jaguima <jaguima@gmail.com> Co-authored-by: mmalerba <mmalerba@google.com> Co-authored-by: roboshoes <mail@mathias-paumgarten.com> Co-authored-by: goldblatt <suzgoldblatt@gmail.com>
crisbeto
added a commit
that referenced
this pull request
Jan 11, 2020
* Adds a date selection model (#17363) * Adds a date selection model * Adds a date selection model * Use MatDateSelectionModel to model the selected value in MatDatepickerInput (#17497) * Make the selection model injectable and add an `overlaps` method (#17766) * Adds a date selection model (#17363) * Adds a date selection model * Adds a date selection model * Add overlaps function to date selection model * Trying to incorporate the new type definition (#17942) * incoporate new type definition * fix test and clean up the types a bit * update api gold * fix some nits * fix lint Co-authored-by: mmalerba <mmalerba@google.com> * refactor(datepicker): implement date selection model provider Reworks the datepicker-related directives to move the source of the value into the new datepicker selection provider. Co-authored-by: xlou978 <51772166+xlou978@users.noreply.github.com> Co-authored-by: jaguima <jaguima@gmail.com> Co-authored-by: mmalerba <mmalerba@google.com> Co-authored-by: roboshoes <mail@mathias-paumgarten.com> Co-authored-by: goldblatt <suzgoldblatt@gmail.com>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not working yet, because we are running into some issues. Please take a look and let us know whether we are going the right direction or not.