Skip to content

refactor(datepicker): implement range selection model - #18247

Merged
crisbeto merged 1 commit into
angular:date-rangefrom
crisbeto:date-range-input-model
Jan 23, 2020
Merged

refactor(datepicker): implement range selection model#18247
crisbeto merged 1 commit into
angular:date-rangefrom
crisbeto:date-range-input-model

Conversation

@crisbeto

@crisbeto crisbeto commented Jan 21, 2020

Copy link
Copy Markdown
Member

Implements the date range selection model in the individual range inputs.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe labels Jan 21, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 21, 2020
Comment thread src/material/core/datetime/date-selection-model.ts Outdated
Comment thread src/material/datepicker/date-range-input-parts.ts Outdated
Comment thread src/material/core/datetime/date-selection-model.ts Outdated
@crisbeto
crisbeto force-pushed the date-range-input-model branch from fa95dc7 to 3dc14ec Compare January 22, 2020 14:07
@crisbeto crisbeto changed the title refactor: tweak date selection model signature and implement model in range input refactor(datepicker): implement range selection model Jan 22, 2020
@crisbeto

Copy link
Copy Markdown
Member Author

@mmalerba I've reworked it so that we don't have to change the selection model signature and to avoid some potentially-breaky changes in the datepicker input generic. Can you take another look?

Comment thread src/dev-app/datepicker/datepicker-demo.ts Outdated
@crisbeto
crisbeto force-pushed the date-range-input-model branch from 3dc14ec to 5ab333e Compare January 22, 2020 21:11

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from 1 nit

Comment thread src/material/core/datetime/date-selection-model.ts
Implements the date range selection model in the individual range inputs.
@crisbeto
crisbeto force-pushed the date-range-input-model branch from 5ab333e to 5faa7e6 Compare January 22, 2020 21:51
@crisbeto
crisbeto merged commit fd99256 into angular:date-range Jan 23, 2020
crisbeto added a commit that referenced this pull request Jan 24, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Jan 24, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit that referenced this pull request Jan 29, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit that referenced this pull request Feb 5, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit that referenced this pull request Feb 17, 2020
Implements the date range selection model in the individual range inputs.
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 17, 2020
Implements the date range selection model in the individual range inputs.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants