Skip to content

fix(datepicker): add gap between range rows and handle rtl - #18660

Merged
crisbeto merged 1 commit into
angular:date-rangefrom
crisbeto:date-range-gap
Mar 1, 2020
Merged

fix(datepicker): add gap between range rows and handle rtl#18660
crisbeto merged 1 commit into
angular:date-rangefrom
crisbeto:date-range-gap

Conversation

@crisbeto

Copy link
Copy Markdown
Member
  • Makes the range background shorter so that there's a gap when a range spans across multiple rows. This makes it easier to see what's going on.
  • Fixes the range styles not accounting for RTL layouts.

Before/After for reference:
before
after

* Makes the range background shorter so that there's a gap when a range spans across multiple rows. This makes it easier to see what's going on.
* Fixes the range styles not accounting for RTL layouts.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent pr: merge safe labels Feb 29, 2020
@crisbeto
crisbeto requested a review from mmalerba as a code owner February 29, 2020 15:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 29, 2020
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 29, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
crisbeto merged commit d822649 into angular:date-range Mar 1, 2020
crisbeto added a commit that referenced this pull request Mar 12, 2020
* Makes the range background shorter so that there's a gap when a range spans across multiple rows. This makes it easier to see what's going on.
* Fixes the range styles not accounting for RTL layouts.
crisbeto added a commit that referenced this pull request Mar 17, 2020
* Makes the range background shorter so that there's a gap when a range spans across multiple rows. This makes it easier to see what's going on.
* Fixes the range styles not accounting for RTL layouts.
crisbeto added a commit that referenced this pull request Mar 21, 2020
* Makes the range background shorter so that there's a gap when a range spans across multiple rows. This makes it easier to see what's going on.
* Fixes the range styles not accounting for RTL layouts.
crisbeto added a commit that referenced this pull request Mar 31, 2020
* Makes the range background shorter so that there's a gap when a range spans across multiple rows. This makes it easier to see what's going on.
* Fixes the range styles not accounting for RTL layouts.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants