Skip to content

fix(material-experimental/mdc-chips): add feature targeting to theme styles - #18830

Merged
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:mdc-chips-theme-targeting
Mar 21, 2020
Merged

fix(material-experimental/mdc-chips): add feature targeting to theme styles#18830
mmalerba merged 1 commit into
angular:masterfrom
crisbeto:mdc-chips-theme-targeting

Conversation

@crisbeto

Copy link
Copy Markdown
Member

The MDC chips theme was including some styles without a feature target, resulting in some unnecessary styles being added.

…styles

The MDC chips theme was including some styles without a feature target, resulting in some unnecessary styles being added.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 14, 2020
@crisbeto
crisbeto requested a review from mmalerba as a code owner March 14, 2020 18:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 14, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants