Skip to content

fix(material-experimental/mdc-card): not handling dark themes - #18938

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:mdc-card-dark-themes
Mar 31, 2020
Merged

fix(material-experimental/mdc-card): not handling dark themes#18938
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:mdc-card-dark-themes

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes some variables for the MDC-based card not being set up to handle the theme colors properly. Also makes it easier to test outlined cards in the dev app.

Fixes some variables for the MDC-based card not being set up to handle the theme colors properly. Also makes it easier to test outlined cards in the dev app.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Mar 28, 2020
@crisbeto
crisbeto requested a review from mmalerba as a code owner March 28, 2020 12:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 28, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Mar 30, 2020
@jelbourn
jelbourn merged commit 1c8a2c9 into angular:master Mar 31, 2020
jelbourn pushed a commit that referenced this pull request Mar 31, 2020
Fixes some variables for the MDC-based card not being set up to handle the theme colors properly. Also makes it easier to test outlined cards in the dev app.

(cherry picked from commit 1c8a2c9)
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants