Skip to content

fix(tree): complete viewChange stream on destroy - #18991

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:tree-view-change-complete
Apr 24, 2020
Merged

fix(tree): complete viewChange stream on destroy#18991
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:tree-view-change-complete

Conversation

@crisbeto

@crisbeto crisbeto commented Apr 4, 2020

Copy link
Copy Markdown
Member

Fixes the tree not completing its viewChange stream.

Fixes the tree not completing its `viewChange` stream.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Apr 4, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 4, 2020

@jelbourn jelbourn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 23, 2020
@jelbourn
jelbourn merged commit 403a3d1 into angular:master Apr 24, 2020
jelbourn pushed a commit that referenced this pull request Apr 24, 2020
Fixes the tree not completing its `viewChange` stream.
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
Fixes the tree not completing its `viewChange` stream.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants