Skip to content

fix(autocomplete/testing): incorrect options if multiple panels are on the page at the same time - #19114

Merged
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:multiple-autocomplete-incorrect-options
Apr 23, 2020
Merged

fix(autocomplete/testing): incorrect options if multiple panels are on the page at the same time#19114
jelbourn merged 1 commit into
angular:masterfrom
crisbeto:multiple-autocomplete-incorrect-options

Conversation

@crisbeto

Copy link
Copy Markdown
Member

Fixes the autocomplete harness returning the options of the first autocomplete panel, if multiple panels are on the page at the same time.

…n the page at the same time

Fixes the autocomplete harness returning the options of the first autocomplete panel, if multiple panels are on the page at the same time.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Apr 19, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 19, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added lgtm action: merge The PR is ready for merge by the caretaker labels Apr 21, 2020
@jelbourn
jelbourn merged commit 4eef958 into angular:master Apr 23, 2020
jelbourn pushed a commit that referenced this pull request Apr 23, 2020
…n the page at the same time (#19114)

Fixes the autocomplete harness returning the options of the first autocomplete panel, if multiple panels are on the page at the same time.
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
…n the page at the same time (angular#19114)

Fixes the autocomplete harness returning the options of the first autocomplete panel, if multiple panels are on the page at the same time.
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants