Skip to content

fix(components-examples): rename example component - #19142

Merged
jelbourn merged 1 commit into
angular:masterfrom
annieyw:rename
Apr 23, 2020
Merged

fix(components-examples): rename example component #19142
jelbourn merged 1 commit into
angular:masterfrom
annieyw:rename

Conversation

@annieyw

@annieyw annieyw commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

Rename example component (previous nested-menu to menu-nested) to be consistent with other menu examples. This facilitates autoloading examples onto the materials documentation site.

@annieyw
annieyw requested review from atscott and mmalerba April 22, 2020 18:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 22, 2020

@atscott atscott left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisbeto crisbeto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 22, 2020
@mmalerba mmalerba removed docs This issue is related to documentation target: patch This PR is targeted for the next patch release labels Apr 22, 2020
@crisbeto crisbeto added target: development-branch docs This issue is related to documentation target: patch This PR is targeted for the next patch release and removed target: development-branch labels Apr 22, 2020

@mmalerba mmalerba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yeah, pelase open one to change the documentation-items manually so it continues to work while you're working on the other PR

Comment thread src/components-examples/material/menu/index.ts Outdated
@jelbourn
jelbourn merged commit d129692 into angular:master Apr 23, 2020
jelbourn pushed a commit that referenced this pull request Apr 23, 2020
…onvention for autoloading in docs (#19142)

Co-authored-by: Annie Wang <annieyw@google.com>
@annieyw
annieyw deleted the rename branch April 23, 2020 16:58
soro-google pushed a commit to soro-google/components that referenced this pull request Apr 24, 2020
…onvention for autoloading in docs (angular#19142)

Co-authored-by: Annie Wang <annieyw@google.com>
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants