fix(chips): chip list overriding chip disabled value - #19228
Merged
jelbourn merged 1 commit intoMay 8, 2020
Conversation
When a chip list is disabled, it goes through all the chips and sets their `disabled` values. The problem is that this overrides any individual values the consumer may have set. These changes fix the issue by saving the value to a different field. Fixes angular#19213.
jelbourn
approved these changes
May 6, 2020
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Is something like also necessary for the mdc chips?
jelbourn
pushed a commit
that referenced
this pull request
May 8, 2020
When a chip list is disabled, it goes through all the chips and sets their `disabled` values. The problem is that this overrides any individual values the consumer may have set. These changes fix the issue by saving the value to a different field. Fixes #19213.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a chip list is disabled, it goes through all the chips and sets their
disabledvalues. The problem is that this overrides any individual values the consumer may have set. These changes fix the issue by saving the value to a different field.Fixes #19213.