fix(column-resize): Resize table as well as columns, improve handing … - #19264
Merged
Conversation
…of min/max width, and simplify overlay positioning.
jelbourn
reviewed
May 6, 2020
jelbourn
left a comment
Contributor
There was a problem hiding this comment.
Also general function JsDocs
@andrewseguin PTAL
| } | ||
|
|
||
| setResized() { | ||
| this.elementRef.nativeElement!.classList.add(WITH_RESIZED_COLUMN_CLASS); |
Contributor
There was a problem hiding this comment.
Why does this need to be called from other classes instead of only responding to the resize stream?
Contributor
Author
There was a problem hiding this comment.
I went back and forth on this - I was not sure that applying a min/max size should trigger the notifier, which will eventually have side effects like persisting the size setting.
crisbeto
reviewed
May 6, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…of min/max width, and simplify overlay positioning.